Hi,

On 6/5/23 12:22 PM, Julien Grall wrote:
Hi,

On 02/06/2023 08:45, Michal Orzel wrote:

On 02/06/2023 02:48, Vikram Garhwal wrote:
diff --git a/xen/include/xen/iommu-private.h b/xen/include/xen/iommu-private.h
new file mode 100644
index 0000000000..5615decaff
--- /dev/null
+++ b/xen/include/xen/iommu-private.h
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+ /*
incorrect indentation (<< 1)

+ * xen/iommu-private.h
+ *
+ *
+ * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved.
+ * Written by Vikram Garhwal <vikram.garh...@amd.com>
I'm not sure if placing the copyright is appropriate, given a single prototype for a function not really implemented by you with just spinlocks removed. But I might be wrong.

I agree. If you want to add a copyright then it should be the one from the original author.

But in this case, I don't think we should add an copyright as there is nothing really interesting in the header.

Thanks for pointing this out and explaining the process. Will remove in next version.

Cheers,



Reply via email to