On Thu, Jun 01, 2023 at 04:06:53PM +0200, Jan Beulich wrote: > On 01.06.2023 13:50, Roger Pau Monné wrote: > > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: > >> On 01.06.2023 11:17, Roger Pau Monné wrote: > >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > >>>> To avoid the need for a forward declaration of pit_load_count() in a > >>>> subsequent change, move it earlier in the file (along with its helper > >>>> callback). > >>>> > >>>> Signed-off-by: Jan Beulich <jbeul...@suse.com> > >>> > >>> Reviewed-by: Roger Pau Monné <roger....@citrix.com> > >> > >> Thanks. > >> > >>> Just a couple of nits, which you might also noticed but decided to not > >>> fix given this is just code movement. > >> > >> Indeed, I meant this to be pure code movement. Nevertheless I'd be happy > >> to take care of style issues, if that's deemed okay in a "pure code > >> movement" patch. However, ... > > > > It's just small style issues, so it would be OK for me. > > So I've done the obvious ones. There's a further signed/unsigned issue > which isn't quite as clear whether to take care of "on the fly": The > function's 2nd and 3rd parameters both ought to be unsigned, yet > throughout the full file the same issue exists many more times. So I > guess I'll leave those untouched for now.
No strong opinion regarding those, I'm fine if you want to adjust also to unsigned. Thanks, Roger.
