[xen-unstable-smoke test] 176292: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176292 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176292/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

[xen-unstable-smoke test] 176288: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176288 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176288/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

RE: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART

2023-01-30 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Monday, January 30, 2023 6:00 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified functi

[linux-linus test] 176279: trouble: blocked/broken/fail/pass

2023-01-30 Thread osstest service owner
flight 176279 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176279/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-pygr

[xen-4.17-testing test] 176281: trouble: blocked/broken/fail/pass/starved

2023-01-30 Thread osstest service owner
flight 176281 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176281/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken build-armhf

[ovmf test] 176287: all pass - PUSHED

2023-01-30 Thread osstest service owner
flight 176287 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176287/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 35091031329e741b25ed60ac51f4710d75d92310 baseline version: ovmf c59230bce1c6973af4190

RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map

2023-01-30 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Monday, January 30, 2023 5:40 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xe

[xen-unstable-smoke test] 176286: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176286 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176286/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

RE: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-30 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > Hi Henry, > > > +{ > > +paddr_t bank_start = INVALID_PADDR, bank_end = 0; > > +paddr_t region_end = region_start + region_size; >

Re: [PATCH v2 06/14] xen/riscv: introduce empty

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > To include is required > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V2: > - is a new empty header which is required to include > > --- > xen/arch/riscv/include/asm/cache.h | 6

Re: [PATCH v2 05/14] xen/riscv: introduce empty

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > To include is required > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V2: > - is a new empty header which is required to include > > --- > xen/arch/riscv/include/asm/string.h |

[xen-unstable-smoke test] 176285: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176285 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176285/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v2 02/14] xen/riscv: add header

2023-01-30 Thread Alistair Francis
On Fri, Jan 27, 2023 at 11:59 PM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/include/asm/asm.h | 54 > 1 file changed, 54 insertions(+)

Re: [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > Work with some registers requires csr command which is part of > Zicsr. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/arch.mk | 2 +- >

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-30 Thread Julien Grall
Hi Jan, On 30/01/2023 13:50, Jan Beulich wrote: On 30.01.2023 12:54, Oleksii wrote: Hi Jan, On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: On 27.01.2023 14:59, Oleksii Kurochko wrote: --- /dev/null +++ b/xen/arch/riscv/include/asm/processor.h @@ -0,0 +1,82 @@ +/* SPDX-License-Identifi

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Julien Grall
Hi Oleksii, On 30/01/2023 11:35, Oleksii wrote: Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instructi

[xen-unstable-smoke test] 176283: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176283 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176283/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-30 Thread Julien Grall
Hi, On 30/01/2023 11:40, Oleksii wrote: On Fri, 2023-01-27 at 14:54 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: +static inline void wfi(void) +{ +    __asm__ __volatile__ ("wfi"); I have starred at this line for a while and I am not quite too sure to

Re: [XEN v2 09/11] xen/arm: Introduce ARM_PA_32 to support 32 bit physical address

2023-01-30 Thread Julien Grall
Hi, On 17/01/2023 17:43, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h index 083acbd151..f9595b9098 100644 --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -37,9 +37,16 @@ typedef signed long long s64;

Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-30 Thread Julien Grall
Hi Henry, On 30/01/2023 04:05, Henry Wang wrote: diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..f0592370ea 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -143,6 +143,8 @@ void fw_unreserved_regions(paddr

Re: [PATCH] Add more rules to docs/misra/rules.rst

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Luca Fancellu wrote: > > On 30 Jan 2023, at 07:33, Jan Beulich wrote: > > > > On 27.01.2023 19:33, Stefano Stabellini wrote: > >> On Fri, 27 Jan 2023, Jan Beulich wrote: > >>> On 26.01.2023 19:54, Stefano Stabellini wrote: > >>> Looking back at the sheet, it says "rule alread

Re: [PATCH v2 1/2] xen/cppcheck: sort alphabetically cppcheck report entries

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Luca Fancellu wrote: > Sort alphabetically cppcheck report entries when producing the text > report, this will help comparing different reports and will group > together findings from the same file. > > The sort operation is performed with two criteria, the first one is > sort

Re: [PATCH v3 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Henry Wang wrote: > Similarly as the static regions defined in bootinfo.reserved_mem, > the bootmodule regions defined in bootinfo.modules should also not > be overlapping with memory regions in either bootinfo.reserved_mem > or bootinfo.modules. > > Therefore, this commit int

Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Henry Wang wrote: > As we are having more and more types of static region, and all of > these static regions are defined in bootinfo.reserved_mem, it is > necessary to add the overlap check of reserved memory regions in Xen, > because such check will help user to identify the m

Re: [PATCH v3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Juergen Gross wrote: > On 30.01.23 10:18, Julien Grall wrote: > > Hi Juergen, > > > > On 30/01/2023 09:09, Juergen Gross wrote: > > > The Xenstore related documentation is currently to be found in > > > docs/misc/9pfs.pandoc, instead of the related header file > > > xen/includ

Re: [XEN v6] xen/arm: Probe the load/entry point address of an uImage correctly

2023-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Julien Grall wrote: > Hi Stefano, > > On 25/01/2023 21:06, Stefano Stabellini wrote: > > On Wed, 25 Jan 2023, Ayan Kumar Halder wrote: > > > Currently, kernel_uimage_probe() does not read the load/entry point > > > address > > > set in the uImge header. Thus, info->zimage.star

[xen-unstable test] 176277: regressions - trouble: blocked/broken/fail/pass/starved

2023-01-30 Thread osstest service owner
flight 176277 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176277/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-inst

[ovmf test] 176282: all pass - PUSHED

2023-01-30 Thread osstest service owner
flight 176282 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176282/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c59230bce1c6973af4190b418971c1d008340cc4 baseline version: ovmf 4b384c21ad02fbf5eda25

Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit

2023-01-30 Thread Julien Grall
Hi Jan, On 23/12/2022 11:31, Julien Grall wrote: On 20/12/2022 15:30, Jan Beulich wrote: On 16.12.2022 12:48, Julien Grall wrote: From: Hongyan Xia This avoids the assumption that boot pages are in the direct map. Signed-off-by: Hongyan Xia Signed-off-by: Julien Grall Reviewed-by: Jan B

Re: [PATCH] x86: idle domains don't have a domain-page mapcache

2023-01-30 Thread Julien Grall
Hi Jan, On 05/01/2023 11:09, Jan Beulich wrote: First and foremost correct a comment implying the opposite. Then, to make things more clear PV-vs-HVM-wise, move the PV check earlier in the function, making it unnecessary for both callers to perform the check individually. Finally return NULL fro

Re: [PATCH v5 2/5] xen/arm64: Rework the memory layout

2023-01-30 Thread Julien Grall
On 30/01/2023 09:08, Michal Orzel wrote: Hi Julien, Hi Michal, On 27/01/2023 20:55, Julien Grall wrote: From: Julien Grall Xen is currently not fully compliant with the Arm Arm because it will switch the TTBR with the MMU on. In order to be compliant, we need to disable the MMU befor

Re: [PATCH v5 1/5] xen/arm32: head: Widen the use of the temporary mapping

2023-01-30 Thread Julien Grall
On 30/01/2023 08:58, Michal Orzel wrote: Hi Julien, Hi Michal, On 27/01/2023 20:55, Julien Grall wrote: From: Julien Grall At the moment, the temporary mapping is only used when the virtual runtime region of Xen is clashing with the physical region. In follow-up patches, we will rew

Re: [PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()

2023-01-30 Thread Julien Grall
Hi, I forgot to CC the maintainers. Please ignore this version. Cheers, On 30/01/2023 18:28, Julien Grall wrote: From: Julien Grall The lock is not meant to be modified by _rw_is{,_write}_locked(). So constify it. This is helpful to be able to assert if the lock is taken when the underlying

[PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()

2023-01-30 Thread Julien Grall
From: Julien Grall The lock is not meant to be modified by _rw_is{,_write}_locked(). So constify it. This is helpful to be able to assert if the lock is taken when the underlying structure is const. Signed-off-by: Julien Grall --- xen/include/xen/rwlock.h | 4 ++-- 1 file changed, 2 insertion

[PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()

2023-01-30 Thread Julien Grall
From: Julien Grall The lock is not meant to be modified by _rw_is{,_write}_locked(). So constify it. This is helpful to be able to assert if the lock is taken when the underlying structure is const. Signed-off-by: Julien Grall --- xen/include/xen/rwlock.h | 4 ++-- 1 file changed, 2 insertion

Re: [PATCH 0/6] tools: Switch to non-truncating XENVER_* ops

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:30PM +, Andrew Cooper wrote: > This is the tools side of the Xen series posted previously. There's also python bindings using xc_version(), is it something we want to update? Cheers, -- Anthony PERARD

Re: [PATCH 6/6] tools: Introduce a xc_xenver_buildid() wrapper

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:36PM +, Andrew Cooper wrote: > ... which converts binary content to hex automatically. > > Update libxl to match. No API/ABI change. > > This removes a latent bug for cases when the buildid is longer than 4092 > bytes. > > Signed-off-by: Andrew Cooper Reviewe

Re: [PATCH 5/6] tools: Introduce a non-truncating xc_xenver_cmdline()

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:35PM +, Andrew Cooper wrote: > Update libxl to match. No API/ABI change. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 4/6] tools: Introduce a non-truncating xc_xenver_changeset()

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:34PM +, Andrew Cooper wrote: > Update libxl and the ocaml stubs to match. No API/ABI change in either. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 3/6] tools: Introduce a non-truncating xc_xenver_capabilities()

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:33PM +, Andrew Cooper wrote: > Update libxl and the ocaml stubs to match. No API/ABI change in either. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 2/6] tools: Introduce a non-truncating xc_xenver_extraversion()

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:32PM +, Andrew Cooper wrote: > ... which uses XENVER_extraversion2. > > In order to do sensibly, use manual hypercall buffer handling. Not only does > this avoid an extra bounce buffer (we need to strip the xen_varbuf_t header > anyway), it's also shorter and eas

Re: [PATCH 1/6] tools/libxc: Move xc_version() out of xc_private.c into its own file

2023-01-30 Thread Anthony PERARD
On Tue, Jan 17, 2023 at 01:53:31PM +, Andrew Cooper wrote: > kexec-tools uses xc_version(), meaning that it is not a private API. As we're > going to extend the functionality substantially, move it to its own file. > > Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Ant

[PATCH v4] xen/x86: public: add TSC defines for cpuid leaf 4

2023-01-30 Thread Krister Johansen
Cpuid leaf 4 contains information about how the state of the tsc, its mode, and some additional information. A commit that is queued for linux would like to use this to determine whether the tsc mode has been set to 'no emulation' in order to make some decisions about which clocksource is more rel

Re: [PATCH v3] xen/x86: public: add TSC defines for cpuid leaf 4

2023-01-30 Thread Krister Johansen
Hi Jan, On Mon, Jan 30, 2023 at 09:22:11AM +0100, Jan Beulich wrote: > On 27.01.2023 19:51, Krister Johansen wrote: > > --- a/xen/include/public/arch-x86/cpuid.h > > +++ b/xen/include/public/arch-x86/cpuid.h > > @@ -72,6 +72,15 @@ > > * Sub-leaf 2: EAX: host tsc frequency in kHz > > */ > > >

[libvirt test] 176276: trouble: blocked/broken/pass

2023-01-30 Thread osstest service owner
flight 176276 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176276/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

[ovmf test] 176280: all pass - PUSHED

2023-01-30 Thread osstest service owner
flight 176280 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176280/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4b384c21ad02fbf5eda25a1516cc72fa66b150f6 baseline version: ovmf bb1376254803bfdaa012c

Re: [XEN PATCH v4 3/3] build: compat-xlat-header.py: optimisation to search for just '{' instead of [{}]

2023-01-30 Thread Andrew Cooper
On 23/01/2023 10:30 am, Anthony PERARD wrote: > On Fri, Jan 20, 2023 at 06:26:14PM +, Andrew Cooper wrote: >> On 19/01/2023 3:22 pm, Anthony PERARD wrote: >>> `fields` and `extrafields` always all the parts of a sub-struct, so >>> when there is '}', there is always a '{' before it. Also, both a

[xen-4.17-testing test] 176275: trouble: blocked/broken/fail/pass/starved

2023-01-30 Thread osstest service owner
flight 176275 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176275/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken test-

Re: [PATCH] Changelog: Add details about new features for SPR

2023-01-30 Thread Andrew Cooper
On 27/01/2023 11:40 am, Henry Wang wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Cooper >> Subject: [PATCH] Changelog: Add details about new features for SPR >> >> Signed-off-by: Andrew Cooper > Thanks for remembering this :) > > Acked-by: Henry Wang Thanks. I'll commit t

Re: Proposal for consistent Kconfig usage by the hypervisor build system

2023-01-30 Thread Jan Beulich
On 30.01.2023 13:27, Julien Grall wrote: > On 12/01/2023 16:52, Jan Beulich wrote: >> It was additionally suggested that, for a better user experience, unmet >> dependencies which are known to result in build failures (which at times may >> be >> hard to associate back with the original cause) wou

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-30 Thread Jan Beulich
On 30.01.2023 12:54, Oleksii wrote: > Hi Jan, > > On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: >> On 27.01.2023 14:59, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/processor.h >>> @@ -0,0 +1,82 @@ >>> +/* SPDX-License-Identifier: MIT */ >>> +/

Re: [PATCH] Add more rules to docs/misra/rules.rst

2023-01-30 Thread Jan Beulich
On 30.01.2023 10:32, Luca Fancellu wrote: > > >> On 30 Jan 2023, at 07:33, Jan Beulich wrote: >> >> On 27.01.2023 19:33, Stefano Stabellini wrote: >>> On Fri, 27 Jan 2023, Jan Beulich wrote: On 26.01.2023 19:54, Stefano Stabellini wrote: Looking back at the sheet, it says "rule already

Re: [PATCH v2 03/14] xen/riscv: add

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > The following changes were done in Xen code base in comparison with OpenSBI: > * Remove "#include " as most of the stuff inside > it is present in Xen code base. > * Add macros _UL and _ULL as they were in before > * Add SATP3

Re: [PATCH v2 04/14] xen/riscv: add header

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > The following changes were made in comparison with from > Linux: > * remove all defines as they are defined in riscv_encoding.h > * leave only csr_* macros > > Origin: https://github.com/torvalds/linux.git 2475bf0250de > Signed-off-

Re: [XEN v6] xen/arm: Probe the load/entry point address of an uImage correctly

2023-01-30 Thread Julien Grall
Hi Stefano, On 25/01/2023 21:06, Stefano Stabellini wrote: On Wed, 25 Jan 2023, Ayan Kumar Halder wrote: Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to trea

Re: Proposal for consistent Kconfig usage by the hypervisor build system

2023-01-30 Thread Julien Grall
Hi Jan, Apologies for the late reply. On 12/01/2023 16:52, Jan Beulich wrote: (re-sending with REST on Cc, as requested at the community call) At present we use a mix of Makefile and Kconfig driven capability checks for tool chain components involved in the building of the hypervisor. What ap

Re: [PATCH v4 1/3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Julien Grall
Hi, On 30/01/2023 10:08, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at

[linux-linus test] 176274: trouble: blocked/broken/fail/pass/starved

2023-01-30 Thread osstest service owner
flight 176274 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176274/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

[PATCH v3] x86/ucode/AMD: apply the patch early on every logical thread

2023-01-30 Thread Sergey Dyasli
The original issue has been reported on AMD Bulldozer-based CPUs where ucode loading loses the LWP feature bit in order to gain the IBPB bit. LWP disabling is per-SMT/CMT core modification and needs to happen on each sibling thread despite the shared microcode engine. Otherwise, logical CPUs will e

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-30 Thread Oleksii
Hi Jan, On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: > On 27.01.2023 14:59, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/processor.h > > @@ -0,0 +1,82 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/***

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Juergen Gross
On 30.01.23 12:35, Oleksii wrote: Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combinati

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-30 Thread Oleksii
Hi Julien, On Fri, 2023-01-27 at 14:54 +, Julien Grall wrote: > Hi Oleksii, > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > +static inline void wfi(void) > > +{ > > +    __asm__ __volatile__ ("wfi"); > > I have starred at this line for a while and I am not quite too sure > to > underst

Re: [PATCH v2 04/14] xen/riscv: add header

2023-01-30 Thread Oleksii
On Fri, 2023-01-27 at 15:10 +0100, Jan Beulich wrote: > On 27.01.2023 14:59, Oleksii Kurochko wrote: > > The following changes were made in comparison with from > > Linux: > >   * remove all defines as they are defined in riscv_encoding.h > >   * leave only csr_* macros > > > > Origin: https://gi

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Oleksii
Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: > Hi Oleksii, > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > The patch introduces macros: BUG(), WARN(), run_in_exception(), > > assert_failed. > > > > The implementation uses "ebreak" instruction in combination with > > diff

Re: [PATCH v2 1/2] xen/cppcheck: sort alphabetically cppcheck report entries

2023-01-30 Thread Luca Fancellu
> On 30 Jan 2023, at 11:22, Michal Orzel wrote: > > Hi Luca, > > On 30/01/2023 12:01, Luca Fancellu wrote: >> >> >> Sort alphabetically cppcheck report entries when producing the text >> report, this will help comparing different reports and will group >> together findings from the same file

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Oleksii
On Fri, 2023-01-27 at 15:34 +0100, Jan Beulich wrote: > On 27.01.2023 14:59, Oleksii Kurochko wrote: > > The patch introduces macros: BUG(), WARN(), run_in_exception(), > > assert_failed. > > > > The implementation uses "ebreak" instruction in combination with > > diffrent bug frame tables (for ea

Re: [PATCH v2 1/2] xen/cppcheck: sort alphabetically cppcheck report entries

2023-01-30 Thread Michal Orzel
Hi Luca, On 30/01/2023 12:01, Luca Fancellu wrote: > > > Sort alphabetically cppcheck report entries when producing the text > report, this will help comparing different reports and will group > together findings from the same file. > > The sort operation is performed with two criteria, the fir

Re: [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h

2023-01-30 Thread Oleksii
On Fri, 2023-01-27 at 15:43 +0100, Michal Orzel wrote: > Hi Oleksii, > > On 27/01/2023 14:59, Oleksii Kurochko wrote: > > > > > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > >  - Leave only the latest "grep ..." > > --- > >  automation/scripts/qemu-smoke-riscv64.sh | 2 +- > >  

[PATCH v2 0/2] Cppcheck MISRA analysis improvements

2023-01-30 Thread Luca Fancellu
This serie is adding a way to skip the check for some rules that the Xen project has agreed to follow, this is because cppcheck reports too many false-positive on some rules and it would be easier in a first phase to skip the check on them and allow the tool to be mature enough before using it on t

[PATCH v2 1/2] xen/cppcheck: sort alphabetically cppcheck report entries

2023-01-30 Thread Luca Fancellu
Sort alphabetically cppcheck report entries when producing the text report, this will help comparing different reports and will group together findings from the same file. The sort operation is performed with two criteria, the first one is sorting by misra rule, the second one is sorting by file.

[PATCH v2 2/2] xen/cppcheck: add parameter to skip given MISRA rules

2023-01-30 Thread Luca Fancellu
Add parameter to skip the passed MISRA rules during the cppcheck analysis, the rules are specified as a list of comma separated rules with the MISRA number notation (e.g. 1.1,1.3,...). Modify convert_misra_doc.py script to take an extra parameter giving a list of MISRA rule to be skipped, comma se

Re: [PATCH v5 4/5] xen/arm64: mm: Rework switch_ttbr()

2023-01-30 Thread Bertrand Marquis
Hi Julien, On 27 Jan 2023, at 20:55, Julien Grall wrote: From: Julien Grall At the moment, switch_ttbr() is switching the TTBR whilst the MMU is still on. Switching TTBR is like replacing existing mappings with new ones. So we need to follow the break-before-make sequence. In this case, it m

[ANNOUNCE] Call for agenda items for 2 February Community Call @ 1600 UTC

2023-01-30 Thread George Dunlap
Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/cgGa9qrIcYsDwlFMii+tBJv+/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. N

[PATCH v4 3/3] xen/public: fix 9pfs documentation of connection sequence

2023-01-30 Thread Juergen Gross
The documented connection sequence in xen/include/public/io/9pfs.h has a bug: the frontend needs to wait for the backend to have published its features before being able to allocate its rings and event-channels. While correcting that, make it clear that there might be multiple rings and event-chan

[PATCH v4 2/3] xen/public: fix 9pfs Xenstore entry documentation

2023-01-30 Thread Juergen Gross
In xen/include/public/io/9pfs.h the documentation regarding the Xenstore entries isn't reflecting reality: the "tag" Xenstore entry is on the frontend side, not on the backend one. Signed-off-by: Juergen Gross --- V4: - patch split off (Julien Grall) --- xen/include/public/io/9pfs.h | 12 ++-

[PATCH v4 1/3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Juergen Gross
The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at the document, but the given file name is wrong. A

[PATCH v4 0/3] xen/public move and fix 9pfs documentation

2023-01-30 Thread Juergen Gross
Changes in V4: - patch split into 3 patches Juergen Gross (3): xen/public: move xenstore related doc into 9pfs.h xen/public: fix 9pfs Xenstore entry documentation xen/public: fix 9pfs documentation of connection sequence docs/misc/9pfs.pandoc| 153 +- xe

Re: [PATCH] xen/common: Constify the parameter of _spin_is_locked()

2023-01-30 Thread Julien Grall
On 30/01/2023 08:11, Jan Beulich wrote: On 27.01.2023 20:05, Julien Grall wrote: From: Julien Grall The lock is not meant to be modified by _spin_is_locked(). So constify it. This is helpful to be able to assert the locked is taken when the underlying structure is const. Signed-off-by: Ju

Re: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART

2023-01-30 Thread Julien Grall
On 30/01/2023 06:24, Penny Zheng wrote: Hi, Julien Hi Penny, -Original Message- From: Julien Grall Sent: Sunday, January 29, 2023 3:43 PM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH

Weekly meeting - Xen Gitlab Issues Review

2023-01-30 Thread Marc Ungeschikts
Hi everydody, last Friday, during the Backlog Review meeting, we decided to schedule a weekly meeting every Friday-14:00(UTC) to talk about Xen Gitlab issues [https://gitlab.com/groups/xen-project/-/issues](discussion, grooming, triage,...) Jitsi Room: https://meet.jit.si/XenIssuesReview [http

[ovmf test] 176278: all pass - PUSHED

2023-01-30 Thread osstest service owner
flight 176278 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176278/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bb1376254803bfdaa012c62f1cf6d6b26161cfe7 baseline version: ovmf e7aac7fc137e247edad22

Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map

2023-01-30 Thread Julien Grall
Hi Penny, On 30/01/2023 05:45, Penny Zheng wrote: There are three types of MPU regions during boot-time: 1. Fixed MPU region Regions like Xen text section, Xen heap section, etc. 2. Boot-only MPU region Regions like Xen init sections, etc. It will be removed at the end of booting. 3. Regions

Re: [PATCH v3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Julien Grall
Hi, On 30/01/2023 09:23, Juergen Gross wrote: On 30.01.23 10:18, Julien Grall wrote: Hi Juergen, On 30/01/2023 09:09, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like

Re: [PATCH] Add more rules to docs/misra/rules.rst

2023-01-30 Thread Luca Fancellu
> On 30 Jan 2023, at 07:33, Jan Beulich wrote: > > On 27.01.2023 19:33, Stefano Stabellini wrote: >> On Fri, 27 Jan 2023, Jan Beulich wrote: >>> On 26.01.2023 19:54, Stefano Stabellini wrote: >>> Looking back at the sheet, it says "rule already followed by >>> the community in most cases" whic

Re: [PATCH v3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Juergen Gross
On 30.01.23 10:18, Julien Grall wrote: Hi Juergen, On 30/01/2023 09:09, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols

Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2023-01-30 Thread Josef Johansson
On 11/21/22 11:21, Roger Pau Monne wrote: When running as a Xen dom0 the number of CPUs available to Linux can be different from the number of CPUs present on the system, but in order to properly fetch processor performance related data _PDC must be executed on all the physical CPUs online on the

Re: [PATCH v3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Julien Grall
Hi Juergen, On 30/01/2023 09:09, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header poin

Re: [PATCH v5 4/5] xen/arm64: mm: Rework switch_ttbr()

2023-01-30 Thread Michal Orzel
Hi Julien, On 27/01/2023 20:55, Julien Grall wrote: > > > From: Julien Grall > > At the moment, switch_ttbr() is switching the TTBR whilst the MMU is > still on. > > Switching TTBR is like replacing existing mappings with new ones. So > we need to follow the break-before-make sequence. > > I

Re: [PATCH 3/3] xen/acpi: upload power and performance related data from a PVH dom0

2023-01-30 Thread Josef Johansson
On 11/21/22 11:21, Roger Pau Monne wrote: When running as a PVH dom0 the ACPI MADT is crafted by Xen in order to report the correct numbers of vCPUs that dom0 has, so the host MADT is not provided to dom0. This creates issues when parsing the power and performance related data from ACPI dynami

[PATCH v3] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Juergen Gross
The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at the document, but the given file name is wrong. A

Re: [PATCH v5 2/5] xen/arm64: Rework the memory layout

2023-01-30 Thread Michal Orzel
Hi Julien, On 27/01/2023 20:55, Julien Grall wrote: > > > From: Julien Grall > > Xen is currently not fully compliant with the Arm Arm because it will > switch the TTBR with the MMU on. > > In order to be compliant, we need to disable the MMU before > switching the TTBR. The implication is th

Re: [PATCH v5 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping

2023-01-30 Thread Julien Grall
On 27/01/2023 19:55, Julien Grall wrote: From: Julien Grall In follow-up patches we will need to have part of Xen identity mapped in order to safely switch the TTBR. On some platform, the identity mapping may have to start at 0. If we always keep the identity region mapped, NULL pointer der

Re: [PATCH v5 1/5] xen/arm32: head: Widen the use of the temporary mapping

2023-01-30 Thread Michal Orzel
Hi Julien, On 27/01/2023 20:55, Julien Grall wrote: > > > From: Julien Grall > > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. > > In follow-up patches, we will rework how secondary CPU bring-up works > and it

Re: [PATCH v2] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Juergen Gross
On 30.01.23 09:17, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at the doc

Re: [PATCH v2] Add more rules to docs/misra/rules.rst

2023-01-30 Thread Jan Beulich
On 27.01.2023 19:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > As agreed during the last MISRA C discussion, I am adding the following > MISRA C rules: 7.1, 7.3, 18.3. > > I am also adding 13.1 that was "agreed pending an analysis on the amount > of violations". There are zero vio

Re: [PATCH v3] xen/x86: public: add TSC defines for cpuid leaf 4

2023-01-30 Thread Jan Beulich
On 27.01.2023 19:51, Krister Johansen wrote: > --- a/xen/include/public/arch-x86/cpuid.h > +++ b/xen/include/public/arch-x86/cpuid.h > @@ -72,6 +72,15 @@ > * Sub-leaf 2: EAX: host tsc frequency in kHz > */ > > +#define XEN_CPUID_TSC_EMULATED (1u << 0) > +#define XEN_CPUID_HOST_T

[PATCH v2] xen/public: move xenstore related doc into 9pfs.h

2023-01-30 Thread Juergen Gross
The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at the document, but the given file name is wrong. A

Re: [PATCH] xen/common: Constify the parameter of _spin_is_locked()

2023-01-30 Thread Jan Beulich
On 27.01.2023 20:05, Julien Grall wrote: > From: Julien Grall > > The lock is not meant to be modified by _spin_is_locked(). So constify > it. > > This is helpful to be able to assert the locked is taken when the > underlying structure is const. > > Signed-off-by: Julien Grall Reviewed-by: Ja

Re: Ping: [PATCH] Argo: don't obtain excess page references

2023-01-30 Thread Jan Beulich
On 30.01.2023 05:35, Christopher Clark wrote: > On Mon, Nov 21, 2022 at 4:41 AM Jan Beulich wrote: > >> On 11.10.2022 11:28, Jan Beulich wrote: >>> find_ring_mfn() already holds a page reference when trying to obtain a >>> writable type reference. We shouldn't make assumptions on the general >>>