Hi Jan, On Mon, Jan 30, 2023 at 09:22:11AM +0100, Jan Beulich wrote: > On 27.01.2023 19:51, Krister Johansen wrote: > > --- a/xen/include/public/arch-x86/cpuid.h > > +++ b/xen/include/public/arch-x86/cpuid.h > > @@ -72,6 +72,15 @@ > > * Sub-leaf 2: EAX: host tsc frequency in kHz > > */ > > > > +#define XEN_CPUID_TSC_EMULATED (1u << 0) > > +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1) > > +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2) > > + > > +#define XEN_CPUID_TSC_MODE_DEFAULT (0) > > +#define XEN_CPUID_TSC_MODE_ALWAYS_EMULATE (1u) > > +#define XEN_CPUID_TSC_MODE_NEVER_EMULATE (2u) > > +#define XEN_CPUID_TSC_MODE_NEVER_EMULATE_TSC_AUX (3u) > > While perhaps it doesn't matter much with the mode no longer supported, > I'd prefer if here we used the original name (PVRDTSCP) as well. > Preferably with that adjustment (which once again I'd be happy to do > while committing, albeit I'd like to wait with that until osstest is in > a better mood again) > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks for the additional feedback. I'll send you a v4 that makes the requested modification. -K
