[PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c

2022-10-14 Thread Vikram Garhwal
Extract common functionalities from hw/i386/xen/xen-hvm.c and move them to hw/xen/xen-hvm-common.c. These common functions are useful for creating an IOREQ server. xen_hvm_init_pc() contains the arch independent code for creating and mapping a IOREQ server, connecting memory and IO listeners, init

[PATCH v1 10/12] hw/arm: introduce xenpv machine

2022-10-14 Thread Vikram Garhwal
Add a new machine xenpv which creates a IOREQ server to register/connect with Xen Hypervisor. Xen IOREQ connection expect the TARGET_PAGE_SIZE to 4096, and the xenpv machine on ARM will have no CPU definitions. We need to define TARGET_PAGE_SIZE appropriately ourselves. Optional: When CONFIG_TPM

[PATCH v1 08/12] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2022-10-14 Thread Vikram Garhwal
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Signed-off-by: Stefano Stabellini --- hw/xen/xen-hvm-common.c | 7 ++- 1 file cha

[PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2022-10-14 Thread Vikram Garhwal
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated XenIOS

[PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state

2022-10-14 Thread Vikram Garhwal
xenstore_record_dm_state() will also be used in aarch64 xenpv machine. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini --- accel/xen/xen-all.c | 2 +- include/hw/xen/xen.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/accel/xen/xen-all.c b/accel/xen/xen-

[PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq and arch_xen_set_memory

2022-10-14 Thread Vikram Garhwal
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also move handle_vmport_ioreq to arch_handle_ioreq. NOTE: This patch breaks the build. Next patch fixes the build issue. Re

[PATCH v1 07/12] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2022-10-14 Thread Vikram Garhwal
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off-by

[PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc

2022-10-14 Thread Vikram Garhwal
In preparation to moving most of xen-hvm code to an arch-neutral location, move non IOREQ references to: - xen_get_vmport_regs_pfn - xen_suspend_notifier - xen_wakeup_notifier - xen_ram_init towards the end of the xen_hvm_init_pc() function. This is done to keep the common ioreq functions in one

[PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub

2022-10-14 Thread Vikram Garhwal
Build fails when have_xen_pci_passthrough is disabled. This is because of incorrect build configuration for xen_pt_stub.c. Signed-off-by: Stefano Stabellini Signed-off-by: Vikram Garhwal --- hw/xen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/meson.buil

[PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2022-10-14 Thread Vikram Garhwal
xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini --- hw/i386/meson.build

[xen-4.14-testing test] 173725: regressions - trouble: broken/fail/pass

2022-10-14 Thread osstest service owner
flight 173725 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/173725/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-vhd 12 debia

[xen-unstable-smoke test] 173786: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173786 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173786/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 173457 test-armhf-a

[qemu-mainline test] 173722: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173722 qemu-mainline real [real] flight 173788 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173722/ http://logs.test-lab.xenproject.org/osstest/logs/173788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[libvirt test] 173742: tolerable all pass - PUSHED

2022-10-14 Thread osstest service owner
flight 173742 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173742/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 173671 test-armhf-armhf-libvirt-qcow2 15 saveres

[xen-unstable-smoke test] 173776: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173776 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173776/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 173457 test-armhf-a

[xen-4.15-testing test] 173720: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173720 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/173720/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 172547 test-armhf-arm

[xen-4.16-testing bisection] complete test-arm64-arm64-xl-seattle

2022-10-14 Thread osstest service owner
branch xen-4.16-testing xenbranch xen-4.16-testing job test-arm64-arm64-xl-seattle testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://xenbits.x

privcmd.c not calling set_phys_to_machine

2022-10-14 Thread Stefano Stabellini
Hi Juergen and all, I am writing again to ask a question about privcmd.c in PV dom0 x86. This is related to the previous pin_user_pages_fast issue: https://marc.info/?l=xen-devel&m=166268914727630 https://marc.info/?l=xen-devel&m=166322385912052 In summary this is the situation: 1. domU (HVM)

Re: [PATCH v2 0/3] Yocto Gitlab CI

2022-10-14 Thread Stefano Stabellini
On Wed, 12 Oct 2022, Bertrand Marquis wrote: > This patch series is a first attempt to check if we could use Yocto in > gitlab ci to build and run xen on qemu for arm, arm64 and x86. > > The first patch is creating a container with all elements required to > build Yocto, a checkout of the yocto la

Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init

2022-10-14 Thread Julien Grall
Hi Stewart, On 14/10/2022 20:23, Stewart Hildebrand wrote: On 10/14/22 04:22, Julien Grall wrote: Hi, On 14/10/2022 08:16, Jan Beulich wrote: On 14.10.2022 04:53, Stewart Hildebrand wrote: Signed-off-by: Stewart Hildebrand I guess a non-empty description and a Fixes: tag would be nice.

[xen-unstable-smoke test] 173760: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173760 xen-unstable-smoke real [real] flight 173770 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173760/ http://logs.test-lab.xenproject.org/osstest/logs/173770/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

[PATCH v2] xen/arm: mark handle_linux_pci_domain() __init

2022-10-14 Thread Stewart Hildebrand
All functions in domain_build.c should be marked __init. This was spotted when building the hypervisor with -Og. Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices Signed-off-by: Stewart Hildebrand --- v1 -> v2: Add Fixes: tag Add patch description --- xen/arch/arm/domain_build.

Re: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets prerequisites

2022-10-14 Thread Andrew Cooper
On 13/10/2022 14:05, Anthony Perard wrote: > No need for $(AUTOSRCS), GNU make can generate them as needed when > trying to build them as needed when trying to build the object. Also, > those two AUTOSRCS don't need to be a prerequisite of "all". As for > the "clean" target, those two files are alr

Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init

2022-10-14 Thread Stewart Hildebrand
On 10/14/22 04:22, Julien Grall wrote: Hi, On 14/10/2022 08:16, Jan Beulich wrote: On 14.10.2022 04:53, Stewart Hildebrand wrote: Signed-off-by: Stewart Hildebrand I guess a non-empty description and a Fixes: tag would be nice. Okay, I will send a v2 with the following description: All fu

Re: [XEN PATCH for-4.17 v5 10/17] libs: Fix auto-generation of version-script for unstable libs

2022-10-14 Thread Andrew Cooper
On 13/10/2022 14:05, Anthony Perard wrote: > When there isn't a version-script for a shared library (like for > unstable libs), we create one based on the current Xen version. But > that version-script became out-of-date as soon as Xen's version > changes and make as no way to regenerate the versio

Re: Need guidance to support reading GICR_TYPER (64 bit register) on Aarch32_v8r

2022-10-14 Thread Stefano Stabellini
On Thu, 13 Oct 2022, Ayan Kumar Halder wrote: > Hi Arm mantainers/Folks, > > Please refer to the discussion > https://github.com/zephyrproject-rtos/zephyr/pull/51163 . > > We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed virtual > platform. > > Zephyr is trying to read GICR_TY

Re: [XEN PATCH for-4.17 v5 06/17] tools/hotplug: Generate "hotplugpath.sh" with configure

2022-10-14 Thread Andrew Cooper
On 13/10/2022 14:05, Anthony Perard wrote: > Signed-off-by: Anthony PERARD It occurs to me that with this sorted, there's only a single remaining user of buildmakevars2file, and that's for stubdompath.sh.  It would be great if we could convert that final user too. ~Andrew

Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap

2022-10-14 Thread Julien Grall
On 14/10/2022 10:31, Henry Wang wrote: Hi Julien, Hi, -Original Message- From: Julien Grall +Users should be mindful that the static heap should at least satisfy the +allocation of the P2M maps for all guests. Currently, the minimal requirement +of per-domain P2M pages pool i

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer

2022-10-14 Thread George Dunlap
On Tue, Sep 20, 2022 at 11:23 AM Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > > I have two (non exclusive) ideas here: > 1. If old_cpu is actually still available, do not move it at all. > 2. Use sched_migrate() instead of sched_set_res(). > Other possibilities: 3. Mak

Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Julien Grall
Hi Xenia, On 14/10/2022 16:05, Xenia Ragiadakou wrote: On 10/14/22 13:22, Xenia Ragiadakou wrote: On 10/14/22 13:04, Julien Grall wrote: Hi Xenia, On 14/10/2022 10:46, Xenia Ragiadakou wrote: On 10/13/22 15:39, Julien Grall wrote: Hi, On 13/10/2022 13:29, Henry Wang wrote: -Original

Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere else

2022-10-14 Thread Anthony PERARD
On Thu, Oct 13, 2022 at 02:05:01PM +0100, Anthony PERARD wrote: > Patch "tools: Add -Werror by default to all tools/" have added > "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > makefiles as it is now duplicated. > > Signed-off-by: Anthony PERARD > Acked-by: Christian Lindig

Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Xenia Ragiadakou
On 10/14/22 13:22, Xenia Ragiadakou wrote: On 10/14/22 13:04, Julien Grall wrote: Hi Xenia, On 14/10/2022 10:46, Xenia Ragiadakou wrote: On 10/13/22 15:39, Julien Grall wrote: Hi, On 13/10/2022 13:29, Henry Wang wrote: -Original Message- From: Jan Beulich Assuming you have 4 (N)

[xen-4.16-testing test] 173702: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173702 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/173702/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 12 debian-di-installfail REGR. vs. 172623 test-arm64-arm

Re: [PATCH] argo: Fixes to argo_dprintk()

2022-10-14 Thread Jan Beulich
On 14.10.2022 16:02, Andrew Cooper wrote: > Rewrite argo_dprintk() so printk() format typechecking can always be > performed. This also fixes the evaluation of parameters. Emit the messages > at XENLOG_DEBUG. I guess I don't really understand the "fixes the evaluation of parameters" aspect: What

[xen-unstable-smoke test] 173754: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173754 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173754/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 14 guest-start fail REGR. vs. 173457 Tests which

Re: [PATCH] argo: Fixes to argo_dprintk()

2022-10-14 Thread Jason Andryuk
On Fri, Oct 14, 2022 at 10:02 AM Andrew Cooper wrote: > > Rewrite argo_dprintk() so printk() format typechecking can always be > performed. This also fixes the evaluation of parameters. Emit the messages > at XENLOG_DEBUG. > > Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Thanks, J

[PATCH] argo: Fixes to argo_dprintk()

2022-10-14 Thread Andrew Cooper
Rewrite argo_dprintk() so printk() format typechecking can always be performed. This also fixes the evaluation of parameters. Emit the messages at XENLOG_DEBUG. Signed-off-by: Andrew Cooper --- CC: Jason Andryuk CC: Christopher Clark --- xen/common/argo.c | 14 ++ 1 file changed,

Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE

2022-10-14 Thread Jason Andryuk
On Fri, Oct 14, 2022 at 9:22 AM Andrew Cooper wrote: > > On 07/10/2022 20:31, Jason Andryuk wrote: > > I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently > > trip. It was in OpenXT with the viptables patch applied. > > > > dom10 shuts down. > > dom7 is REJECTED sending to dom

[ovmf test] 173752: all pass - PUSHED

2022-10-14 Thread osstest service owner
flight 173752 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173752/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf baseline version: ovmf e0200cc47a691291ce1ad

Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE

2022-10-14 Thread Andrew Cooper
On 07/10/2022 20:31, Jason Andryuk wrote: > I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently > trip. It was in OpenXT with the viptables patch applied. > > dom10 shuts down. > dom7 is REJECTED sending to dom10. > dom7 shuts down and this ASSERT trips for dom10. > > The argo_

Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles

2022-10-14 Thread Christian Lindig
On 13 Oct 2022, at 14:04, Anthony PERARD mailto:anthony.per...@citrix.com>> wrote: Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v5 Changes in v5: - rebased on staging - added "tools: Rework linking option

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > On 14.10.2022 13:04, Henry Wang wrote: > >> -Original Message- > >> From: Jan Beulich > >> > >>> My initial thought is the "els

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Jan Beulich
On 14.10.2022 13:04, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >>> My initial thought is the "else if" part in p2m_set_allocation. It might be >>> wrong. Would the code below seems ok to you? >>> >>> int err; >>> >>> do { >>> err = p2m_teardown_allocation(d) >>> }

Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go

2022-10-14 Thread Andrew Cooper
On 14/10/2022 12:42, George Dunlap wrote: On 14 Oct 2022, at 12:37, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: On 14/10/2022 12:24, George Dunlap wrote: On 13 Oct 2022, at 16:00, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: On 13/10/2022 14:05, Anthony Perard wrote: di

Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go

2022-10-14 Thread George Dunlap
> On 14 Oct 2022, at 12:37, Andrew Cooper wrote: > > On 14/10/2022 12:24, George Dunlap wrote: >>> On 13 Oct 2022, at 16:00, Andrew Cooper wrote: >>> >>> On 13/10/2022 14:05, Anthony Perard wrote: diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.p

Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go

2022-10-14 Thread Andrew Cooper
On 14/10/2022 12:24, George Dunlap wrote: >> On 13 Oct 2022, at 16:00, Andrew Cooper wrote: >> >> On 13/10/2022 14:05, Anthony Perard wrote: >>> diff --git a/tools/golang/xenlight/gengotypes.py >>> b/tools/golang/xenlight/gengotypes.py >>> index ac1cf060dd..ff4c2ad216 100644 >>> --- a/tools/golan

Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go

2022-10-14 Thread George Dunlap
> On 13 Oct 2022, at 14:05, Anthony PERARD wrote: > > gengotypes.py creates both "types.gen.go" and "helpers.gen.go", but > make can start gengotypes.py twice. Rework the rules so that > gengotypes.py is executed only once. > > Also, add the ability to provide a path to tell gengotypes.py wher

Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go

2022-10-14 Thread George Dunlap
> On 13 Oct 2022, at 16:00, Andrew Cooper wrote: > > On 13/10/2022 14:05, Anthony Perard wrote: >> diff --git a/tools/golang/xenlight/gengotypes.py >> b/tools/golang/xenlight/gengotypes.py >> index ac1cf060dd..ff4c2ad216 100644 >> --- a/tools/golang/xenlight/gengotypes.py >> +++ b/tools/golang

[xen-unstable-smoke test] 173749: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173749 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173749/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 14 guest-start fail REGR. vs. 173457 Tests which

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > Hi Henry, > > > > > -int p2m_teardown(struct domain *d) > > +int p2m_teardown(struct domain *d, bool allow_preemption) > > { >

[ovmf test] 173739: all pass - PUSHED

2022-10-14 Thread osstest service owner
flight 173739 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173739/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e0200cc47a691291ce1ad0207678a2db12d6503f baseline version: ovmf 5bd2dbc6982734132debd

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > > My initial thought is the "else if" part in p2m_set_allocation. It might be > > wrong. Would the code below seems ok to you? > > > > i

Re: [4.17 nice-to-have] Remaining Xen build output

2022-10-14 Thread Anthony PERARD
On Thu, Oct 13, 2022 at 02:58:18PM +, Andrew Cooper wrote: > Hi, > > Having got Kbuild almost integrated, there are a few artefacts remaining > which it would be nice to address seeing as out-of-tree builds is a big Those would be nice to address indeed, but can those wait for the next releas

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Jan Beulich
On 14.10.2022 12:53, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >> On 14.10.2022 12:38, Henry Wang wrote: -Original Message- From: Julien Grall >>> +if ( d->arch.paging.p2m_total_pages != 0 ) >>> +{ >>> +spin_lock(&d->arch

Re: [PATCH v6 0/9] Xen FF-A mediator

2022-10-14 Thread Jens Wiklander
Hi, I understand that you're busy with the Xen release. When you have time to resume reviewing this patch set please let me know if I should rebase it first. Thanks, Jens On Mon, Sep 19, 2022 at 11:12 AM Jens Wiklander wrote: > > Hi, > > This patch sets add a FF-A [1] mediator modeled after the

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > On 14.10.2022 12:38, Henry Wang wrote: > >> -Original Message- > >> From: Julien Grall > > +if ( d->arch.paging.p2m_tot

Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions

2022-10-14 Thread Jan Beulich
On 14.10.2022 12:30, Roger Pau Monné wrote: > On Fri, Oct 14, 2022 at 10:49:55AM +0200, Jan Beulich wrote: >> The addition of a call to shadow_blow_tables() from shadow_teardown() >> has resulted in the "no vcpus" related assertion becoming triggerable: >> If domain_create() fails with at least one

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Jan Beulich
On 14.10.2022 12:38, Henry Wang wrote: >> -Original Message- >> From: Julien Grall > +if ( d->arch.paging.p2m_total_pages != 0 ) > +{ > +spin_lock(&d->arch.paging.lock); > +p2m_set_allocation(d, 0, NULL); > +spin_unlock(&d->arch.paging.lo

Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions

2022-10-14 Thread Jan Beulich
On 14.10.2022 12:02, Andrew Cooper wrote: > On 14/10/2022 09:49, Jan Beulich wrote: >> The addition of a call to shadow_blow_tables() from shadow_teardown() >> has resulted in the "no vcpus" related assertion becoming triggerable: >> If domain_create() fails with at least one page successfully allo

RE: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles

2022-10-14 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system > improvement, toward non-recursive makefiles > The XenServer specfile lists all build artefacts specifically, because > we've had too many bugs where things have sile

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > >>> +spin_lock(&d->arch.paging.lock); > >>> +rc = p2m_set_allocation(d, 16, NULL); > >>> +spin_unlock(&d->arch.paging.lock)

Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection

2022-10-14 Thread Roger Pau Monné
On Fri, Oct 14, 2022 at 11:00:10AM +0200, Jan Beulich wrote: > On 14.10.2022 10:17, Roger Pau Monné wrote: > > On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote: > >> On 13.10.2022 15:50, Roger Pau Monné wrote: > >>> On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote: > On 1

Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles

2022-10-14 Thread Andrew Cooper
On 14/10/2022 11:14, Anthony PERARD wrote: > On Fri, Oct 14, 2022 at 06:26:09AM +, Henry Wang wrote: >>> -Original Message- >>> From: Andrew Cooper >>> Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system >>> improvement, toward non-recursive makefiles >>> >>> On 13/10/202

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Julien Grall
Hi Henry, On 14/10/2022 09:09, Henry Wang wrote: Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area when the domain is created. Considering the worst case of page tables which requires 6 P2M pages as the two pages will be consecutive but not necessarily in the same L3 page tabl

Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions

2022-10-14 Thread Roger Pau Monné
On Fri, Oct 14, 2022 at 10:49:55AM +0200, Jan Beulich wrote: > The addition of a call to shadow_blow_tables() from shadow_teardown() > has resulted in the "no vcpus" related assertion becoming triggerable: > If domain_create() fails with at least one page successfully allocated > in the course of s

RE: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles

2022-10-14 Thread Henry Wang
Hi Anthony, > -Original Message- > From: Anthony PERARD > Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system > improvement, toward non-recursive makefiles > > On Fri, Oct 14, 2022 at 06:26:09AM +, Henry Wang wrote: > > > -Original Message- > > > From: Andrew Co

Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Xenia Ragiadakou
On 10/14/22 13:04, Julien Grall wrote: Hi Xenia, On 14/10/2022 10:46, Xenia Ragiadakou wrote: On 10/13/22 15:39, Julien Grall wrote: Hi, On 13/10/2022 13:29, Henry Wang wrote: -Original Message- From: Jan Beulich Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N

Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere else

2022-10-14 Thread Anthony PERARD
On Thu, Oct 13, 2022 at 03:13:32PM +, Andrew Cooper wrote: > On 13/10/2022 14:05, Anthony Perard wrote: > > diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk > > index 920f1c87fb..0610db873b 100644 > > --- a/tools/debugger/gdbsx/Rules.mk > > +++ b/tools/debugger/gdbsx/R

Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles

2022-10-14 Thread Anthony PERARD
On Fri, Oct 14, 2022 at 06:26:09AM +, Henry Wang wrote: > > -Original Message- > > From: Andrew Cooper > > Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system > > improvement, toward non-recursive makefiles > > > > On 13/10/2022 14:04, Anthony PERARD wrote: > > > Patch s

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Julien Grall
On 14/10/2022 10:28, Henry Wang wrote: Hi Jan, Thanks for the review. -Original Message- From: Jan Beulich Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() On 14.10.2022 10:09, Henry Wang wrote: --- a/xen/arch/arm/domain.c +++ b/xen/a

Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Julien Grall
Hi Xenia, On 14/10/2022 10:46, Xenia Ragiadakou wrote: On 10/13/22 15:39, Julien Grall wrote: Hi, On 13/10/2022 13:29, Henry Wang wrote: -Original Message- From: Jan Beulich Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 1))? Or is the root table not taken fro

Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions

2022-10-14 Thread Andrew Cooper
On 14/10/2022 09:49, Jan Beulich wrote: > The addition of a call to shadow_blow_tables() from shadow_teardown() > has resulted in the "no vcpus" related assertion becoming triggerable: > If domain_create() fails with at least one page successfully allocated > in the course of shadow_enable(), or if

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Jan Beulich
On 14.10.2022 11:28, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >> On 14.10.2022 10:09, Henry Wang wrote: >>> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d) >>> if ( !p2m->domain ) >>> return; >>> >>> +if ( !page_list_empty(&p2m->pag

Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Xenia Ragiadakou
On 10/13/22 15:39, Julien Grall wrote: Hi, On 13/10/2022 13:29, Henry Wang wrote: -Original Message- From: Jan Beulich Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 1))? Or is the root table not taken from the p2m pool? Correct, on arm the root is not taken

Re: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as supported

2022-10-14 Thread Bertrand Marquis
Hi, > On 14 Oct 2022, at 09:35, Julien Grall wrote: > > Hi Stefano, > > On 14/10/2022 00:55, Stefano Stabellini wrote: >> On Thu, 13 Oct 2022, Henry Wang wrote: >>> With the P2M pages pool bounding the domain memory runtime allocation >>> and the documented minimal size requirement of the stati

RE: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap

2022-10-14 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > >>> +Users should be mindful that the static heap should at least satisfy the > >>> +allocation of the P2M maps for all guests. Currently, the minimal > >> requirement > >>> +of per-domain P2M pages pool is in-sync with function > >>>

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hi Jan, Thanks for the review. > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > On 14.10.2022 10:09, Henry Wang wrote: > > --- a/xen/arch/arm/domain.c > > +++ b/xen/arch/arm/domain.c > > @@ -7

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Jan Beulich
On 14.10.2022 10:09, Henry Wang wrote: > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d, > BUG(); > } > > +/* > + * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area > + * when t

Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap

2022-10-14 Thread Julien Grall
On 14/10/2022 09:58, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap Hi Henry, +Users should be mindful that the static heap should at least satisfy the +allocation of the P

Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection

2022-10-14 Thread Jan Beulich
On 14.10.2022 10:17, Roger Pau Monné wrote: > On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote: >> On 13.10.2022 15:50, Roger Pau Monné wrote: >>> On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote: On 11.10.2022 18:02, Roger Pau Monne wrote: > @@ -2365,12 +2365,6 @@ On

RE: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap

2022-10-14 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement > of static heap > > Hi Henry, > > > +Users should be mindful that the static heap should at least satisfy the > > +allocation of the P2M maps for all guests.

Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle

2022-10-14 Thread Jan Beulich
On 14.10.2022 10:03, Roger Pau Monné wrote: > On Thu, Oct 13, 2022 at 04:15:04PM +0200, Jan Beulich wrote: >> On 13.10.2022 15:10, Roger Pau Monné wrote: >>> On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote: On 13.10.2022 14:03, Roger Pau Monné wrote: > On Thu, Aug 18, 2022 at 0

[PATCH][4.17] x86/shadow: drop (replace) bogus assertions

2022-10-14 Thread Jan Beulich
The addition of a call to shadow_blow_tables() from shadow_teardown() has resulted in the "no vcpus" related assertion becoming triggerable: If domain_create() fails with at least one page successfully allocated in the course of shadow_enable(), or if domain_create() succeeds and the domain is then

Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection

2022-10-14 Thread Roger Pau Monné
On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote: > On 13.10.2022 15:50, Roger Pau Monné wrote: > > I was under the impression that the command line ssbd option was added > > to cope with Xen not exposing the feature to guests. Now that the > > feature is exposed guests should be free to

Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap

2022-10-14 Thread Julien Grall
Hi Henry, On 13/10/2022 03:57, Henry Wang wrote: The static heap feature requires user to know the minimal size of heap to make sure the system can work. Since the heap controlled by Xen is intended to provide memory for the whole system, not only the boot time memory allocation should be covere

Re: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as supported

2022-10-14 Thread Julien Grall
Hi Stefano, On 14/10/2022 00:55, Stefano Stabellini wrote: On Thu, 13 Oct 2022, Henry Wang wrote: With the P2M pages pool bounding the domain memory runtime allocation and the documented minimal size requirement of the static heap, it is safe to mark static heap feature as supported. Usually

Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init

2022-10-14 Thread Julien Grall
Hi, On 14/10/2022 08:16, Jan Beulich wrote: On 14.10.2022 04:53, Stewart Hildebrand wrote: Signed-off-by: Stewart Hildebrand I guess a non-empty description and a Fixes: tag would be nice. +1. I am actually quite interested to understand how this was spotted. The build system should check

Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection

2022-10-14 Thread Roger Pau Monné
On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote: > On 13.10.2022 15:50, Roger Pau Monné wrote: > > On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote: > >> On 11.10.2022 18:02, Roger Pau Monne wrote: > >>> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread > >>

Re: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is available

2022-10-14 Thread Roger Pau Monné
On Thu, Oct 13, 2022 at 04:43:15PM +0200, Jan Beulich wrote: > On 13.10.2022 16:06, Roger Pau Monné wrote: > > On Wed, Oct 12, 2022 at 10:36:57AM +0200, Jan Beulich wrote: > >> On 11.10.2022 18:02, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/cpu/amd.c > >>> +++ b/xen/arch/x86/cpu/amd.c > >>> @@

[xen-unstable-smoke test] 173743: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173743 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173743/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 14 guest-start fail REGR. vs. 173457 Tests which

[PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-10-14 Thread Henry Wang
Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area when the domain is created. Considering the worst case of page tables which requires 6 P2M pages as the two pages will be consecutive but not necessarily in the same L3 page table and keep a buffer, populate 16 pages as the defaul

Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle

2022-10-14 Thread Roger Pau Monné
On Thu, Oct 13, 2022 at 04:15:04PM +0200, Jan Beulich wrote: > On 13.10.2022 15:10, Roger Pau Monné wrote: > > On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote: > >> On 13.10.2022 14:03, Roger Pau Monné wrote: > >>> On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote: > From

Re: [PATCH V2 2/2] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts

2022-10-14 Thread Xenia Ragiadakou
On 10/8/22 18:10, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Currently, a grant ref is always based on the Xen page granularity (4KB), and guest commonly uses the same page granularity. But the guest may use a different page granularity (i.e 64KB). So adopt the code to be able to de

Re: [PATCH V2 1/2] xen/virtio: Handle cases when page offset > PAGE_SIZE properly

2022-10-14 Thread Xenia Ragiadakou
On 10/8/22 18:10, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Passed to xen_grant_dma_map_page() offset in the page can be > PAGE_SIZE even if the guest uses the same page granularity as Xen (4KB). Before current patch, if such case happened we ended up providing grants for the whol

Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init

2022-10-14 Thread Jan Beulich
On 14.10.2022 04:53, Stewart Hildebrand wrote: > Signed-off-by: Stewart Hildebrand I guess a non-empty description and a Fixes: tag would be nice. Jan

[linux-linus test] 173675: regressions - FAIL

2022-10-14 Thread osstest service owner
flight 173675 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173675/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl