Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > > My initial thought is the "else if" part in p2m_set_allocation. It might be > > wrong. Would the code below seems ok to you? > > > > int err; > > > > do { > > err = p2m_teardown_allocation(d) > > } while ( err == -ERESTART ) > > Sure, one of several ways of doing it.
Thanks for your confirmation. Just to play safe if you have more simple Solutions please do raise it. It is a good opportunity for me to learn and personally I am not a big fan of either do-while or the introduced "err" which is used only by p2m_teardown_allocation(d), considering the p2m_final_teardown(d) has a void return type... Thanks for your patience in advance :) Kind regards, Henry > > Jan