Re: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush

2022-07-27 Thread Jan Beulich
On 27.07.2022 20:31, Andrew Cooper wrote: > On 26/07/2022 17:07, Jan Beulich wrote: >> Checks dependent on only d and x can be pulled out, thus allowing to >> skip the flush mask calculation. >> >> Signed-off-by: Jan Beulich > > Do I get a Suggested-by seeing as this was on the very long list of

Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush

2022-07-27 Thread Jan Beulich
On 27.07.2022 20:25, Andrew Cooper wrote: > On 26/07/2022 17:06, Jan Beulich wrote: >> While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is >> cleared upon de-validation (see also the respective assertion earlier in >> the function). > > While this statement is true, it doesn't really

Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing

2022-07-27 Thread Jan Beulich
On 27.07.2022 21:06, Andrew Cooper wrote: > On 27/07/2022 13:53, Jan Beulich wrote: >> On 27.07.2022 14:46, Andrew Cooper wrote: >>> On 26/07/2022 17:04, Jan Beulich wrote: --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -132,7 +132,8 @@ delete_fl1_shadow

[ovmf test] 171894: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171894 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171894/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0e7add1d75fc75762208af84579e6809589ea6e5 baseline version: ovmf 1774a44ad91d01294bace

RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel

2022-07-27 Thread Jason Shuhua Lei
Hello, > -Original Message- > From: Smith, Jackson > > > -Original Message- > > From: Stefano Stabellini > > > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > > Hi Stefano, > > > > > > My colleague Jason Lei and I would like to submit a patch to imagebuilder. > > > > > > It seem

[qemu-mainline test] 171885: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171885 qemu-mainline real [real] flight 171893 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171885/ http://logs.test-lab.xenproject.org/osstest/logs/171893/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

[ovmf test] 171892: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171892 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171892/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1774a44ad91d01294bace32b0060ce26da2f0140 baseline version: ovmf f26b70cb9f1367ceb2519

RE: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu

2022-07-27 Thread Penny Zheng
Hi Xenia > -Original Message- > From: Xen-devel On Behalf Of > Xenia Ragiadakou > Sent: Wednesday, July 27, 2022 3:07 AM > To: xen-devel@lists.xenproject.org > Cc: Doug Goldstein ; Stefano Stabellini > > Subject: [PATCH v2 2/2] automation: arm64: Create a test job for testing > static al

Re: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu

2022-07-27 Thread Stefano Stabellini
On Tue, 26 Jul 2022, Xenia Ragiadakou wrote: > Enable CONFIG_STATIC_MEMORY in the existing arm64 build. > > Create a new test job, called qemu-smoke-arm64-gcc-staticmem. > > Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a > new test variant. The test variant is determi

Re: [PATCH v2 1/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-27 Thread Stefano Stabellini
On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > The macro parameter 'p' is used as an expression and needs to be enclosed in > parentheses. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > > Changes in v2: > - remove parentheses in the cases that p is not used as an

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-27 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Xenia Ragiadakou wrote: > Hi Stefano, > > On 7/27/22 23:26, Stefano Stabellini wrote: > > On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > > > On 7/27/22 03:10, Stefano Stabellini wrote: > > > > On Tue, 26 Jul 2022, Jan Beulich wrote: > > > > > On 26.07.2022 02:33, Stefano Stabe

[linux-linus test] 171882: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171882 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171882/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 171871 Tests which did not succeed,

[ovmf test] 171889: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171889 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171889/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f26b70cb9f1367ceb25190ba2777631ee42c69fe baseline version: ovmf 2677286307c67b62c198c

[xen-4.16-testing test] 171881: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171881 xen-4.16-testing real [real] flight 171890 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171881/ http://logs.test-lab.xenproject.org/osstest/logs/171890/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-27 Thread Xenia Ragiadakou
Hi Stefano, On 7/27/22 23:26, Stefano Stabellini wrote: On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: On 7/27/22 03:10, Stefano Stabellini wrote: On Tue, 26 Jul 2022, Jan Beulich wrote: On 26.07.2022 02:33, Stefano Stabellini wrote: On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: On 7/25/22 09:

[ovmf test] 171888: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171888 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171888/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2677286307c67b62c198cf6890d62ec540dd8c99 baseline version: ovmf e3d468acb9ce26a75fee4

[xen-4.15-testing test] 171880: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171880 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171880/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 171866 test-armhf-armhf-libvirt 16

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-27 Thread Stefano Stabellini
On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > On 7/27/22 03:10, Stefano Stabellini wrote: > > On Tue, 26 Jul 2022, Jan Beulich wrote: > > > On 26.07.2022 02:33, Stefano Stabellini wrote: > > > > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > > > > > On 7/25/22 09:32, Jan Beulich wrote: > > > > > >

Re: [ImageBuilder][PATCH v3 3/3] uboot-script-gen: Enable not adding boot command to script

2022-07-27 Thread Stefano Stabellini
On Wed, 13 Jul 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > If the "BOOT_CMD" variable is set to "none" inside the config > file, the boot command (i.e. "booti") will not by added to the > generated script, to allow the user to customize the u-boot env > or the device-tree a

Re: [ImageBuilder][PATCH v3 2/3] uboot-script-gen: Enable appending extra commands to boot script

2022-07-27 Thread Stefano Stabellini
On Wed, 13 Jul 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > Added the parsing for APPEND_EXTRA_CMDS variable, which enables the > user to specify the path to a text file that contains, on each line, > u-boot commands that will be added to the generated script as > "fixups",

RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel

2022-07-27 Thread Stefano Stabellini
On Wed, 27 Jul 2022, Jason Shuhua Lei wrote: > Hello, > > -Original Message- > > From: Smith, Jackson > > > > > -Original Message- > > > From: Stefano Stabellini > > > > > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > > > Hi Stefano, > > > > > > > > My colleague Jason Lei and

Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests

2022-07-27 Thread Oleksandr
Hello Jan On 27.07.22 20:54, Oleksandr wrote: On 26.07.22 18:16, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,   /* da

Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing

2022-07-27 Thread Andrew Cooper
On 27/07/2022 13:53, Jan Beulich wrote: > On 27.07.2022 14:46, Andrew Cooper wrote: >> On 26/07/2022 17:04, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm/shadow/multi.c >>> +++ b/xen/arch/x86/mm/shadow/multi.c >>> @@ -132,7 +132,8 @@ delete_fl1_shadow_status(struct domain * >>> SHADOW_PRINTK("g

Re: [PATCH v7] evtchn: convert domain event lock to an r/w one

2022-07-27 Thread Julien Grall
Hi Jan, On 27/07/2022 16:56, Jan Beulich wrote: Especially for the use in evtchn_move_pirqs() (called when moving a vCPU across pCPU-s) and the ones in EOI handling in PCI pass-through code, serializing perhaps an entire domain isn't helpful when no state (which isn't e.g. further protected by t

Re: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:07, Jan Beulich wrote: > Checks dependent on only d and x can be pulled out, thus allowing to > skip the flush mask calculation. > > Signed-off-by: Jan Beulich Do I get a Suggested-by seeing as this was on the very long list of improvements ? Either way, Reviewed-by: Andrew Coop

Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:06, Jan Beulich wrote: > While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is > cleared upon de-validation (see also the respective assertion earlier in > the function). While this statement is true, it doesn't really explain why this is relevant (or not) to TLB flush

Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests

2022-07-27 Thread Oleksandr
On 26.07.22 18:16, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info, /* data is needed to prevent a pointer cast on 32bit */

Re: [PATCH V7 07/11] vpci/header: emulate PCI_COMMAND register for guests

2022-07-27 Thread Oleksandr
On 26.07.22 18:30, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -443,11 +443,27 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) return 0; } +/* T

[PATCH v2 1/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-27 Thread Xenia Ragiadakou
The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove parentheses in the cases that p is not used as an expression that is when it is used as a function argument xen/arch/arm/include/asm/atomic.h

[PATCH v2 0/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule violations

2022-07-27 Thread Xenia Ragiadakou
This patch series fixes violations of rule 20.7 found in xen/arch/arm/include/asm/atomic.h. Changes in v2: - removed redundant parentheses in patch 1/2 - dropped patch 2/2 that removes unused atomic_xchg() because changes Xen's atomic API, and such a change cannot be justified since compliance t

Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view

2022-07-27 Thread Oleksandr
On 27.07.22 13:19, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value as set up by the PCI bus driv

Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices

2022-07-27 Thread Oleksandr
On 27.07.22 12:46, Jan Beulich wrote: Hello Jan On 27.07.2022 10:58, Oleksandr wrote: On 26.07.22 18:23, Jan Beulich wrote: On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Reset the command register when assigning a PCI device to a guest: according to the P

Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign

2022-07-27 Thread Oleksandr
On 27.07.22 17:35, Jan Beulich wrote: Hello Jan On 27.07.2022 16:01, Oleksandr wrote: On 27.07.22 13:03, Jan Beulich wrote: On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)

[xen-unstable test] 171873: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171873 xen-unstable real [real] flight 171886 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171873/ http://logs.test-lab.xenproject.org/osstest/logs/171886/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[ovmf test] 171883: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171883 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171883/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e3d468acb9ce26a75fee45d742619ac1c6683280 baseline version: ovmf b68d566439683d0ebe60d

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-27 Thread Xenia Ragiadakou
Hi Julien, On 7/27/22 18:46, Julien Grall wrote: Hi Xenia, On 27/07/2022 16:32, Xenia Ragiadakou wrote: Remove unused macro atomic_xchg(). Signed-off-by: Xenia Ragiadakou ---   xen/arch/arm/include/asm/atomic.h | 2 --   1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/at

Re: [PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-27 Thread Xenia Ragiadakou
Hi Jan, On 7/27/22 18:36, Jan Beulich wrote: On 27.07.2022 17:32, Xenia Ragiadakou wrote: The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Yes, but ... --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -123,15 +123,15

Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers

2022-07-27 Thread Oleksandr
On 27.07.22 13:15, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) { bars[i].type = VPCI

[libvirt test] 171877: regressions - FAIL

2022-07-27 Thread osstest service owner
flight 171877 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171877/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH] x86: rework hypercall argument count table instantiation & use

2022-07-27 Thread Jan Beulich
The initial observation were duplicate symbols that our checking warns about. Instead of merely renaming one or both pair(s) of symbols, reduce #ifdef-ary at the same time by moving the instantiation of the arrays into macros (a native and a 32-bit one each, where likely more redundancy could be el

[PATCH v7] evtchn: convert domain event lock to an r/w one

2022-07-27 Thread Jan Beulich
Especially for the use in evtchn_move_pirqs() (called when moving a vCPU across pCPU-s) and the ones in EOI handling in PCI pass-through code, serializing perhaps an entire domain isn't helpful when no state (which isn't e.g. further protected by the per-channel lock) changes. Unfortunately this i

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-27 Thread Julien Grall
Hi Xenia, On 27/07/2022 16:32, Xenia Ragiadakou wrote: Remove unused macro atomic_xchg(). Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index f

Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-27 Thread Jane Malalane
On 27/07/2022 13:32, Julien Grall wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open > attachments unless you have verified the sender and know the content is > safe. > > Hi Jane, > > On 26/07/2022 13:56, Jane Malalane wrote: >> diff --git a/arch/x86/xen/suspend_hvm.c b/arch

Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-27 Thread Jane Malalane
On 27/07/2022 00:31, Boris Ostrovsky wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open > attachments unless you have verified the sender and know the content is > safe. > > On 7/26/22 8:56 AM, Jane Malalane wrote: >> +/* Setup per-vCPU vector-type callbacks and trick toolsta

Re: [PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-27 Thread Jan Beulich
On 27.07.2022 17:32, Xenia Ragiadakou wrote: > The macro parameter 'p' is used as an expression and needs to be enclosed in > parentheses. Yes, but ... > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -123,15 +123,15 @@ static always_inline void write_atomi

[PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-27 Thread Xenia Ragiadakou
The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/as

[PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-27 Thread Xenia Ragiadakou
Remove unused macro atomic_xchg(). Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index f5ef744b4b..a2dc125291 100644 --- a/xen/arch/arm/include/asm/

[PATCH 0/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule violations

2022-07-27 Thread Xenia Ragiadakou
This patch series fixes violations of rules 20.7 and 2.5 found in xen/arch/arm/include/asm/atomic.h. Rule 2.5 (a project should not contain unused macro declarations) is advisory. Xenia Ragiadakou (2): xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation xen/arm: asm/atomic.h: Fix MISRA

[PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-27 Thread Xenia Ragiadakou
Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou --- xen/include/xsm/dummy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 77f27e7163..8671af1ba4 100644 --- a/xen/incl

[xen-unstable-smoke test] 171884: tolerable all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171884 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171884/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel

2022-07-27 Thread Smith, Jackson
> -Original Message- > From: Stefano Stabellini > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > Hi Stefano, > > > > My colleague Jason Lei and I would like to submit a patch to imagebuilder. > > > > It seems that generating a .fit with a true dom0less configuration fails > because an ex

Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign

2022-07-27 Thread Jan Beulich
On 27.07.2022 16:01, Oleksandr wrote: > On 27.07.22 13:03, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, >>> u8 bus, u8 devfn, u32 flag) >>> pci_to_dev(pdev), flag); >>

Re: [PATCH v1 17/18] builder: introduce domain builder hypfs tree

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/common/domain-builder/core.c > +++ b/xen/common/domain-builder/core.c > @@ -134,6 +134,9 @@ uint32_t __init builder_create_domains(struct boot_info > *info) > /* Free temporary buffers. */ > discard_initial_images(); > > +

Re: [PATCH v1 16/18] x86: add pv multidomain construction

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -524,37 +524,6 @@ int __init dom0_setup_permissions(struct domain *d) > > return rc; > } > - > -int __init construct_domain(struct boot_domain *bd) > -{ > -int rc = 0; >

Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign

2022-07-27 Thread Oleksandr
On 27.07.22 13:03, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: @@ -1558,6 +1560,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) { const struct domain_iommu *hd = dom_iommu(d); struct pci_dev *pdev; +u

Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device

2022-07-27 Thread Rahul Singh
Hi Julien, > On 26 Jul 2022, at 6:35 pm, Julien Grall wrote: > > Hi, > > On 21/07/2022 16:53, Rahul Singh wrote: >>> On 28 Jun 2022, at 6:23 pm, Mykyta Poturai wrote: >>> With this patch I get the same results, here is the error message: >>> >>> (XEN) smmu: /iommu@5140: Unexpected global

Re: [PATCH v1 15/18] x86: rework domain page allocation

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > This reworks all the dom0 page allocation functions for general domain > construction. Where possible, common logic between the two was split into a > separate function for reuse by the two functions. You absolutely need to mention what behavioral / fu

Re: [PATCH 6/8] x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3()

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:06, Jan Beulich wrote: > Now that we're not building multi.c anymore for 2 and 3 guest levels > when !HVM, there's no point in having these conditionals anymore. (As > somewhat a special case, the last of the removed conditionals really > builds on shadow_mode_external() always ret

Re: [PATCH 5/8] x86/shadow: don't open-code shadow_remove_all_shadows()

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:05, Jan Beulich wrote: > Let's use the existing inline wrapper instead of repeating respective > commentary at every site. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:05, Jan Beulich wrote: > In my (debug) build this amounts to well over 500 bytes of dead code. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing

2022-07-27 Thread Jan Beulich
On 27.07.2022 14:46, Andrew Cooper wrote: > On 26/07/2022 17:04, Jan Beulich wrote: >> We should not blindly (in a release build) insert the new entry in the >> hash if a reference to the guest page cannot be obtained, or else an >> excess reference would be put when removing the hash entry again.

Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:04, Jan Beulich wrote: > We should not blindly (in a release build) insert the new entry in the > hash if a reference to the guest page cannot be obtained, or else an > excess reference would be put when removing the hash entry again. Crash > the domain in that case instead. The so

Re: [PATCH v1 14/18] x86: generalize vcpu for domain building

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > Here, the vcpu initialization code for dom0 creation is generalized for use > for > other domains. Yet with "other domains" still only ones created during boot, aiui. Imo such details want spelling out. The title also is too generic / imprecise. > -

Re: [PATCH v1 13/18] x86: generalize physmap logic

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > The existing physmap code is specific to dom0. I think this needs better wording. Either you name the function or you explain what piece of code you're talking about. "physmap" alone is just not meaningful enough. (Also applies to the title.) > --- a/

Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-27 Thread Julien Grall
Hi Jane, On 26/07/2022 13:56, Jane Malalane wrote: diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c index 9d548b0c772f..0c4f7554b7cc 100644 --- a/arch/x86/xen/suspend_hvm.c +++ b/arch/x86/xen/suspend_hvm.c @@ -5,6 +5,7 @@ #include #include #include +#include #i

Re: [PATCH v1 12/18] x86: convert dom0 creation to domain builder

2022-07-27 Thread Jan Beulich
On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/arch/x86/domain_builder.c > @@ -0,0 +1,128 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +extern unsigned long cr4_pv32_mask; Suc

[qemu-mainline test] 171872: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171872 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171872/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 171863 test-amd64-amd64-xl-qemuu-win7-amd6

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

2022-07-27 Thread Jan Beulich
On 27.07.2022 12:46, Andrew Cooper wrote: > On 27/07/2022 11:44, Andrew Cooper wrote: >> On 27/07/2022 11:41, Jan Beulich wrote: >>> Coverity validly points out that the mfn_add() as used was dead code. >>> >>> Coverity ID: 1507475 >>> Signed-off-by: Jan Beulich >> Acked-by: Andrew Cooper > > Al

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

2022-07-27 Thread Andrew Cooper
On 27/07/2022 11:44, Andrew Cooper wrote: > On 27/07/2022 11:41, Jan Beulich wrote: >> Coverity validly points out that the mfn_add() as used was dead code. >> >> Coverity ID: 1507475 >> Signed-off-by: Jan Beulich > Acked-by: Andrew Cooper Although on second thoughts, this needs a fixes c1e1564c

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

2022-07-27 Thread Andrew Cooper
On 27/07/2022 11:41, Jan Beulich wrote: > Coverity validly points out that the mfn_add() as used was dead code. > > Coverity ID: 1507475 > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

[PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

2022-07-27 Thread Jan Beulich
Coverity validly points out that the mfn_add() as used was dead code. Coverity ID: 1507475 Signed-off-by: Jan Beulich --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -130,7 +130,7 @@ static void __init iommu_memory_setup(st IOMMUF_readable |

Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology

2022-07-27 Thread Jan Beulich
On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Assign SBDF to the PCI devices being passed through with bus 0. > The resulting topology is where PCIe devices reside on the bus 0 of the > root complex itself (embedded endpoints). > This implementation is limit

Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view

2022-07-27 Thread Jan Beulich
On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value as set > up by the PCI bus driver in the hardware domain. > This way hardware

Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers

2022-07-27 Thread Jan Beulich
On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) > if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) > { > bars[i].type = VPCI_BAR_IO; > + > +#ifndef CONFIG_X86 > +

[ovmf test] 171878: all pass - PUSHED

2022-07-27 Thread osstest service owner
flight 171878 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171878/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b68d566439683d0ebe60d52c85ff0e90331db740 baseline version: ovmf 7f1c89f16790fc2fa8bc8

Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign

2022-07-27 Thread Jan Beulich
On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > @@ -1558,6 +1560,7 @@ static int assign_device(struct domain *d, u16 seg, u8 > bus, u8 devfn, u32 flag) > { > const struct domain_iommu *hd = dom_iommu(d); > struct pci_dev *pdev; > +uint8_t old_devfn; Why "old"? There's nothing "n

Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices

2022-07-27 Thread Jan Beulich
On 27.07.2022 10:58, Oleksandr wrote: > On 26.07.22 18:23, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Reset the command register when assigning a PCI device to a guest: >>> according to the PCI spec the PCI_COMMAND register is t

Re: [PATCH 1/8] x86/shadow: drop shadow_prepare_page_type_change()'s 3rd parameter

2022-07-27 Thread Andrew Cooper
On 26/07/2022 17:03, Jan Beulich wrote: > As of 8cc5036bc385 ("x86/pv: Fix ABAC cmpxchg() race in > _get_page_type()") this no longer needs passing separately - the type > can now be read from struct page_info, as the call now happens after its > writing. > > While there also constify the 2nd param

[linux-linus test] 171871: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171871 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171871/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 171847 test-armhf-armhf-libvirt 16 saver

Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices

2022-07-27 Thread Oleksandr
On 26.07.22 18:23, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Reset the command register when assigning a PCI device to a guest: according to the PCI spec the PCI_COMMAND register is typically all 0's after reset, but this mi

Re: Question to mem-path support at QEMU for Xen

2022-07-27 Thread Igor Mammedov
On Tue, 26 Jul 2022 15:27:07 +0800 Huang Rui wrote: > Hi Anthony and other Qemu/Xen guys, > > We are trying to enable venus on Xen virtualization platform. And we would > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > options on QEMU, however, the QEMU will tell us th

[xen-4.13-testing test] 171868: tolerable FAIL - PUSHED

2022-07-27 Thread osstest service owner
flight 171868 xen-4.13-testing real [real] flight 171879 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171868/ http://logs.test-lab.xenproject.org/osstest/logs/171879/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

preparations for 4.16.2

2022-07-27 Thread Jan Beulich
All, the release is due in about two weeks time. Please point out backports you find missing from the respective staging branch, but which you consider relevant. I'm surprised in particular that no Arm backports have appeared on the branch at all since 4.16.1 had gone out. Jan