On 27.07.2022 10:58, Oleksandr wrote: > On 26.07.22 18:23, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> >>> >>> Reset the command register when assigning a PCI device to a guest: >>> according to the PCI spec the PCI_COMMAND register is typically all 0's >>> after reset, but this might not be true for the guest as it needs >>> to respect host's settings. >>> For that reason, do not write 0 to the PCI_COMMAND register directly, >>> but go through the corresponding emulation layer (cmd_write), which >>> will take care about the actual bits written. >>> >>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> >>> --- >>> Since v6: >>> - use cmd_write directly without introducing emulate_cmd_reg >>> - update commit message with more description on all 0's in PCI_COMMAND >> I agree with the change, > > thanks, may I please ask can this be converted to some tag?
I could offer a R-b, but you've got one from Rahul already, so mine won't buy you anything further. What you will need is a maintainer ack, which imo isn't a priority since this is only patch 8 in a series which itself depends on a further series likely continuing to be controversial (didn't get there yet). Jan
