On 26.07.22 18:23, Jan Beulich wrote:
Hello Jan
On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com>
Reset the command register when assigning a PCI device to a guest:
according to the PCI spec the PCI_COMMAND register is typically all 0's
after reset, but this might not be true for the guest as it needs
to respect host's settings.
For that reason, do not write 0 to the PCI_COMMAND register directly,
but go through the corresponding emulation layer (cmd_write), which
will take care about the actual bits written.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com>
---
Since v6:
- use cmd_write directly without introducing emulate_cmd_reg
- update commit message with more description on all 0's in PCI_COMMAND
I agree with the change,
thanks, may I please ask can this be converted to some tag?
but it's imo enough that you also need to sign
off on the patch (and this likely also applies elsewhere in the series).
I got your point. Regarding the current patch, I didn't make any changes
to it. As I mentioned in the cover letter [1] after "!!! OT: please note,"
Oleksandr Andrushchenko has addressed almost all review comments given
for v6 by himself. For the patches which I had to touch I added "OT:" to
the change log. For example, like here [2].
I will consider signing off these patches.
[1]
https://lore.kernel.org/xen-devel/20220719174253.541965-1-olekst...@gmail.com/
[2]
https://lore.kernel.org/xen-devel/20220719174253.541965-8-olekst...@gmail.com/
Jan
--
Regards,
Oleksandr Tyshchenko
