On 23.08.2020 07:52, Jürgen Groß wrote:
> On 23.08.20 07:24, osstest service owner wrote:
>> flight 152672 linux-linus real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/152672/
>>
>> Regressions :-(
>
> With 32-bit pv support now removed from the kernel the associated tests
> should
flight 152720 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152720/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777
build-i386-libvirt
On 21.08.20 02:24, Thomas Gleixner wrote:
To allow utilizing the irq domain pointer in struct device it is necessary
to make XEN/MSI irq domain compatible.
While the right solution would be to truly convert XEN to irq domains, this
is an exercise which is not possible for mere mortals with limit
On 21.08.20 02:24, Thomas Gleixner wrote:
X86 cannot store the irq domain pointer in struct device without breaking
XEN because the irq domain pointer takes precedence over arch_*_msi_irqs()
fallbacks.
XENs MSI teardown relies on default_teardown_msi_irqs() which invokes
arch_teardown_msi_irq().
On 21.08.20 02:24, Thomas Gleixner wrote:
X86 cannot store the irq domain pointer in struct device without breaking
XEN because the irq domain pointer takes precedence over arch_*_msi_irqs()
fallbacks.
To achieve this XEN MSI interrupt management needs to be wrapped into an
irq domain.
Move the
On 21.08.20 02:24, Thomas Gleixner wrote:
The only user is in the same file and the name is too generic because this
function is only ever used for HVM domains.
Signed-off-by: Thomas Gleixner
Cc: Konrad Rzeszutek Wilk
Cc:linux-...@vger.kernel.org
Cc:xen-devel@lists.xenproject.org
Cc: Juergen Gro
flight 152709 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152709/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332
test-amd64-i386-qem
Xen has cpu_has_fp/cpu_has_simd to detect whether the CPU supports
FP/SIMD or not. But currently, these two MACROs only consider value 0
of ID_AA64PFR0_EL1.FP/SIMD as FP/SIMD features enabled. But for CPUs
that support FP/SIMD and half-precision floating-point arithmetic, the
ID_AA64PFR0_EL1.FP/SIM
On latest Arm Cortex-N1/A76/A75 cores, Xen guests will encouter random
crash when they have wordloads. It's because Xen will ignore FP/SIMD
registers in vCPU context switch (see patch#1 for more details).
This patch set fix guest random crash on these new cores, and throw
messages when Xen detects
Arm ID_AA64PFR0_EL1 register provides two fields to describe CPU
FP/SIMD implementations. Currently, we exactly know the meaning of
0x0, 0x1 and 0xf of these fields. Xen treats value < 8 as FP/SIMD
features presented. If there is a value 0x2 bumped in the future,
Xen behaviors for value <= 0x1 can
flight 152696 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152696/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemuu-rhel6hvm-amd 10 redhat-install fail REGR. vs. 152631
test-amd64-amd64-
flight 152688 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152688/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 152332
test-amd64-i386-qem
flight 152701 examine real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152701/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
examine-italia0 5 host-installbroken like 152156
examine-debina0 5 host-inst
flight 152684 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152684/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 152667
test-amd64-amd64-xl-qemuu-ws16-amd64
flight 152682 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152682/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-qemuu-rhel6hvm-amd 10 redhat-install fail REGR. vs. 152631
test-amd64-amd64-
flight 152693 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152693/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
xen 858c0be8c2fa4125a0fa0acaa03ae730e5c7cb3c
baseline version:
xen 391a
flight 152686 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152686/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777
build-i386-libvirt
Juergen Gross, le dim. 23 août 2020 11:35:08 +0200, a ecrit:
> tools/libxc now contains libxenguest only. Move it to tools/libs/guest.
I was wondering about factorizing parts of the rules for libxc indeed,
now done then :)
Thanks!
> Signed-off-by: Juergen Gross
For the stubdom part:
Reviewed-b
Juergen Gross, le dim. 23 août 2020 11:34:49 +0200, a ecrit:
> The pattern for building a Xen library with sources under tools/libs
> is always the same. Simplify stubdom/Makefile by defining a callable
> make program for those libraries.
Ah, sorry, I should have read the series before reviewing :
On 23.08.20 11:47, Samuel Thibault wrote:
Juergen Gross, le dim. 23 août 2020 11:34:48 +0200, a ecrit:
The stubdom Makefile is missing several dependencies between Xen
libraries. Add them.
Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
In case another round of review is needed,
Juergen Gross, le dim. 23 août 2020 11:34:48 +0200, a ecrit:
> The stubdom Makefile is missing several dependencies between Xen
> libraries. Add them.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
In case another round of review is needed, perhaps you can just
factorize:
> @@
xenpaging is using libxc internals. Fix that.
Signed-off-by: Juergen Gross
---
tools/xenpaging/Makefile | 3 +-
tools/xenpaging/file_ops.c | 8 ++--
tools/xenpaging/pagein.c | 2 +-
tools/xenpaging/policy_default.c | 2 +-
tools/xenpaging/xenpaging.c | 32 +++--
Add the correct flags for both, libxenlight and libxlutil, when
building xl.
Signed-off-by: Juergen Gross
---
tools/xl/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/xl/Makefile b/tools/xl/Makefile
index af4912e67a..407dd7554c 100644
--- a/tools/xl/Makefile
+++ b/tools/xl/Mak
For being able to disentangle lixenctrl and libxenguest headers
xc_dom.h will need to be public. Prepare that by renaming xc_dom.h
to xenctrl_dom.h.
Signed-off-by: Juergen Gross
---
stubdom/grub/kexec.c| 2 +-
tools/helpers/init-xenstore-domain.c| 2 +-
to
Some generated files are not removed by "make clean". Add them.
Signed-off-by: Juergen Gross
---
tools/libxl/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 1541d25f72..1476c7897f 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl
There is no reason why libxenstore is not placed in the tools/libs
directory.
The common files between libxenstore and xenstored are kept in the
tools/xenstore directory to be easily accessible by xenstore-stubdom
which needs the xenstored files to be built.
Signed-off-by: Juergen Gross
---
.gi
There is no need for the sources of libxlutil to include libxl_osdeps.h
as the only dependency is the leading
#define _GNU_SOURCE
in libxl_osdeps.h. So replace including libxl_osdeps.h by the needed
define.
Signed-off-by: Juergen Gross
---
tools/libxl/libxlu_cfg.c| 3 +--
tools/libxl/libx
Carve out all libxenlight related sources and move them to
tools/libs/light in order to use the generic library build environment.
The closely related sources for libxl-save-helper and the libxl test
environment are being moved, too.
Signed-off-by: Juergen Gross
---
.gitignore
check-xl-* scripts and data are not libxl- but xl-specific. Move them
from tools/libxl/ to tools/xl/.
Signed-off-by: Juergen Gross
---
tools/{libxl => xl}/check-xl-disk-parse | 0
tools/{libxl => xl}/check-xl-vcpupin-parse | 0
tools/{libxl => xl}/check-xl-vcpupin-pa
tools/libxc now contains libxenguest only. Move it to tools/libs/guest.
Signed-off-by: Juergen Gross
---
.gitignore| 16 +-
stubdom/Makefile | 34 +--
stubdom/grub/Makefile | 2 +-
stubdom/mini-os.mk
Today tools/libxc needs to be built after tools/libs as libxenctrl is
depending on some libraries in tools/libs. This in turn blocks moving
other libraries depending on libxenctrl below tools/libs.
So carve out libxenctrl from tools/libxc and move it into
tools/libs/ctrl.
Signed-off-by: Juergen G
There is no reason why libvchan is not placed in the tools/libs
directory.
At the same time move libxenvchan.h to a dedicated include directory
in tools/libs/vchan in order to follow the same pattern as the other
libraries in tools/libs.
As tools/libvchan now contains no library any longer rename
There is no reason why libxenstat is not placed in the tools/libs
directory.
At the same time move xenstat.h to a dedicated include directory
in tools/libs/stat in order to follow the same pattern as the other
libraries in tools/libs.
As now xentop is the only left directory in xenstat move it di
All Xen libraries but one (libxlutil) are named libxen...
Add support in the generic library build framework for that different
naming by adding another indirection layer. For a library
LIB_PREFIX_ can be set in tools/libs/uselibs.mk. The default is
"xen", assuming that all libraries are starting
Move the libxlutil source to tools/libs/util and delete tools/libxl.
Signed-off-by: Juergen Gross
---
.gitignore| 6 +-
tools/Makefile| 1 -
tools/Rules.mk| 7 --
tools/libs/Makefile
Rename the header files private to libxenguest from xc_*.h to xg_*.h.
Signed-off-by: Juergen Gross
---
tools/libxc/xg_dom_bzimageloader.c | 2 +-
tools/libxc/{xc_dom_decompress.h => xg_dom_decompress.h}| 2 +-
tools/libxc/xg_dom_decompress_lz4.c
Sources of libxenctrl and libxenguest are completely entangled. In
practice libxenguest is a user of libxenctrl, so don't let any source
libxenctrl include xg_private.h.
This can be achieved by moving all definitions used by libxenctrl from
xg_private.h to xc_private.h.
Export xenctrl_dom.h as it
Today building the libxl internal tests depends on libxlutil having
been built, in spite of the tests not using any functionality og
libxlutil. Fix this by dropping the dependency.
Signed-off-by: Juergen Gross
---
tools/libxl/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
The definition of PAGE_SIZE comes from xc_private.h, which shouldn't be
used by xen-mfndump.c. Replace PAGE_SIZE by XC_PAGE_SIZE, as
xc_private.h contains:
#define PAGE_SIZE XC_PAGE_SIZE
For the same reason PAGE_SHIFT_X86 needs to replaced with
XC_PAGE_SHIFT.
Signed-off-by: Juergen Gross
---
t
Some sources of libxenguest are named xg_*.c and some xc_*.c. Rename
the xc_*.c files to xg_*.c.
Signed-off-by: Juergen Gross
---
tools/libxc/Makefile | 59 ++-
.../libxc/{xc_cpuid_x86.c => xg_cpuid_x86.c} | 0
tools/libxc/{xc_dom_arm.c => xg_dom_arm.c}
Move xc_[un]map_domain_meminfo() functions to new source xg_domain.c as
they are defined in include/xenguest.h and should be in libxenguest.
Signed-off-by: Juergen Gross
---
tools/libxc/Makefile| 4 +-
tools/libxc/xc_domain.c | 126 -
tools/libxc/xg_domain.c
Remove xc_efi.h and xc_elf.h as they aren't used anywhere.
Signed-off-by: Juergen Gross
---
tools/libxc/xc_efi.h | 158 ---
tools/libxc/xc_elf.h | 16 -
2 files changed, 174 deletions(-)
delete mode 100644 tools/libxc/xc_efi.h
delete mode 100644 too
Since more than three years now qemu is capable to set the needed
include and library paths for the Xen libraries via pkg-config.
So drop the specification of those paths in tools/Makefile. This will
enable to move libxenctrl away from tools/libxc, as qemu's configure
script has special treatment
In order to harmonize names of library related make variables switch
XEN_LIBXEN* names to XEN_libxen*, as all other related variables (e.g.
CFLAGS_libxen*, SHDEPS_libxen*, ...) already use this pattern.
Rename XEN_LIBXC to XEN_libxenctrl, XEN_XENSTORE to XEN_libxenstore,
XEN_XENLIGHT to XEN_libxen
Move most remaining libraries under tools/libs, including libxenctrl
and libxl. This is resulting in a lot of cleanup work regarding
building libs and restructuring of the tools directory.
After this huge cleanup all dependencies between libraries are defined
in a single rather small file tools/li
The last libxc internal used by xen-mfndump.c is the ERROR() macro.
Add a simple definition for that macro to xen-mfndump.c and replace
the libxc private header includes by official ones.
Signed-off-by: Juergen Gross
---
tools/misc/Makefile | 2 --
tools/misc/xen-mfndump.c | 13 +--
The headers.chk target in tools/Rules.mk tries to compile all headers
stand alone for testing them not to include any internal header.
Unfortunately the headers tested against are not complete, as any
header for a Xen library is not included in the include path of the
test compile run, resulting i
The pkg-config file for libxenguest is missing the private dependency
on libxenctrl.
Signed-off-by: Juergen Gross
---
tools/libxc/xenguest.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xenguest.pc.in b/tools/libxc/xenguest.pc.in
index 225ac0b9c8..6b43b67e6
xen-mfndump.c is including the libxc private header xg_save_restore.h.
Avoid that by moving the definition of is_mapped() to xen-mfndump.c
(it is used there only) and by duplicating the definition of
M2P_SIZE() in xen-mfndump.c.
Signed-off-by: Juergen Gross
---
tools/libxc/xg_save_restore.h | 4
The stubdom Makefile is missing several dependencies between Xen
libraries. Add them.
Signed-off-by: Juergen Gross
---
stubdom/Makefile | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/stubdom/Makefile b/stubdom/Makefile
index af8cde41b9..a95212e363 100644
---
During build of a xen library make is called again via libs.mk. This is
not necessary as the same can be achieved by a simple dependency.
Signed-off-by: Juergen Gross
Reviewed-by: Ian Jackson
---
tools/libs/libs.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/libs
There are quite some places in Makefiles assuming libxenguest and
libxenctrl being built in the same directory via a single Makefile.
Drop this assumption by specifying the dependencies and path variables
for both libraries correctly.
Signed-off-by: Juergen Gross
---
tools/Rules.mk | 7 ++
Library related make variables (CFLAGS_lib*, SHDEPS_lib*, LDLIBS_lib*
and SHLIB_lib*) mostly have a common pattern for their values. Generate
most of this content automatically by adding a new per-library variable
defining on which other libraries a lib is depending. Those definitions
are put into
xen-hptool is including private headers from tools/libxc without any
need. Switch it to use official headers only.
Signed-off-by: Juergen Gross
---
tools/misc/Makefile | 2 --
tools/misc/xen-hptool.c | 8 +---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/misc/Make
stubdom/mini-os.mk should contain paths used by Mini-OS when built as
stubdom.
Signed-off-by: Juergen Gross
Reviewed-by: Samuel Thibault
---
stubdom/mini-os.mk | 17 +
1 file changed, 17 insertions(+)
create mode 100644 stubdom/mini-os.mk
diff --git a/stubdom/mini-os.mk b/stub
The pattern for building a Xen library with sources under tools/libs
is always the same. Simplify stubdom/Makefile by defining a callable
make program for those libraries.
Even if not needed right now add the possibility for defining
additional dependencies for a library.
Signed-off-by: Juergen G
readnotes.c is including xg_private.h. Now that the xenctrl headers
are structured better this is no longer needed.
Signed-off-by: Juergen Gross
---
tools/xcutils/Makefile| 3 +--
tools/xcutils/readnotes.c | 5 +++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/xcutil
Today there are multiple copies of the ROUNDUP() macro in various
sources and headers. Define it once in tools/include/xen-tools/libs.h.
Using xen-tools/libs.h enables removing copies of MIN() and MAX(), too.
Signed-off-by: Juergen Gross
---
tools/console/daemon/io.c| 6 +-
tools/in
tools/libs/libs.mk needs to be modified for being able to support
building libxenctrl, as the pkg-config file of that library is not
following the same conventions as those of the other libraries.
So add support for specifying PKG_CONFIG before including libs.mk.
In order to make life easier for
There is not a single wrapper for a libxenguest function defined.
So drop libxenguest from tools/python/setup.py.
Signed-off-by: Juergen Gross
---
tools/python/setup.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/python/setup.py b/tools/python/setup.py
index 8fa
flight 152675 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/152675/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-i386-libvirt-xsm 20 guest-destroyfail in 152664 pass in 152675
test-amd64-amd64-xl-qemut-debianhvm
On Sat, Aug 22 2020 at 20:05, Jason Gunthorpe wrote:
> On Sat, Aug 22, 2020 at 03:34:45AM +0200, Thomas Gleixner wrote:
> As a silicon design it might work, but it means existing devices can't
> be used with this dev_msi. It is also the sort of thing that would
> need a standard document to have an
62 matches
Mail list logo
