Juergen Gross, le dim. 23 août 2020 11:34:48 +0200, a ecrit: > The stubdom Makefile is missing several dependencies between Xen > libraries. Add them. > > Signed-off-by: Juergen Gross <jgr...@suse.com>
Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> In case another round of review is needed, perhaps you can just factorize: > @@ -387,6 +394,7 @@ $(TARGETS_MINIOS): mini-os-%: > > .PHONY: libxentoolcore > libxentoolcore: libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a > +libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: $(LIBDEPS_toolcore) > libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: > mk-headers-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) > CPPFLAGS="$(TARGET_CPPFLAGS)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) > DESTDIR= -C libs-$(XEN_TARGET_ARCH)/toolcore > > @@ -396,6 +404,7 @@ libs-$(XEN_TARGET_ARCH)/toolcore/libxentoolcore.a: > mk-headers-$(XEN_TARGET_ARCH) > > .PHONY: libxentoollog > libxentoollog: libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a > +libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a: $(LIBDEPS_toollog) > libs-$(XEN_TARGET_ARCH)/toollog/libxentoollog.a: > mk-headers-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) > CPPFLAGS="$(TARGET_CPPFLAGS)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) > DESTDIR= -C libs-$(XEN_TARGET_ARCH)/toollog etc. by iterating over LIBS_LIBS? That'll make the maintenance easier. Samuel
