Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote: > >>> Roger Pau Monne 06/28/18 5:38 PM >>> > >lld (the llvm linker) has some issues with Xen linker script. It > >doesn't understand '||' in assert expressions: > > > >ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ >

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Jan Beulich
>>> Razvan Cojocaru 06/28/18 4:58 PM >>> >On 06/28/2018 05:53 PM, Alexandru Stefan ISAILA wrote: >> The number was with this patch so no correction. This was done with >> xen-access write and I don't think it will make a difference if you >> change the access to all the mem pages. > >Right, so the

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Jan Beulich
>>> Alexandru Stefan ISAILA 06/28/18 4:53 PM >>> >On Jo, 2018-06-28 at 08:40 -0600, Jan Beulich wrote: >> > > > On 28.06.18 at 16:10, wrote: >> > On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: >> > > > > > On 18.06.18 at 17:17, wrote: >> > > > From: Isaila Alexandru >> > > > >> > > > This

Re: [Xen-devel] Help: a xen crash of 4.8.2 version/////答复: Is there a faster way to restore Virtual machine status in Xen?

2018-06-28 Thread Jan Beulich
>>> "Chenjia (C)" 06/29/18 6:27 AM >>> >We meet a xen bug in our project(our project job is descript in the last >email), the crash information is this: Before sending bug reports, may I ask that you test against latest code (at the very least the latest on the branch in question). In the parti

Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-06-28 Thread Jan Beulich
>>> Roger Pau Monne 06/28/18 5:38 PM >>> >lld (the llvm linker) has some issues with Xen linker script. It >doesn't understand '||' in assert expressions: > >ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ >/root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.

Re: [Xen-devel] [PATCH] x86/pv: Deprecate support for paging out the LDT

2018-06-28 Thread Jan Beulich
>>> Andrew Cooper 06/28/18 6:10 PM >>> >On 28/06/18 14:35, Jan Beulich wrote: > On 26.06.18 at 13:35, wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -161,3 +161,24 @@ endmenu >>> source "common/Kconfig" >>> >>> source "drivers/Kconfig" >>> + >>> +menu "Depreca

[Xen-devel] [freebsd-master test] 124803: all pass - PUSHED

2018-06-28 Thread osstest service owner
flight 124803 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124803/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 1263f7a5abb2102f40349b2f1d16adc6a2140fae baseline version: freebsd decf0e8734c

[Xen-devel] Help: a xen crash of 4.8.2 version/////答复: Is there a faster way to restore Virtual machine status in Xen?

2018-06-28 Thread Chenjia (C)
Dear xen expert: We meet a xen bug in our project(our project job is descript in the last email), the crash information is this: (XEN) RFLAGS: 00010003 CONTEXT: hypervisor (XEN) rax: 8005003b rbx: 83006215f000 rcx: (XEN) rdx: 6c00 rsi:

[Xen-devel] [xen-4.6-testing test] 124785: regressions - FAIL

2018-06-28 Thread osstest service owner
flight 124785 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 13 guest-saverestore fail REGR. vs. 124551 Tests wh

[Xen-devel] [xen-unstable-smoke test] 124813: trouble: blocked/broken/pass

2018-06-28 Thread osstest service owner
flight 124813 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124813/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-pv

[Xen-devel] [linux-next test] 124760: trouble: blocked/broken/queued/running

2018-06-28 Thread osstest service owner
flight 124760 linux-next running [real] http://logs.test-lab.xenproject.org/osstest/logs/124760/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-amd64

[Xen-devel] [xen-unstable-smoke test] 124738: trouble: blocked/broken/queued/running

2018-06-28 Thread osstest service owner
flight 124738 xen-unstable-smoke running [real] http://logs.test-lab.xenproject.org/osstest/logs/124738/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-arm64

[Xen-devel] [linux-4.9 test] 124777: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
flight 124777 linux-4.9 running [real] http://logs.test-lab.xenproject.org/osstest/logs/124777/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-amd64

[Xen-devel] [xen-4.10-testing test] 124781: trouble: blocked/broken/preparing/queued/running

2018-06-28 Thread osstest service owner
flight 124781 xen-4.10-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124781/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64-x

[Xen-devel] [linux-4.14 test] 124775: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
flight 124775 linux-4.14 running [real] http://logs.test-lab.xenproject.org/osstest/logs/124775/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvopsbroken build-i386-pvops

[Xen-devel] [ovmf test] 124779: trouble: blocked/broken

2018-06-28 Thread osstest service owner
flight 124779 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124779/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm broken build-i386

[Xen-devel] [xen-4.9-testing test] 124780: trouble: blocked/broken/preparing/queued/running

2018-06-28 Thread osstest service owner
flight 124780 xen-4.9-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124780/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xtf broken build-arm64-pv

Re: [Xen-devel] [PATCH 1/2] osstest: allow to treat host install errors as failures

2018-06-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 1/2] osstest: allow to treat host install errors as failures"): > And use it for the build-amd64-freebsd-again job, which should test > the new FreeBSD build produced by build-amd64-freebsd and a host > install error should be treated as a failure in order to trigge

[Xen-devel] [linux-linus test] 124772: trouble: blocked/broken/preparing/queued/running

2018-06-28 Thread osstest service owner
flight 124772 linux-linus running [real] http://logs.test-lab.xenproject.org/osstest/logs/124772/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops broken build-amd64

[Xen-devel] [freebsd-master test] 124787: all pass - PUSHED

2018-06-28 Thread osstest service owner
flight 124787 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124787/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd decf0e8734ccc2370181c089e8205e1f19a0972f baseline version: freebsd 137a4801848

[Xen-devel] [qemu-mainline test] 124765: trouble: blocked/broken/preparing/queued/running

2018-06-28 Thread osstest service owner
flight 124765 qemu-mainline running [real] http://logs.test-lab.xenproject.org/osstest/logs/124765/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken build-arm64-xsm

[Xen-devel] [xen-4.7-testing test] 124782: trouble: blocked/broken/preparing/queued/running

2018-06-28 Thread osstest service owner
flight 124782 xen-4.7-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124782/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm broken build-i386-xsm

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Tamas K Lengyel
On Thu, Jun 28, 2018 at 8:40 AM Jan Beulich wrote: > > >>> On 28.06.18 at 16:10, wrote: > > On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: > >> > > > On 18.06.18 at 17:17, wrote: > >> > From: Isaila Alexandru > >> > > >> > This patch adds access rights for the NPT pages. The access rights

[Xen-devel] [qemu-upstream-4.11-testing baseline test] 124768: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 124768 qemu-upstream-4.11-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124768/

Re: [Xen-devel] [PATCH V3] xen/altp2m: set access_required properly for all altp2ms

2018-06-28 Thread Tamas K Lengyel
On Thu, Jun 28, 2018 at 1:54 AM Razvan Cojocaru wrote: > > For the hostp2m, access_required starts off as 0, then it can be > set with xc_domain_set_access_required(). However, all the altp2ms > set it to 1 on init, and ignore both the hostp2m and the hypercall. > This patch sets access_required t

[Xen-devel] [seabios test] 124776: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
flight 124776 seabios running [real] http://logs.test-lab.xenproject.org/osstest/logs/124776/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 broken build-i386-xsm

Re: [Xen-devel] [PATCH] x86/pv: Deprecate support for paging out the LDT

2018-06-28 Thread Andrew Cooper
On 28/06/18 14:35, Jan Beulich wrote: On 26.06.18 at 13:35, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -161,3 +161,24 @@ endmenu >> source "common/Kconfig" >> >> source "drivers/Kconfig" >> + >> +menu "Deprecated Functionality" >> + >> +config LEGACY_PV_LDT_P

[Xen-devel] [PATCH 1/2] osstest: allow to treat host install errors as failures

2018-06-28 Thread Roger Pau Monne
And use it for the build-amd64-freebsd-again job, which should test the new FreeBSD build produced by build-amd64-freebsd and a host install error should be treated as a failure in order to trigger the bisection. Signed-off-by: Roger Pau Monné --- make-freebsd-flight | 3 ++- sg-run-job

[Xen-devel] [PATCH 2/2] osstest: move install of FreeBSD build deps to build-prep

2018-06-28 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- ts-build-prep-freebsd | 6 ++ ts-freebsd-build | 5 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ts-build-prep-freebsd b/ts-build-prep-freebsd index 1d78a3e1..3999ed79 100755 --- a/ts-build-prep-freebsd +++ b/ts-build-prep-freebs

Re: [Xen-devel] [OSSTEST PATCH v2] crontabs: Run freebsd-master only three times per week

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 11:34:11AM +0100, Ian Jackson wrote: > freebsd master seems to update very frequently and our tests are > pretty minimal. Right now having a permanent freebsd build test going > is probably not a very good use of our resources. > > CC: Roger Pau Monné > Signed-off-by: Ian

[Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

2018-06-28 Thread Roger Pau Monne
lld (the llvm linker) has some issues with Xen linker script. It doesn't understand '||' in assert expressions: ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ /root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.0 ld: error: xen.lds:260: malformed number:

[Xen-devel] [libvirt test] 124755: trouble: blocked/broken

2018-06-28 Thread osstest service owner
flight 124755 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/124755/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Razvan Cojocaru
On 06/28/2018 05:53 PM, Alexandru Stefan ISAILA wrote: > On Jo, 2018-06-28 at 08:40 -0600, Jan Beulich wrote: >>> > > On 28.06.18 at 16:10, wrote: >>> On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: > >> >>> >>> On 18.06.18 at 17:17, wrote: > From: Isail

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Alexandru Stefan ISAILA
On Jo, 2018-06-28 at 08:40 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 28.06.18 at 16:10, wrote: > > On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 18.06.18 at 17:17, wrote: > > > > From: Isaila Alexandru > > > > > > > > This pa

Re: [Xen-devel] [PATCH v2 04/10] x86: Add Intel Processor Trace MSRs and bit definitions

2018-06-28 Thread Jan Beulich
>>> On 30.05.18 at 15:27, wrote: > --- a/xen/include/asm-x86/msr-index.h > +++ b/xen/include/asm-x86/msr-index.h > @@ -548,4 +548,41 @@ > #define MSR_PKGC9_IRTL 0x0634 > #define MSR_PKGC10_IRTL 0x0635 > > +/* Intel PT MSRs */ > +#define MSR_IA

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Jan Beulich
>>> On 28.06.18 at 16:10, wrote: > On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: >> > > > On 18.06.18 at 17:17, wrote: >> > From: Isaila Alexandru >> > >> > This patch adds access rights for the NPT pages. The access rights >> > are >> > saved in a radix tree with the root saved in p2m_do

Re: [Xen-devel] [PATCH V5] x86/altp2m: Fix crash with INVALID_ALTP2M EPTP index

2018-06-28 Thread Jan Beulich
>>> On 28.06.18 at 16:35, wrote: > A VM exit handler executed immediately after enabling #VE might > find a stale __vmsave()d EPTP_INDEX, stored by calling > altp2m_vcpu_destroy() when SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS > had been enabled by altp2m_vcpu_update_vmfunc_ve(). > > vmx_vmexit_handl

[Xen-devel] [PATCH V5] x86/altp2m: Fix crash with INVALID_ALTP2M EPTP index

2018-06-28 Thread Razvan Cojocaru
A VM exit handler executed immediately after enabling #VE might find a stale __vmsave()d EPTP_INDEX, stored by calling altp2m_vcpu_destroy() when SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS had been enabled by altp2m_vcpu_update_vmfunc_ve(). vmx_vmexit_handler() __vmread()s EPTP_INDEX as soon as SECONDA

[Xen-devel] [xen-4.8-testing test] 124783: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
flight 124783 xen-4.8-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124783/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-xs

Re: [Xen-devel] [PATCH v2 03/10] x86: Add Intel Processor Trace support for cpuid

2018-06-28 Thread Jan Beulich
>>> On 30.05.18 at 15:27, wrote: > @@ -759,12 +760,19 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t > domid, > continue; > } > > +if ( input[0] == 0x14 ) > +{ > +input[1]++; > +if ( input[1] == 1 ) > +c

[Xen-devel] [xen-4.11-testing test] 124740: trouble: blocked/broken/preparing/queued

2018-06-28 Thread osstest service owner
flight 124740 xen-4.11-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124740/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvopsbroken build-arm64-p

Re: [Xen-devel] [PATCH v2 01/10] x86: add an flag to enable Intel Processor Trace in guest

2018-06-28 Thread Jan Beulich
>>> On 30.05.18 at 15:27, wrote: > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1215,6 +1215,16 @@ Rather than only mapping RAM pages for IOMMU accesses > for Dom0, with this > option all pages not marked as unusable in the E820 table will get a map

Re: [Xen-devel] [PATCH v2] x86/mm: Add mem access rights to NPT

2018-06-28 Thread Alexandru Stefan ISAILA
On Vi, 2018-06-22 at 09:51 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 18.06.18 at 17:17, wrote: > > From: Isaila Alexandru > > > > This patch adds access rights for the NPT pages. The access rights > > are > > saved in a radix tree with the root saved in p2m_domain. > Sounds resource

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Jan Beulich
>>> On 28.06.18 at 15:36, wrote: > On 28/06/18 14:00, Jan Beulich wrote: > On 26.06.18 at 15:18, wrote: >>> @@ -49,6 +28,18 @@ >>> #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) >>> #define ARCH_CAPS_SSB_NO (_AC(1, ULL) << 4) >>> >>> +#define MSR_EFER

Re: [Xen-devel] [PATCH v2 8/8] efi: drop original xen.efi code and build mechanism

2018-06-28 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > Then rename xen.mb.efi to xen.efi and drop all related > differentiators in the code. For this you'll first of all need to convince me that the binary you build is a drop-in replacement for xen.efi. As noted in the replies to earlier patches, I'm getting the imp

Re: [Xen-devel] [PATCH v2 7/8] xen/x86/efi: Verify dom0 kernel with SHIM_LOCK protocol in efi_multiboot2()

2018-06-28 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > @@ -435,6 +439,18 @@ __efi64_mb2_start: > cmove MB2_efi64_ih(%rcx),%rdi > je .Lefi_mb2_next_tag > > +/* > + * Get dom0 kernel module struct address from Multiboot2 > + * information and ignore the rest of modules

Re: [Xen-devel] [PATCH v2 6/8] efi: split out efi_shim_lock()

2018-06-28 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > ..which verifies PE signatures with SHIM_LOCK protocol. We want > to re-use this code in subsequent patch in efi_multiboot2(). > > Signed-off-by: Daniel Kiper I think this would better be merged with the patch actually needing it, but anyway Acked-by: Jan Beul

Re: [Xen-devel] [PATCH v2 5/8] xen/x86: add some addresses to the Multiboot2 header

2018-06-28 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > In comparison to ELF the PE format is not supported by the Multiboot2 > protocol. So, if we wish to load xen.mb.efi using this protocol we have > to add MULTIBOOT2_HEADER_TAG_ADDRESS and MULTIBOOT2_HEADER_TAG_ENTRY_ADDRESS > tags into Multiboot2 header. > > Addi

Re: [Xen-devel] [PATCH v2 4/8] xen/x86: add some addresses to the Multiboot header

2018-06-28 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > In comparison to ELF the PE format is not supported by the Multiboot > protocol. So, if we wish to load xen.mb.efi using this protocol we > have to put header_addr, load_addr, load_end_addr, bss_end_addr and > entry_addr data into Multiboot header. > > The Multi

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Andrew Cooper
On 28/06/18 14:00, Jan Beulich wrote: On 26.06.18 at 15:18, wrote: >> @@ -49,6 +28,18 @@ >> #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) >> #define ARCH_CAPS_SSB_NO(_AC(1, ULL) << 4) >> >> +#define MSR_EFER0xc080 /* Extended Featur

Re: [Xen-devel] [PATCH] x86/pv: Deprecate support for paging out the LDT

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 13:35, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -161,3 +161,24 @@ endmenu > source "common/Kconfig" > > source "drivers/Kconfig" > + > +menu "Deprecated Functionality" > + > +config LEGACY_PV_LDT_PAGING > + def_bool n > + prompt "PV LDT P

Re: [Xen-devel] [PATCH 7/6] x86/msr: Introduce msr_{set, clear}_bits() helpers

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 20:22, wrote: > --- a/xen/include/asm-x86/msr.h > +++ b/xen/include/asm-x86/msr.h > @@ -11,6 +11,11 @@ > #include > #include > > +static inline void rdmsr_split(unsigned int msr, uint32_t *lo, uint32_t *hi) > +{ > +asm volatile ( "rdmsr" : "=a" (*lo), "=d" (*hi) : "c"

Re: [Xen-devel] [PATCH 6/6] x86/msr: Clean up the x2APIC MSR constants

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 15:18, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2995,19 +2995,19 @@ void vmx_vlapic_msr_changed(struct vcpu *v) > SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; > if ( cpu_has_vmx_apic_reg_virt ) > { >

Re: [Xen-devel] [PATCH 4/6] x86/msr: Clean up the MSR_FEATURE_CONTROL constants

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 15:18, wrote: > --- a/xen/include/asm-x86/msr-index.h > +++ b/xen/include/asm-x86/msr-index.h > @@ -15,6 +15,13 @@ > * abbreviated name. > */ > > +#define MSR_FEATURE_CONTROL 0x003a > +#define FEAT_CTL_LOCK (_AC(1, ULL) << 0) > +#define F

Re: [Xen-devel] [PATCH 3/6] x86/msr: Clean up the MSR_{PLATFORM_INFO, MISC_FEATURES_ENABLES} constants

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 15:18, wrote: > These MSRs, while being Intel specific, are used to offer virtualised > CPUID faulting support on AMD hardware, so remove the INTEL infix. > > The bit position constants are used by guest_rdmsr(), but the logic can > be expressed using MASK_INSR() which allows t

[Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-06-28 Thread Adrian Pop
A new function, p2m_access_to_xenmem_access(), has been added to avoid code duplication. The existing _p2m_get_mem_access() now uses this function as does p2m_get_mem_access(). --- tools/libxc/include/xenctrl.h | 3 ++ tools/libxc/xc_altp2m.c | 33 -- xen/arch/arm/mem_acces

Re: [Xen-devel] [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP

2018-06-28 Thread Anthony PERARD
On Thu, Jun 28, 2018 at 12:44:28PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH v3 14/31] libxl_qmp_ev: Introduce > libxl__ev_qmp_start() to connect to QMP"): > > So what the interface looks like at the end of the series is: > > > > void libxl__ev_qmp_init(libxl__ev_qmp *ev); >

Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

2018-06-28 Thread Jan Beulich
>>> On 26.06.18 at 15:18, wrote: > @@ -49,6 +28,18 @@ > #define ARCH_CAPS_RSBA (_AC(1, ULL) << 2) > #define ARCH_CAPS_SSB_NO (_AC(1, ULL) << 4) > > +#define MSR_EFER0xc080 /* Extended Feature > Enable Register */ > +#define EFER_SC

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]

2018-06-28 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]"): > On Thu, Jun 28, 2018 at 12:35:38PM +0100, Ian Jackson wrote: > > The one that writes a nul to the file. I can't believe it was > > deliberate. I haven't look

[Xen-devel] [xen-unstable test] 124753: trouble: blocked/broken

2018-06-28 Thread osstest service owner
flight 124753 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/124753/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-i386-prev

Re: [Xen-devel] [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP

2018-06-28 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP"): > So what the interface looks like at the end of the series is: > > void libxl__ev_qmp_init(libxl__ev_qmp *ev); > int libxl__ev_qmp_register(libxl__gc *gc, libxl__ev_qmp *ev, >

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 12:35:38PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: make sure buffer is > null-terminated in libxl_read_file_contents [and 3 more messages]"): > > We can safely remove the trailing nul if libxl API makes sure a buffer > > is nul-terminated

Re: [Xen-devel] [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data

2018-06-28 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data"): > On Wed, Jun 27, 2018 at 04:10:18PM +0100, Ian Jackson wrote: > > How big is this data ? Is all this business with a linked list of > > buffers really necessary ? > > The alternative is realloc. I

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]

2018-06-28 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]"): > We can safely remove the trailing nul if libxl API makes sure a buffer > is nul-terminated. Old files will still work with new library. New files > won't work

Re: [Xen-devel] [PATCH v3 15/31] libxl_qmp_ev: Implement fd callback and read data

2018-06-28 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 04:10:18PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 15/31] libxl_qmp_ev: Implement fd callback > and read data"): > > First step into taking care of the input from QEMU's QMP socket. For > > now, we read data and store them in buffers. > > How big is t

Re: [Xen-devel] [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP

2018-06-28 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 04:07:52PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 14/31] libxl_qmp_ev: Introduce > libxl__ev_qmp_start() to connect to QMP"): > > This is a first patch to implement libxl__ev_qmp, it only connect to the > > QMP socket of QEMU and register a callback t

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 11:24:42AM +0100, Ian Jackson wrote: > Taking things in order from most salient to least salient: > > Robin Lee writes ("Re: [Xen-devel] [PATCH] libxl: make sure buffer is > null-terminated in libxl_read_file_contents"): > > In my situation, the json file is created with e

[Xen-devel] [freebsd-master test] 124778: all pass - PUSHED

2018-06-28 Thread osstest service owner
flight 124778 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124778/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 137a4801848fde80544a987fb168ff56face2ffd baseline version: freebsd dc8d1c8d510

[Xen-devel] [linux-3.18 test] 124746: trouble: blocked/broken

2018-06-28 Thread osstest service owner
flight 124746 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124746/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm broken build-armhf

[Xen-devel] [OSSTEST PATCH v2] crontabs: Run freebsd-master only three times per week

2018-06-28 Thread Ian Jackson
freebsd master seems to update very frequently and our tests are pretty minimal. Right now having a permanent freebsd build test going is probably not a very good use of our resources. CC: Roger Pau Monné Signed-off-by: Ian Jackson --- v2: Do not accidentally drop bisections. --- cr-for-branch

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 11:21:35AM +0100, Andrew Cooper wrote: > On 28/06/18 11:17, Wei Liu wrote: > > On Thu, Jun 28, 2018 at 10:27:33AM +0800, Robin Lee wrote: > >> On Wed, Jun 27, 2018 at 8:29 PM, Wei Liu wrote: > >>> On Wed, Jun 27, 2018 at 07:37:42PM +0800, Robin Lee wrote: > On Wed, Jun

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents [and 3 more messages]

2018-06-28 Thread Ian Jackson
Taking things in order from most salient to least salient: Robin Lee writes ("Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents"): > In my situation, the json file is created with external program and > contains just "{}\n" and not trailing 0. I just

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents

2018-06-28 Thread Andrew Cooper
On 28/06/18 11:17, Wei Liu wrote: > On Thu, Jun 28, 2018 at 10:27:33AM +0800, Robin Lee wrote: >> On Wed, Jun 27, 2018 at 8:29 PM, Wei Liu wrote: >>> On Wed, Jun 27, 2018 at 07:37:42PM +0800, Robin Lee wrote: On Wed, Jun 27, 2018 at 7:24 PM, Wei Liu wrote: > On Wed, Jun 27, 2018 at 07:08

Re: [Xen-devel] [PATCH] libxl: make sure buffer is null-terminated in libxl_read_file_contents

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 10:27:33AM +0800, Robin Lee wrote: > On Wed, Jun 27, 2018 at 8:29 PM, Wei Liu wrote: > > On Wed, Jun 27, 2018 at 07:37:42PM +0800, Robin Lee wrote: > >> On Wed, Jun 27, 2018 at 7:24 PM, Wei Liu wrote: > >> > On Wed, Jun 27, 2018 at 07:08:02PM +0800, Robin Lee wrote: > >> >

Re: [Xen-devel] [PATCH v2 2/2] x86/cpuid: Alter the policy logic for leaf 0xb to be multi-invocation

2018-06-28 Thread Wei Liu
On Wed, Jun 27, 2018 at 06:11:49PM +0100, Andrew Cooper wrote: > The new data lives in the .topo union, rather than being treated as a single > leaf in the basic union. > > While adjusting cpuid_policy, pad .basic to CPUID_GUEST_NR_BASIC for the > benefit of people extending the number of leaves i

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 10:07:00AM +0200, Roger Pau Monné wrote: > On Thu, Jun 28, 2018 at 09:45:06AM +0200, Roger Pau Monné wrote: > > On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote: > > > On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > > > > On Wed, Jun 27, 2018 at 03:

[Xen-devel] [distros-debian-wheezy test] 74919: trouble: blocked/broken

2018-06-28 Thread Platform Team regression test user
flight 74919 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74919/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i38

Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-28 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next."): > On Wed, Jun 27, 2018 at 03:32:32PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the > > stack of qmp_next."): > > > That buffer is only used loc

Re: [Xen-devel] [PATCH v3 07/31] libxl_qmp: Learned to send FD through QMP to QEMU

2018-06-28 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v3 07/31] libxl_qmp: Learned to send FD through QMP to QEMU"): > Yes, anywhere before the last byte of the command that is going to use > the fd. QEMU is going to store any fd received until a command is using > it. Great. Can you maybe add a comment about that

[Xen-devel] [PATCH v9 07/11] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/viridian.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c index 694eae6..ed164ab 10064

[Xen-devel] [PATCH v9 00/11] x86/domctl: Save info for one vcpu instance

2018-06-28 Thread Alexandru Isaila
Hi all, This patch series addresses the ideea of saving data from a single vcpu instance. First it starts by adding *save_one functions, then it introduces a handler for the new save_one* funcs and makes use of it in the hvm_save and hvm_save_one funcs. The final 2 patches are used for clean up.

[Xen-devel] [PATCH v9 06/11] x86/hvm: Introduce hvm_save_mtrr_msr_one func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V7: - Add const to the declaration of mtrr_state Note: This patch is based on Roger Pau Monne's series[1] --- xen/arch/x86/hvm/mtrr.c | 79 +++

[Xen-devel] [PATCH v9 03/11] x86/hvm: Introduce hvm_save_cpu_ctxt_one func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V8: - Correct coding style issue from comment - Move return check to the one function. --- xen/arch/x86/hvm/hvm.c| 222 -- xen/incl

[Xen-devel] [PATCH v9 05/11] x86/hvm: Introduce hvm_save_cpu_msrs_one func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V7: - Moved the init of ctxt->count to hvm_save_cpu_msrs_one() --- xen/arch/x86/hvm/hvm.c | 103 +++-- 1 file changed, 57 insertions(+), 46 del

Re: [Xen-devel] strange behavior with Multiboot2 on EFI

2018-06-28 Thread Kristaps Čivkulis
Roger provided Xen kernel binary for me and it worked. I don't know why I couldn't build it properly on FreeBSD. >> menuentry 'Xen kernel' { >> set root='(hd0,1)' >> multiboot2 /xen > > I think that you should add at least this to Xen command line: > dom0_mem=1g,max:1g guest_logl

[Xen-devel] [PATCH v9 01/11] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V8: - Move return check to the one function. --- xen/arch/x86/cpu/mcheck/vmce.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/c

[Xen-devel] [PATCH v9 09/11] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-06-28 Thread Alexandru Isaila
This patch is focused on moving the for loop to the caller so now we can save info for a single vcpu instance with the save_one handlers. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/save.c | 141 +--- 1 file changed, 111 insertions(+), 30 dele

[Xen-devel] [PATCH v9 04/11] x86/hvm: Introduce hvm_save_cpu_xsave_states_one

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/hvm.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index c7ba794..e8e0be5 100644 --

[Xen-devel] [PATCH v9 02/11] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

2018-06-28 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V8: - Move return check to the one function. --- xen/arch/x86/hvm/hvm.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/

[Xen-devel] [PATCH v9 08/11] x86/hvm: Add handler for save_one funcs

2018-06-28 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila --- Changes since V8: - Add comment for the handler return values. --- xen/arch/x86/cpu/mcheck/vmce.c | 1 + xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86/hvm/hvm.c | 6 +- xen/arch/x86/hvm/i8254.c | 2 +- xen/arch/x86/hvm/irq.c

[Xen-devel] [PATCH v9 11/11] x86/hvm: Remove save_one handler

2018-06-28 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 1 - xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86/hvm/hvm.c | 5 + xen/arch/x86/hvm/i8254.c | 2 +- xen/arch/x86/hvm/irq.c | 6 +++--- xen/arch/x86/hvm/mtrr.c| 2 +- xen/arch/x86/hv

[Xen-devel] [PATCH v9 10/11] x86/hvm: Remove redundant save functions

2018-06-28 Thread Alexandru Isaila
This patch removes the redundant save functions and renames the save_one* to save. It then changes the domain param to vcpu in the save funcs. Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 19 ++ xen/arch/x86/hvm/hpet.c| 3 +- xen/arch/x86/hvm/hvm.c

Re: [Xen-devel] [PATCH v2 2/2] x86/cpuid: Alter the policy logic for leaf 0xb to be multi-invocation

2018-06-28 Thread Roger Pau Monné
On Wed, Jun 27, 2018 at 06:11:49PM +0100, Andrew Cooper wrote: > The new data lives in the .topo union, rather than being treated as a single > leaf in the basic union. > > While adjusting cpuid_policy, pad .basic to CPUID_GUEST_NR_BASIC for the > benefit of people extending the number of leaves i

Re: [Xen-devel] [PATCH 1/2] x86/cpuid: Fix up stale comments

2018-06-28 Thread Roger Pau Monné
On Wed, Jun 27, 2018 at 02:55:49PM +0100, Andrew Cooper wrote: > * There is no legacy path any more. All static information is retrieved in >the first pass. > * d->arch.cpuids[] doesn't exist any more. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné ___

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 09:45:06AM +0200, Roger Pau Monné wrote: > On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote: > > On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > > > > On Wed, Jun 27, 2018 at 04:32:14PM

[Xen-devel] [PATCH V3] xen/altp2m: set access_required properly for all altp2ms

2018-06-28 Thread Razvan Cojocaru
For the hostp2m, access_required starts off as 0, then it can be set with xc_domain_set_access_required(). However, all the altp2ms set it to 1 on init, and ignore both the hostp2m and the hypercall. This patch sets access_required to the value from the hostp2m on altp2m init, and propagates the va

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote: > On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > > > On Wed, Jun 27, 2018 at 04:32:14PM +0200, Roger Pau Monne wrote: > > > > None of the called functions return

Re: [Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-06-28 Thread Roger Pau Monné
On Thu, Jun 28, 2018 at 09:27:08AM +0200, Dario Faggioli wrote: > On Thu, 2018-06-14 at 13:20 -0700, Stefano Stabellini wrote: > > On Thu, 14 Jun 2018, Andrew Cooper wrote: > > > On 14/06/18 14:40, Jan Beulich wrote: > > > I don't think its reasonable to alter the support status with this > > issue

Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

2018-06-28 Thread Wei Liu
On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote: > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote: > > On Wed, Jun 27, 2018 at 04:32:14PM +0200, Roger Pau Monne wrote: > > > None of the called functions return any errors, so there's no point in > > > returning an int from x

Re: [Xen-devel] [PATCH v2 8/8] tools/tests/depriv-fd-checker: Support checking of Linux tun devices

2018-06-28 Thread Wei Liu
On Wed, Jun 27, 2018 at 03:07:56PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v2 8/8] tools/tests/depriv-fd-checker: Support > checking of Linux tun devices"): > > On Mon, Jun 11, 2018 at 03:13:24PM +0100, Ian Jackson wrote: > > > Signed-off-by: Ian Jackson > > > > The code looks OK

  1   2   >