>>> On 19.06.18 at 16:35, <daniel.ki...@oracle.com> wrote: > @@ -435,6 +439,18 @@ __efi64_mb2_start: > cmove MB2_efi64_ih(%rcx),%rdi > je .Lefi_mb2_next_tag > > + /* > + * Get dom0 kernel module struct address from Multiboot2 > + * information and ignore the rest of modules. > + */ > + cmpl $MULTIBOOT2_TAG_TYPE_MODULE,MB2_tag_type(%rcx) > + jne .Lefi_mb2_end > + > + test %r14d,%r14d > + cmovz %ecx,%r14d > + jmp .Lefi_mb2_next_tag > + > +.Lefi_mb2_end:
Especially here, but perhaps also applicable to other hunks: Despite surrounding code being like this, can we please stop the bad habit of not having blanks after the commas in insn operand lists? Also personally I'd prefer if you uppercased the d in Dom0 everywhere - we commonly use something like d%d or otherwise Dom%d (or DomU). With these purely mechanical things taken care of Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
