Re: [Xen-devel] [PATCH 5/8] libxl: Share logic for finding path between qemuu and pygrub

2016-03-19 Thread George Dunlap
On Thu, Mar 17, 2016 at 6:22 PM, Ian Jackson wrote: > George Dunlap writes ("[PATCH 5/8] libxl: Share logic for finding path > between qemuu and pygrub"): >> From: George Dunlap > > Thanks. There are a few format inconsistencies (long lines, spaces) > which I

[Xen-devel] [PATCH 0/8] tools: Allow HVM domains emulated access to disks provided by hotplug scripts

2016-03-19 Thread George Dunlap
cooked" version available to qemu. This series also starts to work towards a rationalized interface to the block hotplug scripts, on which hotplug scripts for FreeBSD can be added. George Dunlap (7): tools/hotplug: Add a "dummy" hotplug script for testing libxl: Remove red

Re: [Xen-devel] [PATCH 3/3] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-20 Thread George Dunlap
On Thu, Mar 10, 2016 at 3:00 PM, Juergen Gross wrote: > Add a new pvusb backend type "qusb" which is provided by qemu. It can > be selected either by specifying the type directly in the configuration > or it is selected automatically by libxl in case there is no "usbback" > driver loaded. > > Sign

Re: [Xen-devel] [PATCH v4 08/34] vmap: Make the while loop less fishy.

2016-03-21 Thread George Dunlap
On Thu, Mar 17, 2016 at 4:08 PM, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v4 08/34] vmap: Make the while loop > less fishy."): >> error: >> -while ( i-- ) >> -free_domheap_page(mfn_to_page(mfn_x(mfn[i]))); >> +while ( i ) >> +free_domheap_page(mfn_to_pa

Re: [Xen-devel] [PATCH v4 08/34] vmap: Make the while loop less fishy.

2016-03-21 Thread George Dunlap
On Mon, Mar 21, 2016 at 1:26 PM, Jan Beulich wrote: On 21.03.16 at 13:04, wrote: >> On Thu, Mar 17, 2016 at 4:08 PM, Ian Jackson >> wrote: >>> Konrad Rzeszutek Wilk writes ("[PATCH v4 08/34] vmap: Make the while loop >>> less fishy."): error: -while ( i-- ) -f

Re: [Xen-devel] [PATCH 2/3] libxl: add domain config parameter to force start of qemu

2016-03-21 Thread George Dunlap
On 18/03/16 08:11, Juergen Gross wrote: > On 17/03/16 17:06, George Dunlap wrote: >> On Thu, Mar 10, 2016 at 3:00 PM, Juergen Gross wrote: >>> Today the device model (qemu) is started for a pv domain only in case >>> a device requiring qemu is specified in the domain co

Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

2016-03-21 Thread George Dunlap
On 17/03/16 18:11, Ian Jackson wrote: > George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a > funciton"): >> +static char * libxl__device_disk_find_local_path(libxl__gc *gc, >> + const

Re: [Xen-devel] [PATCH v8 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-03-21 Thread George Dunlap
On 21/03/16 15:18, Chong Li wrote: > On Mon, Mar 21, 2016 at 8:35 AM, Jan Beulich wrote: > On 18.03.16 at 22:26, wrote: >>> Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls >>> to independently get and set the scheduling parameters of each >>> vCPU of a domain >>> >>> Signed-off

[Xen-devel] [PATCH v2 4/9] libxl: Move check for local access to a funciton

2016-03-21 Thread George Dunlap
From: George Dunlap Move pygrub checks for local access ability into a separate function. Also reorganize libxl__device_disk_local_initiate_attach so that we don't initialize dls->disk unless we actually end up doing a local attach. Signed-off-by: George Dunlap --- Changes

[Xen-devel] [PATCH v2 2/9] libxl: Remove redundant setting of phyical-device

2016-03-21 Thread George Dunlap
licate physical block devices used in different virtual devices. The first thing the block script does is check to see if this node is written; and if it is, it silently exits. Remove this, and let the block script perform its duplicate checking function. Signed-off-by: George Dunlap Acked-

[Xen-devel] [PATCH v2 3/9] tools/hotplug: Write physical-device-path in addition to physical-device

2016-03-21 Thread George Dunlap
Change block-common.sh on Linux to write physical-device-path with the path of the device node, in addition to physical-device with its major:minor numbers. Signed-off-by: George Dunlap --- NB that a later patch in this series introduces some documentation for the block script protocol. If it&#

[Xen-devel] [PATCH v2 5/9] libxl: Rearrange qemu upstream disk argument code

2016-03-21 Thread George Dunlap
qemu, most likely resulting in qemu exiting with an error. This will be fixed in follow-up patches. Signed-off-by: George Dunlap --- Changes since v1: - Move qemuu disk argument refactoring into a separate patch CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Anthony Perard

[Xen-devel] [PATCH v2 6/9] libxl: Share logic for finding path between qemuu and pygrub

2016-03-21 Thread George Dunlap
From: George Dunlap qemu can also access disks which will be provided with a qdisk backend directly; add a flag to libxl__device_disk_find_local_path to indicate whether to check for qdisk direct access. Call libxl__device_disk_find_local_path() for most paths. If we can't find a local

[Xen-devel] [PATCH v2 0/9] tools: Allow HVM domains emulated access to disks provided by hotplug scripts

2016-03-21 Thread George Dunlap
cooked" version available to qemu. This series also starts to work towards a rationalized interface to the block hotplug scripts, on which hotplug scripts for FreeBSD can be added. Changes since v1: - Split one of the patches into two George Dunlap (8): tools/hotplug: Add a "dummy&

[Xen-devel] [PATCH v2 1/9] tools/hotplug: Add a "dummy" hotplug script for testing

2016-03-21 Thread George Dunlap
From: George Dunlap Testing the hotplug external script path at the moment involves actually setting up one of the alternate datapaths (blktap, iscsi, &c). Simplify testing by making a script which does a simple loopback, but still has a target that can't be used directly. To use

[Xen-devel] [PATCH v2 8/9] docs: Document block-script protocol

2016-03-21 Thread George Dunlap
Signed-off-by: George Dunlap --- Changes since v1: - Attempt to make a clear distinction between custom hotplug scripts and the script called for raw physical devices and files CC: Ian Jackson CC: Wei Liu CC: Roger Pau Monne --- docs/misc/block-scripts.txt | 101

[Xen-devel] [PATCH v2 9/9] DO NOT APPLY libxl: Change hotplug script interface to use physical-device-path

2016-03-21 Thread George Dunlap
re libxl gets a chance to write that node. It should be sufficient to modify check_sharing() to read that node if it's avialable, and if it's not available, to instead read the major/minor from physical-device-path. Signed-off-by: Ian Jackson Signed-off-by: George Dunlap --- Chances si

[Xen-devel] [PATCH v2 7/9] libxl: Allow local access for block devices with hotplug scripts

2016-03-21 Thread George Dunlap
From: George Dunlap pygrub and qemuu need to be able to access a VM's disks locally in order to be able to pull out the kernel and provide emulated disk access, respectively. This can be done either by accessing the local disk directly, or by plugging the target disk into dom0 to allow a

Re: [Xen-devel] [PATCH v2 6/9] libxl: Share logic for finding path between qemuu and pygrub

2016-03-22 Thread George Dunlap
On Mon, Mar 21, 2016 at 6:16 PM, George Dunlap wrote: > From: George Dunlap > > qemu can also access disks which will be provided with a qdisk backend > directly; add a flag to libxl__device_disk_find_local_path to indicate > whether to check for qdisk direct a

Re: [Xen-devel] [PATCH 1/3] Add new functions to get/set memory types.

2016-03-22 Thread George Dunlap
On Wed, Mar 16, 2016 at 12:21 PM, Yu Zhang wrote: > For clarity this patch breaks the code to set/get memory types out > of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type(). > Also, for clarity, checks for whether a memory type change is allowed > are broken out into a separate funct

Re: [Xen-devel] [PATCH 2/3] Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-03-22 Thread George Dunlap
On 16/03/16 12:21, Yu Zhang wrote: > Previously p2m type p2m_mmio_write_dm was introduced for write- > protected memory pages whose write operations are supposed to be > forwarded to and emulated by an ioreq server. Yet limitations of > rangeset restricts the number of guest pages to be write-prote

Re: [Xen-devel] [PATCH 3/3] Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-03-22 Thread George Dunlap
On 16/03/16 12:22, Yu Zhang wrote: > A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to > let one ioreq server claim its responsibility for the handling > of guest pages with p2m type p2m_ioreq_server. Users of this > HVMOP can specify whether the p2m_ioreq_server is supposed to > handle

Re: [Xen-devel] [PATCH v2 0/9] tools: Allow HVM domains emulated access to disks provided by hotplug scripts

2016-03-23 Thread George Dunlap
On 23/03/16 10:10, Roger Pau Monné wrote: > On Mon, 21 Mar 2016, George Dunlap wrote: > >> In order for HVM domains to provide emulated access to disks provided >> by hotplug scripts, qemu needs access to a "cooked" version of the >> disk. In the case of hotplug

Re: [Xen-devel] [PATCH v2 8/9] docs: Document block-script protocol

2016-03-23 Thread George Dunlap
On 22/03/16 12:52, Roger Pau Monné wrote: > On Mon, 21 Mar 2016, George Dunlap wrote: >> Signed-off-by: George Dunlap >> --- >> Changes since v1: >> - Attempt to make a clear distinction between custom hotplug scripts >> and the script called for raw physica

Re: [Xen-devel] [PATCH 3/3] Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-03-23 Thread George Dunlap
On 22/03/16 17:51, Paul Durrant wrote: >> -Original Message- >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 22 March 2016 17:27 >> To: Yu Zhang; xen-devel@lists.xen.org >> Cc: Keir (Xen.org); jbeul...@suse.com; Andrew Cooper; George Dun

Re: [Xen-devel] [PATCH 1/3] xenalyze: handle DOM0 operaions events

2016-03-23 Thread George Dunlap
x27;. But re the content (i.e., this patch with the SoB and the title fixed) Acked-by: George Dunlap Sorry it took so long to get to this. > Cc: George Dunlap > Cc: Ian Jackson > Cc: Wei Liu > Cc: Konrad Rzeszutek Wilk > --- > Changes from v1: > * new patc

Re: [Xen-devel] [PATCH 3/3] xenalyze: handle RTDS scheduler events

2016-03-23 Thread George Dunlap
On 12/03/16 11:34, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: George Dunlap > --- > Cc: George Dunlap > Cc: Meng Xu &

Re: [Xen-devel] [PATCH 01/16] xen: sched: fix locking when allocating an RTDS pCPU

2016-03-23 Thread George Dunlap
the mapping of the lock to the RTDS one; > - release the lock (the one that has actually been >taken!) > > Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap > --- > Cc: Meng Xu > Cc: George Dunlap > Cc: Tianyang Chen > --- > xen/common/sched_rt.c

Re: [Xen-devel] [PATCH 02/16] xen: sched: add .init_pdata hook to the scheduler interface

2016-03-23 Thread George Dunlap
ormation > (for instance, the host CPU topology) are available. This, > for now, is important only for Credit2, but it can well be > useful to other schedulers. > > Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Just one note -- I found this patch harder to review than

Re: [Xen-devel] [PATCH 03/16] xen: sched: make implementing .alloc_pdata optional

2016-03-23 Thread George Dunlap
On 21/03/16 14:22, Jan Beulich wrote: On 18.03.16 at 20:04, wrote: >> --- a/xen/include/xen/sched-if.h >> +++ b/xen/include/xen/sched-if.h >> @@ -9,6 +9,7 @@ >> #define __XEN_SCHED_IF_H__ >> >> #include >> +#include >> >> /* A global pointer to the initial cpupool (POOL0). */ >> ext

Re: [Xen-devel] [PATCH 03/16] xen: sched: make implementing .alloc_pdata optional

2016-03-23 Thread George Dunlap
On 18/03/16 19:04, Dario Faggioli wrote: > The .alloc_pdata scheduler hook must, before this change, > be implemented by all schedulers --even those ones that > don't need to allocate anything. > > Make it possible to just use the SCHED_OP(), like for > the other hooks, by using ERR_PTR() and IS_E

Re: [Xen-devel] [PATCH 04/16] xen: sched: implement .init_pdata in all schedulers

2016-03-23 Thread George Dunlap
simplification, it is now also ok to >> move some of the logic meant at double checking that a >> cpu was (or was not) initialized, into ASSERTS (rather >> than an if() and a BUG_ON). >> >> Signed-off-by: Dario Faggioli >> --- >>

Re: [Xen-devel] [PATCH 05/16] xen: sched: move pCPU initialization in an helper

2016-03-23 Thread George Dunlap
some style cleanup is also done. > > No functional change intended. > > Signed-off-by: Dario Faggioli > --- > Cc: George Dunlap > --- > xen/common/sched_credit.c | 22 +- > xen/common/sched_credit2.c | 26 -- >

Re: [Xen-devel] [PATCH 05/16] xen: sched: move pCPU initialization in an helper

2016-03-23 Thread George Dunlap
On 23/03/16 17:51, George Dunlap wrote: > On 18/03/16 19:04, Dario Faggioli wrote: >> That will turn out useful in following patches, where such >> code will need to be called more than just once. Create an >> helper now, and move the code there, to avoid mixing code >

Re: [Xen-devel] [PATCH 09/16] xen: sched: close potential races when switching scheduler to CPUs

2016-03-23 Thread George Dunlap
On 18/03/16 19:05, Dario Faggioli wrote: > by using the sched_switch hook that we have introduced in > the various schedulers. > > The key is to let the actual switch of scheduler and the > remapping of the scheduler lock for the CPU (if necessary) > happen together (in the same critical section)

Re: [Xen-devel] Severe guest disk corruption with device_model_stubdomain_override=1...

2016-03-24 Thread George Dunlap
On Wed, Mar 23, 2016 at 9:46 PM, Sarah Newman wrote: > On 03/22/2016 11:03 PM, Sarah Newman wrote: >> And nested xen. >> >> CPU: AMD Opteron 2352 >> Outer configuration: Xen4CentOS 6 xen 4.6.1-2.el6, linux >> 3.18.25-18.el6.x86_64 >> Inner configuration: Xen4CentOS 6 xen 4.6.1-2.el6, linux >> 3.

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-24 Thread George Dunlap
On Thu, Mar 24, 2016 at 11:23 AM, Andrew Cooper wrote: > On 24/03/16 10:58, Juergen Gross wrote: >> I've searched a little bit in git history in order to understand why >> xen-detect has been invented and/or has all the options which clearly >> are meant to be used in scripts. >> >> The last large

Re: [Xen-devel] [PATCH 09/16] xen: sched: close potential races when switching scheduler to CPUs

2016-03-24 Thread George Dunlap
On 18/03/16 19:05, Dario Faggioli wrote: > by using the sched_switch hook that we have introduced in > the various schedulers. > > The key is to let the actual switch of scheduler and the > remapping of the scheduler lock for the CPU (if necessary) > happen together (in the same critical section)

Re: [Xen-devel] [PATCH 10/16] xen: sched: improve credit2 bootparams' scope, placement and signedness

2016-03-24 Thread George Dunlap
On 18/03/16 19:05, Dario Faggioli wrote: > From: Uma Sharma > > and, while we are adjusting signedness of opt_load_window_shift, > make also prv->load_window_shift unsigned, as approapriate. > > Signed-off-by: Uma Sharma > Signed-off-by: Dario Faggioli Acked-by: Ge

Re: [Xen-devel] [PATCH 12/16] xen: sched: fix per-socket runqueue creation in credit2

2016-03-24 Thread George Dunlap
he boot CPU in there. The loop is a genius idea, Dario! Well done. One minor nit... > Signed-off-by: Dario Faggioli > --- > Cc: George Dunlap > Cc: Justin Weaver > --- > xen/common/sched_credit2.c | 59 > > 1 file chan

Re: [Xen-devel] [PATCH 13/16] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-03-24 Thread George Dunlap
On 18/03/16 19:05, Dario Faggioli wrote: > In fact, credit2 uses CPU topology to decide how to arrange > its internal runqueues. Before this change, only 'one runqueue > per socket' was allowed. However, experiments have shown that, > for instance, having one runqueue per physical core improves > p

Re: [Xen-devel] [PATCH 14/16] xen: sched: per-core runqueues as default in credit2

2016-03-24 Thread George Dunlap
t; of the results she got are summarized here: > > http://lists.xen.org/archives/html/xen-devel/2015-03/msg01499.html > > Signed-off-by: Dario Faggioli > Signed-off-by: Uma Sharma > Reviewed-by: Juergen Gross Acked-by: George Dunlap > --- > Cc: George Dunlap > -

Re: [Xen-devel] [PATCH 15/16] xen: sched: scratch space for cpumasks on Credit2

2016-03-24 Thread George Dunlap
To avoid having a lot of cpumask_var_t on the stack, >> this patch introduces a global scratch area. >> >> Signed-off-by: Dario Faggioli >> --- >> Cc: George Dunlap >> --- > > I would suggest instead going with > > static DEFINE_PER_CPU(cpumask_t

Re: [Xen-devel] [PATCH 11/16] xen: sched: on Credit2, don't reprogram the timer if idle

2016-03-24 Thread George Dunlap
ents will serve as pokes, when > necessary, but until we can, we should just stay idle. > > Signed-off-by: Dario Faggioli > Reported-by: Tianyang Chen > Suggested-by: George Dunlap This should be my work address (george.dun...@citrix.com). With that change: Acked-by: George Dunlap

Re: [Xen-devel] [PATCH 16/16] xen: sched: implement vcpu hard affinity in Credit2

2016-03-24 Thread George Dunlap
the "scratch_mask" to a different patch 2) The code-cleanups you listed? One rather tangential question... > --- > Cc: George Dunlap > --- > xen/common/sched_credit2.c | 131 > ++-- > 1 file changed, 102 insertions(+)

Re: [Xen-devel] [PATCH v2 8/9] docs: Document block-script protocol

2016-03-24 Thread George Dunlap
On Wed, Mar 23, 2016 at 12:14 PM, Roger Pau Monné wrote: > On Wed, 23 Mar 2016, George Dunlap wrote: >> On 22/03/16 12:52, Roger Pau Monné wrote: >> > On Mon, 21 Mar 2016, George Dunlap wrote: >> >> Signed-off-by: George Dunlap >> >> --- >> >

Re: [Xen-devel] [PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target

2016-03-24 Thread George Dunlap
On 04/01/16 17:28, Ian Jackson wrote: > George Dunlap writes ("[PATCH v4 1/5] libxl: Remove pointless hypercall from > libxl_set_memory_target"): >> There's no obvious reason for the call to xc_domain_getinfolist -- all >> it seems to be doing is checking

[Xen-devel] [PATCH v5 0/3] tools: Return failure when the command failed for more xl commands

2016-03-24 Thread George Dunlap
already-acked patches. (The other two I'll come back to another time, or may make good OPW / GSoC fodder.) George Dunlap (3): libxl: Remove pointless hypercall from libxl_set_memory_target xl: Make set_memory_target return an error code on failure xl: Return an error on failed cd-insert

[Xen-devel] [PATCH v5 3/3] xl: Return an error on failed cd-insert

2016-03-24 Thread George Dunlap
From: George Dunlap This makes xl more useful in scripts. The strange thing about this is that the internal cd_insert function *already* returned something appropriate, and cd-eject was using it, but cd-insert wasn't. Also: * Rework cd_insert to return EXIT_FAILURE and EXIT_SUCCESS r

[Xen-devel] [PATCH v5 2/3] xl: Make set_memory_target return an error code on failure

2016-03-24 Thread George Dunlap
From: George Dunlap Also move the rc -> shell code translation into set_memory_max() to make the two functions consistent with each other, and with other similar examples in xl_cmdimpl.c Change a 'long long' to "int64_t" while we're at it. Signed-off-by: George D

[Xen-devel] [PATCH v5 1/3] libxl: Remove pointless hypercall from libxl_set_memory_target

2016-03-24 Thread George Dunlap
From: George Dunlap There's no obvious reason for the call to xc_domain_getinfolist -- all it seems to be doing is checking that the domain exists; but if it doesn't exist, it will have already failed by this point. NB that this will change the return value for libxl_set_memory_targ

[Xen-devel] [PATCH v3 8/9] docs: Document block-script protocol

2016-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- Changes since v2: - Note that the "Inputs" describe Linux only Changes since v1: - Attempt to make a clear distinction between custom hotplug scripts and the script called for raw physical devices and files CC: Ian Jackson CC: Wei Liu CC: Roger

[Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-03-24 Thread George Dunlap
qemu, most likely resulting in qemu exiting with an error. This will be fixed in follow-up patches. Signed-off-by: George Dunlap --- Changes since v1: - Move qemuu disk argument refactoring into a separate patch CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Anthony Perard

[Xen-devel] [PATCH v3 3/9] tools/hotplug: Write physical-device-path in addition to physical-device

2016-03-24 Thread George Dunlap
Change block-common.sh on Linux to write physical-device-path with the path of the device node, in addition to physical-device with its major:minor numbers. Signed-off-by: George Dunlap --- NB that a later patch in this series introduces some documentation for the block script protocol. If it&#

[Xen-devel] [PATCH v3 7/9] libxl: Allow local access for block devices with hotplug scripts

2016-03-24 Thread George Dunlap
From: George Dunlap pygrub and qemuu need to be able to access a VM's disks locally in order to be able to pull out the kernel and provide emulated disk access, respectively. This can be done either by accessing the local disk directly, or by plugging the target disk into dom0 to allow a

[Xen-devel] [PATCH v3 9/9] DO NOT APPLY libxl: Change hotplug script interface to use physical-device-path

2016-03-24 Thread George Dunlap
re libxl gets a chance to write that node. It should be sufficient to modify check_sharing() to read that node if it's avialable, and if it's not available, to instead read the major/minor from physical-device-path. Signed-off-by: Ian Jackson Signed-off-by: George Dunlap --- Chances si

[Xen-devel] [PATCH v3 6/9] libxl: Share logic for finding path between qemuu and pygrub

2016-03-24 Thread George Dunlap
From: George Dunlap qemu can also access disks which will be provided with a qdisk backend directly; add a flag to libxl__device_disk_find_local_path to indicate whether to check for qdisk direct access. Call libxl__device_disk_find_local_path() for most paths. If we can't find a local

[Xen-devel] [PATCH v3 1/9] tools/hotplug: Add a "dummy" hotplug script for testing

2016-03-24 Thread George Dunlap
From: George Dunlap Testing the hotplug external script path at the moment involves actually setting up one of the alternate datapaths (blktap, iscsi, &c). Simplify testing by making a script which does a simple loopback, but still has a target that can't be used directly. To use

[Xen-devel] [PATCH v3 2/9] libxl: Remove redundant setting of phyical-device

2016-03-24 Thread George Dunlap
licate physical block devices used in different virtual devices. The first thing the block script does is check to see if this node is written; and if it is, it silently exits. Remove this, and let the block script perform its duplicate checking function. Signed-off-by: George Dunlap Acked-

[Xen-devel] [PATCH v3 0/9] tools: Allow HVM domains emulated access to disks provided by hotplug scripts

2016-03-24 Thread George Dunlap
ray comma - Make it clear that block-script.txt inputs are Linux-specific Changes since v1: - Split one of the patches into two George Dunlap (8): tools/hotplug: Add a "dummy" hotplug script for testing libxl: Remove redundant setting of phyical-device tools/hotplug: Write physical

[Xen-devel] [PATCH v3 4/9] libxl: Move check for local access to a funciton

2016-03-24 Thread George Dunlap
From: George Dunlap Move pygrub checks for local access ability into a separate function. Also reorganize libxl__device_disk_local_initiate_attach so that we don't initialize dls->disk unless we actually end up doing a local attach. Signed-off-by: George Dunlap --- Changes

Re: [Xen-devel] [PATCH 3/3] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-29 Thread George Dunlap
On Fri, Mar 25, 2016 at 6:09 AM, Juergen Gross wrote: > On 24/03/16 21:07, Wei Liu wrote: >> On Fri, Mar 18, 2016 at 09:24:26AM +0100, Juergen Gross wrote: >>> On 17/03/16 17:55, George Dunlap wrote: >>>> On Thu, Mar 10, 2016 at 3:00 PM, Juergen Gross wrote: >

Re: [Xen-devel] [PATCH] spinlock: improve spin_is_locked() for recursive locks

2016-03-29 Thread George Dunlap
On Thu, Mar 24, 2016 at 4:19 PM, Jan Beulich wrote: On 24.03.16 at 16:55, wrote: >> On 24/03/16 11:30, Jan Beulich wrote: >>> Recursive locks know their current owner, and since we use the function >>> solely to determine whether a particular lock is being held by the >>> current CPU (which

Re: [Xen-devel] xl: improve return codes for more xl comands

2016-03-29 Thread George Dunlap
On Fri, Mar 25, 2016 at 1:53 PM, Paulina Szubarczyk wrote: > Hi, > > This regards bite-size task for Outreachy program [0]. > > I followed the patches prepared by Harmandeep [1] where functions in > xl_cmdimpl.c have the pattern: > > "*main_foo() is treated somewhat as a regular main(), it is chan

Re: [Xen-devel] [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block

2016-03-29 Thread George Dunlap
On Fri, Mar 25, 2016 at 4:34 PM, Ross Philipson wrote: > On 03/25/2016 12:11 PM, Wei Liu wrote: >> On Thu, Mar 17, 2016 at 06:10:59PM -0400, Ross Philipson wrote: >>> It seems the logic is meant to detect sector unaligned buffers for block >>> writes. The NOTing of the logic instead masks off any

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-29 Thread George Dunlap
On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein wrote: > On 3/16/16 2:14 PM, Doug Goldstein wrote: >> On 3/8/16 10:50 AM, Wei Liu wrote: >>> On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug G

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-29 Thread George Dunlap
On 25/03/16 08:54, Juergen Gross wrote: > On 24/03/16 12:38, George Dunlap wrote: >> On Thu, Mar 24, 2016 at 11:23 AM, Andrew Cooper >> wrote: >>> On 24/03/16 10:58, Juergen Gross wrote: >>>> I've searched a little bit in git history in order to underst

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-29 Thread George Dunlap
On 29/03/16 15:00, Juergen Gross wrote: > On 29/03/16 15:54, George Dunlap wrote: >> On 25/03/16 08:54, Juergen Gross wrote: >>> On 24/03/16 12:38, George Dunlap wrote: >>>> On Thu, Mar 24, 2016 at 11:23 AM, Andrew Cooper >>>> wrote: >>>>

Re: [Xen-devel] Xen 4.6.1 raisin build error etherboot undeclared

2016-03-29 Thread George Dunlap
aisin.git;a=commitdiff;h=5fe3855a6cf69c4aaed89c47b7e7937b9c66d07e It looks like that commit contains a bug -- the patch adds "--enable-rombios", but the text of the patch seems to indicate that "--disable-rombios" is what was wanted. Can you try the attached patch? -George commit 8f40a9a9a61414ef61

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread George Dunlap
On Tue, Mar 29, 2016 at 6:21 PM, Doug Goldstein wrote: > On 3/29/16 6:44 AM, George Dunlap wrote: >> On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein wrote: >>> On 3/16/16 2:14 PM, Doug Goldstein wrote: >>>> On 3/8/16 10:50 AM, Wei Liu wrote: >>>>> O

Re: [Xen-devel] [PATCH v5 2/5] libxl: add query function for backend support by device model

2016-03-30 Thread George Dunlap
On 30/03/16 13:05, Juergen Gross wrote: > Add a function to query whether the device model is supporting a > specific backend type. The device model is writing the supported > backend types to Xenstore on startup. The new query function checks > for the appropriate entry to be present. > > As not

Re: [Xen-devel] [PATCH v5 2/5] libxl: add query function for backend support by device model

2016-03-30 Thread George Dunlap
On 30/03/16 14:53, Wei Liu wrote: > On Wed, Mar 30, 2016 at 02:05:55PM +0200, Juergen Gross wrote: >> Add a function to query whether the device model is supporting a >> specific backend type. The device model is writing the supported >> backend types to Xenstore on startup. The new query function

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-31 Thread George Dunlap
On Wed, Mar 30, 2016 at 5:00 PM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug > optimization level"): >> On 3/8/16 9:38 AM, Wei Liu wrote: >> > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >> >> The build should not use -O0 as tha

Re: [Xen-devel] [PATCH v3 0/8] libxl: add support for FreeBSD block hotplug scripts

2016-03-31 Thread George Dunlap
On Thu, Mar 31, 2016 at 4:09 PM, Roger Pau Monne wrote: > This series enables using hotplug scripts with the FreeBSD blkback > implementation. Since FreeBSD blkback can use both block devices and regular > RAW files as disks, the physical-device-path xenstore backend node is used > in order to sto

Re: [Xen-devel] [PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node

2016-03-31 Thread George Dunlap
> of the physical-device node. > > Signed-off-by: Roger Pau Monné Looks good to me: Reviewed-by: George Dunlap > --- > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Tim Deegan > --- > Changes since v2: > - Use physical-device-path instead of physical-device in order

Re: [Xen-devel] [PATCH v3 8/8] hotplug/FreeBSD: document disk hotplug interface

2016-03-31 Thread George Dunlap
On Thu, Mar 31, 2016 at 4:09 PM, Roger Pau Monne wrote: > Add the FreeBSD disk hotplug interface details to the block-scripts.txt > document. > > Signed-off-by: Roger Pau Monné Thanks! Reviewed-by: George Dunlap ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v4 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-03-31 Thread George Dunlap
On Thu, Mar 31, 2016 at 3:36 PM, Jim Fehlig wrote: > Jan Beulich wrote: > On 30.03.16 at 19:22, wrote: >>> Anthony PERARD wrote: Hi all, Few changes in V4: I leave the ACPI alone and only load the BIOS via libxl now. Detail of changes in each patches. >>

Re: [Xen-devel] [PATCH] x86/hvm: separate ioreq server code from generic hvm code

2016-03-31 Thread George Dunlap
On Thu, Mar 31, 2016 at 11:20 AM, Paul Durrant wrote: > The code in hvm/hvm.c related to handling I/O emulation using the ioreq > server framework is large and mostly self-contained. > > This patch separates the ioreq server code into a new hvm/ioreq.c source > module and accompanying asm-x86/hvm/

Re: [Xen-devel] [PATCH v4 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-04-01 Thread George Dunlap
On Thu, Mar 31, 2016 at 5:49 PM, George Dunlap wrote: > On Thu, Mar 31, 2016 at 3:36 PM, Jim Fehlig wrote: >> Jan Beulich wrote: >>>>>> On 30.03.16 at 19:22, wrote: >>>> Anthony PERARD wrote: >>>>> Hi all, >>>>> >>>&

Re: [Xen-devel] Getting rid of inside_vm in intel8x0

2016-04-04 Thread George Dunlap
On 02/04/16 13:57, Andy Lutomirski wrote: > On Fri, Apr 1, 2016 at 10:33 PM, Takashi Iwai wrote: >> On Sat, 02 Apr 2016 00:28:31 +0200, >> Luis R. Rodriguez wrote: >>> If the former, could a we somehow detect an emulated device other than >>> through >>> this type of check ? Or could we *add* a c

Re: [Xen-devel] [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-04 Thread George Dunlap
On 01/04/16 15:33, Roger Pau Monné wrote: > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: > >> - Use EXIT_{SUCCESS,FAILURE} for main_mem*() function >> - Use 0/1 as return values of set_memory_{max,target} >> >> Signed-off-by: Paulina Szubarczyk >> --- >> tools/libxl/xl_cmdimpl.c | 24

Re: [Xen-devel] [PATCH 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-04 Thread George Dunlap
On 01/04/16 15:55, Roger Pau Monné wrote: > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: >> libxl_set_memory_target seems to have the following return values: >> >> * 1 on failure, if the failure happens because of a xenstore error *or* >> * invalid >> target > > AFAICT it seems like you haven't

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-04 Thread George Dunlap
On 01/04/16 15:31, Ian Jackson wrote: > George Dunlap writes ("[PATCH v3 5/9] libxl: Rearrange qemu upstream disk > argument code"): >> Reorganize the qemuu disk argument code to make a clean separation >> between finding a file to use, and constructing the parameter

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread George Dunlap
On 04/04/16 16:58, Chong Li wrote: > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper > wrote: >> On 01/04/16 05:59, Chong Li wrote: >>> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c >>> index 305889a..e5d15d8 100644 >>> --- a/xen/common/sched_credit.c >>> +++ b/xen/common/sched

Re: [Xen-devel] [PATCH] xen: enable per-VCPU parameter for RTDS

2016-04-05 Thread George Dunlap
On 05/04/16 00:14, Andrew Cooper wrote: > On 04/04/2016 23:45, Chong Li wrote: >> From: Chong-Li >> >> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced >> a bug: it made it possible, in Credit and Credit2, when doing domain >> or vcpu parameters' manipulation, to leave the hy

Re: [Xen-devel] [PATCH] xen: enable per-VCPU parameter for RTDS

2016-04-05 Thread George Dunlap
On 05/04/16 08:57, Jan Beulich wrote: On 05.04.16 at 03:07, wrote: >> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced >> a bug: it made it possible, in Credit and Credit2, when doing domain >> or vcpu parameters' manipulation, to leave the hypervisor with a >> spinlock h

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-05 Thread George Dunlap
On Mon, Apr 4, 2016 at 6:16 PM, Andrew Cooper wrote: > On 04/04/16 18:11, Andrew Cooper wrote: >> On 04/04/16 17:59, Ian Jackson wrote: >>> George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream >>> disk argument code"): >>>> I l

Re: [Xen-devel] [PATCH v2 1/3] x86/ioreq server: Add new functions to get/set memory types.

2016-04-05 Thread George Dunlap
o a separate function called by hvmop_set_mem_type(). > > There is no intentional functional change in this patch. > > Signed-off-by: Paul Durrant > Signed-off-by: Yu Zhang > Cc: Keir Fraser > Cc: Jan Beulich > Cc: Andrew Cooper Reviewed-by: George Dunlap &

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-05 Thread George Dunlap
, and move the type change to the next patch. Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/3] x86/ioreq server: Add new functions to get/set memory types.

2016-04-05 Thread George Dunlap
On Tue, Apr 5, 2016 at 2:57 PM, George Dunlap wrote: > On Thu, Mar 31, 2016 at 11:53 AM, Yu Zhang wrote: >> For clarity this patch breaks the code to set/get memory types out >> of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type(). >> Also, for clarity, checks

Re: [Xen-devel] [PATCH v6] libxl: allow 'phy' backend to use empty files

2016-04-05 Thread George Dunlap
On Wed, Feb 17, 2016 at 5:20 PM, Roger Pau Monne wrote: > This was introduced by 97ee1f (~5 years ago), but was probably never > surfaced because most people used regular files as CDROM images, so the PHY > backend was actually never selected. A year ago this was changed, and now > regular RAW fil

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 3:40 AM, Luis R. Rodriguez wrote: > A huge summary of the discussion over EFI boot option for HVMLite is now on a > wiki [2], below I'll just provide the outline of the discussion. Consider > this a > request for more public review, feel free to take any of the items below

[Xen-devel] [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom

2016-04-06 Thread George Dunlap
: Andrew Cooper Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper --- tools/libxl/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 5b79aa2..eac5501 100644 --- a/tools/libxl/libxl_dm.c

Re: [Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk wrote: > From: George Dunlap > > libxl_set_memory_target seems to have the following return values: > > * 1 on failure, if the failure happens because of a xenstore error *or* > * invalid target > > * -1 if the setmaxme

Re: [Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 2:21 PM, Paulina Szubarczyk wrote: > On Wed, 2016-04-06 at 13:54 +0100, George Dunlap wrote: >> On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk >> wrote: >> > From: George Dunlap >> > >> > libxl_set_memory_target

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 3:07 PM, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug > optimization level"): >> The build should not use -O0 as that results in miscompilations. There >> have been a few instances on the ML where users were told to switch >> from

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-06 Thread George Dunlap
On Thu, Mar 31, 2016 at 11:53 AM, Yu Zhang wrote: > A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to > let one ioreq server claim/disclaim its responsibility for the > handling of guest pages with p2m type p2m_ioreq_server. Users > of this HVMOP can specify whether the p2m_ioreq_serve

Re: [Xen-devel] [PATCH v2 01/11] xen: sched: make implementing .alloc_pdata optional

2016-04-07 Thread George Dunlap
, can avoid implementing the > hook. In fact, the artificial implementation of > .alloc_pdata in the ARINC653 is removed (and, while there, > nuke .free_pdata too, as it is equally useless). > > Signed-off-by: Dario Faggioli > Reviewed-by: Meng Xu Acked-by: George Dunlap

Re: [Xen-devel] [PATCH v2 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-07 Thread George Dunlap
ything here looks good, except for one thing: the scheduler lock for arinc653 scheduler. :-) What happens now if you assign a cpu to credit2, and then assign it to arinc653? Since arinc doesn't implement the switch_sched() functionality, the per-cpu scheduler lock will still point to the cred

Re: [Xen-devel] [PATCH v2 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-04-07 Thread George Dunlap
t would be a nice feature to be able to select >> a particular runqueue arrangement, even when creating a >> Credit2 cpupool. This is left as future work. >> >> Signed-off-by: Dario Faggioli >> Signed-off-by: Uma Sharma > > With the one comment below addres

  1   2   3   4   5   6   7   8   9   10   >