On 21/03/16 14:22, Jan Beulich wrote: >>>> On 18.03.16 at 20:04, <dario.faggi...@citrix.com> wrote: >> --- a/xen/include/xen/sched-if.h >> +++ b/xen/include/xen/sched-if.h >> @@ -9,6 +9,7 @@ >> #define __XEN_SCHED_IF_H__ >> >> #include <xen/percpu.h> >> +#include <xen/err.h> >> >> /* A global pointer to the initial cpupool (POOL0). */ >> extern struct cpupool *cpupool0; > > There is no visible use in this header of what err.h defines - why > does it get included all of the sudden?
I'm guessing it's so that all the files that use the scheduler interface automatically get IS_ERR and PTR_ERR without having to include xen/err.h directly. But of course that means files like sched_arinc653.c and sched_credit2.c end up including xen/err.c even though they don't use those macros. Would you prefer the other files include it directly instead? -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
