On 21/03/16 15:18, Chong Li wrote: > On Mon, Mar 21, 2016 at 8:35 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 18.03.16 at 22:26, <lichong...@gmail.com> wrote: >>> Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls >>> to independently get and set the scheduling parameters of each >>> vCPU of a domain >>> >>> Signed-off-by: Chong Li <chong...@wustl.edu> >>> Signed-off-by: Meng Xu <men...@cis.upenn.edu> >>> Signed-off-by: Sisu Xi <xis...@gmail.com> >>> >>> --- >>> Changes on PATCH v7: >>> 1) A bug in case XEN_DOMCTL_SCHEDOP_getinfo (in Xen 4.6) is fixed: >>> The default PERIOD or BUDGET should be divided by MICROSECS(1), >>> before returned to upper caller. >> >> Seems like there's still some misunderstanding here: Anything >> past the first --- won't make it into the repo, yet the description >> of what bug you fix should end up there. > > I see. Do I put the "bug fix" before "Signed-off-by ..." or after it?
You need to put everything important for understanding this changeset in the changset description. So in this case, you'd probably add a paragraph like this: "Also fix a bug in XEN_DOMCTL_SCHEDOP_getinfo, where PERIOD and BUDGET are not divided by MICROSECS(1) before being returned to the caller." (And that would be before the SoB.) -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
