Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
to independently get and set the scheduling parameters of each
vCPU of a domain
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v6:
1) Add explain for nr_vcpus in struct
ing
The current status:
1) patch for xen: The "mentioning a bug fixed" issue
2) patch for libxc: Acked-by: Wei Liu; Reviewed-by: Dario Faggioli
3) patch for libxl: Acked-by: Wei Liu
4) patch for xl: More examples need to be added to man page
Chong
--
Chong Li
Department o
On Mon, Mar 21, 2016 at 8:35 AM, Jan Beulich wrote:
>>>> On 18.03.16 at 22:26, wrote:
>> Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
>> to independently get and set the scheduling parameters of each
>> vCPU of a domain
>>
>> Signed-o
16_t padding[2];
>>>
>>> So why uint16_t[2] instead of just uint32_t? And what's the
>>> padding needed for in the first place?
>>
>> You're right. It's better to use uint32_t, which pads (the struct) to
>> the 64-bit boun
It's better to use uint32_t, which pads (the struct) to
>>>> the 64-bit boundary.
>>>
>>> Which doesn't answer the "why in the first place" part - I don't
>>> see why structure size needs to be a multiple of 64 bits.
>>>
>> In this patch post,
>>
>> http://lists.xen.org/archives/html/xen-devel/2015-07/msg02334.html
>>
>> you had a comment about the structure size, which I think you mean
>> the struct size should be a multiple of 64 bits.
>
> Looks like I had got mislead by there being struct
> xen_domctl_sched_sedf, but it not being part of the union. I'm
> sorry for that.
>
Ok. I've already fixed all problems pointed out by George and Jan.
Dario and Meng, do you have any other comments on this patch?
Chong
--
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v8:
1) Move BUG fix description before SoB.
2) Remove the unuseful padding in struct xen_domctl_schedparam_vcpu.
Changes on PATCH v7:
1) A bug in case XEN_DOMCTL_SCHEDOP_getinfo (in Xen 4.6) is fixed:
The default
1 -v 0 -p 100 -b 50 -v 3 -p 300 -b 150".
Users can set all VCPUs with the same parameters, by one command.
e.g., "xl sched-rtds -d vm1 -v all -p 500 -b 250".
The github repo for this patch is at:
https://github.com/Chong-Li/xen.git
And the branch name is:
vcpu-rtds
(https://
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
functions to support per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
Acked-by: Wei Liu
Reviewed-by: Dario Faggioli
---
Changes on PATCH v8:
1) Add libxl_vcpu_sched_params_get_all() and
Add xc_sched_rtds_vcpu_get/set functions to interact with
Xen to get/set a domain's per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
Acked-by: Wei Liu
Reviewed-by: Dario Faggioli
---
Changes on PATCH v7:
1) rc in xc_sched_rtds_vcpu_set() shoul
Change main_sched_rtds and related output functions to support
per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
Acked-by: Wei Liu
---
Changes on PATCH v8:
1) Improve the example in xl.pod.1
2) Add sched_rtds_vcpu_output_all() and sched_vcpu_get_all
On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper
wrote:
> On 01/04/16 05:59, Chong Li wrote:
>> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
>> index 305889a..e5d15d8 100644
>> --- a/xen/common/sched_credit.c
>> +++ b/xen/common/sched_credi
On Mon, Apr 4, 2016 at 11:47 AM, Wei Liu wrote:
> On Mon, Apr 04, 2016 at 06:32:48PM +0200, Dario Faggioli wrote:
>> On Mon, 2016-04-04 at 17:05 +0100, George Dunlap wrote:
>> > On 04/04/16 16:58, Chong Li wrote:
>> > > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper
From: Chong-Li
Fix a bug in sched_credit.c and sched_credit2.c: in the default case
of csched_dom_cntl and csched2_dom_cntl, function returns without
unlocking prv->lock.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
CC:
CC:
CC:
CC:
CC:
CC:
---
xen/com
From: Chong-Li
Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
a bug: it made it possible, in Credit and Credit2, when doing domain
or vcpu parameters' manipulation, to leave the hypervisor with a
spinlock held.
Fix it.
Signed-off-by: Chong Li
Signed-
Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
a bug: it made it possible, in Credit and Credit2, when doing domain
or vcpu parameters' manipulation, to leave the hypervisor with a
spinlock held and interrupts disabled.
Fix it.
Signed-off-by: Chong Li
Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
a bug: it made it possible, in Credit and Credit2, when doing domain
or vcpu parameters' manipulation, to leave the hypervisor with a
spinlock held and interrupts disabled.
Fix it.
Signed-off-by: Chong Li
even when
> sending new versions of a series) that the appropriate maintainers are
> Cc-ed... This would help limiting problems like this one we've seen
> here.
>
Yes, I'll.
Thanks for your help on this.
Chong
--
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper wrote:
> On 06/04/16 17:41, Chong Li wrote:
>> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli
>> wrote:
>>> On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote:
>>>> Ian Jackson writes ("Re: [PATCH v9 for
On Wed, Apr 6, 2016 at 2:30 PM, Wei Liu wrote:
> On Wed, Apr 06, 2016 at 02:20:55PM -0500, Chong Li wrote:
>> On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper
>> wrote:
>> > On 06/04/16 17:41, Chong Li wrote:
>> >> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggio
Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build
failure: in some cases (e.g., num_vcpus <=0),
xc_sched_rtds_vcpu_get/set returns an uninitialized variable.
Fix it.
Signed-off-by: Chong Li
---
CC:
CC:
CC:
CC:
CC:
CC:
CC:
---
tools/libxc/xc_rt.c | 4 ++--
1 f
xl mannual page
<http://xenbits.xen.org/docs/unstable/man/xl.1.html#DOMAIN-SUBCOMMANDS>
have been tested,
and all run successfully.
If users type in wrong parameters (e.g., budget > period), the
error/warnning messages
are returned correctly as well.
Chong Li
--
Chong Li
Department of C
On Mon, Jun 8, 2015 at 10:56 AM, Dario Faggioli
wrote:
> On Fri, 2015-06-05 at 12:37 +0100, Ian Campbell wrote:
>> On Mon, 2015-05-25 at 19:09 -0500, Chong Li wrote:
>
>> > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> > index 117b61d..d
On Mon, Jun 8, 2015 at 11:21 AM, Dario Faggioli
wrote:
> On Mon, 2015-05-25 at 19:11 -0500, Chong Li wrote:
>> Change main_sched_rtds and related output functions to support per-VCPU
>> settings
>> for xl sched-rtds tool.
>>
>> Signed-off-by: Chong Li
>> S
On Tue, Jun 9, 2015 at 3:01 AM, Dario Faggioli
wrote:
> On Mon, 2015-06-08 at 16:18 -0500, Chong Li wrote:
>> On Mon, Jun 8, 2015 at 11:21 AM, Dario Faggioli
>> wrote:
>> > On Mon, 2015-05-25 at 19:11 -0500, Chong Li wrote:
>
>> > I appreciate just now that th
and some others (details can be found in
http://www.gossamer-threads.com/lists/xen/devel/380726?do=post_view_threaded
). Because of this new xen_domctl_scheduler_op_t, some changes have to
be done for credit and credit2 schedulers (for the
XEN_DOMCTL_scheduler_op processing there).
Please correct
On Wed, Jun 17, 2015 at 7:32 AM, Dario Faggioli
wrote:
> On Wed, 2015-06-17 at 13:08 +0100, Ian Campbell wrote:
>> On Tue, 2015-06-09 at 18:18 +0200, Dario Faggioli wrote:
>> > On Mon, 2015-06-08 at 15:55 -0500, Chong Li wrote:
>> > > On Mon, Jun 8, 2015 at 10:56 AM
On Tue, Feb 9, 2016 at 12:17 PM, Dario Faggioli
wrote:
> On Thu, 2016-02-04 at 16:50 -0600, Chong Li wrote:
>> Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
>> to independently get and set the scheduling parameters of each
>> vCPU of a domain
>>
message (both in xen). These issues are addressed
in this patch.
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
Chong Li (4):
xen: enable per-VCPU parameter settings for RTDS scheduler
libxc: enable per-VCPU parameter settings for RTDS scheduler
libxl: enable per-VCPU parameter setting
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
functions to support per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v5:
1) Add a seperate function, sched_rtds_vcpus_params_set_all(), to set
the parameters of all
Add xc_sched_rtds_vcpu_get/set functions to interact with
Xen to get/set a domain's per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v5:
1) In xc_sched_rtds_vcpu_get/set, re-issueing the hypercall
if it is preempted.
Chang
Change main_sched_rtds and related output functions to support
per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v5:
1) Add sched_vcpu_set_all() for the cases that all vcpus of a
domain need to be changed together.
Changes on PATCH
Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
to independently get and set the scheduling parameters of each
vCPU of a domain
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v5:
1) When processing XEN_DOMCTL_SCHEDOP_get/putvcpuinfo
;t think the right side of the && is really necessary / useful.
The right side is to check whether the vcpus array is fully processed.
When it is true and no error occurs (rc == 0), we
update op->u.v.nr_vcpus, which is returned to libxc, and helps xc
function figuring out how many un-p
> libxc knows whether all vcpus have been processed or now).
I think by "op->u.v.nr_vcpus = index", we already make the new nr_vcpus
seen by the guest (I've verified it).
In the case XEN_DOMCTL_scheduler_op of do_domctl(),
we make "copyback = 1" after calling sched_adjust(), which means all
fields in op (including
the new nr_vcpus) will be copied to u_domctl (at the end of
do_domctl()). This operation
ensures the new nr_vcpus is copied back up to the guest.
Please correct me if my understanding is wrong.
Chong
>
> Regards,
> Dario
> --
> <> (Raistlin Majere)
> -
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>
--
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Tue, Mar 8, 2016 at 1:09 PM, Wei Liu wrote:
> On Sun, Mar 06, 2016 at 11:55:56AM -0600, Chong Li wrote:
>> Add xc_sched_rtds_vcpu_get/set functions to interact with
>> Xen to get/set a domain's per-VCPU parameters.
>>
>> Signed-off-by: Chong Li
>> Si
On Tue, Mar 8, 2016 at 1:12 PM, Wei Liu wrote:
> On Sun, Mar 06, 2016 at 11:55:58AM -0600, Chong Li wrote:
> [...]
>> @@ -6222,77 +6359,166 @@ int main_sched_rtds(int argc, char **argv)
>> {
>> const char *dom = NULL;
>> const char *cpupool = NULL;
>&g
On Tue, Mar 8, 2016 at 1:12 PM, Wei Liu wrote:
> On Sun, Mar 06, 2016 at 11:55:57AM -0600, Chong Li wrote:
> [...]
>> tools/libxl/libxl.c | 326
>>
>> tools/libxl/libxl.h | 37 +
>> tools/libxl/
Raistlin Majere)
> -----
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>
--
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Tue, Mar 8, 2016 at 1:09 PM, Wei Liu wrote:
> On Sun, Mar 06, 2016 at 11:55:55AM -0600, Chong Li wrote:
> [...]
>> @@ -1163,6 +1173,96 @@ rt_dom_cntl(
>> }
>> spin_unlock_irqrestore(&prv->lock, flags);
>> break;
>&g
On Wed, Mar 9, 2016 at 10:38 AM, Jan Beulich wrote:
>>>> On 09.03.16 at 17:10, wrote:
>> On Tue, 2016-03-08 at 19:09 +, Wei Liu wrote:
>>> On Sun, Mar 06, 2016 at 11:55:55AM -0600, Chong Li wrote:
>>>
>>> > +spin_lock_irqsave(&p
per-domain "warn_on_once", I may need a hash table
(name it as "dom_warned"), and dom_warned[domid] returns true or
false.
I don't know if hash table is supported in Xen. Or do we have any list
structure which is very good at searching?
Another way is to add a "bool" field in struct domain, but I don't
think that would be a good design.
Any ideas?
Thanks,
Chong
--
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Tue, Mar 15, 2016 at 11:41 AM, Dario Faggioli
wrote:
> On Tue, 2016-03-15 at 11:22 -0500, Chong Li wrote:
>> On Mon, Mar 14, 2016 at 5:05 AM, Dario Faggioli
>> wrote:
>> >
>
> We said 'once' and then 'once per domain', but something I'd b
On Tue, Mar 15, 2016 at 10:14 PM, Meng Xu wrote:
> On Tue, Mar 15, 2016 at 1:22 PM, Chong Li wrote:
>> On Tue, Mar 15, 2016 at 11:41 AM, Dario Faggioli
>> wrote:
>>> On Tue, 2016-03-15 at 11:22 -0500, Chong Li wrote:
>>>> On Mon, Mar 14, 2016 at
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
functions to support per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v7:
1) Fix a mistake in sched_rtds_domain_set()
Changes on PATCH v6:
1) Resolve some coding style
s the bugs they fixed. I think the answer to you question
>> is obvious then...
>>
> Exactly! :-)
>
> And, please (Chong), let me restate this: "having a separate one is
> indeed almost always preferable (e.g., the fix can be backported)"
>
Considering
Add xc_sched_rtds_vcpu_get/set functions to interact with
Xen to get/set a domain's per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v6:
1) Resolve some coding sytle issues
Changes on PATCH v5:
1) In xc_sched_rtds_vcpu_ge
Change main_sched_rtds and related output functions to support
per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v6:
1) More explain in xl.pod.1 and cmdtable.c
2) Resolve some coding sytle issues
Changes on PATCH v5:
1) Add
On Wed, Mar 16, 2016 at 11:05 PM, Dario Faggioli
wrote:
> On Wed, 2016-03-16 at 11:47 -0500, Chong Li wrote:
>> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
>> functions to support per-VCPU settings.
>>
>> +/* Set the RTDS scheduling paramete
On Thu, Mar 17, 2016 at 5:03 AM, Dario Faggioli
wrote:
> On Wed, 2016-03-16 at 11:47 -0500, Chong Li wrote:
>
>> --- a/xen/common/sched_rt.c
>> +++ b/xen/common/sched_rt.c
>> @@ -1129,24 +1145,22 @@ rt_dom_cntl(
>> struct vcpu *v;
>> uns
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
functions to support per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v6:
1) Resolve some coding style issues
2) Change sched_rtds_validate_params()
3) Small changes
Change main_sched_rtds and related output functions to support
per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v7:
1) Add example to xl.pod.1
Changes on PATCH v6:
1) More explain in xl.pod.1 and cmdtable.c
2) Resolve some coding
Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
to independently get and set the scheduling parameters of each
vCPU of a domain
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v7:
1) A bug in case XEN_DOMCTL_SCHEDOP_getinfo (in Xen 4.6
On Wed, Mar 16, 2016 at 3:23 AM, Dario Faggioli
wrote:
> On Tue, 2016-03-15 at 23:43 -0400, Meng Xu wrote:
>> On Tue, Mar 15, 2016 at 11:32 PM, Chong Li
>> wrote:
>> > > > How about:
>> > > >
>> > > > We create a global variable
Add xc_sched_rtds_vcpu_get/set functions to interact with
Xen to get/set a domain's per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v6:
1) Resolve some coding sytle issues
Changes on PATCH v5:
1) In xc_sched_rtds_vcpu_ge
1 -v 0 -p 100 -b 50 -v 3 -p 300 -b 150".
Users can set all VCPUs with the same parameters, by one command.
e.g., "xl sched-rtds -d vm1 -v all -p 500 -b 250".
---
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
Chong Li (4):
xen: enable per-VCPU parameter settings for RTDS
On Wed, Mar 16, 2016 at 9:37 AM, Meng Xu wrote:
> On Wed, Mar 16, 2016 at 4:23 AM, Dario Faggioli
> wrote:
>> On Tue, 2016-03-15 at 23:43 -0400, Meng Xu wrote:
>>> On Tue, Mar 15, 2016 at 11:32 PM, Chong Li
>>> wrote:
>>> > > > How about:
&g
1 -v 0 -p 100 -b 50 -v 3 -p 300 -b 150".
Users can set all VCPUs with the same parameters, by one command.
e.g., "xl sched-rtds -d vm1 -v all -p 500 -b 250".
---
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
Chong Li (4):
xen: enable per-VCPU parameter for RTDS
libxc: ena
parameters of the
VCPUs of a specific domain.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
---
tools/libxl/libxl.c | 209 +++-
tools/libxl/libxl.h | 17
tools/libxl
turns the default budget
and period values of RTDS scheduler.
3) Handler of XEN_DOMCTL_SCHEDOP_getvcpuinfo now can return a random subset of
the parameters of the VCPUs of a specific domain
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
CC:
CC:
CC:
CC:
CC
ic
domain.
4) When setting all VCPUs with the same parameters (by only one command), no
per-domain function is invoked.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
CC:
CC:
CC:
CC:
CC:
CC:
---
docs/man/xl.pod.1 | 4 +
tools/libxl/xl_cmdimp
ith the same parameters, by one command.
e.g., "xl sched-rtds -d vm1 -v all -p 500 -b 250".
---
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
Chong Li (4):
xen: enable per-VCPU parameter settings for RTDS scheduler
libxc: enable per-VCPU parameter settings for RTDS scheduler
libxl
Add xc_sched_rtds_vcpu_get/set functions to interact with Xen to get/set a
domain's
per-VCPU parameters.
Changes on PATCH v2:
1) Minor modifications due to the change of struct xen_domctl_scheduler_op.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
CC:
CC
On Tue, Jun 30, 2015 at 7:22 AM, Ian Campbell wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> Add xc_sched_rtds_vcpu_get/set functions to interact with Xen to get/set a
>> domain's
>> per-VCPU parameters.
>>
>> Changes on PATCH v2:
>>
&g
On Tue, Jun 30, 2015 at 7:26 AM, Ian Campbell wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>
>> +GC_INIT(ctx);
>> +libxl_scheduler sched = scinfo->sched;
>> +int ret;
>> +
>> +if (sched == LIBXL_SCHEDULER_UNKNOWN)
>>
On Tue, Jun 30, 2015 at 10:32 AM, Ian Campbell wrote:
> On Tue, 2015-06-30 at 10:18 -0500, Chong Li wrote:
>> On Tue, Jun 30, 2015 at 7:22 AM, Ian Campbell
>> wrote:
>> > On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> >
>> >> diff --git a/tool
On Tue, Jun 30, 2015 at 10:57 AM, Ian Campbell wrote:
> On Tue, 2015-06-30 at 10:42 -0500, Chong Li wrote:
>> >> @@ -1554,10 +1564,17 @@ int libxl_sched_credit_params_set(libxl_ctx *ctx,
>> >> uint32_t poolid,
>> >> #define LIBXL_DOMAIN_SCHED_PA
On Tue, Jun 30, 2015 at 11:19 AM, Ian Campbell wrote:
> On Tue, 2015-06-30 at 11:10 -0500, Chong Li wrote:
>> On Tue, Jun 30, 2015 at 10:57 AM, Ian Campbell
>> wrote:
>> > On Tue, 2015-06-30 at 10:42 -0500, Chong Li wrote:
>> >> >> @@ -1554,10 +15
ise. :-)
I did some sanity check about the vcpuid in hypervisor. Maybe that's
not enough. I'll add other check on vcpuid in libxl
(sched_rtds_vcpu_get/set) to ensure vcpuid has a valid value.
Chong
>
> Regards,
> Dario
>
> --
> <> (Raistlin Majere)
> -
; -} rtds;
>> +xen_domctl_schedparam_t d;
>
> With this type gone I'm not even sure we need to wrap this in
> another union; not doing so would eliminate some of the other
> changes in this patch.
I see your point. Because of xen_domctl_schedparam_vcpu_t
On Tue, Jul 7, 2015 at 10:34 AM, Dario Faggioli
wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> Change main_sched_rtds and related output functions to support per-VCPU
>> settings.
>>
>> Changes on PATCH v2:
>>
>> 1) Remove per-domain outpu
On Tue, Jul 7, 2015 at 10:16 AM, Dario Faggioli
wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>
>> [Usage]
>> With this patchset in use, xl sched-rtds tool can:
>>
>> 1) show the budget and period of each VCPU of each domain, by using "xl
>&g
On Tue, Jul 7, 2015 at 11:23 AM, Dario Faggioli
wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to
>> support
>> per-VCPU settings.
>>
>>
>>
EN_DOMCTL_SCHEDOP_getinfo) &&
> > + (op->cmd != XEN_DOMCTL_SCHEDOP_putvcpuinfo) &&
> > + (op->cmd != XEN_DOMCTL_SCHEDOP_getvcpuinfo)) )
>
> Imo this should become a switch now.
>
Do you mean "switch ( op->cmd )" ? I&#x
On Mon, May 11, 2015 at 4:56 AM, Dario Faggioli
wrote:
> On Thu, 2015-05-07 at 12:05 -0500, Chong Li wrote:
> > [Goal]
> > The current xl sched-rtds tool can only set the VCPUs of a domain to the
> same parameter
> > although the scheduler supports VCPUs with di
On Mon, May 11, 2015 at 8:11 AM, Dario Faggioli
wrote:
> On Thu, 2015-05-07 at 12:05 -0500, Chong Li wrote:
> > Add two hypercalls(XEN_DOMCTL_SCHEDOP_getvcpuinfo/putvcpuinfo) to
> get/set a domain's
> > per-VCPU parameters. Hypercalls are handled in function rt_dom_
number of vCPU-s in a domain?
>
Based on Dario's suggestion, I'll use vcpu_id to locate the vcpu to set,
which cost much
less time.
>
> > If this does cause problems, I think adding a "hypercall_preempt_check()"
> > at th
On Mon, May 11, 2015 at 9:06 AM, Dario Faggioli
wrote:
>
> On Thu, 2015-05-07 at 12:05 -0500, Chong Li wrote:
> > Change sched_rtds_domain_get/set functions to support per-VCPU settings for
> > RTDS scheduler.
> >
>
> > +rc = xc_domain_getinfo(CTX->xch, d
On Tue, May 12, 2015 at 5:01 AM, Dario Faggioli
wrote:
> [Adjusting the Cc list:
> - removing hypervisor only people
> - adding more tools maintainers
> - adding George]
>
> On Thu, 2015-05-07 at 12:05 -0500, Chong Li wrote:
>> Change sched_rtds_domain_get/set funct
On Tue, May 12, 2015 at 5:01 AM, Dario Faggioli
wrote:
> [Adjusting the Cc list:
> - removing hypervisor only people
> - adding more tools maintainers
> - adding George]
>
> On Thu, 2015-05-07 at 12:05 -0500, Chong Li wrote:
>> Change sched_rtds_domain_get/set funct
# xl sched-rtds -d vm1
NameID VCPUPeriodBudget
vm1 1 0 500 250
vm1 11 500 250
Chong Li (4):
xen: enabling XL to set per-VCPU parameters of a domain for RTDS
scheduler
libxc: enab
l and hypervisor.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
xen/common/domctl.c | 5
xen/common/sched_rt.c | 71 -
xen/common/schedule.c | 24 +++
xen/include/public/domctl.h
Add xc_sched_rtds_vcpu_get/set functions to interact with Xen to get/set a
domain's
per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
tools/libxc/include/xenctrl.h | 9
tools/libxc/xc_rt.c
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to
support
per-VCPU settings for RTDS scheduler.
Add a new data structure (libxl_vcpu_sched_params) to help per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
tools/libxl
Change main_sched_rtds and related output functions to support per-VCPU settings
for xl sched-rtds tool.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
tools/libxl/xl_cmdimpl.c | 261 +--
1 file changed, 230 insertions
djust_vcpu) in the
>> scheduler interface.
>>
>> Add a new data structure (struct xen_domctl_scheduler_vcpu_op) for
>> transferring data
>> between tool and hypervisor.
>>
>> Signed-off-by: Chong Li
>> Signed-off-by: Meng Xu
>> Signed-off-by: Sisu
On Tue, May 26, 2015 at 12:18 PM, Chong Li wrote:
> On Tue, May 26, 2015 at 4:08 AM, Jan Beulich wrote:
>>>>> On 26.05.15 at 02:05, wrote:
>>> Add two hypercalls(XEN_DOMCTL_SCHEDOP_getvcpuinfo/putvcpuinfo) to get/set a
>>> domain's
>>> per-VCPU
On Wed, May 27, 2015 at 5:02 AM, Chao Peng wrote:
> On Mon, May 25, 2015 at 07:05:52PM -0500, Chong Li wrote:
>
> I didn't see any fields you need to copy back here ('vcpus' were copied back
> in rt_vcpu_cntl() already).
>
>> +{
>> +struct rt_p
On Fri, May 29, 2015 at 8:51 AM, Dario Faggioli
wrote:
> On Mon, 2015-05-25 at 19:05 -0500, Chong Li wrote:
>
>> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
>> index 28aea55..8143c44 100644
>> --- a/xen/common/domctl.c
>> +++ b/xen/common/domctl.c
>
&
On Tue, Jun 2, 2015 at 7:53 AM, George Dunlap
wrote:
> On 05/26/2015 01:09 AM, Chong Li wrote:
>> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to
>> support
>> per-VCPU settings for RTDS scheduler.
>>
>> Add a new data structure (lib
message (both in xen). These issues are addressed
in this patch.
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
CC:
Chong Li (4):
xen: enable per-VCPU parameter settings for RTDS scheduler
libxc: enable per-VCPU parameter settings for RTDS scheduler
libxl: enable per-VCPU parameter setting
Change main_sched_rtds and related output functions to support
per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v4:
1) Coding style changes
Changes on PATCH v3:
1) Support commands, e.g., "xl sched-rtds -d vm1" to
Add xc_sched_rtds_vcpu_get/set functions to interact with
Xen to get/set a domain's per-VCPU parameters.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v4:
1) Minor modifications on the function parameters.
Changes on PATCH v2:
1)
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
functions to support per-VCPU settings.
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v4:
1) Coding style changes
Changes on PATCH v3:
1) Add sanity check on vcpuid
2) Add comments
Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and _putvcpuinfo hypercalls
to independently get and set the scheduling parameters of each
vCPU of a domain
Signed-off-by: Chong Li
Signed-off-by: Meng Xu
Signed-off-by: Sisu Xi
---
Changes on PATCH v4:
1) Add uint32_t vcpu_index to struct
I'll fix these coding style issues.
On Fri, Feb 5, 2016 at 8:44 AM, Wei Liu wrote:
> On Thu, Feb 04, 2016 at 04:50:43PM -0600, Chong Li wrote:
>> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
>> functions to support per-VCPU settings.
>>
>
>
ly whether the array is empty. When num_vcpus is 0,
> you shouldn't dereference vcpus array, at all, because the semantics of
> num_vcpus == 0 is that the array is empty.
>
> Wei.
I see. I'll think about re-designing the data structure of
libxl_vcpu_sched_params.
Chong
>
>
On Tue, Feb 9, 2016 at 6:00 AM, Dario Faggioli
wrote:
> On Thu, 2016-02-04 at 16:50 -0600, Chong Li wrote:
>>
>> +{
>> +int rc;
>> +int i;
>> +uint16_t max_vcpuid;
>> +xc_dominfo_t info;
>> +struct xen_domctl_schedparam_vcpu *vcpus
On Mon, Jul 27, 2015 at 10:14 AM, Dario Faggioli
wrote:
> On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote:
>
>
> Or by "just" adding a note before the actual output:
>
> # xl sched-rtds -d vm1
> Showing per-vm(s) default scheduling parameters,
> use `-v
On Mon, Jul 27, 2015 at 11:11 AM, Dario Faggioli
wrote:
> On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote:
>
>> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
>> index d1d2ab3..58f1a7a 100644
>> --- a/tools/libxc/include/xenctrl.h
>
On Tue, Jul 28, 2015 at 4:15 AM, Dario Faggioli
wrote:
> On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote:
>
>> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
>> index e9a2d26..9f7f859 100644
>> --- a/tools/libxl/libxl.c
>> +++ b/tools/l
1 - 100 of 115 matches
Mail list logo
