From: Chong-Li <lichong...@gmail.com>
Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
a bug: it made it possible, in Credit and Credit2, when doing domain
or vcpu parameters' manipulation, to leave the hypervisor with a
spinlock held.
Fix it.
Signed-off-by: Chong Li <chong...@wustl.edu>
Signed-off-by: Meng Xu <men...@cis.upenn.edu>
Signed-off-by: Sisu Xi <xis...@gmail.com>
Acked-by: Dario Faggioli <dario.faggi...@citrix.com>
---
CC: <dario.faggi...@citrix.com>
CC: <george.dun...@eu.citrix.com>
CC: <dgol...@seas.upenn.edu>
CC: <men...@cis.upenn.edu>
CC: <jbeul...@suse.com>
CC: <lichong...@gmail.com>
---
xen/common/sched_credit.c | 1 +
xen/common/sched_credit2.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index e5d15d8..fa6b7f0 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -1101,6 +1101,7 @@ csched_dom_cntl(
sdom->cap = op->u.credit.cap;
break;
default:
+ spin_unlock_irqrestore(&prv->lock, flags);
return -EINVAL;
}
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index d48ed5a..cf444c9 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -1457,6 +1457,7 @@ csched2_dom_cntl(
}
break;
default:
+ spin_unlock_irqrestore(&prv->lock, flags);
return -EINVAL;
}
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
