[Xen-devel] [linux-4.9 test] 107546: regressions - FAIL

2017-04-20 Thread osstest service owner
flight 107546 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/107546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 6 xen-boot fail REGR. vs. 107358 Tests which are faili

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Yu Zhang
On 4/19/2017 10:09 PM, Andrew Cooper wrote: On 19/04/17 15:07, Jan Beulich wrote: On 19.04.17 at 15:58, wrote: On 19/04/17 14:50, Yu Zhang wrote: On 4/19/2017 9:34 PM, Jan Beulich wrote: On 19.04.17 at 13:44, wrote: On 4/19/2017 7:19 PM, Jan Beulich wrote: On 19.04.17 at 11:48, wrote:

[Xen-devel] [linux-3.18 test] 107548: tolerable FAIL - PUSHED

2017-04-20 Thread osstest service owner
flight 107548 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/107548/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-localmigrate/x10 fail in 107534 pass in 107548 te

Re: [Xen-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

2017-04-20 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 20 April 2017 00:02 > To: Paul Durrant > Cc: 'Stefano Stabellini' ; qemu-de...@nongnu.org; > Anthony Perard ; Wei Liu > ; jgr...@suse.com; julien.gr...@arm.com; xen- > de...@lists.xenproject.org > Subje

[Xen-devel] [distros-debian-wheezy test] 71208: tolerable trouble: broken/pass

2017-04-20 Thread Platform Team regression test user
flight 71208 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71208/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64-pvops 2 hosts-allocate broken never pass build-arm64

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 19:16, wrote: > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: >> >>> On 19.04.17 at 17:54, wrote: >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: >> >> @@ -1193,6 +1194,9 @@ static int do_kexec_op_internal(unsigned long op, >> >> if ( ret

Re: [Xen-devel] [PATCH v10 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 04:14, wrote: > On 17-04-19 03:00:29, Jan Beulich wrote: >> >>> On 19.04.17 at 10:22, wrote: >> > On 17-04-18 05:46:43, Jan Beulich wrote: >> >> >>> On 18.04.17 at 12:55, wrote: >> >> > I made a test patch based on v10 and attached it in mail. Could you >> >> > please >> >> >

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 09:15, wrote: > And back to the schedule of this feature, are you working on it? Or any > specific plan? Well, the HVM side is basically ready (as said, the single hunk needed to support UMIP when hardware supports it could be easily split off of my emulation patch). For the P

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Yu Zhang
On 4/20/2017 5:47 PM, Jan Beulich wrote: On 20.04.17 at 09:15, wrote: And back to the schedule of this feature, are you working on it? Or any specific plan? Well, the HVM side is basically ready (as said, the single hunk needed to support UMIP when hardware supports it could be easily split

Re: [Xen-devel] [PATCH v2] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 21:33, wrote: > On Wed, Apr 19, 2017 at 03:41:41PM +0800, Chao Gao wrote: -vlapic->hw.apic_base_msr = (MSR_IA32_APICBASE_ENABLE | -APIC_DEFAULT_PHYS_BASE); +vlapic->hw.apic_base_msr |= APIC_DEFAULT_PHYS_BASE; >>> >>>Perhaps

Re: [Xen-devel] [PATCH 08/11] xen-blkfront: remove bio splitting.

2017-04-20 Thread Roger Pau Monné
On Thu, Apr 20, 2017 at 03:38:50PM +1000, NeilBrown wrote: > bios that are re-submitted will pass through blk_queue_split() when > blk_queue_bio() is called, and this will split the bio if necessary. > There is no longer any need to do this splitting in xen-blkfront. > > Signed-off-by: NeilBrown

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 11:53, wrote: > On 4/20/2017 5:47 PM, Jan Beulich wrote: > On 20.04.17 at 09:15, wrote: >>> And back to the schedule of this feature, are you working on it? Or any >>> specific plan? >> Well, the HVM side is basically ready (as said, the single hunk needed >> to support UMI

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Yu Zhang
On 4/20/2017 6:01 PM, Jan Beulich wrote: On 20.04.17 at 11:53, wrote: On 4/20/2017 5:47 PM, Jan Beulich wrote: On 20.04.17 at 09:15, wrote: And back to the schedule of this feature, are you working on it? Or any specific plan? Well, the HVM side is basically ready (as said, the single hun

Re: [Xen-devel] [PATCH for-4.9 v2 0/3] oxenstored: make it work on FreeBSD

2017-04-20 Thread Ian Jackson
Christian Lindig writes ("Re: [PATCH for-4.9 v2 0/3] oxenstored: make it work on FreeBSD"): > This approach adds two new entries into oxenstored.conf that are > determined by the configure script. I prefer it over the previous > design not the least because it results in a much smaller change and

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Andrew Cooper
On 20/04/17 11:10, Yu Zhang wrote: > > > On 4/20/2017 6:01 PM, Jan Beulich wrote: > On 20.04.17 at 11:53, wrote: >>> On 4/20/2017 5:47 PM, Jan Beulich wrote: >>> On 20.04.17 at 09:15, wrote: > And back to the schedule of this feature, are you working on it? > Or any > specific

Re: [Xen-devel] [PATCH for-4.9 v2 1/3] paths.m4: provide XENSTORED_{KVA, PORT}

2017-04-20 Thread Roger Pau Monné
On Tue, Apr 18, 2017 at 04:31:42PM +0100, Wei Liu wrote: > The default values are Linux device names. No users yet. > > Signed-off-by: Wei Liu Since it's FreeBSD related stuff: Acked-by: Roger Pau Monné ___ Xen-devel mailing list Xen-devel@lists.xe

Re: [Xen-devel] [PATCH for-4.9 v2 3/3] hotplug/FreeBSD: configure xenstored

2017-04-20 Thread Roger Pau Monné
On Tue, Apr 18, 2017 at 04:31:44PM +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Roger Pau Monné ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] about fully UMIP support in Xen

2017-04-20 Thread Yu Zhang
On 4/20/2017 6:23 PM, Andrew Cooper wrote: On 20/04/17 11:10, Yu Zhang wrote: On 4/20/2017 6:01 PM, Jan Beulich wrote: On 20.04.17 at 11:53, wrote: On 4/20/2017 5:47 PM, Jan Beulich wrote: On 20.04.17 at 09:15, wrote: And back to the schedule of this feature, are you working on it? Or a

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Daniel Kiper
On Thu, Apr 20, 2017 at 03:34:21AM -0600, Jan Beulich wrote: > >>> On 19.04.17 at 19:16, wrote: > > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: > >> >>> On 19.04.17 at 17:54, wrote: > >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVolder wrote: > >> >> @@ -1193,6 +1194,9 @

Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 23:01, wrote: > The spinlock in kexec_swap_images() was removed as > this function is only reachable on the kexec hypercall, which is > now protected at the top-level in do_kexec_op_internal(), > thus the local spinlock is no longer necessary. > > Per recommendation from Jan Be

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 17:58, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > > default: > unexpected_exit_type: > -gdprintk(XENLOG_ERR, "unexpected VMEXIT: exit reason = %#

Re: [Xen-devel] [PATCH v3 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 12:42, wrote: > On Thu, Apr 20, 2017 at 03:34:21AM -0600, Jan Beulich wrote: >> >>> On 19.04.17 at 19:16, wrote: >> > On Wed, Apr 19, 2017 at 10:19:44AM -0600, Jan Beulich wrote: >> >> >>> On 19.04.17 at 17:54, wrote: >> >> > On Wed, Apr 19, 2017 at 10:47:15AM -0500, Eric DeVo

[Xen-devel] [linux-arm-xen test] 107552: tolerable FAIL - PUSHED

2017-04-20 Thread osstest service owner
flight 107552 linux-arm-xen real [real] http://logs.test-lab.xenproject.org/osstest/logs/107552/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 15 guest-start/debian.repeat fail in 107537 pass in 107552 test-armhf-armhf-xl-rt

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Andrew Cooper
On 20/04/17 11:52, Jan Beulich wrote: > >>> On 19.04.17 at 17:58, wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >> >> default: >> unexpected_exit_type: >> -gdprintk(X

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 13:01, wrote: > On 20/04/17 11:52, Jan Beulich wrote: >> >>> On 19.04.17 at 17:58, wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -2833,10 +2833,9 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >>> >>> default: >>> u

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Markus Armbruster
Eric Blake writes: > Libvirt would like to be able to distinguish between a SHUTDOWN > event triggered solely by guest request and one triggered by a > SIGTERM or other action on the host. qemu_kill_report() is > already able to tell whether a shutdown was triggered by a host > signal (but NOT b

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Daniel P. Berrange
On Thu, Apr 20, 2017 at 01:59:29PM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > Libvirt would like to be able to distinguish between a SHUTDOWN > > event triggered solely by guest request and one triggered by a > > SIGTERM or other action on the host. qemu_kill_report() is > > alre

Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-20 Thread Andrew Cooper
On 20/04/17 11:46, Jan Beulich wrote: On 19.04.17 at 23:01, wrote: >> The spinlock in kexec_swap_images() was removed as >> this function is only reachable on the kexec hypercall, which is >> now protected at the top-level in do_kexec_op_internal(), >> thus the local spinlock is no longer nec

[Xen-devel] [xen-unstable test] 107553: regressions - FAIL

2017-04-20 Thread osstest service owner
flight 107553 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/107553/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 5 xen-buildfail REGR. vs. 107539 Regressions which

Re: [Xen-devel] [PATCH 00/10] pl011 emulation support in Xen

2017-04-20 Thread Julien Grall
Hi Bhupinder, On 03/04/17 10:44, Bhupinder Thakur wrote: tools/console/client/main.c | 6 + tools/console/daemon/io.c| 532 +++ tools/libxc/include/xc_dom.h | 3 + tools/libxc/xc_dom_arm.c | 7 +- tools/libxc/xc_dom_boot.c

[Xen-devel] [ovmf test] 107554: regressions - FAIL

2017-04-20 Thread osstest service owner
flight 107554 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/107554/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-buildfail REGR. vs. 107545 test-amd64-amd64-xl-qemuu-

Re: [Xen-devel] [PATCH for-4.9 v2 0/3] oxenstored: make it work on FreeBSD

2017-04-20 Thread Julien Grall
Hi, On 20/04/17 11:22, Ian Jackson wrote: Christian Lindig writes ("Re: [PATCH for-4.9 v2 0/3] oxenstored: make it work on FreeBSD"): This approach adds two new entries into oxenstored.conf that are determined by the configure script. I prefer it over the previous design not the least because

Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-20 Thread Daniel Kiper
On Thu, Apr 20, 2017 at 01:14:30PM +0100, Andrew Cooper wrote: > On 20/04/17 11:46, Jan Beulich wrote: > On 19.04.17 at 23:01, wrote: > >> The spinlock in kexec_swap_images() was removed as > >> this function is only reachable on the kexec hypercall, which is > >> now protected at the top-lev

Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

2017-04-20 Thread Julien Grall
Hi Andrew, On 20/04/17 13:14, Andrew Cooper wrote: On 20/04/17 11:46, Jan Beulich wrote: On 19.04.17 at 23:01, wrote: The spinlock in kexec_swap_images() was removed as this function is only reachable on the kexec hypercall, which is now protected at the top-level in do_kexec_op_internal(), t

Re: [Xen-devel] [PATCH] x86/hvm: Corrections and improvements to unhandled vmexit logging

2017-04-20 Thread Julien Grall
Hi Andrew, On 19/04/17 16:58, Andrew Cooper wrote: * Use gprintk rather than gdprintk. These logging messages shouldn't disappear in release builds, as they usually happen immediately before a domain crash. Raise them from WARNING to ERR. * Format the vmexit reason in the same base as

Re: [Xen-devel] [PATCH for-4.9 2/4] xen/arm: Move the code to map FDT in the boot tables from assembly to C

2017-04-20 Thread Julien Grall
Hi Stefano, On 19/04/17 22:18, Stefano Stabellini wrote: On Wed, 19 Apr 2017, Julien Grall wrote: On 19/04/2017 22:01, Stefano Stabellini wrote: On Wed, 19 Apr 2017, Julien Grall wrote: I would have added early_fdt_map to this file in a way to avoid the need for duplicating the declaration of

Re: [Xen-devel] [PATCH v10 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

2017-04-20 Thread Lars Kurth
Apologies for stepping in here. But it feels to me that this thread is at risk of becoming unproductive. > On 20 Apr 2017, at 10:43, Jan Beulich wrote: > On 20.04.17 at 04:14, wrote: >> On 17-04-19 03:00:29, Jan Beulich wrote: >> On 19.04.17 at 10:22, wrote: On 17-04-18 05:46:43

[Xen-devel] [PATCH 1/2] sg-report-flight: Do not try to print nonexistent FirstTip info

2017-04-20 Thread Ian Jackson
The use of $info->{FirstTip}{flight} autovivifies $info->{FirstTip}. Defend $pinfo against the use of an autovivified empty hashref. Signed-off-by: Ian Jackson --- sg-report-flight |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sg-report-flight b/sg-report-flight index 7d

[Xen-devel] [PATCH 2/2] sg-report-flight: Do not report many non-regressions as allowable

2017-04-20 Thread Ian Jackson
In bd648aea2ebe sg-report-flight: report allowable regressions separately in summary whether the regression was allowable was put in $allow, but this was erroneously not used. In 4a210cda9cc8 sg-report-flight: fix allowable failure logic not to reuse $allow for two purposes (!) that use of the

Re: [Xen-devel] [xen-unstable test] 107553: regressions - FAIL

2017-04-20 Thread Andrew Cooper
On 20/04/17 13:18, osstest service owner wrote: > flight 107553 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/107553/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64-xsm 5 xen-

[Xen-devel] [PATCH] x86/microcode: Use the return value from early_microcode_update_cpu

2017-04-20 Thread Ross Lagerwall
Use the return value from early_microcode_update_cpu rather than ignoring it. Signed-off-by: Ross Lagerwall --- xen/arch/x86/microcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c index 4e7dfcd..7558202 100644 --- a/xen

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Eric Blake
On 04/20/2017 07:09 AM, Daniel P. Berrange wrote: >>> +++ b/qapi/event.json >>> @@ -10,6 +10,10 @@ >>> # Emitted when the virtual machine has shut down, indicating that qemu is >>> # about to exit. >>> # >>> +# @guest: If true, the shutdown was triggered by a guest request (such as >>> +# execu

Re: [Xen-devel] [PATCH v10 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 15:02, wrote: >> On 20 Apr 2017, at 10:43, Jan Beulich wrote: >> > On 20.04.17 at 04:14, wrote: >>> On 17-04-19 03:00:29, Jan Beulich wrote: >>> On 19.04.17 at 10:22, wrote: > On 17-04-18 05:46:43, Jan Beulich wrote: > On 18.04.17 at 12:55, wrote: >>

Re: [Xen-devel] [PATCH] x86/microcode: Use the return value from early_microcode_update_cpu

2017-04-20 Thread Andrew Cooper
On 20/04/17 14:18, Ross Lagerwall wrote: > Use the return value from early_microcode_update_cpu rather than > ignoring it. Spotted by Coverity. > > Signed-off-by: Ross Lagerwall Reviewed-by: Andrew Cooper Julien, can we have a release ack please? ~Andrew

[Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Vitaly Kuznetsov
Recent changes in logical package management (Commit 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") and its predecessor) caused boot failures for some Xen guests. E.g. I'm trying to boot 10 CPU guest on AMD Opteron 4284 system and I see the following crash: [0.116104

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Eric Blake
On 04/20/2017 06:59 AM, Markus Armbruster wrote: > > No objection to Alistair's idea to turn this into an enumeration. Question - should the enum be more than just 'guest' and 'host'? For example, my patch proves that we have a lot of places that handle complimentary machine commands to reset a

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Jan Beulich
>>> On 19.04.17 at 22:22, wrote: > According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> > "EXTENDED XAPIC (X2APIC)" -> "x2APIC State Transitions", the APIC mode > and APIC ID are preserved when handling INIT signal and a reset places > APIC to xAPIC mode and APIC base address to

[Xen-devel] [PATCH] correct rcu_unlock_domain()

2017-04-20 Thread Jan Beulich
Match rcu_lock_domain(), and remove the slightly misleading comment: This isn't just the companion to rcu_lock_domain_by_id() (and that latter function indeed also keeps the domain locked, not the domain list). No functional change, as rcu_read_{,un}lock() ignore their arguments anyway. Reported-

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Chao Gao
On Thu, Apr 20, 2017 at 07:34:30AM -0600, Jan Beulich wrote: On 19.04.17 at 22:22, wrote: >> According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> >> "EXTENDED XAPIC (X2APIC)" -> "x2APIC State Transitions", the APIC mode >> and APIC ID are preserved when handling INIT signal

Re: [Xen-devel] [PATCH] correct rcu_unlock_domain()

2017-04-20 Thread Andrew Cooper
On 20/04/17 14:48, Jan Beulich wrote: > Match rcu_lock_domain(), and remove the slightly misleading comment: > This isn't just the companion to rcu_lock_domain_by_id() (and that > latter function indeed also keeps the domain locked, not the domain > list). > > No functional change, as rcu_read_{,un

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 08:59, wrote: > On Thu, Apr 20, 2017 at 07:34:30AM -0600, Jan Beulich wrote: > On 19.04.17 at 22:22, wrote: >>> According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> >>> "EXTENDED XAPIC (X2APIC)" -> "x2APIC State Transitions", the APIC mode >>> and APIC ID

Re: [Xen-devel] [PATCH for-4.9 4/4] xen/arm: Properly map the FDT in the boot page table

2017-04-20 Thread Julien Grall
Hi Stefano, On 19/04/17 22:56, Stefano Stabellini wrote: On Wed, 19 Apr 2017, Julien Grall wrote: On 19/04/2017 22:01, Stefano Stabellini wrote: On Wed, 19 Apr 2017, Julien Grall wrote: @@ -113,12 +113,12 @@ #define FIXMAP_ADDR(n)(_AT(vaddr_t,0x0040) + (n) * PAGE_SIZE) #define

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Chao Gao
On Thu, Apr 20, 2017 at 08:15:49AM -0600, Jan Beulich wrote: On 20.04.17 at 08:59, wrote: >> On Thu, Apr 20, 2017 at 07:34:30AM -0600, Jan Beulich wrote: >> On 19.04.17 at 22:22, wrote: According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> "EXTENDED XAPIC (X2AP

Re: [Xen-devel] [PATCH] correct rcu_unlock_domain()

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 16:11, wrote: > On 20/04/17 14:48, Jan Beulich wrote: >> Match rcu_lock_domain(), and remove the slightly misleading comment: >> This isn't just the companion to rcu_lock_domain_by_id() (and that >> latter function indeed also keeps the domain locked, not the domain >> list). >>

[Xen-devel] [xen-unstable-smoke test] 107563: tolerable trouble: broken/pass - PUSHED

2017-04-20 Thread osstest service owner
flight 107563 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/107563/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl 12 mig

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 09:37, wrote: > On Thu, Apr 20, 2017 at 08:15:49AM -0600, Jan Beulich wrote: > On 20.04.17 at 08:59, wrote: >>> On Thu, Apr 20, 2017 at 07:34:30AM -0600, Jan Beulich wrote: >>> On 19.04.17 at 22:22, wrote: > According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROL

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Peter Zijlstra
On Thu, Apr 20, 2017 at 03:24:53PM +0200, Vitaly Kuznetsov wrote: > In this patch I suggest we set __max_logical_packages based on the > max_physical_pkg_id and total_cpus, So my 4 socket 144 CPU system will then get max_physical_pkg_id=144, instead of 4. This wastes quite a bit of memory for the

[Xen-devel] [PATCH v2 for-4.9 1/5] xen/arm: Add BOOT_FDT_VIRT_END and BOOT_FDT_SLOT_SIZE

2017-04-20 Thread Julien Grall
The 2 new defines will help to avoid hardcoding the size and the end of the slot in the code. The newlines are added for clarity. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/include/asm-arm/config.h | 4 1

[Xen-devel] [PATCH v2 for-4.9 0/5] xen/arm: Properly map the FDT in the boot page table

2017-04-20 Thread Julien Grall
Hi, Whilst doing some testing on Juno using GRUB, I noticed random early crash depending ([1]) on the binaries I was using. This is because Xen is assuming that the FDT will always fit in a 2MB superpage whilst the boot documentation allow the FDT to cross a 2MB boundary. The first patch move th

[Xen-devel] [PATCH v2 for-4.9 3/5] xen/arm: Move the code to map FDT in the boot tables from assembly to C

2017-04-20 Thread Julien Grall
The FDT will not be accessed before start_xen (begining of C code) is called and it will be easier to maintain as the code could be common between AArch32 and AArch64. A new function early_fdt_map is introduced to map the FDT in the boot page table. Signed-off-by: Julien Grall Reviewed-by: Stefa

[Xen-devel] [PATCH v2 for-4.9 2/5] xen/arm: mm: Move create_mappings function earlier in the file

2017-04-20 Thread Julien Grall
This function will be called by other function later one. This will avoid forward declaration and keep the new function close to sibling ones. This was moved just after *_fixmap helpers as they are page table handling functions too. Signed-off-by: Julien Grall --- Changes in v2: - P

[Xen-devel] [PATCH v2 for-4.9 5/5] xen/arm: Properly map the FDT in the boot page table

2017-04-20 Thread Julien Grall
Currently, Xen is assuming the FDT will always fit in a 2MB section. Recently, I noticed an early crash on Xen when using GRUB with the following call trace: (XEN) Hypervisor Trap. HSR=0x9606 EC=0x25 IL=1 Syndrome=0x6 (XEN) CPU0: Unexpected Trap: Hypervisor (XEN) [ Xen-4.9-unstable arm64

[Xen-devel] [PATCH v2 for-4.9 4/5] xen/arm: Check if the FDT passed by the bootloader is valid

2017-04-20 Thread Julien Grall
There is currently no sanity check on the FDT passed by the bootloader. Whilst they are stricly not necessary, it will avoid us to spend hours to try to find out why it does not work. From the booting documentation for AArch32 [1] and AArch64 [2] must : - be placed on 8-byte boundary - not

[Xen-devel] [PATCH v2 4/9] xen/pci: split code to size BARs from pci_add_device

2017-04-20 Thread Roger Pau Monne
So that it can be called from outside in order to get the size of regular PCI BARs. This will be required in order to map the BARs from PCI devices into PVH Dom0 p2m. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich --- xen/drivers/passthrough/pci.c | 86 ++

[Xen-devel] [PATCH v2 7/9] vpci: add a priority field to the vPCI register initializer

2017-04-20 Thread Roger Pau Monne
And mark the capability and header vPCI register initializers as high priority, so that they are initialized first. This is needed for MSI-X, since MSI-X needs to know the position of the BARs in order to perform it's initialization, and in order to mask or enable the MSI/MSI-X functionality on de

[Xen-devel] [PATCH v2 2/9] x86/ecam: add handlers for the PVH Dom0 MMCFG areas

2017-04-20 Thread Roger Pau Monne
Introduce a set of handlers for the accesses to the ECAM areas. Those areas are setup based on the contents of the hardware MMCFG tables, and the list of handled ECAM areas is stored inside of the hvm_domain struct. The read/writes are forwarded to the generic vpci handlers once the address is dec

[Xen-devel] [PATCH v2 5/9] xen/vpci: add handlers to map the BARs

2017-04-20 Thread Roger Pau Monne
Introduce a set of handlers that trap accesses to the PCI BARs and the command register, in order to emulate BAR sizing and BAR relocation. The command handler is used to detect changes to bit 2 (response to memory space accesses), and maps/unmaps the BARs of the device into the guest p2m. The BA

[Xen-devel] [PATCH v2 3/9] xen/mm: move modify_identity_mmio to global file and drop __init

2017-04-20 Thread Roger Pau Monne
And also allow it to do non-identity mappings by adding a new parameter. This function will be needed in other parts apart from PVH Dom0 build. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/dom0_build.c | 22 +- xen/common/memory.

[Xen-devel] [PATCH v2 8/9] vpci/msi: add MSI handlers

2017-04-20 Thread Roger Pau Monne
Add handlers for the MSI control, address, data and mask fields in order to detect accesses to them and setup the interrupts as requested by the guest. Note that the pending register is not trapped, and the guest can freely read/write to it. Whether Xen is going to provide this functionality to D

[Xen-devel] [PATCH v2 1/9] xen/vpci: introduce basic handlers to trap accesses to the PCI config space

2017-04-20 Thread Roger Pau Monne
This functionality is going to reside in vpci.c (and the corresponding vpci.h header), and should be arch-agnostic. The handlers introduced in this patch setup the basic functionality required in order to trap accesses to the PCI config space, and allow decoding the address and finding the correspo

[Xen-devel] [PATCH v2 0/9] vpci: PCI config space emulation

2017-04-20 Thread Roger Pau Monne
Hello, The following series contain an implementation of handlers for the PCI configuration space inside of Xen. This allows Xen to detect accesses to the PCI configuration space and react accordingly. Patch 1 implements the generic handlers for accesses to the PCI configuration space together wi

[Xen-devel] [PATCH v2 9/9] vpci/msix: add MSI-X handlers

2017-04-20 Thread Roger Pau Monne
Add handlers for accesses to the MSI-X message control field on the PCI configuration space, and traps for accesses to the memory region that contains the MSI-X table. This traps detect attempts from the guest to configure MSI-X interrupts and properly sets them up. Note that accesses to the Table

[Xen-devel] [PATCH v2 6/9] xen/vpci: trap access to the list of PCI capabilities

2017-04-20 Thread Roger Pau Monne
Add traps to each capability PCI_CAP_LIST_NEXT field in order to mask them on request. All capabilities from the device are fetched and stored in an internal list, that's later used in order to return the next capability to the guest. Note that this only removes the capability from the linked list

[Xen-devel] [PATCH] x86/mm: also flush TLB when putting writable foreign page reference

2017-04-20 Thread Jan Beulich
Jann's explanation of the problem: "start situation: - domain A and domain B are PV domains - domain A and B both have currently scheduled vCPUs, and the vCPUs are not scheduled away - domain A has XSM_TARGET access to domain B - page X is owned by domain B and has no mappings - page X is

[Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Olaf Hering
Andrew, with eab806a097b ("tools/libxc: x86 PV restore code") the only call of xc_domain_populate_physmap_exact was added to the new restore code. This call always sets order=0. The old migration code did consider superpages, the new one does not. What is the reason for not using superpages when

[Xen-devel] Xen Project Security Team considering becoming a CNA

2017-04-20 Thread Ian Jackson
We are in discussions with MITRE with a view to potentially becoming a CVE Numbering Authority. This would probably smooth the process of getting CVE numbers for XSAs. If anyone has any opinions/representations/concerns/whatever about this, please do share them (here in this thread, or privately

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Julien Grall
Hi, On 20/04/17 14:34, Jan Beulich wrote: On 19.04.17 at 22:22, wrote: According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> "EXTENDED XAPIC (X2APIC)" -> "x2APIC State Transitions", the APIC mode and APIC ID are preserved when handling INIT signal and a reset places APIC to xA

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Vitaly Kuznetsov
Peter Zijlstra writes: > On Thu, Apr 20, 2017 at 03:24:53PM +0200, Vitaly Kuznetsov wrote: >> In this patch I suggest we set __max_logical_packages based on the >> max_physical_pkg_id and total_cpus, > > So my 4 socket 144 CPU system will then get max_physical_pkg_id=144, > instead of 4. > > This

Re: [Xen-devel] [PATCH] correct rcu_unlock_domain()

2017-04-20 Thread Julien Grall
Hi, On 20/04/17 15:11, Andrew Cooper wrote: On 20/04/17 14:48, Jan Beulich wrote: Match rcu_lock_domain(), and remove the slightly misleading comment: This isn't just the companion to rcu_lock_domain_by_id() (and that latter function indeed also keeps the domain locked, not the domain list). N

Re: [Xen-devel] [PATCH] x86/microcode: Use the return value from early_microcode_update_cpu

2017-04-20 Thread Julien Grall
Hi, On 20/04/17 14:20, Andrew Cooper wrote: On 20/04/17 14:18, Ross Lagerwall wrote: Use the return value from early_microcode_update_cpu rather than ignoring it. Spotted by Coverity. Signed-off-by: Ross Lagerwall Reviewed-by: Andrew Cooper Julien, can we have a release ack please?

Re: [Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Andrew Cooper
On 20/04/17 16:35, Olaf Hering wrote: > Andrew, > > with eab806a097b ("tools/libxc: x86 PV restore code") the only call of > xc_domain_populate_physmap_exact was added to the new restore code. > This call always sets order=0. The old migration code did consider > superpages, the new one does not. >

[Xen-devel] Xen Project Security Team considering becoming a CNA

2017-04-20 Thread Ian Jackson
(Resending with the correct CC (!)) We are in discussions with MITRE with a view to potentially becoming a CVE Numbering Authority. This would probably smooth the process of getting CVE numbers for XSAs. If anyone has any opinions/representations/concerns/whatever about this, please do share the

Re: [Xen-devel] [RFC PATCH v2 04/25] x86: NUMA: Add accessors for acpi_numa, numa_off and numa_fake variables

2017-04-20 Thread Julien Grall
Hi Vijay, On 28/03/17 16:53, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add accessor functions for acpi_numa and numa_off static variables. Init value of acpi_numa is set 1 instead of 0. Please explain why you change the acpi_numa value from 0 to 1. Also, I am not sure to understand

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Boris Ostrovsky
On 04/20/2017 11:40 AM, Vitaly Kuznetsov wrote: > Peter Zijlstra writes: > >> On Thu, Apr 20, 2017 at 03:24:53PM +0200, Vitaly Kuznetsov wrote: >>> In this patch I suggest we set __max_logical_packages based on the >>> max_physical_pkg_id and total_cpus, >> So my 4 socket 144 CPU system will then

Re: [Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Olaf Hering
On Thu, Apr 20, Andrew Cooper wrote: > As it currently stands, the sending side iterates from 0 to p2m_size, > and sends every frame on the first pass. This means we get PAGE_DATA > records linearly, in batches of 1024, or two aligned 2M superpages. Is there a way to preserve 1G pages? This 380G

[Xen-devel] [linux-3.18 baseline-only test] 71209: regressions - trouble: blocked/broken/fail/pass

2017-04-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 71209 linux-3.18 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71209/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-midway 15 guest-start/debia

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Markus Armbruster
Eric Blake writes: > On 04/20/2017 07:09 AM, Daniel P. Berrange wrote: > +++ b/qapi/event.json @@ -10,6 +10,10 @@ # Emitted when the virtual machine has shut down, indicating that qemu is # about to exit. # +# @guest: If true, the shutdown was triggered by a guest

Re: [Xen-devel] [RFC PATCH v2 05/25] x86: NUMA: Move generic dummy_numa_init to separate function

2017-04-20 Thread Julien Grall
Hi Vijay, On 28/03/17 16:53, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Split numa_initmem_init() so that the numa fallback code is moved as separate function which is generic. Signed-off-by: Vijaya Kumar K --- xen/arch/x86/numa.c | 29 + 1 file changed,

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Peter Zijlstra
On Thu, Apr 20, 2017 at 05:40:37PM +0200, Vitaly Kuznetsov wrote: > > This is getting ludicrous. Xen is plain broken, and instead of fixing > > it, you propose to somehow deal with its obviously crack induced > > behaviour :-( > > Totally agree and I don't like the solution I propose (and that's w

Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

2017-04-20 Thread Markus Armbruster
Eric Blake writes: > On 04/20/2017 06:59 AM, Markus Armbruster wrote: > >> >> No objection to Alistair's idea to turn this into an enumeration. > > Question - should the enum be more than just 'guest' and 'host'? For > example, my patch proves that we have a lot of places that handle > complime

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Vitaly Kuznetsov
Boris Ostrovsky writes: > On 04/20/2017 11:40 AM, Vitaly Kuznetsov wrote: >> Peter Zijlstra writes: >> >>> On Thu, Apr 20, 2017 at 03:24:53PM +0200, Vitaly Kuznetsov wrote: In this patch I suggest we set __max_logical_packages based on the max_physical_pkg_id and total_cpus, >>> So my

[Xen-devel] [libvirt test] 107556: tolerable FAIL - PUSHED

2017-04-20 Thread osstest service owner
flight 107556 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/107556/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 107536 test-armhf-armhf-libvirt-raw 12

Re: [Xen-devel] [PATCH v3] x86/vlapic: Don't reset APIC ID when handling INIT signal

2017-04-20 Thread Chao Gao
On Thu, Apr 20, 2017 at 04:39:06PM +0100, Julien Grall wrote: >Hi, > >On 20/04/17 14:34, Jan Beulich wrote: >> > > > On 19.04.17 at 22:22, wrote: >> > According to SDM "ADVANCED PROGRAMMABLE INTERRUPT CONTROLLER (APIC) -> >> > "EXTENDED XAPIC (X2APIC)" -> "x2APIC State Transitions", the APIC mode

Re: [Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Jan Beulich
>>> On 20.04.17 at 18:04, wrote: > On Thu, Apr 20, Andrew Cooper wrote: > >> As it currently stands, the sending side iterates from 0 to p2m_size, >> and sends every frame on the first pass. This means we get PAGE_DATA >> records linearly, in batches of 1024, or two aligned 2M superpages. > > I

[Xen-devel] Xen ARM community call - meeting minutes and date for the next one

2017-04-20 Thread Julien Grall
Hi all, Below the meeting minutes for the previous Xen community call. Feel free to reply if I missed some parts. I suggest to have the next call on the 3rd May at 5PM BST. Any opinions. Also, do you have any specific topic you would like to talk during this call? Cheers, == Attendees == S

Re: [Xen-devel] [PATCH] x86/mm: also flush TLB when putting writable foreign page reference

2017-04-20 Thread Jann Horn
On Thu, Apr 20, 2017 at 5:26 PM, Jan Beulich wrote: > Jann's explanation of the problem: > > "start situation: > - domain A and domain B are PV domains > - domain A and B both have currently scheduled vCPUs, and the vCPUs >are not scheduled away > - domain A has XSM_TARGET access to domain

Re: [Xen-devel] [PATCH v10 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

2017-04-20 Thread Lars Kurth
> On 20 Apr 2017, at 14:21, Jan Beulich wrote: > On 20.04.17 at 15:02, wrote: >>> On 20 Apr 2017, at 10:43, Jan Beulich wrote: >>> >> On 20.04.17 at 04:14, wrote: On 17-04-19 03:00:29, Jan Beulich wrote: On 19.04.17 at 10:22, wrote: >> On 17-04-18 05:46:43, Jan Be

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Andrew Cooper
On 20/04/17 16:06, Peter Zijlstra wrote: > On Thu, Apr 20, 2017 at 03:24:53PM +0200, Vitaly Kuznetsov wrote: >> In this patch I suggest we set __max_logical_packages based on the >> max_physical_pkg_id and total_cpus, > So my 4 socket 144 CPU system will then get max_physical_pkg_id=144, > instead

Re: [Xen-devel] [PATCH RFC] x86/smpboot: Set safer __max_logical_packages limit

2017-04-20 Thread Boris Ostrovsky
On 04/20/2017 12:15 PM, Peter Zijlstra wrote: > On Thu, Apr 20, 2017 at 05:40:37PM +0200, Vitaly Kuznetsov wrote: >>> This is getting ludicrous. Xen is plain broken, and instead of fixing >>> it, you propose to somehow deal with its obviously crack induced >>> behaviour :-( >> Totally agree and I d

[Xen-devel] [PATCH] xen/pvh: Do not fill kernel's e820 map in init_pvh_bootparams()

2017-04-20 Thread Boris Ostrovsky
e820 map is updated with information from the zeropage (i.e. pvh_bootparams) by default_machine_specific_memory_setup(). With the way things are done now, we end up with a duplicated e820 map. Signed-off-by: Boris Ostrovsky --- This patch is against for-linus-4.12 branch. Since this is not a crit

  1   2   >