Hi Stefano,
On 19/04/17 22:18, Stefano Stabellini wrote:
On Wed, 19 Apr 2017, Julien Grall wrote:
On 19/04/2017 22:01, Stefano Stabellini wrote:
On Wed, 19 Apr 2017, Julien Grall wrote:
I would have added early_fdt_map to this file in a way to avoid the need
for duplicating the declaration of create_mappings (because this version
doesn't have the useful comment on top).
I wanted to keep the function close to the counterpart remove_early_mappings
rather than adding somewhere that make less sense.
Hence why I suggested to move the create_mappings function. Would you be fine
with code motion for Xen 4.9?
Sure. But please keep the code motion in its own separate patch.
I was planning to do the code motion in a separate patch :). My concern
was to shuffle the code unnecessarily during code freeze and was
planning to do it after the freeze.
Anyway, I will resend this series with a patch to move the function.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
