[Xen-devel] [distros-debian-squeeze test] 66621: tolerable trouble: blocked/broken

2016-07-20 Thread Platform Team regression test user
flight 66621 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66621/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 66561 build-armhf

[Xen-devel] [PATCH v2 2/2] tools: make xenstore domain easy configurable

2016-07-20 Thread Juergen Gross
Add configuration entries to sysconfig.xencommons for selection of the xenstore type (domain or daemon) and start the selected xenstore service via a script called from sysvinit or systemd. Signed-off-by: Juergen Gross --- V2: add .gitignore entry for launch-xenstore --- .gitignore

[Xen-devel] [PATCH v2 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On a system with systemd the xenstore sockets are created via systemd. Remove the related configuration files in order to be able to decide at runtime whether the sockets should be created or not. This will enable Xen to start xenstore either via a daemon or via a stub domain. Signed-off-by: Juerg

[Xen-devel] [PATCH v2 0/2] tools: make xenstore domain/daemon configurable

2016-07-20 Thread Juergen Gross
Add a configuration option to /etc/sysconfig/xencommons to let the user configure whether he wants to start xenstore service as a daemon or as a stubdom. Changes in V2: - move service type modification form patch 2 to patch 1 as implied by Ross Lagerwall (at least I guess so) - add .gitignore en

[Xen-devel] [PATCH] xl: rename variable pause to pause_after_migration

2016-07-20 Thread Wei Liu
Gcc 4.4.4 complained that the "pause" variable introduced in 22b430e0 ("xl: add option to leave domain paused after migration") shadowed pause(2) declaration in unistd.h. Rename "pause" to "pause_after_migration" to fix this issue. Reported-by: Boris Ostrovsky Signed-off-by: Wei Liu --- Cc: Ian

Re: [Xen-devel] [PATCH v2 7/9] xen/arm: Allow DOM0 to set the IRQ type

2016-07-20 Thread Julien Grall
Hi Stefano, On 20/07/2016 00:43, Stefano Stabellini wrote: On Thu, 14 Jul 2016, Julien Grall wrote: void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n) { const unsigned long mask = r; @@ -352,6 +368,7 @@ void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n) unsigned long fla

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Ross Lagerwall
On 06/29/2016 02:44 PM, Juergen Gross wrote: On 29/06/16 15:31, Ross Lagerwall wrote: On 06/29/2016 02:00 PM, Juergen Gross wrote: On 29/06/16 14:52, Andrew Cooper wrote: On 29/06/16 13:44, Juergen Gross wrote: @@ -2068,13 +1964,6 @@ int main(int argc, char *argv[]) /* Tell the kernel we

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-20 Thread Wei Liu
On Wed, Jul 20, 2016 at 02:52:05PM +0800, Shannon Zhao wrote: > > > On 2016/7/19 18:38, Wei Liu wrote: > > On Fri, Jul 15, 2016 at 05:39:32PM +0800, Shannon Zhao wrote: > > [...] > >>> > > > >>> > > It would be trivial to have another option in xl.cfg to allow MB > >>> > > granularity. But I don

Re: [Xen-devel] [PATCH v2 1/2] xen: credit2: fix two s_time_t handling issues in load balancing

2016-07-20 Thread George Dunlap
On Tue, Jul 19, 2016 at 4:33 PM, Dario Faggioli wrote: > both introduced in d205f8a7f48e2ec ("xen: credit2: rework > load tracking logic"). > > First, in __update_runq_load(), the ASSERT() was actually > useless. Let's instead check that the computed value of > the load has not overflowed (and hen

Re: [Xen-devel] Xen 4.8 Development Update

2016-07-20 Thread Andrew Cooper
On 19/07/16 14:48, Wei Liu wrote: > This email only tracks big items for xen.git tree. Please reply for items you > woulk like to see in 4.8 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use cases of the feature you're > wor

Re: [Xen-devel] [PATCH] xl: rename variable pause to pause_after_migration

2016-07-20 Thread Roger Pau Monne
On Wed, Jul 20, 2016 at 09:30:17AM +0100, Wei Liu wrote: > Gcc 4.4.4 complained that the "pause" variable introduced in 22b430e0 > ("xl: add option to leave domain paused after migration") shadowed > pause(2) declaration in unistd.h. > > Rename "pause" to "pause_after_migration" to fix this issue.

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Geert Uytterhoeven
Hi Dirk, On Tue, Jul 12, 2016 at 9:46 AM, Dirk Behme wrote: > Clocks described by this property are reserved for use by Xen, and the OS > must not alter their state any way, such as disabling or gating a clock, > or modifying its rate. Ensuring this may impose constraints on parent > clocks or ot

Re: [Xen-devel] [PATCH v2 2/2] xen: credit2: fix potential issues in csched2_cpu_pick with tracing enabled

2016-07-20 Thread George Dunlap
On Tue, Jul 19, 2016 at 4:34 PM, Dario Faggioli wrote: > In fact, when not finding a suitable runqueue where to > place a vCPU, and hence using a fallback, we either: > - don't issue any trace record (while we should), > - risk underruning when accessing the runqueues >array, while preparing

[Xen-devel] [xen-unstable-coverity test] 97701: regressions - ALL FAIL

2016-07-20 Thread osstest service owner
flight 97701 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/97701/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd645 coverity-buildfail REGR. vs. 96924 version tar

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 11:02, Ross Lagerwall wrote: > On 06/29/2016 02:44 PM, Juergen Gross wrote: >> On 29/06/16 15:31, Ross Lagerwall wrote: >>> On 06/29/2016 02:00 PM, Juergen Gross wrote: On 29/06/16 14:52, Andrew Cooper wrote: > On 29/06/16 13:44, Juergen Gross wrote: >> @@ -2068,13 +1964,6

Re: [Xen-devel] Xen 4.8 Development Update

2016-07-20 Thread Wei Liu
On Wed, Jul 20, 2016 at 10:34:01AM +0100, Andrew Cooper wrote: > On 19/07/16 14:48, Wei Liu wrote: > > This email only tracks big items for xen.git tree. Please reply for items > > you > > woulk like to see in 4.8 so that people have an idea what is going on and > > prioritise accordingly. > > > >

Re: [Xen-devel] [PATCH] xl: rename variable pause to pause_after_migration

2016-07-20 Thread Wei Liu
On Wed, Jul 20, 2016 at 11:43:19AM +0200, Roger Pau Monne wrote: > On Wed, Jul 20, 2016 at 09:30:17AM +0100, Wei Liu wrote: > > Gcc 4.4.4 complained that the "pause" variable introduced in 22b430e0 > > ("xl: add option to leave domain paused after migration") shadowed > > pause(2) declaration in un

Re: [Xen-devel] [PATCH v2 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Ian Jackson
Juergen Gross writes ("[PATCH v2 1/2] tools: remove systemd xenstore socket definitions"): > On a system with systemd the xenstore sockets are created via systemd. > Remove the related configuration files in order to be able to decide > at runtime whether the sockets should be created or not. This

Re: [Xen-devel] [PATCH v2 2/2] tools: make xenstore domain easy configurable

2016-07-20 Thread Ian Jackson
Juergen Gross writes ("[PATCH v2 2/2] tools: make xenstore domain easy configurable"): > Add configuration entries to sysconfig.xencommons for selection of the > xenstore type (domain or daemon) and start the selected xenstore > service via a script called from sysvinit or systemd. Can you please

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread George Dunlap
On Wed, Jul 20, 2016 at 10:58 AM, Juergen Gross wrote: > On 20/07/16 11:02, Ross Lagerwall wrote: >> On 06/29/2016 02:44 PM, Juergen Gross wrote: >>> On 29/06/16 15:31, Ross Lagerwall wrote: On 06/29/2016 02:00 PM, Juergen Gross wrote: > On 29/06/16 14:52, Andrew Cooper wrote: >> On 2

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Julien Grall
On 20/07/16 10:43, Geert Uytterhoeven wrote: Hi Dirk, Hi Geert, On Tue, Jul 12, 2016 at 9:46 AM, Dirk Behme wrote: Clocks described by this property are reserved for use by Xen, and the OS must not alter their state any way, such as disabling or gating a clock, or modifying its rate. Ensu

[Xen-devel] [xen-unstable test] 97664: tolerable FAIL

2016-07-20 Thread osstest service owner
flight 97664 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/97664/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-xsm 6 xen-bootfail pass in 97623 test-armhf-armhf-xl-rtds 15 gu

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 12:52, George Dunlap wrote: > On Wed, Jul 20, 2016 at 10:58 AM, Juergen Gross wrote: >> On 20/07/16 11:02, Ross Lagerwall wrote: >>> On 06/29/2016 02:44 PM, Juergen Gross wrote: On 29/06/16 15:31, Ross Lagerwall wrote: > On 06/29/2016 02:00 PM, Juergen Gross wrote: >> On 2

Re: [Xen-devel] [PATCH v2 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 12:36, Ian Jackson wrote: > Juergen Gross writes ("[PATCH v2 1/2] tools: remove systemd xenstore socket > definitions"): >> On a system with systemd the xenstore sockets are created via systemd. >> Remove the related configuration files in order to be able to decide >> at runtime wheth

Re: [Xen-devel] [PATCH v2 2/2] tools: make xenstore domain easy configurable

2016-07-20 Thread Juergen Gross
On 20/07/16 12:43, Ian Jackson wrote: > Juergen Gross writes ("[PATCH v2 2/2] tools: make xenstore domain easy > configurable"): >> Add configuration entries to sysconfig.xencommons for selection of the >> xenstore type (domain or daemon) and start the selected xenstore >> service via a script cal

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Andrew Cooper
On 20/07/16 12:12, Juergen Gross wrote: > On 20/07/16 12:52, George Dunlap wrote: >> On Wed, Jul 20, 2016 at 10:58 AM, Juergen Gross wrote: >>> On 20/07/16 11:02, Ross Lagerwall wrote: On 06/29/2016 02:44 PM, Juergen Gross wrote: > On 29/06/16 15:31, Ross Lagerwall wrote: >> On 06/29/

Re: [Xen-devel] [PATCH V2 2/4] xen: Add generic implementation of binary search

2016-07-20 Thread Julien Grall
Hi Shanker, On 18/07/16 00:26, Shanker Donthineni wrote: This patch adds the generic implementation of binary search algorithm whcih is copied from Linux kernel v4.7-rc7. No functional changes. NIT: ws/whcih/which/ Signed-off-by: Shanker Donthineni Reviewed-by: Andrew Cooper FWIW: Revi

[Xen-devel] [PATCH v2 0/3] xen-scsiback: Fine-tuning for scsiback_device_action()

2016-07-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Jul 2016 13:20:04 +0200 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete an unnecessary check before the function call "kfree" Rename jump labels in scsiback_device_act

[Xen-devel] [PATCH v2 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-20 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 19 Jul 2016 15:42:19 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: Rebased

Re: [Xen-devel] [PATCH V2 2/4] xen: Add generic implementation of binary search

2016-07-20 Thread Julien Grall
On 20/07/16 12:25, Julien Grall wrote: Hi Shanker, On 18/07/16 00:26, Shanker Donthineni wrote: This patch adds the generic implementation of binary search algorithm whcih is copied from Linux kernel v4.7-rc7. No functional changes. NIT: ws/whcih/which/ Signed-off-by: Shanker Donthineni

[Xen-devel] [PATCH v2 2/3] xen-scsiback: Rename jump labels in scsiback_device_action()

2016-07-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Jul 2016 13:03:16 +0200 * Adjust jump targets according to the Linux coding style convention. * A bit of refactoring for the control flow Suggested-by: Jürgen Groß Signed-off-by: Markus Elfring --- v2: Rebased on source files from "Linux next-20160719" C

[Xen-devel] [PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-20 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 20 Jul 2016 13:12:33 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring --- v2: Rebased on source files from "Linux next-20160719" drivers/xen/xen-scsiback.c | 4 ++-

Re: [Xen-devel] [PATCH] xen/domctl: Add DOMINFO_hap to xen_domctl_getdomaininfo

2016-07-20 Thread Julien Grall
Hi Andrew, On 15/07/16 17:57, Andrew Cooper wrote: diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c index f61f98a..afa16d8 100644 --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -14,6 +14,12 @@ #include #include +void arch_get_domain_info(const struct domain *d, +

Re: [Xen-devel] [PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-20 Thread Juergen Gross
On 20/07/16 13:36, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 20 Jul 2016 13:12:33 +0200 > > Pass the constant "FAILED" in a function call directly instead of > using an intialisation for a local variable. > > Signed-off-by: Markus Elfring Even if already given, here it is ag

Re: [Xen-devel] [PATCH v2 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-20 Thread Juergen Gross
On 20/07/16 13:30, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 19 Jul 2016 15:42:19 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle

Re: [Xen-devel] [PATCH v2 2/3] xen-scsiback: Rename jump labels in scsiback_device_action()

2016-07-20 Thread Juergen Gross
On 20/07/16 13:34, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 20 Jul 2016 13:03:16 +0200 > > * Adjust jump targets according to the Linux coding style convention. > > * A bit of refactoring for the control flow > > Suggested-by: Jürgen Groß > Signed-off-by: Markus Elfring R

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Geert Uytterhoeven
Hi Julien, On Wed, Jul 20, 2016 at 1:01 PM, Julien Grall wrote: > On 20/07/16 10:43, Geert Uytterhoeven wrote: >> On Tue, Jul 12, 2016 at 9:46 AM, Dirk Behme >> wrote: >>> >>> Clocks described by this property are reserved for use by Xen, and the OS >>> must not alter their state any way, such a

[Xen-devel] [PATCH XTF] build: introduce a dist target

2016-07-20 Thread Wei Liu
The install target doesn't honour $PREFIX. Introduce a dist target to make it easier to package the artifacts. Signed-off-by: Wei Liu --- Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index 1a8099d..d625b90 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,7

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 13:21, Andrew Cooper wrote: > On 20/07/16 12:12, Juergen Gross wrote: >> On 20/07/16 12:52, George Dunlap wrote: >>> On Wed, Jul 20, 2016 at 10:58 AM, Juergen Gross wrote: On 20/07/16 11:02, Ross Lagerwall wrote: > On 06/29/2016 02:44 PM, Juergen Gross wrote: >> On 29/06/1

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions"): > On 20/07/16 12:12, Juergen Gross wrote: > > To be clear: I don't want to avoid systemd by any means. I just don't > > want to have a complex and ugly solution with no gain just because > > doi

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Julien Grall
On 20/07/16 12:49, Geert Uytterhoeven wrote: Hi Julien, On Wed, Jul 20, 2016 at 1:01 PM, Julien Grall wrote: On 20/07/16 10:43, Geert Uytterhoeven wrote: On Tue, Jul 12, 2016 at 9:46 AM, Dirk Behme wrote: Clocks described by this property are reserved for use by Xen, and the OS must not

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Ian Jackson
Ross Lagerwall writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions"): > Nevertheless, I feel that this patch series makes the implementation > worse for users of xenstored as a daemon: > > - Because Type=oneshot is not intended to be used for daemon processes,

Re: [Xen-devel] [PATCH] xl: rename variable pause to pause_after_migration

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH] xl: rename variable pause to pause_after_migration"): > Gcc 4.4.4 complained that the "pause" variable introduced in 22b430e0 > ("xl: add option to leave domain paused after migration") shadowed > pause(2) declaration in unistd.h. > > Rename "pause" to "pause_after_migrati

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 14:08, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd > xenstore socket definitions"): >> On 20/07/16 12:12, Juergen Gross wrote: >>> To be clear: I don't want to avoid systemd by any means. I just don't >>> want to have a complex and ugly

Re: [Xen-devel] [PATCH 1/2] arm/traps: fix bug in dump_guest_s1_walk L1 page table offset computation

2016-07-20 Thread Julien Grall
Hi Jonathan, Thank you for sending the bug fix. On 19/07/16 18:15, Jonathan Daugherty wrote: The dump_guest_s1_walk function was incorrectly using the top 10 bits of the virtual address to select the L1 page table index. The correct amount is 12 bits, resulting in a shift of 20 bits rather tha

Re: [Xen-devel] [PATCH 2/2] arm/traps: fix bug in dump_guest_s1_walk handling of level 2 page tables

2016-07-20 Thread Julien Grall
On 19/07/16 18:15, Jonathan Daugherty wrote: dump_guest_s1_walk intends to walk to level 2 page table entries but was failing to do so because of a check that caused level 2 page table descriptors to be ignored. This change fixes the check so that level 2 page table walks occur as intended by i

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Andrew Cooper
On 20/07/16 13:08, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd > xenstore socket definitions"): >> On 20/07/16 12:12, Juergen Gross wrote: >>> To be clear: I don't want to avoid systemd by any means. I just don't >>> want to have a complex and ugly

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-20 Thread Julien Grall
Hi, On 14/07/16 14:37, Stefano Stabellini wrote: On Wed, 13 Jul 2016, Julien Grall wrote: Hello, On 12/07/2016 17:58, Boris Ostrovsky wrote: On 07/12/2016 12:10 PM, Julien Grall wrote: On 12/07/2016 16:08, Boris Ostrovsky wrote: On 07/12/2016 10:57 AM, Shannon Zhao wrote: It will affect so

Re: [Xen-devel] [PATCH 6/9] xen/multicall: Rework arch multicall handling

2016-07-20 Thread Julien Grall
Hi Andrew, On 18/07/16 10:51, Andrew Cooper wrote: The x86 multicall handling was previously some very hairy inline assembly, and is hard to follow and maintain. Replace the existing do_multicall_call() with arch_do_multicall_call(). The x86 side needs to handle both compat and non-compat call

[Xen-devel] [qemu-mainline test] 97665: tolerable FAIL - PUSHED

2016-07-20 Thread osstest service owner
flight 97665 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/97665/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 96791 test-amd64-i386-xl-qemuu-win

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 14:11, Ian Jackson wrote: > Ross Lagerwall writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd > xenstore socket definitions"): >> Nevertheless, I feel that this patch series makes the implementation >> worse for users of xenstored as a daemon: >> >> - Because Type=oneshot is n

Re: [Xen-devel] [PATCH 5/9] xen/arm: Provide macros to help creating workaround helpers

2016-07-20 Thread Julien Grall
Hi Konrad, On 14/07/16 14:57, Stefano Stabellini wrote: On Wed, 22 Jun 2016, Julien Grall wrote: Workarounds may require to execute a different path when the platform is affected by the associated erratum. Furthermore, this may need to be called in the common code. To avoid too much intrusion/

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Geert Uytterhoeven
Hi Julien, On Wed, Jul 20, 2016 at 2:10 PM, Julien Grall wrote: > On 20/07/16 12:49, Geert Uytterhoeven wrote: >> On Wed, Jul 20, 2016 at 1:01 PM, Julien Grall >> wrote: >>> On 20/07/16 10:43, Geert Uytterhoeven wrote: On Tue, Jul 12, 2016 at 9:46 AM, Dirk Behme wrote: > Clocks de

Re: [Xen-devel] [PATCH XTF] build: introduce a dist target

2016-07-20 Thread Andrew Cooper
On 20/07/16 12:55, Wei Liu wrote: > The install target doesn't honour $PREFIX. Introduce a dist target to > make it easier to package the artifacts. > > Signed-off-by: Wei Liu > --- > Makefile | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Makefile b/Makefile > index 1a8099d..d625b

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Dirk Behme
On 20.07.2016 14:46, Geert Uytterhoeven wrote: Hi Julien, On Wed, Jul 20, 2016 at 2:10 PM, Julien Grall wrote: On 20/07/16 12:49, Geert Uytterhoeven wrote: On Wed, Jul 20, 2016 at 1:01 PM, Julien Grall wrote: On 20/07/16 10:43, Geert Uytterhoeven wrote: On Tue, Jul 12, 2016 at 9:46 AM, Dir

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Juergen Gross
On 20/07/16 14:32, Andrew Cooper wrote: > On 20/07/16 13:08, Ian Jackson wrote: >> Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd >> xenstore socket definitions"): >>> On 20/07/16 12:12, Juergen Gross wrote: To be clear: I don't want to avoid systemd by any means. I

Re: [Xen-devel] [PATCH XTF] build: introduce a dist target

2016-07-20 Thread Wei Liu
On Wed, Jul 20, 2016 at 01:52:43PM +0100, Andrew Cooper wrote: > On 20/07/16 12:55, Wei Liu wrote: > > The install target doesn't honour $PREFIX. Introduce a dist target to > > make it easier to package the artifacts. > > > > Signed-off-by: Wei Liu > > --- > > Makefile | 5 + > > 1 file chang

[Xen-devel] [xen-unstable-smoke test] 97707: tolerable all pass - PUSHED

2016-07-20 Thread osstest service owner
flight 97707 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/97707/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH XTF] build: introduce a dist target

2016-07-20 Thread Andrew Cooper
On 20/07/16 14:10, Wei Liu wrote: > On Wed, Jul 20, 2016 at 01:52:43PM +0100, Andrew Cooper wrote: >> On 20/07/16 12:55, Wei Liu wrote: >>> The install target doesn't honour $PREFIX. Introduce a dist target to >>> make it easier to package the artifacts. >>> >>> Signed-off-by: Wei Liu >>> --- >>>

[Xen-devel] [OSSTEST PATCH 3/5] cr-ensure-disk-space: Break out check_space

2016-07-20 Thread Ian Jackson
Break out the df check into its own subroutine. iteration_proceed now becomes iteration_continue and doesn't return a booleanish. No functional change. Signed-off-by: Ian Jackson --- cr-ensure-disk-space | 33 + 1 file changed, 17 insertions(+), 16 deletions(-)

[Xen-devel] [OSSTEST PATCH 4/5] cr-ensure-disk-space: Run check_space before taking lock

2016-07-20 Thread Ian Jackson
This allows cr-ensure-disk-space to be a noop if there is enough space, even if run on a host which doesn't have access to the relevant lock directory. Signed-off-by: Ian Jackson --- cr-ensure-disk-space | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cr-ensure-disk-space b/cr-ensure-disk-

[Xen-devel] [OSSTEST PATCH 2/5] mfi-common: Do not set di_version runvar to empty string in build jobs

2016-07-20 Thread Ian Jackson
2601498df77c "mfi-common: Do not set di_version runvar to empty string" fixed the test jobs but not the build jobs, because the setting of hostos_runvars was (it seems) cloned-and-hacked, and it fixed only one instance. Now that we have set_hostos_runvars, use it in create_build_jobs too. Signed-

[Xen-devel] [OSSTEST PATCH 5/5] mg-list-all-branches: Do not match ${BRANCHES+= ... }

2016-07-20 Thread Ian Jackson
This is not valid shell syntax and should not appear. The confusion seems to have arisen because of the need for to match BRANCHES+=... (without the surrounding { }). This results in no change to the output. (I seem to have collected this patch some time ago as part of some fixes to mg-list-all-

[Xen-devel] [OSSTEST PATCH 1/5] mfi-common: Break out set_hostos_runvars

2016-07-20 Thread Ian Jackson
We are going to want to reuse this. No functional change. (NB shell `local' variables have dynamic rather than lexical scope.) Signed-off-by: Ian Jackson --- mfi-common | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/mfi-common b/mfi-common index ca1e0dd..

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-20 Thread Julien Grall
On 20/07/2016 13:46, Geert Uytterhoeven wrote: Hi Julien, Hello Geert, On Wed, Jul 20, 2016 at 2:10 PM, Julien Grall wrote: On 20/07/16 12:49, Geert Uytterhoeven wrote: On Wed, Jul 20, 2016 at 1:01 PM, Julien Grall wrote: On 20/07/16 10:43, Geert Uytterhoeven wrote: On Tue, Jul 12, 20

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread George Dunlap
On 20/07/16 14:23, Ian Jackson wrote: > But I think you need to be more careful with your use of language. > `Disingenuous' implies dishonesty. The way I've heard it used implies a level of pretense, not necessarily dishonesty -- i.e., pretending that stubdom xenstored was a usable option when it

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions"): > However, calling what previously exists WRT xenstored stubdomains as > "supported" is laughable. The lack of integration meant that anyone > trying to use it had to make intrusive modificatio

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-20 Thread Boris Ostrovsky
On 07/20/2016 08:33 AM, Julien Grall wrote: > Hi, > > On 14/07/16 14:37, Stefano Stabellini wrote: >> On Wed, 13 Jul 2016, Julien Grall wrote: >>> Hello, >>> >>> On 12/07/2016 17:58, Boris Ostrovsky wrote: On 07/12/2016 12:10 PM, Julien Grall wrote: > On 12/07/2016 16:08, Boris Ostrovsky w

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-20 Thread Julien Grall
On 20/07/2016 14:33, Boris Ostrovsky wrote: On 07/20/2016 08:33 AM, Julien Grall wrote: Hi, On 14/07/16 14:37, Stefano Stabellini wrote: On Wed, 13 Jul 2016, Julien Grall wrote: Hello, On 12/07/2016 17:58, Boris Ostrovsky wrote: On 07/12/2016 12:10 PM, Julien Grall wrote: On 12/07/2016 1

[Xen-devel] [PATCH V3 0/4] Change fixed mmio handlers to a variable number

2016-07-20 Thread Shanker Donthineni
The maximum number of mmio handlers that are allowed is limited to a macro MAX_IO_HANDLER(16), which is not enough for supporting per CPU Redistributor regions. We need at least MAX_IO_HANDLER+CONFIG_NR_CPUS mmio handlers in order to support ACPI based XEN boot. This patchset uses the dynamic allo

[Xen-devel] [PATCH V3 3/4] xen/arm: io: Use binary search for mmio handler lookup

2016-07-20 Thread Shanker Donthineni
As the number of I/O handlers increase, the overhead associated with linear lookup also increases. The system might have maximum of 144 (assuming CONFIG_NR_CPUS=128) mmio handlers. In worst case scenario, it would require 144 iterations for finding a matching handler. Now it is time for us to chang

[Xen-devel] [PATCH V3 1/4] arm/io: Use separate memory allocation for mmio handlers

2016-07-20 Thread Shanker Donthineni
The number of mmio handlers are limited to a compile time macro MAX_IO_HANDLER which is 16. This number is not at all sufficient to support per CPU distributor regions. Either it needs to be increased to a bigger number, at least CONFIG_NR_CPUS+16, or allocate a separate memory for mmio handlers dy

[Xen-devel] [PATCH V3 2/4] xen: Add generic implementation of binary search

2016-07-20 Thread Shanker Donthineni
This patch adds the generic implementation of binary search algorithm which is copied from Linux kernel v4.7-rc7. No functional changes. Signed-off-by: Shanker Donthineni Reviewed-by: Andrew Cooper Reviewed-by: Julien Grall --- Changes since v2: Fixed the compilation issue due to a missing ';'

[Xen-devel] [PATCH V3 4/4] arm/vgic: Change fixed number of mmio handlers to variable number

2016-07-20 Thread Shanker Donthineni
Compute the number of mmio handlers that are required for vGICv3 and vGICv2 emulation drivers in vgic_v3_init()/vgic_v2_init(). Augment this variable number of mmio handers to a fixed number MAX_IO_HANDLER and pass it to domain_io_init() to allocate enough memory. New code path: domain_vgic_regis

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-20 Thread Boris Ostrovsky
On 07/20/2016 09:41 AM, Julien Grall wrote: > > > On 20/07/2016 14:33, Boris Ostrovsky wrote: >> On 07/20/2016 08:33 AM, Julien Grall wrote: >>> Hi, >>> >>> On 14/07/16 14:37, Stefano Stabellini wrote: On Wed, 13 Jul 2016, Julien Grall wrote: > Hello, > > On 12/07/2016 17:58, Boris

[Xen-devel] [PATCH 0/2] Two coverity inspired patches for xenstored

2016-07-20 Thread Wei Liu
Wei Liu (2): xenstore: send error earlier in do_mkdir xenstore: add assertion in database dumping code tools/xenstore/xenstored_core.c | 7 +++ 1 file changed, 7 insertions(+) -- 2.1.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org https

[Xen-devel] [PATCH 1/2] xenstore: send error earlier in do_mkdir

2016-07-20 Thread Wei Liu
XenServer's coverity instance complains that a few lines below create_node dereferences NULL if name == NULL. It however fails to figure out that if node is NULL, errno won't be ENOENT, so do_mkdir should have bailed before create_node. That said, it would be good if we don't need to go through th

Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-20 Thread Andrew Cooper
On 20/07/16 14:29, George Dunlap wrote: > On 20/07/16 14:23, Ian Jackson wrote: >> But I think you need to be more careful with your use of language. >> `Disingenuous' implies dishonesty. > The way I've heard it used implies a level of pretense, not necessarily > dishonesty -- i.e., pretending that

[Xen-devel] [PATCH 2/2] xenstore: add assertion in database dumping code

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/2] xenstore: add assertion in database dumping code"): > If memfile is NULL, the signal handler won't be installed, hence fopen > won't dereference NULL. Coverity is not smart enough to figure that out > unfortunately. Acked-by: Ian Jackson _

[Xen-devel] [PATCH 1/2] xenstore: send error earlier in do_mkdir

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/2] xenstore: send error earlier in do_mkdir"): > XenServer's coverity instance complains that a few lines below > create_node dereferences NULL if name == NULL. It however fails to > figure out that if node is NULL, errno won't be ENOENT, so do_mkdir > should have bailed b

[Xen-devel] [PATCH 2/2] xenstore: add assertion in database dumping code

2016-07-20 Thread Wei Liu
If memfile is NULL, the signal handler won't be installed, hence fopen won't dereference NULL. Coverity is not smart enough to figure that out unfortunately. Add an assertion to prevent coverity from complaining. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/xenstore/xenstored_core.c |

Re: [Xen-devel] [PATCH v2 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH v2 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c"): > Place the PID file under XEN_RUN_DIR. Note that this change the default > location from /var/run to /var/run/xen. > > Generate a _paths.h as that is required to make this change work. Acked-by: Ian Ja

Re: [Xen-devel] [PATCH v2 1/7] xenconsoled: honour XEN_RUN_DIR

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH v2 1/7] xenconsoled: honour XEN_RUN_DIR"): > Place the PID file under XEN_RUN_DIR by default. Note this change the > default location from /var/run to /var/run/xen. > > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-deve

Re: [Xen-devel] [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR

2016-07-20 Thread Ian Jackson
Wei Liu writes ("[PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR"): > This is because libxl uses XEN_RUN_DIR to generate the socket path for > libxenstat while libxenstat itself uses hard-coded path, which is not > necessarily the same path as XEN_RUN_DIR. The default configuration > happened to wor

Re: [Xen-devel] [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR

2016-07-20 Thread Wei Liu
On Wed, Jul 20, 2016 at 03:40:56PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR"): > > This is because libxl uses XEN_RUN_DIR to generate the socket path for > > libxenstat while libxenstat itself uses hard-coded path, which is not > > necessarily the s

[Xen-devel] [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding

2016-07-20 Thread Ross Lagerwall
Don't change the timestamp of arch/x86/Makefile when editing it since it forces much of the Xen tree to be rebuilt and then requires many invocations of create-diff-tool. This is safe since the Makefile change only changes the final link rule, and xen will be relinked anyway. --- livepatch-build

[Xen-devel] [ovmf test] 97683: regressions - FAIL

2016-07-20 Thread osstest service owner
flight 97683 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/97683/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-

[Xen-devel] [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options

2016-07-20 Thread Ross Lagerwall
--- livepatch-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/livepatch-build b/livepatch-build index 7395b49..d9d9da3 100755 --- a/livepatch-build +++ b/livepatch-build @@ -185,7 +185,7 @@ usage() { find_tools || die "can't find supporting tools" -options=$(getopt -

[Xen-devel] [libvirt test] 97688: regressions - FAIL

2016-07-20 Thread osstest service owner
flight 97688 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/97688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 6 xen-boot fail REGR. vs. 97638 Tests which did not succe

Re: [Xen-devel] [PATCH 0/2] Two coverity inspired patches for xenstored

2016-07-20 Thread Wei Liu
Pushed. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/7] Remove hard-coded /var/run in tools

2016-07-20 Thread Wei Liu
Series pushed to staging. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xl: rename variable pause to pause_after_migration

2016-07-20 Thread Wei Liu
Pushed. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v5 4/7] xen/arm: Document the errata implemented in Xen

2016-07-20 Thread Julien Grall
The new document will help to keep track of each erratum Xen is able to handle. The text is based on the Linux doc in Documents/arm64/silicon-errata.txt. Also list the current errata that Xen is aware of. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v4:

[Xen-devel] [PATCH v5 5/7] xen/arm: arm64: Add Cortex-A53 cache errata workaround

2016-07-20 Thread Julien Grall
The ARM errata 819472, 827319 and 824069 define the same workaround for these hardware issues in certain Cortex-A53 parts. The cache instructions "dc cvac" and "dc cvau" need to be upgraded to "dc civac". Use the alternative framework to replace those instructions only on affected cores. Whilst

[Xen-devel] [PATCH v5 6/7] xen/arm: arm64: Add cortex-A57 erratum 832075 workaround

2016-07-20 Thread Julien Grall
The ARM erratum 832075 applies to certain revisions of Cortex-A57, one of the workarounds is to change device loads into using load-acquire semantics. Use the alternative framework to enable the workaround only on affected cores. Whilst a guest could trigger the deadlock, it can be broken when th

[Xen-devel] [PATCH v5 3/7] xen/arm: Detect silicon revision and set cap bits accordingly

2016-07-20 Thread Julien Grall
After each CPU has been started, we iterate through a list of CPU errata to detect CPUs which need from hypervisor code patches. For each bug there is a function which check if that a particular CPU is affected. This needs to be done on every CPUs to cover heterogenous system properly. If a certa

[Xen-devel] [PATCH v5 0/7] xen/arm: Introduce alternative runtime patching for ARM64

2016-07-20 Thread Julien Grall
Hello, Some of the processor errata will require to modify code sequence. As those modifications may impact the performance, they should only be enabled on affected cores. Furthermore, Xen may also want to take advantage of new hardware features coming up with v8.1 and v8.2. The first part of the

[Xen-devel] [PATCH v5 7/7] xen/arm: traps: Don't inject a fault if the translation VA -> IPA fails

2016-07-20 Thread Julien Grall
Based on ARM ARM (D4.5.3 in ARM DDI 0486A and B3.12.7 in ARM DDI 0406C.c), a Stage 1 translation error has priority over a Stage 2 translation error. Therefore gva_to_ipa can only fail if another vCPU is playing with the page table. Rather than injecting a custom fault, replay the instruction and

[Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-20 Thread Julien Grall
Some of the processor erratum will require to modify code sequence. As those modifications may impact the performance, they should only be enabled on affected cores. Furthermore, Xen may also want to take advantage of new hardware features coming up with v8.1 and v8.2. This patch adds an infrastru

[Xen-devel] [PATCH v5 2/7] xen/arm: cpufeature: Provide an helper to check if a capability is supported

2016-07-20 Thread Julien Grall
The CPU capabilities will be set depending on the value found in the CPU registers. This patch provides a generic to go through a set of capabilities and find which one should be enabled. The parameter "info" is used to display the kind of capability updated (e.g workaround, feature...). Signed-o

  1   2   >