Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 18:29, wrote: > On Fri, Jun 24, 2016 at 5:24 AM, Jan Beulich wrote: > On 24.06.16 at 13:20, wrote: From: Tamas K Lengyel [mailto:ta...@tklengyel.com] + * rc < error, fall-through to exit_and_crash + */ +i

Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 19:02, wrote: > On Fri, Jun 24, 2016 at 01:33:45AM -0600, Jan Beulich wrote: >> >>> On 22.06.16 at 19:15, wrote: >> > --- a/tools/firmware/hvmloader/hvmloader.c >> > +++ b/tools/firmware/hvmloader/hvmloader.c >> > @@ -253,10 +253,51 @@ static void acpi_enable_sci(void) >> >

Re: [Xen-devel] [PATCH v5 09/14] hvmloader: Check modules whereabouts in perform_tests

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 19:14, wrote: > On Fri, Jun 24, 2016 at 01:44:30AM -0600, Jan Beulich wrote: >> >>> On 22.06.16 at 19:15, wrote: >> > +uint64_t cmdline_paddr = modlist[i].cmdline_paddr; >> > + >> > +if ( check_test_overlap(modlist[i].paddr, modlist[i].size) ) >> > +{ >>

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init()

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 17:01, wrote: > On 07/06/16 07:31, Jan Beulich wrote: >> - drop unused function parameter of read_dev_bar() >> - drop rom_init() (now identical to bar_init()) >> - fold read_dev_bar() into its now single caller >> - simplify determination of 64-bit memory resource >> - use const

[Xen-devel] [PATCH v4] xen: arm: Update arm64 image header

2016-06-27 Thread Dirk Behme
With the Linux kernel commits https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=a2c1d73b94ed49

Re: [Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-27 Thread Jan Beulich
>>> On 26.06.16 at 11:18, wrote: > On June 24, 2016 7:55 PM, Tian, Kevin wrote: >> > From: Xu, Quan >> > Sent: Friday, June 24, 2016 1:52 PM >> > diff --git a/xen/drivers/passthrough/vtd/extern.h >> > b/xen/drivers/passthrough/vtd/extern.h >> > index 45357f2..efaff28 100644 >> > --- a/xen/drivers

Re: [Xen-devel] [PATCH v12 1/6] IOMMU: add a timeout parameter for device IOTLB invalidation

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 07:51, wrote: > From: Quan Xu > > The parameter 'iommu_dev_iotlb_timeout' specifies the timeout > of device IOTLB invalidation in milliseconds. By default, the > timeout is 1000 milliseconds, which can be boot-time changed. > > We also confirmed with VT-d hardware team that 1

Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 07:51, wrote: > --- a/xen/drivers/passthrough/x86/ats.c > +++ b/xen/drivers/passthrough/x86/ats.c > @@ -22,26 +22,34 @@ LIST_HEAD(ats_devices); > bool_t __read_mostly ats_enabled = 0; > boolean_param("ats", ats_enabled); > > -int enable_ats_device(int seg, int bus, int devfn

Re: [Xen-devel] [PATCH v12 5/6] IOMMU: move the domain crash logic up to the generic IOMMU layer

2016-06-27 Thread Jan Beulich
>>> On 26.06.16 at 10:58, wrote: > On June 24, 2016 7:48 PM, Tian, Kevin wrote: >> > From: Xu, Quan >> > Sent: Friday, June 24, 2016 1:52 PM >> > >> > From: Quan Xu >> > >> > Signed-off-by: Quan Xu >> > >> > CC: Julien Grall >> > CC: Kevin Tian >> > CC: Feng Wu >> > CC: Jan Beulich >> > CC:

Re: [Xen-devel] [PATCH v12 1/6] IOMMU: add a timeout parameter for device IOTLB invalidation

2016-06-27 Thread Xu, Quan
On June 27, 2016 4:03 PM, Jan Beulich wrote: > >>> On 24.06.16 at 07:51, wrote: > > From: Quan Xu > > > > The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of > > device IOTLB invalidation in milliseconds. By default, the timeout is > > 1000 milliseconds, which can be boot-time chang

[Xen-devel] [xen-4.3-testing test] 96295: regressions - FAIL

2016-06-27 Thread osstest service owner
flight 96295 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96295/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 87893 build-amd64-libvi

Re: [Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 07:51, wrote: > @@ -199,24 +199,73 @@ static int __must_check queue_invalidate_wait(struct > iommu *iommu, > return -EOPNOTSUPP; > } > > -static int __must_check invalidate_sync(struct iommu *iommu, > -bool_t flush_dev_iotlb) > +s

Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 10:17, wrote: On 24.06.16 at 07:51, wrote: >> --- a/xen/drivers/passthrough/x86/ats.c >> +++ b/xen/drivers/passthrough/x86/ats.c >> @@ -22,26 +22,34 @@ LIST_HEAD(ats_devices); >> bool_t __read_mostly ats_enabled = 0; >> boolean_param("ats", ats_enabled); >> >> -int ena

Re: [Xen-devel] [PATCH v12 1/6] IOMMU: add a timeout parameter for device IOTLB invalidation

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 10:19, wrote: > On June 27, 2016 4:03 PM, Jan Beulich wrote: >> >>> On 24.06.16 at 07:51, wrote: >> > From: Quan Xu >> > >> > The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of >> > device IOTLB invalidation in milliseconds. By default, the timeout is >> > 1000

[Xen-devel] [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() during migration, but that's too later after multi-queue introduced. After a migrate to another host (which may not have multiqueue support), the number of rings (block hardware queues) may be changed and the ring and shadow

Re: [Xen-devel] [PATCH v12 1/6] IOMMU: add a timeout parameter for device IOTLB invalidation

2016-06-27 Thread Xu, Quan
On June 27, 2016 4:29 PM, Jan Beulich wrote: > >>> On 27.06.16 at 10:19, wrote: > > On June 27, 2016 4:03 PM, Jan Beulich wrote: > >> >>> On 24.06.16 at 07:51, wrote: > >> > From: Quan Xu > >> > > >> > The parameter 'iommu_dev_iotlb_timeout' specifies the timeout of > >> > device IOTLB invalid

[Xen-devel] [qemu-mainline test] 96288: regressions - FAIL

2016-06-27 Thread osstest service owner
flight 96288 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/96288/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 94856 test-amd64

[Xen-devel] FIXME question

2016-06-27 Thread Xu, Quan
Hi, When I read IOMMU code, In xen/drivers/passthrough/vtd/intremap.c : pi_update_irte().. There are a FIXME -- '' * FIXME: For performance reasons we should store the 'iommu' pointer in * 'struct msi_desc' in some other place, so we don't need to waste * time searching it here. " IMO, we are bet

[Xen-devel] [libvirt test] 96299: tolerable FAIL - PUSHED

2016-06-27 Thread osstest service owner
flight 96299 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/96299/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt-xsm 14 guest-saver

Re: [Xen-devel] FIXME question

2016-06-27 Thread Wu, Feng
> -Original Message- > From: Xu, Quan > Sent: Monday, June 27, 2016 5:24 PM > To: xen-devel@lists.xen.org > Cc: Jan Beulich ; Tian, Kevin ; Wu, > Feng > Subject: FIXME question > > Hi, > > When I read IOMMU code, > In xen/drivers/passthrough/vtd/intremap.c : pi_update_irte().. > There

Re: [Xen-devel] FIXME question

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 11:23, wrote: > Hi, > > When I read IOMMU code, > In xen/drivers/passthrough/vtd/intremap.c : pi_update_irte().. > There are a FIXME -- > '' > * FIXME: For performance reasons we should store the 'iommu' pointer in > * 'struct msi_desc' in some other place, so we don't need to

Re: [Xen-devel] [PATCH v2 00/17] XSM/FLASK updates for 4.8

2016-06-27 Thread Andrew Cooper
On 21/06/16 16:24, Andrew Cooper wrote: > On 20/06/16 15:04, Daniel De Graaf wrote: >> Changes from v1: >> - Change c->context and c->sid from arrays to fields when shrinking >> - Keep struct xen_flask_userlist in headers, but guard it with #ifs >> - Split off Kconfig changes into their own patc

Re: [Xen-devel] [PATCH v2 15/17] libxl/arm: Add ACPI module

2016-06-27 Thread Julien Grall
Hi Shannon, On 25/06/16 04:22, Shannon Zhao wrote: On 2016/6/24 2:35, Julien Grall wrote: Hi Shannon, On 23/06/2016 04:17, Shannon Zhao wrote: From: Shannon Zhao Add the ARM Multiboot module for ACPI, so UEFI or DomU can get the base address of ACPI tables from it. Signed-off-by: Shannon

Re: [Xen-devel] FIXME question

2016-06-27 Thread Andrew Cooper
On 27/06/16 10:32, Jan Beulich wrote: On 27.06.16 at 11:23, wrote: >> Hi, >> >> When I read IOMMU code, >> In xen/drivers/passthrough/vtd/intremap.c : pi_update_irte().. >> There are a FIXME -- >> '' >> * FIXME: For performance reasons we should store the 'iommu' pointer in >> * 'struct msi_d

Re: [Xen-devel] FIXME question

2016-06-27 Thread Wu, Feng
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Monday, June 27, 2016 5:51 PM > To: Jan Beulich ; Xu, Quan > Cc: Tian, Kevin ; Wu, Feng ; xen- > de...@lists.xen.org > Subject: Re: [Xen-devel] FIXME question > > On 27/06/16 10:32, Jan Beulich wrote:

Re: [Xen-devel] [PATCH v2 07/17] libxl/arm: Construct ACPI GTDT table

2016-06-27 Thread Julien Grall
Hi Shannon, On 27/06/16 02:44, Shannon Zhao wrote: On 2016/6/24 0:26, Julien Grall wrote: On 23/06/16 04:16, Shannon Zhao wrote: From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 28 ++

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-27 Thread Julien Grall
(CC Boris and Doug) Hi Shannon, On 27/06/16 07:01, Shannon Zhao wrote: On 2016/6/24 1:03, Julien Grall wrote: On 23/06/16 04:16, Shannon Zhao wrote: [...] diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 264b6ef..5347480 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Make

Re: [Xen-devel] [PATCH v5 0/6] Support calling functions on dedicated physical cpu

2016-06-27 Thread Juergen Gross
On 06/04/16 16:17, Juergen Gross wrote: > Some hardware (e.g. Dell Studio laptops) require special functions to > be called on physical cpu 0 in order to avoid occasional hangs. When > running as dom0 under Xen this could be achieved only via special boot > parameters (vcpu pinning) limiting the hy

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-06-27 Thread Julien Grall
Hi Shannon, On 23/06/16 15:34, Shannon Zhao wrote: On 2016年06月23日 21:39, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Shannon Zhao wrote: From: Shannon Zhao Add a configuration option for ARM DomU so that user can deicde to use ACPI or not. This option is defaultly false. Signed-off-by: S

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-06-27 Thread Julien Grall
(CC Boris) On 27/06/16 07:25, Shannon Zhao wrote: On 2016/6/24 2:46, Julien Grall wrote: + static int alloc_magic_pages(struct xc_dom_image *dom) { > int rc, i; @@ -100,6 +141,16 @@ static int alloc_magic_pages(struct xc_dom_image *dom) xc_hvm_param_set(dom->xch, dom->gu

Re: [Xen-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-27 Thread Juergen Gross
On 17/06/16 13:14, Juergen Gross wrote: > The qdisk implementation is using the native xenbus protocol only in > case of no protocol specified at all. As using the explicit 32- or > 64-bit protocol is slower than the native one due to copying requests > not by memcpy but element for element, this i

Re: [Xen-devel] [PATCH V2 01/10] arm/gic-v3: Fix bug in function cmp_rdist()

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The cmp_rdist() is always returning value zero irrespective of the input Redistributor base addresses. Both the local variables 'l' and 'r' are pointing to the first argument 'a' causing the logical expression 'l->base < r->base' always ev

Re: [Xen-devel] [PATCH V2 02/10] arm/gic-v3: Do early GICD ioremap and clean up

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: For ACPI based XEN boot, the GICD region needs to be accessed inside the function gicv3_acpi_init() in later pacth. There is a duplicate s/pachth/patch/ panic() message, one in the DTS probe and second one in the ACPI probe path. For t

Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

2016-06-27 Thread Xu, Quan
On June 27, 2016 4:17 PM, Jan Beulich wrote: > >>> On 24.06.16 at 07:51, wrote: > > --- a/xen/drivers/passthrough/x86/ats.c > > +++ b/xen/drivers/passthrough/x86/ats.c > > @@ -22,26 +22,34 @@ LIST_HEAD(ats_devices); bool_t __read_mostly > > ats_enabled = 0; boolean_param("ats", ats_enabled); >

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Julien Grall
Hi Shanker, Title: I think you want to say "Move GICR..." rather than "Fold GICR...". On 26/06/16 18:48, Shanker Donthineni wrote: Add a new function for parsing GICR subtable and move the code Add a new function to parse GICR... that is specific to GICR table to new function without changi

[Xen-devel] Xen 4.3, armhf, ocamlopt, wheezy

2016-06-27 Thread Ian Jackson
Since around January we have been testing our Xen 4.3 stable branches (which still receive security support until very soon) with a version of Debian which was current when 4.3 was also current - ie, wheezy. Debian wheezy has an `ocaml-nox' package, but it does not contain `ocamlopt' on armhf. Th

[Xen-devel] [xen-unstable-smoke test] 96307: trouble: blocked/broken/pass

2016-06-27 Thread osstest service owner
flight 96307 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96307/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 3 host-install(3) broken REGR. vs.

Re: [Xen-devel] [PATCH V2 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The redistributor address can be specified either as part of GICC or GICR subtable depending on the power domain. The current driver doesn't support parsing redistributor entry that is defined in GICC subtable. The GIC CPU subtable entry h

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

2016-06-27 Thread Boris Ostrovsky
On 06/27/2016 06:29 AM, Julien Grall wrote: (CC Boris and Doug) Hi Shannon, On 27/06/16 07:01, Shannon Zhao wrote: On 2016/6/24 1:03, Julien Grall wrote: On 23/06/16 04:16, Shannon Zhao wrote: [...] diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 264b6ef..5347480 100644 --

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-06-27 Thread Boris Ostrovsky
On 06/27/2016 06:49 AM, Julien Grall wrote: (CC Boris) On 27/06/16 07:25, Shannon Zhao wrote: On 2016/6/24 2:46, Julien Grall wrote: + static int alloc_magic_pages(struct xc_dom_image *dom) { > int rc, i; @@ -100,6 +141,16 @@ static int alloc_magic_pages(struct xc_dom_image

[Xen-devel] [qemu-upstream-4.3-testing test] 96301: regressions - FAIL

2016-06-27 Thread osstest service owner
flight 96301 qemu-upstream-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96301/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 80927 build-i

Re: [Xen-devel] [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The number of Re-distributor regions allowed for dom0 is hardcoded s/Re-distributor/Redistributor/ to a compile time macro MAX_RDIST_COUNT which is 4. On some systems, s/a compile time macro/a define/ s/On some/Some/ especially lat

[Xen-devel] making xenstore domain easy configurable

2016-06-27 Thread Juergen Gross
I'm just writing some patches to make it easy to switch between xenstore daemon and xenstore domain. My plan is to achieve this by a global configuration file containing configuration options for the host (e.g. /etc/xen/xen.conf). With the current systemd support this is not easy. There are system

Re: [Xen-devel] [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region

2016-06-27 Thread Andrew Cooper
>> to a compile time macro MAX_RDIST_COUNT which is 4. On some systems, > > s/a compile time macro/a define/ > s/On some/Some/ > >> especially latest server chips might have more than 4 redistributors. > > I would add a comma after 'chips'. In English, rules for dual commas forming a subclause li

Re: [Xen-devel] [PATCH V2 07/10] arm: vgic: Split vgic_domain_init() functionality into two functions

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: Separate the code logic that does the registration of vgic_v3/v2 ops to a new fucntion domain_vgic_register(). The intention of this s/fucntion/function/ separation is to record the required mmio count in vgic_v3/v2_init() and pass it

Re: [Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-27 Thread Xu, Quan
On June 27, 2016 4:24 PM, Jan Beulich wrote: > >>> On 24.06.16 at 07:51, wrote: > > @@ -199,24 +199,73 @@ static int __must_check > queue_invalidate_wait(struct iommu *iommu, > > return -EOPNOTSUPP; > > } > > > > -static int __must_check invalidate_sync(struct iommu *iommu, > > -

Re: [Xen-devel] making xenstore domain easy configurable

2016-06-27 Thread Andrew Cooper
On 27/06/16 13:43, Juergen Gross wrote: > I'm just writing some patches to make it easy to switch between > xenstore daemon and xenstore domain. My plan is to achieve this > by a global configuration file containing configuration options > for the host (e.g. /etc/xen/xen.conf). > > With the current

Re: [Xen-devel] making xenstore domain easy configurable

2016-06-27 Thread Juergen Gross
On 27/06/16 14:59, Andrew Cooper wrote: > On 27/06/16 13:43, Juergen Gross wrote: >> I'm just writing some patches to make it easy to switch between >> xenstore daemon and xenstore domain. My plan is to achieve this >> by a global configuration file containing configuration options >> for the host

Re: [Xen-devel] [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
On 06/27/2016 04:33 PM, Bob Liu wrote: > Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() > during > migration, but that's too later after multi-queue introduced. > > After a migrate to another host (which may not have multiqueue support), the > number of rings (block ha

Re: [Xen-devel] xc_domain_maximum_gpfn

2016-06-27 Thread sepanta s
On Sun, Jun 26, 2016 at 5:19 PM, sepanta s wrote: > Hi, > what exactly does this module do? > sorry, not module but the function. > I have got about 1 million after calling this function for a domain with 1 > Gigabyte ram and page size 4K. If the output of the function is the whole > gfns in a

Re: [Xen-devel] [PATCH V2 09/10] xen/arm: io: Use binary search for mmio handler lookup

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: As the number of I/O handlers increase, the overhead associated with linear lookup also increases. The system might have maximum of 144 (assuming CONFIG_NR_CPUS=128) mmio handlers. In worst case scenario, it would require 144 iterations fo

Re: [Xen-devel] [PATCH V2 10/10] arm/vgic: Change fixed number of mmio handlers to variable number

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 29346c6..b205461 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -111,6 +111,7 @@ struct arch_domain int nr_regions;

Re: [Xen-devel] [PATCH V2 01/10] arm/gic-v3: Fix bug in function cmp_rdist()

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 06:03 AM, Julien Grall wrote: Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The cmp_rdist() is always returning value zero irrespective of the input Redistributor base addresses. Both the local variables 'l' and 'r' are pointing to the first argument 'a' causing the l

[Xen-devel] [xen-unstable-smoke test] 96310: tolerable all pass - PUSHED

2016-06-27 Thread osstest service owner
flight 96310 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96310/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [Xen-users] Binary compatibility report for Xen base libraries

2016-06-27 Thread Ponomarenko Andrey
26.06.2016, 17:42, "Doug Goldstein": >  On 6/24/16 9:21 AM, Ponomarenko Andrey wrote: >>   Hello, >> >>   I maintain a new project for backward compatibility analysis of the Linux >> ABIs. The report for Xen base libraries has been recently added to the >> project: http://abi-laboratory.pro/track

Re: [Xen-devel] [PATCH V2 06/10] arm/gic-v3: Remove an unused macro MAX_RDIST_COUNT

2016-06-27 Thread Julien Grall
On 26/06/16 18:48, Shanker Donthineni wrote: The macro MAX_RDIST_COUNT is not being used after converting code to handle number of redistributor dynamically. So remove it from header file and the two other panic() messages that are not valid anymore. Signed-off-by: Shanker Donthineni Acked-

[Xen-devel] [xen-unstable test] 96296: tolerable FAIL

2016-06-27 Thread osstest service owner
flight 96296 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/96296/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-rumpuserxen 6 xen-buildfail like 96278 build-i386-rumpuserxen

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 06:26 AM, Julien Grall wrote: Hi Shanker, Title: I think you want to say "Move GICR..." rather than "Fold GICR...". On 26/06/16 18:48, Shanker Donthineni wrote: Add a new function for parsing GICR subtable and move the code Add a new function to parse GICR... that is specif

Re: [Xen-devel] [PATCH V2 08/10] arm/io: Use separate memory allocation for mmio handlers

2016-06-27 Thread Julien Grall
Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The number of mmio handlers are limited to a compile time macro MAX_IO_HANDLER which is 16. This number is not at all sufficient to support per CPU distributor regions. Either it needs to be increased to a bigger number, at least CONFIG_NR

Re: [Xen-devel] Elaboration of "Question about sharing spinlock_t among VMs in Xen"

2016-06-27 Thread Konrad Rzeszutek Wilk
On Sun, Jun 26, 2016 at 10:44:53PM -0400, Dagaen Golomb wrote: > I wanted some elaboration on this question and answer posted recently. > > On 06/13/2016 01:43 PM, Meng Xu wrote: > >> Hi, > >> > >> I have a quick question about using the Linux spin_lock() in Xen > >> environment to protect some ho

Re: [Xen-devel] [PATCH V2 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 06:47 AM, Julien Grall wrote: Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The redistributor address can be specified either as part of GICC or GICR subtable depending on the power domain. The current driver doesn't support parsing redistributor entry that is defined

Re: [Xen-devel] [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 07:38 AM, Julien Grall wrote: Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: The number of Re-distributor regions allowed for dom0 is hardcoded s/Re-distributor/Redistributor/ to a compile time macro MAX_RDIST_COUNT which is 4. On some systems, s/a compile time m

Re: [Xen-devel] [PATCH V2 09/10] xen/arm: io: Use binary search for mmio handler lookup

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 08:31 AM, Julien Grall wrote: Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: As the number of I/O handlers increase, the overhead associated with linear lookup also increases. The system might have maximum of 144 (assuming CONFIG_NR_CPUS=128) mmio handlers. In worst ca

Re: [Xen-devel] [PATCH V2 10/10] arm/vgic: Change fixed number of mmio handlers to variable number

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 08:35 AM, Julien Grall wrote: Hi Shanker, On 26/06/16 18:48, Shanker Donthineni wrote: diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 29346c6..b205461 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -111,6 +111,7 @@

Re: [Xen-devel] [PATCH V2 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable

2016-06-27 Thread Julien Grall
On 27/06/16 15:17, Shanker Donthineni wrote: static int __init +gic_acpi_parse_cpu_redistributor(struct acpi_subtable_header *header, + const unsigned long end) +{ +struct acpi_madt_generic_interrupt *processor; +u32 size; + +processor = (struct acpi

Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 13:11, wrote: > On June 27, 2016 4:17 PM, Jan Beulich wrote: >> >>> On 24.06.16 at 07:51, wrote: >> > @@ -98,7 +104,13 @@ void disable_ats_device(int seg, int bus, int >> > devfn) >> >> For symmetry reasons this function would also get converted to taking const >> struct pci_

Re: [Xen-devel] [PATCH v12 6/6] vt-d: fix vt-d Device-TLB flush timeout issue

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 14:56, wrote: > On June 27, 2016 4:24 PM, Jan Beulich wrote: >> >>> On 24.06.16 at 07:51, wrote: >> > @@ -199,24 +199,73 @@ static int __must_check >> queue_invalidate_wait(struct iommu *iommu, >> > return -EOPNOTSUPP; >> > } >> > >> > -static int __must_check invalidate

Re: [Xen-devel] [PATCH 18/19] xen: credit2: implement SMT support independent runq arrangement

2016-06-27 Thread anshul makkar
On 18/06/16 00:13, Dario Faggioli wrote: In fact, right now, we recommend keepeing runqueues arranged per-core, so that it is the inter-runqueue load balancing code that automatically spreads the work in an SMT friendly way. This means that any other runq arrangement one may want to use falls sho

Re: [Xen-devel] Elaboration of "Question about sharing spinlock_t among VMs in Xen"

2016-06-27 Thread Dagaen Golomb
>> >> *** The question is as follows *** >> >> Suppose I have two Linux VMs sharing the same spinlock_t lock (through >> >> the sharing memory) on the same host. Suppose we have one process in >> >> each VM. Each process uses the linux function spin_lock(&lock) [1] to >> >> grab & release the lock.

Re: [Xen-devel] [PATCH V2 09/10] xen/arm: io: Use binary search for mmio handler lookup

2016-06-27 Thread Julien Grall
Hi Shanker, On 27/06/16 15:50, Shanker Donthineni wrote: On 06/27/2016 08:31 AM, Julien Grall wrote: On 26/06/16 18:48, Shanker Donthineni wrote: As the number of I/O handlers increase, the overhead associated with linear lookup also increases. The system might have maximum of 144 (assuming CO

Re: [Xen-devel] Xen 4.3, armhf, ocamlopt, wheezy

2016-06-27 Thread Jan Beulich
>>> On 27.06.16 at 13:29, wrote: > Since around January we have been testing our Xen 4.3 stable branches > (which still receive security support until very soon) with a version > of Debian which was current when 4.3 was also current - ie, wheezy. > > Debian wheezy has an `ocaml-nox' package, but

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Ian Jackson
Jim Fehlig writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > I think that is a good idea too. I've sent a patch setting > LIBXL_API_VERSION to 0x040200 > > https://www.redhat.com/archives/libvir-list/2016-April/msg00771.html It s

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 06:26 AM, Julien Grall wrote: Hi Shanker, Title: I think you want to say "Move GICR..." rather than "Fold GICR...". On 26/06/16 18:48, Shanker Donthineni wrote: Add a new function for parsing GICR subtable and move the code Add a new function to parse GICR... that is specif

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Julien Grall
On 27/06/16 16:40, Shanker Donthineni wrote: +gicv3.rdist_regions = rdist_regs; + +/* Parse always-on power domain Re-distributor entries */ +count = acpi_parse_entries(ACPI_SIG_MADT, + sizeof(struct acpi_table_madt), + gic_acpi_parse_madt_redistributor

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Ian Jackson
(Adding Jan Beulich) Ian Jackson writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > It seems that the libvirt LIBXL_API_VERSION is now rather higher, at > 0x040400, since libvirt#fccf27253ced > libxl: switch to using libxl_domain

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > (Adding Jan Beulich) > > Ian Jackson writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver > breakage -- where to define LIBXL_API_VERSION?"): > > It seems that the libvirt LIBXL_API_VERSION is now rather higher, at > > 0x0

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Shanker Donthineni
be On 06/27/2016 10:41 AM, Julien Grall wrote: On 27/06/16 16:40, Shanker Donthineni wrote: +gicv3.rdist_regions = rdist_regs; + +/* Parse always-on power domain Re-distributor entries */ +count = acpi_parse_entries(ACPI_SIG_MADT, + sizeof(struct acp

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Julien Grall
On 27/06/16 17:07, Shanker Donthineni wrote: On 06/27/2016 10:41 AM, Julien Grall wrote: On 27/06/16 16:40, Shanker Donthineni wrote: +gicv3.rdist_regions = rdist_regs; + +/* Parse always-on power domain Re-distributor entries */ +count = acpi_parse_entries(ACPI_SIG_MADT, +

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Ian Jackson
Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > > Created the following branch refs on xenbits in the toplevel > > libvirt.git: > > > > osstest/f

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Shanker Donthineni
On 06/27/2016 11:09 AM, Julien Grall wrote: On 27/06/16 17:07, Shanker Donthineni wrote: On 06/27/2016 10:41 AM, Julien Grall wrote: On 27/06/16 16:40, Shanker Donthineni wrote: +gicv3.rdist_regions = rdist_regs; + +/* Parse always-on power domain Re-distributor entries */ +cou

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2016 at 05:12:52PM +0100, Ian Jackson wrote: > Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl > driver breakage -- where to define LIBXL_API_VERSION?"): > > On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > > > Created the following branch

Re: [Xen-devel] [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

2016-06-27 Thread Julien Grall
On 27/06/16 17:17, Shanker Donthineni wrote: On 06/27/2016 11:09 AM, Julien Grall wrote: On 27/06/16 17:07, Shanker Donthineni wrote: On 06/27/2016 10:41 AM, Julien Grall wrote: On 27/06/16 16:40, Shanker Donthineni wrote: +gicv3.rdist_regions = rdist_regs; + +/* Parse always-on pow

Re: [Xen-devel] [libvirt] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

2016-06-27 Thread Jim Fehlig
On 06/27/2016 10:12 AM, Ian Jackson wrote: Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: Created the following branch refs on xenbits in the topl

[Xen-devel] [xen-4.3-testing test] 96304: regressions - FAIL

2016-06-27 Thread osstest service owner
flight 96304 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/96304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 87893 build-amd64-libvi

[Xen-devel] [ovmf test] 96298: regressions - FAIL

2016-06-27 Thread osstest service owner
flight 96298 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/96298/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-amd64-

[Xen-devel] [PATCH v4 03/16] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn

2016-06-27 Thread Julien Grall
The correct acronym for a guest physical frame is gfn. Also use the typesafe gfn to ensure that a guest frame is effectively used. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by Changes in v2: - Remove extra pair of

[Xen-devel] [PATCH v4 05/16] xen/mm: Introduce INVALID_GFN_T and INVALID_MFN_T

2016-06-27 Thread Julien Grall
The two new defines will be a typesafe version of resp. INVALID_GFN and INVALID_MFN. Signed-off-by: Julien Grall --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Changes in v4:

[Xen-devel] [PATCH v4 01/16] xen: Use typesafe gfn/mfn in guest_physmap_* helpers

2016-06-27 Thread Julien Grall
Also rename some variables to gfn or mfn when it does not require much rework. Finally replace %hu with %d when printing the domain id in guest_physmap_add_entry (arch/x86/mm/p2m.c). Signed-off-by: Julien Grall Acked-by: Jan Beulich Acked-by: Stefano Stabellini --- Cc: Stefano Stabellini Cc:

[Xen-devel] [PATCH v4 04/16] xen: Use the typesafe mfn and gfn in map_mmio_regions...

2016-06-27 Thread Julien Grall
to avoid mixing machine frame with guest frame. Signed-off-by: Julien Grall Acked-by: Jan Beulich --- Cc: Stefano Stabellini Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Konrad Rzeszutek Wilk Cc: Tim Deegan Cc: Wei Liu Changes in v3: - Use mfn_add

[Xen-devel] [PATCH v4 06/16] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn

2016-06-27 Thread Julien Grall
The prototype and the declaration of p2m_lookup disagree on how the function should be used. One expect a frame number whilst the other an address. Thankfully, everyone is using with an address today. However, most of the callers have to convert a guest frame to an address. Modify the interface to

[Xen-devel] [PATCH v4 00/16] xen/arm: Use the typesafes gfn and mfn

2016-06-27 Thread Julien Grall
Hello all, Some of the ARM functions are mixing gfn vs mfn and even physical vs frame. To avoid more confusion, this patch series makes use of the terminology described in xen/include/xen/mm.h and the associated typesafe. This series requires the patch [1] to be applied beforehand. I pushed a br

[Xen-devel] [PATCH v4 08/16] xen: Replace _mfn(INVALID_MFN) with MFN_INVALID_T

2016-06-27 Thread Julien Grall
This patch is a mechanical replacement. Command used: 42sh> ack -l "_mfn\(INVALID_MFN\)" | xargs sed -i -e 's/_mfn(INVALID_MFN)/INVALID_MFN_T/g' Signed-off-by: Julien Grall --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Jun Nakajima Cc: Kevin Tian Cc: Tim Deegan Change

[Xen-devel] [PATCH v4 13/16] xen/arm: Use the typesafes mfn and gfn in map_regions_rw_cache ...

2016-06-27 Thread Julien Grall
to avoid mixing machine frame with guest frame. Also rename the parameters of the function and drop pointless PAGE_MASK in the caller. Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/domain_build.c | 8 xen/arch/arm/p2m.c | 20 +++

[Xen-devel] [PATCH v4 14/16] xen/arm: p2m: Introduce helpers to insert and remove mapping

2016-06-27 Thread Julien Grall
More the half of the arguments of INSERT and REMOVE are the same for each callers. Simplify the callers of apply_p2m_changes by adding new helpers which will fill common arguments with default values. Acked-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/p2m.c | 7

[Xen-devel] [PATCH v4 09/16] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access

2016-06-27 Thread Julien Grall
The parameter 'access' is used by memaccess to restrict temporarily the permission. This parameter should not be used for other purpose (such as restricting permanently the permission). The type p2m_mmio_direct will map the region Read-Write and non-executable. Note that this is already the curren

[Xen-devel] [PATCH v4 10/16] xen/arm: dom0_build: Remove dead code in allocate_memory

2016-06-27 Thread Julien Grall
The code to allocate memory when dom0 does not use direct mapping is relying on the presence of memory node in the DT. However, they are not present when booting using UEFI or when using ACPI. Rather than fixing the code, remove it because dom0 is always direct memory mapped and therefore the cod

[Xen-devel] [PATCH v4 12/16] xen/arm: Use the typesafes mfn and gfn in map_dev_mmio_region...

2016-06-27 Thread Julien Grall
to avoid mixing machine frame with guest frame. Also drop the prefix start_. Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/mm.c | 2 +- xen/arch/arm/p2m.c| 10 +- xen/include/asm-arm/p2m.h | 4 ++-- 3 files changed, 8 inserti

[Xen-devel] [PATCH v4 15/16] xen/arm: p2m: Use typesafe gfn for {max, lowest}_mapped_gfn

2016-06-27 Thread Julien Grall
Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/mm.c | 2 +- xen/arch/arm/p2m.c| 18 +- xen/include/asm-arm/p2m.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/ar

[Xen-devel] [PATCH v4 16/16] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe

2016-06-27 Thread Julien Grall
Most of the callers of apply_p2m_changes have a GFN, a MFN and the number of frame to change in hand. Rather than asking each caller to convert the frame to an address, rework the interfaces to pass the GFN, MFN and the number of frame. Note that it would be possible to do more clean-up in apply_

[Xen-devel] [PATCH v4 11/16] xen/arm: p2m: Remove unused operation ALLOCATE

2016-06-27 Thread Julien Grall
The operation ALLOCATE is unused. If we ever need it, it could be reimplemented with INSERT. Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/p2m.c| 67 ++- xen/include/asm-arm/p2m.h | 3 --- 2 files c

  1   2   >