[Xen-devel] [PATCH v11 0/2] libxl: add support for pvscsi, iteration 11

2016-04-08 Thread Olaf Hering
Port vscsi=[] and scsi-{attach,detach,list} commands from xend to libxl. libvirt uses its existing SCSI support: http://lists.xenproject.org/archives/html/xen-devel/2015-04/msg02963.html targetcli/rtslib has to be aware of xen-scsiback (upstream unresponsive): http://article.gmane.org/gmane.linux

[Xen-devel] [PATCH v11 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-04-08 Thread Olaf Hering
Just to make them public, not meant for merging: The scripts used during development to create a bunch of SCSI devices in dom0 using the Linux target framework. targetcli3 and rtslib3 is used. A patch is required for python-rtslib: http://article.gmane.org/gmane.linux.scsi.target.devel/8146 Signe

[Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- docs/man/xl.cfg.pod.5| 56 ++ docs/man/xl.pod.1

[Xen-devel] [PATCH] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Razvan Cojocaru
It is meaningless (and potentially dangerous - see hvmemul_virtual_to_linear()) to set mem_access_emulate_each_rep before xc_monitor_enable() (which allocates vcpu->arch.vm_event) has been called, so return an error from the XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP hypercall when that is the case. S

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 08:56, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >> On 08/04/16 08:29, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: > This highlights a semantic gap issue.

Re: [Xen-devel] [PATCH v10 4/5] libxl: add support for vscsi

2016-04-08 Thread Olaf Hering
On Fri, Apr 01, Ian Jackson wrote: > > +static int xlu__vscsi_parse_dev(XLU_Config *cfg, char *pdev, > > libxl_vscsi_hctl *hctl) > > +{ > > +struct stat dentry; > > +char *sysfs = NULL; > > +const char *type; > > +int rc, found = 0; > > +DIR *dirp; > > +struct dirent *de;

Re: [Xen-devel] [PATCH] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Razvan Cojocaru
On 04/08/16 10:10, Razvan Cojocaru wrote: > It is meaningless (and potentially dangerous - see > hvmemul_virtual_to_linear()) > to set mem_access_emulate_each_rep before xc_monitor_enable() (which allocates > vcpu->arch.vm_event) has been called, so return an error from the > XEN_DOMCTL_MONITOR_OP

Re: [Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-04-08 Thread Dario Faggioli
On Fri, 2016-04-08 at 06:18 +0200, Juergen Gross wrote: > On 08/04/16 03:24, Dario Faggioli wrote: > > > > In fact, credit2 uses CPU topology to decide how to arrange > > its internal runqueues. Before this change, only 'one runqueue > > per socket' was allowed. However, experiments have shown tha

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Luis R. Rodriguez
On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: > On 08/04/16 08:56, Luis R. Rodriguez wrote: >> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: >>> On 08/04/16 08:29, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: > On 08/04/16 02:32, Luis R.

Re: [Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-04-08 Thread Juergen Gross
On 08/04/16 09:35, Dario Faggioli wrote: > On Fri, 2016-04-08 at 06:18 +0200, Juergen Gross wrote: >> On 08/04/16 03:24, Dario Faggioli wrote: >>> >>> In fact, credit2 uses CPU topology to decide how to arrange >>> its internal runqueues. Before this change, only 'one runqueue >>> per socket' was a

Re: [Xen-devel] [PATCH v2 01/10] libxl_pci: improve return codes for more xl commands

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > Return error code instead of always 0. Remove assigned-only ret > variable. > > Signed-off-by: Paulina Szubarczyk > > --- > I think a better subject would be:  "libxl: improve return codes for some pci related functions" or somethi

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Juergen Gross
On 08/04/16 09:36, Luis R. Rodriguez wrote: > On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: >> On 08/04/16 08:56, Luis R. Rodriguez wrote: >>> On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: On 08/04/16 08:29, Luis R. Rodriguez wrote: > On Thu, Apr 7, 2016 at 10:18 PM, Juer

Re: [Xen-devel] Does __KERNEL_DS serve a purpose?

2016-04-08 Thread Andrew Cooper
On 08/04/2016 01:24, Andy Lutomirski wrote: > I can't see any reason that we need the __KERNEL_DS segment at all -- > I think that everything that uses __KERNEL_DS could use __USER_DS > instead. Am I missing anything? This has been bugging me for a > while. > > I mulled over this a bit when tryin

Re: [Xen-devel] [PATCH v2 02/10] libxl-pci: removing the extra 'out_closedir' cleaning path

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > Signed-off-by: Paulina Szubarczyk > > --- > Changed since v1: >  * Modify the libxl_device_pci_assignable_list() function to use >    only one 'out' cleaning path. > So, the patch does quite a few style cleanups. This is indeed a good

Re: [Xen-devel] [PATCH] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Andrew Cooper
On 08/04/2016 08:16, Razvan Cojocaru wrote: > On 04/08/16 10:10, Razvan Cojocaru wrote: >> It is meaningless (and potentially dangerous - see >> hvmemul_virtual_to_linear()) >> to set mem_access_emulate_each_rep before xc_monitor_enable() (which >> allocates >> vcpu->arch.vm_event) has been calle

Re: [Xen-devel] [PATCH v2 03/10] libxl: fix return value of libxl__device_pci_destroy_all

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > Return rc value instead of always 0. > I'd say "Propagate the error, insetad of always returning 0", but yeah, this is nitpicking! :-P Also, not my call, but I'd include this change inside of patch 1: both are simple enough that they

Re: [Xen-devel] [PATCH v2 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -3391,15 +3391,15 @@ static int set_memory_max(uint32_t domid, > const char *mem) >  memorykb = parse_mem_size_kb(mem); >  if (memorykb == -1) { >  fpr

Re: [Xen-devel] [PATCH v2 06/10] xl_cmdimpl: improve return codes for cd-insert commands

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: >  - Use EXIT_{SUCCESS,FAILURE} for main_cd*() function >  - Use 0/1 as return values of cd_insert function > Done already by commit 04119085f5a2a135e5161535b8821e1aa0d7db8a. Regards, Dario -- <> (Raistlin Majere) -

Re: [Xen-devel] [PATCH] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Razvan Cojocaru
On 04/08/16 11:17, Andrew Cooper wrote: > On 08/04/2016 08:16, Razvan Cojocaru wrote: >> On 04/08/16 10:10, Razvan Cojocaru wrote: >>> It is meaningless (and potentially dangerous - see >>> hvmemul_virtual_to_linear()) >>> to set mem_access_emulate_each_rep before xc_monitor_enable() (which >>> a

Re: [Xen-devel] [PATCH v2 07/10] xl_cmdimpl - Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove.

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:46 +0200, Paulina Szubarczyk wrote: > From: George Dunlap > > Returning error codes makes it easier for shell scripts to tell if a > command has failed or succeeded. > > NB this violates the CODING_STYLE preference for not initializing the > return-value variable at decl

[Xen-devel] [linux-linus test] 89304: regressions - FAIL

2016-04-08 Thread osstest service owner
flight 89304 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/89304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 59254 build-amd64-rumpuserx

[Xen-devel] Question about the XEN platform pci

2016-04-08 Thread Wu, Bob
Sorry bother, I read the XEN source code recently, and found the XEN platform PCI code under drivers/xen/platform-pci.c, and I can't fully under this driver's affect, can anybody explain a little for me? Is the platform PCI driver for PV-split-PCI-driver-model such as the pci-frontend/pci-back

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Juergen Gross
On 08/04/16 09:01, Olaf Hering wrote: > Port pvscsi support from xend to libxl: > > vscsi=['pdev,vdev{,options}'] > xl scsi-attach > xl scsi-detach > xl scsi-list > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu Reviewed-by: Juer

Re: [Xen-devel] abstract model of IOMMU unmaping/mapping failures

2016-04-08 Thread Xu, Quan
On April 08, 2016 6:44am, wrote: > >>> On 06.04.16 at 09:38, wrote: > > On April 01, 2016 7:57pm, wrote: > >> >>> On 31.03.16 at 11:06, wrote: > >> > 4. __gnttab_unmap_common():rollback (no change) > >> > > >> > (Existing code) > >> >>>... > >> > if ( !kind ) > >> >

Re: [Xen-devel] [PATCH v2 10/10] libxl: libxl_tmem functions improving coding style

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:46 +0200, Paulina Szubarczyk wrote: > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -6238,14 +6238,14 @@ uint32_t libxl_vm_get_start_time(libxl_ctx > *ctx, uint32_t domid) >   >  char *libxl_tmem_list(libxl_ctx *ctx, uint32_t domid, int use_long) >  { > -in

[Xen-devel] [linux-3.16 test] 89328: regressions - FAIL

2016-04-08 Thread osstest service owner
flight 89328 linux-3.16 real [real] http://logs.test-lab.xenproject.org/osstest/logs/89328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. 85048 Tests which are

Re: [Xen-devel] [PATCH v2 08/10] libxl: improve main_tmem_* return codes

2016-04-08 Thread Dario Faggioli
On Wed, 2016-04-06 at 13:46 +0200, Paulina Szubarczyk wrote: > Functions libxl_tmem_freeze(), libxl_tmem_thaw(), libxl_tmem_set() > and > libxl_tmem_shared_auth() located in libxl.c file return > ERROR_FAIL/ERROR_INVAL or internal error codes from libxc library > improve main_tmem_* return codes by

Re: [Xen-devel] [PATCH v2 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-08 Thread Paulina Szubarczyk
On Fri, 2016-04-08 at 10:26 +0200, Dario Faggioli wrote: > On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > > --- a/tools/libxl/xl_cmdimpl.c > > +++ b/tools/libxl/xl_cmdimpl.c > > @@ -3391,15 +3391,15 @@ static int set_memory_max(uint32_t domid, > > const char *mem) > > memorykb

[Xen-devel] [PATCH for-4.7 v3 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

2016-04-08 Thread Andrew Cooper
The existing vIOPL interface is hard to use, and need not be. Introduce a VMASSIST with which a guest can opt-in to having vIOPL behaviour consistenly with native hardware. Specifically: - virtual iopl updated from do_iret() hypercalls. - virtual iopl reported in bounce frames. - guest kernels

Re: [Xen-devel] [PATCH v2 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-08 Thread Dario Faggioli
On Fri, 2016-04-08 at 11:04 +0200, Paulina Szubarczyk wrote: > On Fri, 2016-04-08 at 10:26 +0200, Dario Faggioli wrote: > > Mmmm.. I see no reason why this can't remain exit(). In fact, it > > should > > be turned int exit(EXIT_FAILURE), and there's Harmandeep's series > > -- > > just resubmitted b

Re: [Xen-devel] [PATCH v3] arm: Fix asynchronous aborts (SError exceptions) due to bogus PTEs

2016-04-08 Thread Julien Grall
On 06/04/16 19:57, Shanker Donthineni wrote: Hi Julien/Stefano, Hi Shanker, Any other comments to be addressed? Please propose an alternative solution to fix the problem if this patch changes are not appropriate. All the comments have been addressed. On 03/28/2016 11:46 PM, Shanker Do

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-08 Thread Roger Pau Monné
On Fri, 8 Apr 2016, Bob Liu wrote: > > On 04/07/2016 11:55 PM, Juergen Gross wrote: > > On 07/04/16 12:00, Bob Liu wrote: > >> * What's data integrity extension and why? > >> Modern filesystems feature checksumming of data and metadata to protect > >> against > >> data corruption. However, the d

[Xen-devel] [ovmf test] 89340: regressions - FAIL

2016-04-08 Thread osstest service owner
flight 89340 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/89340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-amd64-xl-qemuu-ov

Re: [Xen-devel] [PATCH v3 1/6] xl: improve return and exit codes of memory related functions

2016-04-08 Thread Dario Faggioli
On Fri, 2016-04-08 at 04:23 +0200, Dario Faggioli wrote: >  > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -3391,7 +3396,7 @@ static int set_memory_max(uint32_t domid, const > char *mem) >  memorykb = parse_mem_size_kb(mem); >  if (memorykb == -1) { >  fprint

Re: [Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-04-08 Thread Dario Faggioli
On Fri, 2016-04-08 at 09:39 +0200, Juergen Gross wrote: > On 08/04/16 09:35, Dario Faggioli wrote: > >  > > A revised version of this patch is provided here (both inlined and > > attached), and a branch with the remaining to be committed patches > > of > > this series, and with this patch changed a

Re: [Xen-devel] Running Xen on Nvidia Jetson-TK1

2016-04-08 Thread Julien Grall
On 07/04/16 08:48, Dushyant Behl wrote: Hello, Hi Dushyant, On Fri, Apr 1, 2016 at 3:34 PM, Julien Grall wrote: Hello Dushyant, On 29/03/16 21:56, Dushyant Behl wrote: On Wed, Mar 30, 2016 at 12:31 AM, Julien Grall wrote: On 24/03/16 11:05, Dushyant Behl wrote: (XEN) DOM0: [

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-08 Thread Bob Liu
On 04/08/2016 05:44 PM, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Bob Liu wrote: >> >> On 04/07/2016 11:55 PM, Juergen Gross wrote: >>> On 07/04/16 12:00, Bob Liu wrote: * What's data integrity extension and why? Modern filesystems feature checksumming of data and metadata to protect

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Olaf Hering
On Fri, Apr 08, Olaf Hering wrote: > +int xlu_vscsi_get_ctrl(XLU_Config *cfg, libxl_ctx *ctx, uint32_t domid, > + const char *str, > + libxl_device_vscsictrl *ctrl, > + libxl_device_vscsidev *dev, > + libxl_dev

Re: [Xen-devel] [PATCH v4 00/14] x86: remove paravirt_enabled

2016-04-08 Thread Borislav Petkov
On Fri, Apr 08, 2016 at 03:14:43AM +0200, Luis R. Rodriguez wrote: > On Wed, Apr 06, 2016 at 05:06:20PM -0700, Luis R. Rodriguez wrote: > > Now that Andy's ASM paravirt_enabled() use is merged > > Sorry I should have provided more context, I meant that now > that Andy's ASM paravirt_enabled() rem

Re: [Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

2016-04-08 Thread Roger Pau Monné
On Thu, 7 Apr 2016, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v2] libxl: replace the usage of uuid_t with a > char array"): > > A thought: maybe it is worth to have a #define LIBXL_HAVE_UNIFIED_UUID > > in libxl.h? > > This is a good idea. > > > /* If this is defined, libxl_uuid is big en

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-08 Thread George Dunlap
Oops -- forgot to CC the list... On Thu, Apr 7, 2016 at 10:55 AM, George Dunlap wrote: > On Thu, Apr 7, 2016 at 8:01 AM, Yu, Zhang wrote: +/* For now, only support for HAP enabled hvm */ +if ( !hap_enabled(d) ) +goto out; >>> >>> >>> So before I suggested that this

Re: [Xen-devel] [PATCH v3 2/5] xentrace: Memory/Page Mapping support for DOMID_XEN on ARM

2016-04-08 Thread Julien Grall
(CC Stefano's new e-mail address) Hello Benjamin, On 04/04/16 19:48, Benjamin Sanda wrote: xen/arch/arm/mm.c | 3 ++- xen/arch/arm/p2m.c | 35 +++ 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 81

[Xen-devel] [distros-debian-squeeze test] 44277: trouble: blocked/broken

2016-04-08 Thread Platform Team regression test user
flight 44277 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44277/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 3 host-install(3) broken RE

Re: [Xen-devel] [PATCH v3 3/5] xentrace: Timestamp support for ARM platform

2016-04-08 Thread Julien Grall
Hello Benjamin, On 04/04/16 19:48, Benjamin Sanda wrote: Moved get_cycles() to time.c and modified to return the core timestamp tick count for use by the trace buffer timestamping routines in xentrace. get_cycles() was moved to the C file to avoid including the register specific header file in t

[Xen-devel] [distros-debian-wheezy test] 44278: tolerable trouble: blocked/broken

2016-04-08 Thread Platform Team regression test user
flight 44278 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44278/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-pvops 3 host-install(3) broken like 44254 build-armhf-pvop

Re: [Xen-devel] [PATCH] tools: handle xl migrate --debug in legacy stream

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 06:31:01PM +0200, Olaf Hering wrote: > Doing a 'xl migrate --debug domU host' on xen-4.5 adds a > XC_SAVE_ID_ENABLE_VERIFY_MODE marker, which is not handled. > Since using --debug is valid usage, handle it by logging the fact > instead of aborting the migration. > > Signed-

Re: [Xen-devel] [PATCH v3 4/5] xentrace: Trace Buffer Initialization on ARM

2016-04-08 Thread Julien Grall
Hello Benjamin, On 04/04/16 19:48, Benjamin Sanda wrote: Added call to init_trace_bufs() to initialize the trace buffers for use by xentrace. Signed-off-by: Benjamin Sanda Acked-by: Julien Grall Regards, -- Julien Grall ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-08 Thread George Dunlap
On 08/04/16 11:10, Yu, Zhang wrote: [snip] > BTW, I noticed your reply has not be CCed to mailing list, and I also > wonder if we should raise this last question in community? Oops -- that was a mistake on my part. :-) I appreciate the discretion; just so you know in the future, if I'm purposely

Re: [Xen-devel] [PATCH v11 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 07:01:31AM +, Olaf Hering wrote: > Just to make them public, not meant for merging: > The scripts used during development to create a bunch of SCSI devices in > dom0 using the Linux target framework. targetcli3 and rtslib3 is used. > > A patch is required for python-rts

Re: [Xen-devel] [PATCH v11 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-04-08 Thread Olaf Hering
On Fri, Apr 08, Wei Liu wrote: > On Fri, Apr 08, 2016 at 07:01:31AM +, Olaf Hering wrote: > > Just to make them public, not meant for merging: > > The scripts used during development to create a bunch of SCSI devices in > > dom0 using the Linux target framework. targetcli3 and rtslib3 is used.

[Xen-devel] [linux-3.18 test] 89339: regressions - FAIL

2016-04-08 Thread osstest service owner
flight 89339 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/89339/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. 86513 test-amd64-amd6

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 07:01:30AM +, Olaf Hering wrote: > Port pvscsi support from xend to libxl: > > vscsi=['pdev,vdev{,options}'] > xl scsi-attach > xl scsi-detach > xl scsi-list > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei

[Xen-devel] x86 patch ping

2016-04-08 Thread Jan Beulich
Andrew, could I please get acks or otherwise on http://lists.xen.org/archives/html/xen-devel/2016-03/msg01469.html http://lists.xen.org/archives/html/xen-devel/2016-03/msg02167.html (with the 1st patch having gone in already) http://lists.xen.org/archives/html/xen-devel/2016-04/msg00040.html T

Re: [Xen-devel] x86 patch ping

2016-04-08 Thread Andrew Cooper
On 08/04/16 13:10, Jan Beulich wrote: > Andrew, > > could I please get acks or otherwise on > > http://lists.xen.org/archives/html/xen-devel/2016-03/msg01469.html > > http://lists.xen.org/archives/html/xen-devel/2016-03/msg02167.html > (with the 1st patch having gone in already) > > http://lists.xe

[Xen-devel] Xen.git freezes today

2016-04-08 Thread Wei Liu
Hi all Committers, please commit all pending feature patch series today. We shall look into stabilising the tree next week and arrange RCs as soon as possible. To committers and contributors, please CC me on patches that wish to go into staging, starting next week. Thanks Wei. _

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 02:29 AM, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 10:18 PM, Juergen Gross wrote: On 08/04/16 02:32, Luis R. Rodriguez wrote: On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: We have 4 types of x86 platform

Re: [Xen-devel] Running Xen on Nvidia Jetson-TK1

2016-04-08 Thread Ian Campbell
On Fri, 2016-04-08 at 11:10 +0100, Julien Grall wrote: > > In your patch for *Hacky* support for Jetsok-TK1 you said that you > > were able to run guests on > > Jetson-tk1 board with Xen. Can I know which kernel version you used as > > dom0 (and possibly domU guests)? I'm afraid I don't remember.

[Xen-devel] [PATCH V2] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Razvan Cojocaru
It is meaningless (and potentially dangerous - see hvmemul_virtual_to_linear()) to set mem_access_emulate_each_rep before xc_monitor_enable() (which allocates vcpu->arch.vm_event) has been called, so return an error from the XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP hypercall when that is the case. S

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-08 Thread Boris Ostrovsky
On 04/08/2016 03:59 AM, Juergen Gross wrote: On 08/04/16 09:36, Luis R. Rodriguez wrote: On Fri, Apr 8, 2016 at 12:13 AM, Juergen Gross wrote: On 08/04/16 08:56, Luis R. Rodriguez wrote: On Thu, Apr 7, 2016 at 11:38 PM, Juergen Gross wrote: Okay. Another idea (not sure whether this is reall

Re: [Xen-devel] [PATCH v3 2/6] xl: improve exit codes of save/restore and migration functions

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:23:39AM +0200, Dario Faggioli wrote: > From: Harmandeep Kaur > > by making them more consistent with other examples in xl. > > Macros CHK_ERRNOVAL, CHK_SYSCALL, MUST are also updated. > > Signed-off-by: Harmandeep Kaur > Signed-off-by: Dario Faggioli Acked-by: Wei

Re: [Xen-devel] [PATCH v3 5/6] xl: make return type of create_domain() more consistent.

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:24:07AM +0200, Dario Faggioli wrote: > create_domain() is of uint32_t return type, because on > success it returns the domid of the new domain, and > uint32_t is what we typically use for domid-s. > > However, on failure, it returns ERROR_FAIL or ERROR_INVAL, > which are

Re: [Xen-devel] [PATCH v3 6/6] xl: improve exit codes of domain creation related functions

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:24:17AM +0200, Dario Faggioli wrote: > by making them more consistent with other examples in xl. > > Signed-off-by: Dario Faggioli > Signed-off-by: Harmandeep Kaur > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > v3: In create_domain(), only deal with exit codes, intern

Re: [Xen-devel] [PATCH v3 1/6] xl: improve return and exit codes of memory related functions

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 11:58:02AM +0200, Dario Faggioli wrote: [...] > commit 43586222084638ec98b693702132f3412a63ddda > Author: Harmandeep Kaur > Date:   Thu Apr 7 12:38:09 2016 +0200 > > xl: improve return and exit codes of memory related functions > > by making them more consiste

Re: [Xen-devel] [PATCH v3 4/6] xl : improve exit codes of debug related functions

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:23:59AM +0200, Dario Faggioli wrote: > From: Harmandeep Kaur > > by making them more consistent with other examples in xl. > > Signed-off-by: Harmandeep Kaur > Signed-off-by: Dario Faggioli Acked-by: Wei Liu ___ Xen-deve

Re: [Xen-devel] [PATCH v3 3/6] xl: improve exit codes of some of the domain handling functions

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:23:50AM +0200, Dario Faggioli wrote: > From: Harmandeep Kaur > > by making them more consistent with other examples in xl. > > Affected functions are the ones related to console, vnc, > dump, destroy, shutdown, list, domid and domname. > > Signed-off-by: Harmandeep Ka

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-08 Thread George Dunlap
On 08/04/16 02:23, Dario Faggioli wrote: > In short, the point is making sure that the actual switch > of scheduler and the remapping of the scheduler's runqueue > lock occur in the same critical section, protected by the > "old" scheduler's lock (and not, e.g., in the free_pdata > hook, as it is n

[Xen-devel] [PATCH 2/6] ARM: xen: Register with kernel restart handler

2016-04-08 Thread Guenter Roeck
Register with kernel restart handler instead of setting arm_pm_restart directly. Select a high priority of 192 to ensure that default restart handlers are replaced if Xen is running. Signed-off-by: Guenter Roeck --- arch/arm/xen/enlighten.c | 13 +++-- 1 file changed, 11 insertions(+),

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-08 Thread George Dunlap
On 08/04/16 13:52, George Dunlap wrote: > On 08/04/16 02:23, Dario Faggioli wrote: >> In short, the point is making sure that the actual switch >> of scheduler and the remapping of the scheduler's runqueue >> lock occur in the same critical section, protected by the >> "old" scheduler's lock (and n

Re: [Xen-devel] [PATCH V2] x86/monitor: Disallow setting mem_access_emulate_each_rep when vm_event is NULL

2016-04-08 Thread Andrew Cooper
On 08/04/16 13:35, Razvan Cojocaru wrote: > It is meaningless (and potentially dangerous - see > hvmemul_virtual_to_linear()) > to set mem_access_emulate_each_rep before xc_monitor_enable() (which allocates > vcpu->arch.vm_event) has been called, so return an error from the > XEN_DOMCTL_MONITOR_OP

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-08 Thread Dario Faggioli
On Fri, 2016-04-08 at 14:00 +0100, George Dunlap wrote: > On 08/04/16 13:52, George Dunlap wrote: > > On 08/04/16 02:23, Dario Faggioli wrote: > > > Signed-off-by: Dario Faggioli > > Thanks! > > > > Reviewed-by: George Dunlap > Committers: > > Hopefully the arinc653 maintainers will get an oppo

Re: [Xen-devel] [PATCH 1/4] libxl: set the device model version earlier in xenstore

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 07:45:26PM +0200, Roger Pau Monne wrote: > So libxl doesn't have to pass the build info around just to get the device > model used by the guest. This allows to simplify > libxl__device_nic_setdefault. > > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Wei Liu I

Re: [Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

2016-04-08 Thread George Dunlap
On 08/04/16 08:35, Dario Faggioli wrote: > On Fri, 2016-04-08 at 06:18 +0200, Juergen Gross wrote: >> On 08/04/16 03:24, Dario Faggioli wrote: >>> >>> In fact, credit2 uses CPU topology to decide how to arrange >>> its internal runqueues. Before this change, only 'one runqueue >>> per socket' was a

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Wei Liu > --- > tools/libxl/libxl.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index 9d785a4..232e2c1 100644

Re: [Xen-devel] [PATCH v2 1/3] x86/ioreq server: Add new functions to get/set memory types.

2016-04-08 Thread Andrew Cooper
On 31/03/16 11:53, Yu Zhang wrote: > For clarity this patch breaks the code to set/get memory types out > of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type(). > Also, for clarity, checks for whether a memory type change is allowed > are broken out into a separate function called by hv

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-08 Thread Andrew Cooper
On 31/03/16 11:53, Yu Zhang wrote: > Previously p2m type p2m_mmio_write_dm was introduced for write- > protected memory pages whose write operations are supposed to be > forwarded to and emulated by an ioreq server. Yet limitations of > rangeset restrict the number of guest pages to be write-protec

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-08 Thread Ian Jackson
Chun Yan Liu writes ("Re: [PATCH 1/4] a fix in libxl_device_usbdev_list"): > On 4/8/2016 at 12:45 AM, in message > <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson > wrote: > > If libxl__device_usbdev_list_for_usbctrl fails, shouldn't > > libxl_device_usbdev_list fail too ? >

Re: [Xen-devel] [PATCH 2/4] libxl: set the backend type to Qdisk for CDROM devices on DM HVM guests

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 07:45:27PM +0200, Roger Pau Monne wrote: > This is needed because the cd-{insert/eject} functions are not prepared to > deal with blkback, which would be used by default if no backend was > specified. > > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Wei Liu Ac

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v6 08/24] xsplice: Add helper elf routines"): > On 07/04/16 17:19, Ian Jackson wrote: > > My understanding of this is that the purpose of this machinery is to > > supply binary runtime patches to the hypervisor. So I think someone > > who can inject malicious xspl

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-08 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 1/4] a fix in libxl_device_usbdev_list"): > We won't fix that bad API pattern for 4.7. So > > Acked-by: Ian Jackson Queued. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/4] libxl: remove code added to use the 'phy' backend with CDROM devices

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 07:45:29PM +0200, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Wei Liu Acked-by: Wei Liu > --- > tools/libxl/libxl_device.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/tools/libxl/libxl_device.c

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-08 Thread Andrew Cooper
On 31/03/16 11:53, Yu Zhang wrote: > A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to > let one ioreq server claim/disclaim its responsibility for the > handling of guest pages with p2m type p2m_ioreq_server. Users > of this HVMOP can specify whether the p2m_ioreq_server is supposed >

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

2016-04-08 Thread Ian Jackson
Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid"): > On 4/8/2016 at 01:04 AM, in message > <22278.37677.975595.101...@mariner.uk.xensource.com>, Ian Jackson > wrote: > > Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of > > usbdev_busad

Re: [Xen-devel] [PATCH V2] bind_usbintf: do not reuse 'path'

2016-04-08 Thread Ian Jackson
Chunyan Liu writes ("[PATCH V2] bind_usbintf: do not reuse 'path'"): > To avoid confusion, use "intf_path" to indicate driver/interface path, > and "bind_path" indicate driver/bind path. > > Signed-off-by: Chunyan Liu > CC: Simon Cao > CC: George Dunlap > CC: Ian Jackson Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH v4 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH ...

2016-04-08 Thread Wei Liu
On Mon, Mar 14, 2016 at 05:55:49PM +, Anthony PERARD wrote: > ... to compile SeaBIOS and OVMF. Only depends on CONFIG_*. > > If --with-system-* configure option is used, then set *_CONFIG=n to not > compile SEABIOS and OVMF. > > Signed-off-by: Anthony PERARD > Acked-by: Wei Liu _

Re: [Xen-devel] [PATCH v4 03/14] configure: #define SEABIOS_PATH and OVMF_PATH

2016-04-08 Thread Wei Liu
On Mon, Mar 14, 2016 at 05:55:38PM +, Anthony PERARD wrote: > Those paths are to be used by libxl, in order to load the firmware in > memory. If a system path is not define via --with-system-seabios or > --with-system-ovmf, then this default to the Xen firmware directory. > > Signed-off-by: An

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-08 Thread Ian Jackson
FYI I have things I want to say in this conversation but today I am concentrating on committing for the 4.7 freeze. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v8 00/28] Add ITS support

2016-04-08 Thread Steve Capper
Hello, We are going to re-examine the design document behind GICv3 ITS within ARM to see if any simplifications can be made. This should, in turn, help us simplify this series somewhat. The revised design document will then be sent to xen-devel for review before we re-examine this series. Cheers,

Re: [Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

2016-04-08 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v2] libxl: replace the usage of uuid_t with a char array"): > What about: > > /* > * LIBXL_HAVE_BYTEARRAY_UUID > * > * If this is defined, the internal member of libxl_uuid is defined > * as a 16 byte array that contains the UUID in big endian format. > *

Re: [Xen-devel] [PATCH] tools: handle xl migrate --debug in legacy stream

2016-04-08 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: handle xl migrate --debug in legacy stream"): > On Thu, Apr 07, 2016 at 06:31:01PM +0200, Olaf Hering wrote: > > Doing a 'xl migrate --debug domU host' on xen-4.5 adds a > > XC_SAVE_ID_ENABLE_VERIFY_MODE marker, which is not handled. > > Since using --debug is v

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v11 1/2] libxl: add support for vscsi"): > What Ian wanted was that we need clear correlation of xl configuration > syntax with libxl API fields. For example, for a FOO device Thanks for explaining, yes. > However, I don't think that can be easily achieved in the case

[Xen-devel] [PATCH v3] libxl: replace the usage of uuid_t with a char array

2016-04-08 Thread Roger Pau Monne
The internals of the uuid_t struct don't match a big endian octet stream on *BSD systems, which means that it cannot be directly casted to a uint8_t[16]. In order to solve that change the type to be an unsigned char[16], which doesn't imply any other change on Linux. On *BSDs change the helpers so

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-08 Thread Robert VanVossen
On 4/8/2016 9:11 AM, Dario Faggioli wrote: > On Fri, 2016-04-08 at 14:00 +0100, George Dunlap wrote: >> On 08/04/16 13:52, George Dunlap wrote: >>> On 08/04/16 02:23, Dario Faggioli wrote: Signed-off-by: Dario Faggioli >>> Thanks! >>> >>> Reviewed-by: George Dunlap >> Committers: >> >> Hop

Re: [Xen-devel] [PATCH v6 1/6] libxl: handle error from libxl__need_xenpv_qemu() correctly

2016-04-08 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v6 1/6] libxl: handle error from libxl__need_xenpv_qemu() correctly"): > On Thu, Mar 31, 2016 at 07:49:01AM +0200, Juergen Gross wrote: > > In case libxl__need_xenpv_qemu() returns an error let domain creation > > fail. > > > > Signed-off-by: Juergen Gross > > Acked-

Re: [Xen-devel] Regarding Outreachy project on Improving CR Dashboard

2016-04-08 Thread Priya
Hello, I tried running the same command in new version of perceval. I found the following missing message id errors in perceval_mbox_parse.log file. I am working on the testing part and I will be able to finish it in one or two days. You can see the errors here [1] [1]:http://imgur.com/yVsIoCT

Re: [Xen-devel] [PATCH v3 01/11] xen: sched: make implementing .alloc_pdata optional

2016-04-08 Thread Robert VanVossen
On 4/7/2016 9:23 PM, Dario Faggioli wrote: > The .alloc_pdata scheduler hook must, before this change, > be implemented by all schedulers --even those ones that > don't need to allocate anything. > > Make it possible to just use the SCHED_OP(), like for > the other hooks, by using ERR_PTR() and

Re: [Xen-devel] [PATCH v3] libxl: replace the usage of uuid_t with a char array

2016-04-08 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3] libxl: replace the usage of uuid_t with a char array"): > The internals of the uuid_t struct don't match a big endian octet stream on > *BSD systems, which means that it cannot be directly casted to a > uint8_t[16]. > > In order to solve that change the type to

Re: [Xen-devel] [PATCH] tools: handle xl migrate --debug in legacy stream

2016-04-08 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] tools: handle xl migrate --debug in legacy stream"): > On 07/04/16 17:31, Olaf Hering wrote: > > Doing a 'xl migrate --debug domU host' on xen-4.5 adds a > > XC_SAVE_ID_ENABLE_VERIFY_MODE marker, which is not handled. > > Since using --debug is valid usage, handl

Re: [Xen-devel] [PATCH v3 0/6] xl: convert exit codes related to domain subcommands to EXIT_[SUCCESS|FAILURE]

2016-04-08 Thread Ian Jackson
Dario Faggioli writes ("[PATCH v3 0/6] xl: convert exit codes related to domain subcommands to EXIT_[SUCCESS|FAILURE]"): > This is about using EXIT_SUCCESS or EXIT_FAILURE when calling > exit(), in xl. main_foo() functions are treated as they were > main(), and so they also return EXIT_SUCCESS or

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-08 Thread George Dunlap
On 07/04/16 19:51, Luis R. Rodriguez wrote: > While Andrew's position is right in that perhaps only Xen tools have to deal > with the HVMLite specific entry, it would also still mean diverging from ARM's > own EFI entry only position, which I'd like to clarify that ARM has no custom > Xen entry, we

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-08 Thread Olaf Hering
On Fri, Apr 08, Wei Liu wrote: > What Ian wanted was that we need clear correlation of xl configuration > syntax with libxl API fields. For example, for a FOO device > >xl.cfg: FOO = [ "bar=baz" ] > >libxl_types.idl: > > libxl_device_FOO = Struct("device_foo", [ > ("bar", some

  1   2   3   4   >