On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote: > Return error code instead of always 0. Remove assigned-only ret > variable. > > Signed-off-by: Paulina Szubarczyk <paulinaszubarc...@gmail.com> > > --- > I think a better subject would be:
"libxl: improve return codes for some pci related functions" or something like that. And in the changelog, I'd say something like: "libxl__device_from_pcidev() can be void, while libxl__create_pci_backend() should propagate the success/error, rather than always returning 0." or something like that. :-) > diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c > index dc10cb7..9c9cd04 100644 > --- a/tools/libxl/libxl_pci.c > +++ b/tools/libxl/libxl_pci.c > The code looks ok to me. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
