Re: [Xen-devel] [RESEND PATCH v4 09/10] vmx: Add VMX RDTSC(P) scaling support

2016-02-16 Thread Zhang, Haozhong
On 02/05/16 22:06, Jan Beulich wrote: > >>> On 19.01.16 at 03:55, wrote: > > @@ -2107,6 +2115,14 @@ const struct hvm_function_table * __init > > start_vmx(void) > > && cpu_has_vmx_secondary_exec_control ) > > vmx_function_table.pvh_supported = 1; > > > > +if ( cpu_has_vmx

Re: [Xen-devel] [PATCH v4 04/10] x86/hvm: Collect information of TSC scaling ratio

2016-02-16 Thread Zhang, Haozhong
On 02/05/16 19:41, Jan Beulich wrote: > >>> On 17.01.16 at 22:58, wrote: > > Both VMX TSC scaling and SVM TSC ratio use the 64-bit TSC scaling ratio, > > but the number of fractional bits of the ratio is different between VMX > > and SVM. This patch adds the architecture code to collect the number

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Corneliu ZUZU
On 2/16/2016 9:08 AM, Corneliu ZUZU wrote: This patch moves monitor_domctl to common-side. Purpose: move what's common to common, prepare for implementation of such vm-events on ARM. * move get_capabilities to arch-side => arch_monitor_get_capabilities. * add arch-side monitor op handling functi

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Tian, Kevin [mailto:kevin.t...@intel.com] > Sent: 16 February 2016 07:23 > To: Paul Durrant; George Dunlap > Cc: Jan Beulich; George Dunlap; Wei Liu; Ian Campbell; Andrew Cooper; > Zhang Yu; xen-devel@lists.xen.org; Stefano Stabellini; Lv, Zhiyuan; Ian > Jackson

Re: [Xen-devel] [PATCH v4 05/10] x86: Add functions for 64-bit integer arithmetic

2016-02-16 Thread Zhang, Haozhong
On 02/05/16 21:36, Jan Beulich wrote: > >>> On 17.01.16 at 22:58, wrote: > > This patch adds several functions to take multiplication, division and > > shifting involving 64-bit integers. > > > > Signed-off-by: Haozhong Zhang > > Reviewed-by: Boris Ostrovsky > > --- > > Changes in v4: > > (add

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > Previously in the three problematic libraries all public headers were > linked to source code directory. We should have created a include > directory and link headers there. What breakage arose from not having done so? > > Signed-off-by: Wei Li

Re: [Xen-devel] [PATCH v2 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

2016-02-16 Thread Jan Beulich
>>> On 15.02.16 at 18:17, wrote: > On Mon, Feb 15, 2016 at 10:06 AM, Jan Beulich wrote: >> >>> On 15.02.16 at 17:55, wrote: >> > All paths that end up using this dr7 value in vm_event have v==current, >> so >> > right now there is no caller to this function using dr7 where v!=current. >> > Futur

Re: [Xen-devel] [PATCH v4 05/10] x86: Add functions for 64-bit integer arithmetic

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 10:02, wrote: > On 02/05/16 21:36, Jan Beulich wrote: >> >>> On 17.01.16 at 22:58, wrote: >> > This patch adds several functions to take multiplication, division and >> > shifting involving 64-bit integers. >> > >> > Signed-off-by: Haozhong Zhang >> > Reviewed-by: Boris Ostro

Re: [Xen-devel] [PATCH v4 06/10] x86/hvm: Setup TSC scaling ratio

2016-02-16 Thread Zhang, Haozhong
On 02/05/16 21:54, Jan Beulich wrote: > >>> On 17.01.16 at 22:58, wrote: > > +u64 hvm_get_tsc_scaling_ratio(u32 gtsc_khz) > > +{ > > +u64 ratio; > > + > > +if ( !hvm_tsc_scaling_supported ) > > +return 0; > > + > > +/* > > + * The multiplication of the first two terms may o

Re: [Xen-devel] [PATCH v2 12/30] xen/x86: Generate deep dependencies of features

2016-02-16 Thread Jan Beulich
>>> On 15.02.16 at 20:07, wrote: > On 15/02/16 16:27, Jan Beulich wrote: > On 15.02.16 at 17:09, wrote: >>> On 15/02/16 15:52, Jan Beulich wrote: >>> --- a/xen/tools/gen-cpuid.py >>> +++ b/xen/tools/gen-cpuid.py >>> @@ -138,6 +138,61 @@ def crunch_numbers(state): >>> stat

Re: [Xen-devel] [PATCH v4 05/10] x86: Add functions for 64-bit integer arithmetic

2016-02-16 Thread Haozhong Zhang
On 02/16/16 02:39, Jan Beulich wrote: > >>> On 16.02.16 at 10:02, wrote: > > On 02/05/16 21:36, Jan Beulich wrote: > >> >>> On 17.01.16 at 22:58, wrote: > >> > This patch adds several functions to take multiplication, division and > >> > shifting involving 64-bit integers. > >> > > >> > Signed-o

Re: [Xen-devel] [PATCH v2 1/1] XEN/ARM: Add Odroid-XU3/XU4 support

2016-02-16 Thread Ian Campbell
On Sun, 2016-02-14 at 22:32 -0800, Suriyan Ramasami wrote: > > > On Thu, Feb 11, 2016 at 1:40 AM, Ian Campbell < > ian.campb...@citrix.com> wrote: > > On Wed, 2016-02-10 at 17:47 -0800, Suriyan Ramasami wrote: > > > > > > > > > On Wed, Feb 10, 2016 at 2:03 AM, Ian Campbell < > > ian.campb...@citr

Re: [Xen-devel] [PATCH v2 15/30] xen/x86: Improvements to in-hypervisor cpuid sanity checks

2016-02-16 Thread Jan Beulich
>>> On 15.02.16 at 18:12, wrote: > On 15/02/16 15:43, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> @@ -4617,50 +4618,39 @@ void hvm_cpuid(unsigned int input, unsigned int >>> *eax, unsigned int *ebx, >>> /* Fix up VLAPIC details. */ >>> *ebx &= 0x00FFu; >>>

Re: [Xen-devel] [PATCH v4 06/10] x86/hvm: Setup TSC scaling ratio

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 10:44, wrote: > On 02/05/16 21:54, Jan Beulich wrote: >> >>> On 17.01.16 at 22:58, wrote: >> > +void hvm_setup_tsc_scaling(struct vcpu *v) >> > +{ >> > +v->arch.hvm_vcpu.tsc_scaling_ratio = >> > +hvm_get_tsc_scaling_ratio(v->domain->arch.tsc_khz); >> > +} >> >> So

[Xen-devel] [PATCH v2] x86: avoid flush IPI when possible

2016-02-16 Thread Jan Beulich
Since CLFLUSH, other than WBINVD, is a cache coherency domain wide flush, there's no need to IPI other CPUs if this is the only flushing being requested. (As a secondary change, move a local variable into the scope where it's actually needed.) Signed-off-by: Jan Beulich --- v2: Adjust the meaning

[Xen-devel] [PATCH v2] x86emul: relax asm() constraints

2016-02-16 Thread Jan Beulich
Let's give the compiler as much liberty at picking instruction operands as possible. Also drop unnecessary size modifiers when the correct size can already be derived from the asm() operands. Finally also drop an "unsigned" from idiv_dbl()'s second parameter, allowing a cast to be eliminated. Sign

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 11:14 +, Paul Durrant wrote: > -#define _NETIF_CTRL_TOEPLITZ_HASH_IPV6 2 > -#define NETIF_CTRL_TOEPLITZ_HASH_IPV6 (1 << > _NETIF_CTRL_TOEPLITZ_HASH_IPV4) > +#define _NETIF_CTRL_HASH_TYPE_IPV6 2 > +#define NETIF_CTRL_HASH_TYPE_IPV6 \ > +(1 << _NETIF_CT

Re: [Xen-devel] [PATCH v11 1/2] vmx: VT-d posted-interrupt core logic handling

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 07:33, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, February 2, 2016 5:53 PM >> To: Wu, Feng >> Cc: Andrew Cooper ; Dario Faggioli >> ; George Dunlap ; >> Tian, Kevin ; xen-devel@lists.xen.org; Keir Fraser >> >> Sub

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > Previously in the three problematic libraries all public headers were > > linked to source code directory. We should have created a include > > directory and link headers there. >

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 09:50, wrote: >> -Original Message- >> From: Tian, Kevin [mailto:kevin.t...@intel.com] >> Sent: 16 February 2016 07:23 >> To: Paul Durrant; George Dunlap >> Cc: Jan Beulich; George Dunlap; Wei Liu; Ian Campbell; Andrew Cooper; >> Zhang Yu; xen-devel@lists.xen.org; Stefa

[Xen-devel] [xen-unstable test] 82662: regressions - trouble: blocked/broken/fail/pass

2016-02-16 Thread osstest service owner
flight 82662 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/82662/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 4 host-build-prep fail REGR. vs. 82516 Tests which are fail

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 09:13, wrote: > On 2/16/2016 9:08 AM, Corneliu ZUZU wrote: >> This patch moves monitor_domctl to common-side. >> Purpose: move what's common to common, prepare for implementation >> of such vm-events on ARM. >> >> * move get_capabilities to arch-side => arch_monitor_get_capabili

Re: [Xen-devel] [PATCH v3 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 07:58, wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -490,6 +490,7 @@ static void vmx_vmcs_save(struct vcpu *v, struct >> hvm_hw_cpu >> *c) >> __vmread(GUEST_SYSENTER_CS, &c->sysenter_cs); >> __vmread(GUEST_SYSENTER_ESP, &c->syse

Re: [Xen-devel] [PATCH v5 1/7] VT-d: Check VT-d Device-TLB flush error(IOMMU part).

2016-02-16 Thread Xu, Quan
> On February 11, 2016 at 1:01am, wrote: > >>> On 05.02.16 at 11:18, wrote: > > This patch checks all kinds of error and all the way up the call trees > > of VT-d Device-TLB flush(IOMMU part). > Please be sure to Cc all maintainers of code you modify. > OK, also CCed Dario Faggioli. Jan, could

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Stefano Stabellini
On Tue, 16 Feb 2016, Corneliu ZUZU wrote: > This patch moves monitor_domctl to common-side. > Purpose: move what's common to common, prepare for implementation > of such vm-events on ARM. > > * move get_capabilities to arch-side => arch_monitor_get_capabilities. > * add arch-side monitor op handli

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: 16 February 2016 10:23 > To: Paul Durrant; xen-de...@lists.xenproject.org > Cc: Ian Jackson; Jan Beulich; Keir (Xen.org); Tim (Xen.org) > Subject: Re: [PATCH v2] public/io/netif.h: make control ring hash prot

Re: [Xen-devel] [PATCH v5 1/7] VT-d: Check VT-d Device-TLB flush error(IOMMU part).

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 11:50, wrote: >> On February 11, 2016 at 1:01am, wrote: >> >>> On 05.02.16 at 11:18, wrote: >> > This patch checks all kinds of error and all the way up the call trees >> > of VT-d Device-TLB flush(IOMMU part). > >> Please be sure to Cc all maintainers of code you modify. >>

[Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Ian Campbell
The underlying code paths in tap_ctl_create attempt to handle both *devpath == NULL (by allocating) and *devpath != NULL (caller provided name) and if they allocate tend to write the return immediately before doing other potentially error generating tasks. All of which makes handling this at a lowe

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 16 February 2016 10:34 > To: Paul Durrant > Cc: Andrew Cooper; George Dunlap; Ian Campbell; Ian Jackson; Stefano > Stabellini; Wei Liu; Kevin Tian; Zhiyuan Lv; Zhang Yu; > xen-devel@lists.xen.org; > George Dunlap;

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 12:02, wrote: >> From: Ian Campbell [mailto:ian.campb...@citrix.com] >> Sent: 16 February 2016 10:23 >> On Mon, 2016-02-15 at 11:14 +, Paul Durrant wrote: >> > + */ >> > +#ifdef NETIF_DEFINE_TOEPLITZ >> >> If we go with this then this should have an addtional XEN_ on the >>

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 16 February 2016 11:11 > To: Paul Durrant > Cc: Ian Campbell; Ian Jackson; xen-de...@lists.xenproject.org; Keir > (Xen.org); Tim (Xen.org) > Subject: RE: [PATCH v2] public/io/netif.h: make control ring hash protocol

Re: [Xen-devel] [PATCH v2] x86emul: relax asm() constraints

2016-02-16 Thread Andrew Cooper
On 16/02/16 10:16, Jan Beulich wrote: > Let's give the compiler as much liberty at picking instruction operands > as possible. Also drop unnecessary size modifiers when the correct size > can already be derived from the asm() operands. Finally also drop an > "unsigned" from idiv_dbl()'s second para

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-16 Thread Stefano Stabellini
On Mon, 15 Feb 2016, Zhang, Haozhong wrote: > On 02/04/16 20:24, Stefano Stabellini wrote: > > On Thu, 4 Feb 2016, Haozhong Zhang wrote: > > > On 02/03/16 15:22, Stefano Stabellini wrote: > > > > On Wed, 3 Feb 2016, George Dunlap wrote: > > > > > On 03/02/16 12:02, Stefano Stabellini wrote: > > > >

[Xen-devel] [PATCH] tools: libxl: NULL terminate partially constructed hex string

2016-02-16 Thread Ian Campbell
Coverity (correctly) complains that the strncpy(p, "0x", 2) will not null terminate p. Although we can see that in the rest of the function p will definitely be NULL terminated by the time it is complete there is no harm in passing 3 to the strncpy and allowing it to NULL terminate to placate Cove

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 12:14, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 16 February 2016 11:11 >> To: Paul Durrant >> Cc: Ian Campbell; Ian Jackson; xen-de...@lists.xenproject.org; Keir >> (Xen.org); Tim (Xen.org) >> Subject: RE: [PATCH v2] public/i

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Corneliu ZUZU
On 2/16/2016 12:45 PM, Jan Beulich wrote: On 16.02.16 at 09:13, wrote: On 2/16/2016 9:08 AM, Corneliu ZUZU wrote: This patch moves monitor_domctl to common-side. Purpose: move what's common to common, prepare for implementation of such vm-events on ARM. * move get_capabilities to arch-side =>

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 16 February 2016 11:19 > To: Paul Durrant > Cc: Ian Campbell; Ian Jackson; xen-de...@lists.xenproject.org; Keir > (Xen.org); Tim (Xen.org) > Subject: RE: [PATCH v2] public/io/netif.h: make control ring hash protocol

Re: [Xen-devel] [PATCH v3 08/23] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'. (v2)

2016-02-16 Thread Ross Lagerwall
On 02/12/2016 06:05 PM, Konrad Rzeszutek Wilk wrote: This change demonstrates how to generate an xSplice ELF payload. The idea here is that we want to patch in the hypervisor the 'xen_version_extra' function with an function that will return 'Hello World'. The 'xl info | grep extraversion' will

Re: [Xen-devel] [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select

2016-02-16 Thread Arnd Bergmann
On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -2241,6 +2241,7 @@ config FB_V

[Xen-devel] [PATCH] xl: close nullfd after dup2'ing it to stdin

2016-02-16 Thread Ian Campbell
Taking care not to do so if nullfd happens (somehow) to have the same fd number as stdin/out/err. CID: 1130519 It was previously hypothesised[0] that fixing 1130516 would solve this too, but that appears to not have been the case. Compile tested only. [0] http://lists.xenproject.org/archives/ht

[Xen-devel] p2m stuff and crash tool

2016-02-16 Thread Daniel Kiper
Hey Juergen, As I saw you are strongly playing with p2m stuff, so, I hope that you can enlighten me a bit in that area. OVM, Oracle product, uses as dom0 kernel Linux 3.8.13 (yep, I know this is very ancient stuff) with a lot of backports. Among them there is commit 2c185687ab016954557aac80074f5d

[Xen-devel] [PATCH] libxl: close fd's in parent when spawning qdisk

2016-02-16 Thread Ian Campbell
Coverity points out that these remain open in the parent upon success, which is a resource leak. To fix this rejig the exit paths such that success and error cases both close the two fds, this means adjusting the callback to only happen for the error case and it also makes sense to rename the labe

Re: [Xen-devel] [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select

2016-02-16 Thread Stefano Stabellini
On Tue, 16 Feb 2016, Arnd Bergmann wrote: > On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/vid

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 10:29 +, Wei Liu wrote: > On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > > Previously in the three problematic libraries all public headers > were > > > linked to source code directory. We should have

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 12:14:33PM +, Ian Campbell wrote: > On Tue, 2016-02-16 at 10:29 +, Wei Liu wrote: > > On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > > > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > > > Previously in the three problematic libraries all publi

[Xen-devel] [PATCH v2] stubdom: fix link farm runes

2016-02-16 Thread Wei Liu
Previously in the three problematic libraries all public headers were linked to source code directory. We should have created an include directory for each library and linked public headers there. Note that there was no breakage for those three libraries before this patch. This patch merely change

Re: [Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 11:09:43AM +, Ian Campbell wrote: > The underlying code paths in tap_ctl_create attempt to handle both > *devpath == NULL (by allocating) and *devpath != NULL (caller provided > name) and if they allocate tend to write the return immediately before > doing other potentia

Re: [Xen-devel] [PATCH] tools: libxl: NULL terminate partially constructed hex string

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 11:18:20AM +, Ian Campbell wrote: > Coverity (correctly) complains that the strncpy(p, "0x", 2) will not > null terminate p. > > Although we can see that in the rest of the function p will > definitely be NULL terminated by the time it is complete there is no > harm in

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 12:20, wrote: > On 2/16/2016 12:45 PM, Jan Beulich wrote: > On 16.02.16 at 09:13, wrote: >>> On 2/16/2016 9:08 AM, Corneliu ZUZU wrote: This patch moves monitor_domctl to common-side. Purpose: move what's common to common, prepare for implementation of such v

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 12:14, wrote: > On Mon, 15 Feb 2016, Zhang, Haozhong wrote: >> On 02/04/16 20:24, Stefano Stabellini wrote: >> > On Thu, 4 Feb 2016, Haozhong Zhang wrote: >> > > On 02/03/16 15:22, Stefano Stabellini wrote: >> > > > On Wed, 3 Feb 2016, George Dunlap wrote: >> > > > > On 03/02/16

Re: [Xen-devel] p2m stuff and crash tool

2016-02-16 Thread Juergen Gross
Hi Daniel, On 16/02/16 12:35, Daniel Kiper wrote: > Hey Juergen, > > As I saw you are strongly playing with p2m stuff, so, > I hope that you can enlighten me a bit in that area. Yes, the p2m stuff is always fun. :-) > OVM, Oracle product, uses as dom0 kernel Linux 3.8.13 > (yep, I know this is

Re: [Xen-devel] [PATCH] libxl: close fd's in parent when spawning qdisk

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 11:49:53AM +, Ian Campbell wrote: > Coverity points out that these remain open in the parent upon > success, which is a resource leak. > > To fix this rejig the exit paths such that success and error cases > both close the two fds, this means adjusting the callback to o

[Xen-devel] [PATCH] xen: make some constants usable for assembler

2016-02-16 Thread Juergen Gross
Some constants defined in xen/include/public/xen.h are not usable in assembler sources as they are either defined with "U" or "UL" suffixes or they are inside #ifndef __ASSEMBLY__ areas. Change this as grub2 could make use of those definitions. Signed-off-by: Juergen Gross --- xen/include/publi

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Corneliu ZUZU
On 2/16/2016 2:34 PM, Jan Beulich wrote: On 16.02.16 at 12:20, wrote: On 2/16/2016 12:45 PM, Jan Beulich wrote: On 16.02.16 at 09:13, wrote: On 2/16/2016 9:08 AM, Corneliu ZUZU wrote: This patch moves monitor_domctl to common-side. Purpose: move what's common to common, prepare for implemen

Re: [Xen-devel] [PATCH] xl: close nullfd after dup2'ing it to stdin

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 11:35:45AM +, Ian Campbell wrote: > Taking care not to do so if nullfd happens (somehow) to have the same > fd number as stdin/out/err. > > CID: 1130519 > > It was previously hypothesised[0] that fixing 1130516 would solve this > too, but that appears to not have been

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 09:40 +0100, Gerd Hoffmann wrote: >   Hi, > > > 1.9-stable created now, with the patch above cherry-picked. > > 1.9.1 tagged & tarball uploaded now. Thanks for the heads up! ___ Xen-devel mailing list Xen-devel@lists.xen.org http

Re: [Xen-devel] [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 16:13 +, Wei Liu wrote: > On Mon, Feb 15, 2016 at 08:38:02AM -0600, Doug Goldstein wrote: > > Switch from tracking a commit post 1.9.0 to the 1.9.1 release. > > > > Thanks for this patch. > > We can't apply this patch just yet. We need to wait a bit until the > change t

Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 16:04 +, Andrew Cooper wrote: > andrewcoop@andrewcoop:/local/xen.git/xen$ dig -t ANY doe.com > ... > ;; AUTHORITY SECTION: > doe.com.3600INNSns52.domaincontrol.com. > doe.com.3600INNSns51.domaincontrol.com. > > ;; ADDITIONAL SECTION

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 11:02 +, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: 16 February 2016 10:23 > > To: Paul Durrant; xen-de...@lists.xenproject.org > > Cc: Ian Jackson; Jan Beulich; Keir (Xen.org); Tim (Xen.org) > > Sub

Re: [Xen-devel] [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 01:43:26PM +, Ian Campbell wrote: > On Mon, 2016-02-15 at 16:13 +, Wei Liu wrote: > > On Mon, Feb 15, 2016 at 08:38:02AM -0600, Doug Goldstein wrote: > > > Switch from tracking a commit post 1.9.0 to the 1.9.1 release. > > > > > > > Thanks for this patch. > > > >

Re: [Xen-devel] [PATCH] xen: make some constants usable for assembler

2016-02-16 Thread Jan Beulich
>>> On 16.02.16 at 14:02, wrote: > Some constants defined in xen/include/public/xen.h are not usable in > assembler sources as they are either defined with "U" or "UL" suffixes > or they are inside #ifndef __ASSEMBLY__ areas. > > Change this as grub2 could make use of those definitions. > > Sign

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Razvan Cojocaru
On 02/16/2016 09:08 AM, Corneliu ZUZU wrote: > This patch moves monitor_domctl to common-side. > Purpose: move what's common to common, prepare for implementation > of such vm-events on ARM. > > * move get_capabilities to arch-side => arch_monitor_get_capabilities. > * add arch-side monitor op han

Re: [Xen-devel] [PATCH] xen: make some constants usable for assembler

2016-02-16 Thread Juergen Gross
On 16/02/16 15:04, Jan Beulich wrote: On 16.02.16 at 14:02, wrote: >> Some constants defined in xen/include/public/xen.h are not usable in >> assembler sources as they are either defined with "U" or "UL" suffixes >> or they are inside #ifndef __ASSEMBLY__ areas. >> >> Change this as grub2 cou

Re: [Xen-devel] [PATCH v2 16/30] x86/cpu: Move set_cpumask() calls into c_early_init()

2016-02-16 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > Before c/s 44e24f8567 "x86: don't call generic_identify() redundantly", the > commandline-provided masks would take effect in Xen's view of the features. > > As the masks got applied after the query for features, the redundant call to > generic_identify() would

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 14:02 +, Paul Durrant wrote: > > -Original Message- > [snip] > > > > > > > >   * > > > > > - * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER > > > > > - * -- > > > > > + * NETIF_CTRL_TYPE_SET_HASH_MAPPING_ORDER > > > > > > > >

[Xen-devel] [linux-4.1 test] 82689: regressions - FAIL

2016-02-16 Thread osstest service owner
flight 82689 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/82689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 66399 build-i386-rumpuserxen

Re: [Xen-devel] [PATCH v2 17/30] x86/cpu: Common infrastructure for levelling context switching

2016-02-16 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > --- a/xen/include/asm-x86/processor.h > +++ b/xen/include/asm-x86/processor.h > @@ -574,6 +574,34 @@ void microcode_set_module(unsigned int); > int microcode_update(XEN_GUEST_HANDLE_PARAM(const_void), unsigned long len); > int microcode_resume_cpu(unsigned int

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
> -Original Message- [snip] > > > > > >   * > > > > - * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER > > > > - * -- > > > > + * NETIF_CTRL_TYPE_SET_HASH_MAPPING_ORDER > > > > > > This one needs a similar "if the hash algorithm requires it" wording > > >

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: 16 February 2016 14:13 > To: Paul Durrant; xen-de...@lists.xenproject.org > Cc: Ian Jackson; Jan Beulich; Keir (Xen.org); Tim (Xen.org) > Subject: Re: [PATCH v2] public/io/netif.h: make control ring hash prot

Re: [Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 14:17 +, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: 16 February 2016 14:13 > > To: Paul Durrant; xen-de...@lists.xenproject.org > > Cc: Ian Jackson; Jan Beulich; Keir (Xen.org); Tim (Xen.org) > > Sub

[Xen-devel] [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"

2016-02-16 Thread Arnd Bergmann
The Xen framebuffer driver selects the xen keyboard driver, so the latter will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT is a loadable module, this configuration cannot work. On mainline kernels, the symbol will be enabled but not used, while in combination with a patch I have

[Xen-devel] [PATCH OSSTEST] crontab: Add a coverity run on a Wednesday

2016-02-16 Thread Ian Campbell
In addition to the current Sunday run. Projects of Xen's size are currently allowed 2 builds per week (max 1 per day), so make use of both. Signed-off-by: Ian Campbell --- This change is already live in the production colo --- crontab | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Xen-devel] [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select

2016-02-16 Thread Arnd Bergmann
On Tuesday 16 February 2016 12:14:14 Stefano Stabellini wrote: > > at all. > > Please correct me if I am wrong, but the difference is that with this > change if INPUT=m, then the build system would ask the user whether she > wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of > uncondi

[Xen-devel] [PATCH v3] public/io/netif.h: make control ring hash protocol more general

2016-02-16 Thread Paul Durrant
This patch modified the control ring protocol (of which there is not yet an implementation) to make it more general. Most of the concepts are not limited to toeplitz hashing so it's best not to make them unnecessarily specific. Apart from changing the names of various definitions and modifying com

Re: [Xen-devel] [PATCH OSSTEST] crontab: Add a coverity run on a Wednesday

2016-02-16 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST] crontab: Add a coverity run on a Wednesday"): > In addition to the current Sunday run. > > Projects of Xen's size are currently allowed 2 builds per week (max 1 > per day), so make use of both. > > Signed-off-by: Ian Campbell Acked-by: Ian Jackson __

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-16 Thread Olaf Hering
On Mon, Feb 15, Ian Jackson wrote: > One reason you might define a virtual controller with no devices yet > is so that you have a stable and pre-expected device path for any > actual targets you choose to hotplug later. Would it be acceptable to reuse the devid as the "group index"? The various v

[Xen-devel] [PATCH] xen: cleanup config.h

2016-02-16 Thread Juergen Gross
config.h contains an unused definition of mk_unsigned_long(). Remove it. Signed-off-by: Juergen Gross --- xen/include/xen/config.h | 9 - 1 file changed, 9 deletions(-) diff --git a/xen/include/xen/config.h b/xen/include/xen/config.h index d780121..a992933 100644 --- a/xen/include/xen/

[Xen-devel] Wall-Clock-Time-Jump after migration [xen-4.1]

2016-02-16 Thread Philipp Hahn
Hello, I'm trying to understand Xens implementation of (wall-)clock time and observed a strange behaviour: Summary: When a Linux-PV-domU is migrated between two hosts, the "ntpdate" time jumps. Environment: xen-4.1 with linux-3.2 and linux-3.10, ntpdate running in all dom[0U]. 1. If I start a n

[Xen-devel] [PATCH V2] xen: make some constants usable for assembler

2016-02-16 Thread Juergen Gross
Some constants defined in xen/include/public/xen.h are not usable in assembler sources as they are either defined with "U" or "UL" suffixes or they are inside #ifndef __ASSEMBLY__ areas. Change this as grub2 could make use of those definitions. This requires to move the definition of mk_unsigned_

[Xen-devel] [qemu-mainline test] 82711: regressions - FAIL

2016-02-16 Thread osstest service owner
flight 82711 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/82711/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 15 guest-start/debian.repeat fail REGR. vs. 82574 test-armhf-armhf-xl

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Tamas K Lengyel
> > > @@ -143,77 +72,75 @@ int monitor_domctl(struct domain *d, struct > xen_domctl_monitor_op *mop) > > case XEN_DOMCTL_MONITOR_EVENT_MOV_TO_MSR: > { > So since we will now have two separate booleans, requested_status and old_status and then manually verify they are opposite.. > -

Re: [Xen-devel] Wall-Clock-Time-Jump after migration [xen-4.1]

2016-02-16 Thread David Vrabel
On 16/02/16 15:38, Philipp Hahn wrote: > Hello, > > I'm trying to understand Xens implementation of (wall-)clock time and > observed a strange behaviour: > > Summary: When a Linux-PV-domU is migrated between two hosts, the > "ntpdate" time jumps. > > Environment: xen-4.1 with linux-3.2 and linux

[Xen-devel] xen/arm64: interrupt trouble porting to a new board

2016-02-16 Thread Dirk Behme
Hi, trying to bring up Xen on an ARM64 CA57 device (1 core atm) using a recent Xen 4.7-unstable and Linux kernel 4.4.0+ I'm getting [1]. The device tree configures arm,gic-400. Regarding the , the Linux kernel boot messages are stopping here. The debugger shows the system looping in xen/arch

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > #xl usbctrl-attach test_vm version=1 ports=8 > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 I think this does not handle the -N knob of xl. Other commands check the global dryrun_only variable. Olaf ___ Xen-de

Re: [Xen-devel] [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND"

2016-02-16 Thread Stefano Stabellini
On Tue, 16 Feb 2016, Arnd Bergmann wrote: > The Xen framebuffer driver selects the xen keyboard driver, so the latter > will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT > is a loadable module, this configuration cannot work. On mainline kernels, > the symbol will be enabled but

[Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

2016-02-16 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f07384c..c056284 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -299,6 +299,7 @@ F: x

Re: [Xen-devel] [PATCH v2] stubdom: fix link farm runes

2016-02-16 Thread Ian Jackson
Wei Liu writes ("[PATCH v2] stubdom: fix link farm runes"): > Previously in the three problematic libraries all public headers were > linked to source code directory. We should have created an include > directory for each library and linked public headers there. > > Note that there was no breakage

[Xen-devel] [PATCH v4 2/4] libxl: introduce LIBXL_VGA_INTERFACE_TYPE_UNKNOWN

2016-02-16 Thread Roger Pau Monne
And use it as the default value for the VGA kind. This allows libxl to set it to the default value later on when the domain type is known. For HVM guests the default value is LIBXL_VGA_INTERFACE_TYPE_CIRRUS while for HVMlite the default value is LIBXL_VGA_INTERFACE_TYPE_NONE. Signed-off-by: Roger

[Xen-devel] [PATCH v4 3/4] libelf: rewrite symtab/strtab loading

2016-02-16 Thread Roger Pau Monne
Current implementation of elf_load_bsdsyms is broken when loading inside of a HVM guest, because it assumes elf_memcpy_safe is able to write into guest memory space, which it is not. Take the oportunity to do some cleanup and properly document how elf_{parse/load}_bsdsyms works. The new implementa

[Xen-devel] [PATCH v4 0/4] Assorted fixes and improvements

2016-02-16 Thread Roger Pau Monne
Hello, This series contains some assorted patches and improvements. They are completely ortogonal one fro meach other, so they can be applied independently without issues. I've just decided to group them together because I prefer it rather than spamming the list with 4 different threads. #1 up

[Xen-devel] [PATCH v4 1/4] x86/HVM: update the start info structure layout

2016-02-16 Thread Roger Pau Monne
After some discussion around the new boot ABI consensus has been reached about the layout and contents of the start info. The following patch updates the layout to what has been agreed. Also, the new layout is described in binary terms in order to avoid issues with alignments when using C structs.

Re: [Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath"): > On Tue, Feb 16, 2016 at 11:09:43AM +, Ian Campbell wrote: > > The underlying code paths in tap_ctl_create attempt to handle both > > *devpath == NULL (by allocating) and *devpath != NULL (caller pr

[Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-16 Thread Roger Pau Monne
Current libxl__device_disk_set_backend implementation tried to guess the backend of devices with format LIBXL_DISK_FORMAT_EMPTY, which is of course doomed to fail since the disk is empty. Instead just return early from the function if an empty disk is detected. This fixes cd ejection. Signed-off-

Re: [Xen-devel] [PATCH] tools: libxl: NULL terminate partially constructed hex string

2016-02-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: libxl: NULL terminate partially constructed hex string"): > On Tue, Feb 16, 2016 at 11:18:20AM +, Ian Campbell wrote: > > Coverity (correctly) complains that the strncpy(p, "0x", 2) will not > > null terminate p. > > Signed-off-by: Ian Campbell > > Acked-b

Re: [Xen-devel] [PATCH] libxl: close fd's in parent when spawning qdisk

2016-02-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: close fd's in parent when spawning qdisk"): > On Tue, Feb 16, 2016 at 11:49:53AM +, Ian Campbell wrote: > > Coverity points out that these remain open in the parent upon > > success, which is a resource leak. > > Acked-by: Wei Liu Committed-by: Ian Jackson

Re: [Xen-devel] [PATCH] libxl: add basic spice support for pv domUs

2016-02-16 Thread Wei Liu
On Wed, Jan 13, 2016 at 11:47:55AM +0100, Fabio Fantoni wrote: [...] > >> > >>diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > >>index 3b695bd..04a96ba 100644 > >>--- a/docs/man/xl.cfg.pod.5 > >>+++ b/docs/man/xl.cfg.pod.5 > >>@@ -1607,82 +1607,6 @@ it. > >> =back > >>-=head3 Spice Gra

Re: [Xen-devel] [PATCH] xl: close nullfd after dup2'ing it to stdin

2016-02-16 Thread Ian Jackson
Ian Campbell writes ("[PATCH] xl: close nullfd after dup2'ing it to stdin"): > Taking care not to do so if nullfd happens (somehow) to have the same > fd number as stdin/out/err. I think that can only happen if the program (the process) has a serious problem: ie, fd 0 1 or 2 would have to be close

Re: [Xen-devel] [PATCH v4 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-16 Thread Corneliu ZUZU
On 2/16/2016 6:02 PM, Tamas K Lengyel wrote: @@ -143,77 +72,75 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop) case XEN_DOMCTL_MONITOR_EVENT_MOV_TO_MSR: { So since we will now have two separate booleans, requested_status and old_status an

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-16 Thread Ian Jackson
Olaf Hering writes ("Re: [PATCH v8 3/5] libxl: add support for vscsi"): > On Mon, Feb 15, Ian Jackson wrote: > > One reason you might define a virtual controller with no devices yet > > is so that you have a stable and pre-expected device path for any > > actual targets you choose to hotplug later.

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Ian Jackson
Jim Fehlig writes ("Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands"): > I just noticed this is the case with network devices as well. E.g. > > #xl network-attach hvm-domU mac=00:16:3e:xx:yy:zz,bridge=br0 > libxl: error: libxl_device.c:1095:device_hotplug_child_death_cb: script: Could > not

  1   2   >