Re: [Xen-devel] [PATCH v3 01/23] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op (v10)

2016-02-15 Thread Jan Beulich
>>> On 12.02.16 at 21:40, wrote: >> > diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h >> > index 96680eb..d549e7a 100644 >> > --- a/xen/include/public/sysctl.h >> > +++ b/xen/include/public/sysctl.h >> > @@ -766,6 +766,160 @@ struct xen_sysctl_tmem_op { >> > typedef struct

Re: [Xen-devel] [PATCH] common: re-arrange struct kernel_param fields

2016-02-15 Thread Andrew Cooper
On 15/02/2016 07:36, Jan Beulich wrote: > Even if placed in .init.* there's no reason to needlessly bloat the > binary due to padding fields the compiler needs to insert on 64-bit > architectures. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper

Re: [Xen-devel] [PATCH] x86/HVM: fold hypercall tables

2016-02-15 Thread Andrew Cooper
On 15/02/2016 07:42, Jan Beulich wrote: > @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg > } > #endif > > -regs->_eax = hvm_hypercall32_table[eax](ebx, ecx, edx, esi, edi, > ebp); > +regs->_eax = hypercall_table[eax].compat(ebx, ecx, edx, esi, edi, > eb

Re: [Xen-devel] [PATCH v3 1/2] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-15 Thread Razvan Cojocaru
On 02/15/2016 08:35 AM, Corneliu ZUZU wrote: > This patch merges almost identical functions hvm_event_int3 and > hvm_event_single_step into a single function called hvm_event_breakpoint. > Also fixes event.c file header comment in the process. > > Signed-off-by: Corneliu ZUZU > --- > xen/arch/x8

Re: [Xen-devel] [PATCH v3 04/23] elf: Add relocation types to elfstructs.h

2016-02-15 Thread Jan Beulich
>>> On 12.02.16 at 19:05, wrote: > --- a/xen/include/xen/elfstructs.h > +++ b/xen/include/xen/elfstructs.h > @@ -348,6 +348,14 @@ typedef struct { > #define ELF64_R_TYPE(info) ((info) & 0x) > #define ELF64_R_INFO(s,t)(((s) << 32) + (u_int32_t)(t)) > > +/* x86-64 relocatio

Re: [Xen-devel] [SeaBIOS] [SEABIOS] Plans for either 1.9.1 or 1.10.0?

2016-02-15 Thread Gerd Hoffmann
Hi, > 1.9-stable created now, with the patch above cherry-picked. 1.9.1 tagged & tarball uploaded now. cheers, Gerd ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-15 Thread Haozhong Zhang
On 02/03/16 03:15, Konrad Rzeszutek Wilk wrote: > > 3. Design of vNVDIMM in Xen > > Thank you for this design! > > > > > Similarly to that in KVM/QEMU, enabling vNVDIMM in Xen is composed of > > three parts: > > (1) Guest clwb/clflushopt/pcommit enabling, > > (2) Memory mapping, and > > (3)

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Corneliu ZUZU
On 2/15/2016 8:37 AM, Corneliu ZUZU wrote: diff --git a/xen/common/monitor.c b/xen/common/monitor.c new file mode 100644 index 000..b708cab --- /dev/null +++ b/xen/common/monitor.c +int rc; +bool_t requested_status = 0; + +if ( unlikely(current->domain == d) ) /* no domain_pause()

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Tom Herbert [mailto:t...@herbertland.com] > Sent: 14 February 2016 22:02 > To: Paul Durrant > Cc: David Miller; net...@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing > > On Fri, Feb 1

Re: [Xen-devel] [PATCH net-next v1 1/8] skbuff: store hash type in socket buffer...

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Tom Herbert [mailto:t...@herbertland.com] > Sent: 14 February 2016 22:25 > To: Paul Durrant > Cc: Linux Kernel Network Developers; xen-de...@lists.xenproject.org; David > S. Miller; Jay Vosburgh; Veaceslav Falico; Andy Gospodarek > Subject: Re: [PATCH net-next v

Re: [Xen-devel] [PATCH] x86/HVM: fold hypercall tables

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 09:26, wrote: > On 15/02/2016 07:42, Jan Beulich wrote: >> @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg >> } >> #endif >> >> -regs->_eax = hvm_hypercall32_table[eax](ebx, ecx, edx, esi, edi, >> ebp); >> +regs->_eax = hypercall_table

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-15 Thread Zhang, Haozhong
On 02/03/16 23:47, Konrad Rzeszutek Wilk wrote: > > > > > Open: It seems no system call/ioctl is provided by Linux kernel to > > > > >get the physical address from a virtual address. > > > > >/proc//pagemap provides information of mapping from > > > > >VA to PA. Is it an ac

Re: [Xen-devel] [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-02-15 Thread Paul Durrant
> -Original Message- > From: qemu-devel-bounces+paul.durrant=citrix@nongnu.org > [mailto:qemu-devel-bounces+paul.durrant=citrix@nongnu.org] On > Behalf Of Wei Liu > Sent: 12 February 2016 19:11 > To: qemu-de...@nongnu.org; Xen-devel > Cc: Anthony Perard; gk...@linux.vnet.ibm.com; We

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Jan Beulich
>>> On 12.02.16 at 18:42, wrote: > On 12/02/16 17:05, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> +#define X86_FEATURE_VMXE ( 1*32+ 5) /*S Virtual Machine >>> Extensions */ >> Shouldn't this get a "nested-only" class? > > I am not sure that would be appropriate. On the

Re: [Xen-devel] Two linkers - EFI one (mingw64) and normal GNU one [Fedora]

2016-02-15 Thread Jan Beulich
>>> On 12.02.16 at 18:19, wrote: > Fedora for the longest time seems to have two linkers - one normal for GNU > applications and then another - mingw64 - for building EFI applications. > > Which means that to compile ELF binaries on Fedora requires this patch > (taken from Fedora build): This se

[Xen-devel] [PATCH] x86/traps: Improve hypervisor stack overflow detection

2016-02-15 Thread Andrew Cooper
A sample Gentoo compliation of Xen contains lea-0x1058(%rsp),%rsp orq$0x0,(%rsp) lea0x1020(%rsp),%rsp Whatever the reason for silly code like this, it fools the current stack overflow detection logic in the #DF handler (which triggers reliably on the 'orq' instruction). U

Re: [Xen-devel] [PATCH v3] libxl: fix handling of returns in libxl_get_version_info()

2016-02-15 Thread Dario Faggioli
Hey, Harmandeep, We're almost there, I would say. The subject is still suboptimal, IMO. I would go for something like "libxl: handle failure of xc_version() in libxl_get_version_info() The changelog... On Sat, 2016-02-13 at 02:05 +0530, Harmandeep Kaur wrote: > Check the return value of xc_ver

[Xen-devel] [PATCH] public/io/netif.h: make control ring hash protocol more general

2016-02-15 Thread Paul Durrant
This patch modified the control ring protocol (of which there is not yet an implementation) to make it more general. Most of the concepts are not limited to toeplitz hashing so it's best not to make them unnecessarily specific. Apart from changing the names of various definitions and modifying com

[Xen-devel] [xen-unstable test] 82516: tolerable FAIL

2016-02-15 Thread osstest service owner
flight 82516 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/82516/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds15 guest-start/debian.repeat fail blocked in 82212 build-amd64-rumpuserxen

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 09:43, wrote: > On 02/03/16 03:15, Konrad Rzeszutek Wilk wrote: >> > Similarly to that in KVM/QEMU, enabling vNVDIMM in Xen is composed of >> > three parts: >> > (1) Guest clwb/clflushopt/pcommit enabling, >> > (2) Memory mapping, and >> > (3) Guest ACPI emulation. >> >>

Re: [Xen-devel] [PATCH] public/io/netif.h: make control ring hash protocol more general

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 11:17, wrote: > +#define NETIF_CTRL_HASH_ALGORITHM_TOEPLITZ 1 > + > +/* > + * This algorithm uses a 'key' as well as the data buffer itself. > + * (Buffer[] and Key[] are treated as shift-registers where the MSB of > + * Buffer/Key[0] is considered 'left-most' and the LSB of Buf

Re: [Xen-devel] [PATCH V3] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-15 Thread Jan Beulich
>>> On 14.02.16 at 09:38, wrote: > xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() > are currently no-ops, that is all they do is set a flag that > nobody else checks. The user can already set the EMULATE flags in > the vm_event response if emulation is desired, and having an ex

Re: [Xen-devel] [PATCH] public/io/netif.h: make control ring hash protocol more general

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 15 February 2016 11:13 > To: Paul Durrant > Cc: Ian Campbell; Ian Jackson; xen-de...@lists.xenproject.org; Keir > (Xen.org); Tim (Xen.org) > Subject: Re: [PATCH] public/io/netif.h: make control ring hash protocol mo

Re: [Xen-devel] [PATCH V3] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-15 Thread Stefano Stabellini
On Mon, 15 Feb 2016, Jan Beulich wrote: > >>> On 14.02.16 at 09:38, wrote: > > xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() > > are currently no-ops, that is all they do is set a flag that > > nobody else checks. The user can already set the EMULATE flags in > > the vm_event

[Xen-devel] [PATCH v2] public/io/netif.h: make control ring hash protocol more general

2016-02-15 Thread Paul Durrant
This patch modified the control ring protocol (of which there is not yet an implementation) to make it more general. Most of the concepts are not limited to toeplitz hashing so it's best not to make them unnecessarily specific. Apart from changing the names of various definitions and modifying com

Re: [Xen-devel] [PATCH V3] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-15 Thread Wei Liu
On Sun, Feb 14, 2016 at 10:38:58AM +0200, Razvan Cojocaru wrote: > xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() > are currently no-ops, that is all they do is set a flag that > nobody else checks. The user can already set the EMULATE flags in > the vm_event response if emulati

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 07:37, wrote: > default: > -return -EOPNOTSUPP; > +/* > + * Should not be reached unless arch_monitor_get_capabilities() is > not > + * properly implemented. In that case, since reaching this point does > + * not really break anythin

[Xen-devel] [qemu-mainline bisection] complete build-i386-xsm

2016-02-15 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://g

Re: [Xen-devel] [PATCH 1/5] xen: audit usages of module.h ; remove unnecessary instances

2016-02-15 Thread Stefano Stabellini
On Sun, 14 Feb 2016, Paul Gortmaker wrote: > Code that uses no modular facilities whatsoever should not be > sourcing module.h at all, since that header drags in a bunch > of other headers with it. > > Similarly, code that is not explicitly using modular facilities > like module_init() but only is

Re: [Xen-devel] [PATCH 2/5] drivers/xen: make [xen-]ballon explicitly non-modular

2016-02-15 Thread Stefano Stabellini
On Sun, 14 Feb 2016, Paul Gortmaker wrote: > The Makefile / Kconfig currently controlling compilation here is: > > obj-y += grant-table.o features.o balloon.o manage.o preempt.o time.o > [...] > obj-$(CONFIG_XEN_BALLOON) += xen-balloon.o > > ...with: > > drivers/xen/Kconfig:config X

Re: [Xen-devel] [PATCH 3/5] drivers/xen: make xenbus_dev_[front/back]end explicitly non-modular

2016-02-15 Thread Stefano Stabellini
On Sun, 14 Feb 2016, Paul Gortmaker wrote: > The Makefile / Kconfig currently controlling compilation here is: > > obj-y += xenbus_dev_frontend.o > [...] > obj-$(CONFIG_XEN_BACKEND) += xenbus_dev_backend.o > > ...with: > > drivers/xen/Kconfig:config XEN_BACKEND > drivers/xen/Kconfig:bool "

Re: [Xen-devel] [PATCH 4/5] drivers/xen: make sys-hypervisor.c explicitly non-modular

2016-02-15 Thread Stefano Stabellini
On Sun, 14 Feb 2016, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config XEN_SYS_HYPERVISOR >bool "Create xen entries under /sys/hypervisor" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modula

Re: [Xen-devel] [PATCH 5/5] drivers/xen: make platform-pci.c explicitly non-modular

2016-02-15 Thread Stefano Stabellini
On Sun, 14 Feb 2016, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/x86/xen/Kconfig:config XEN_PVHVM > arch/x86/xen/Kconfig: def_bool y > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code t

Re: [Xen-devel] [PATCH] tools/libxc: Fix use of zlib-options when building the domain builder

2016-02-15 Thread Wei Liu
On Fri, Feb 12, 2016 at 07:21:31PM +, Andrew Cooper wrote: > c/s de0f8c7c changed the use of zlib-options, and moved it from being locally > generated to coming from ./configure. > Wow, this is ancient commit. > However, it neglected to modify the users of zlib-options. The curious use of >

[Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Jan Beulich
... and hence the respective {read,write}_msr() hook parameter doesn't need to be "unsigned long". Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -966,7 +966,7 @@ static int hvmemul_write_io_discard( } static int hvmemul_write_msr_discard( -

[Xen-devel] [PATCH] x86emul: fold almost identical code

2016-02-15 Thread Jan Beulich
AAM/AAD as well as DAA/DAS emulation code is respectively almost identical. Fold each pair, following what's already the case for AAA/AAS. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2053,46 +2053,25 @@ x86_emulate(

[Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Jan Beulich
Let's give the compiler as much liberty in picking instruction operands as possible. Also drop unnecessary size modifiers when the correct size can already be derived from the asm() operands. Finally also drop an "unsigned" from idiv_dbl()'s second parameter, allowing a cast to be eliminated. Sign

[Xen-devel] [PATCH] xen: xen_is_pirq_msi only when xen_enabled()

2016-02-15 Thread Stefano Stabellini
Only return true from xen_is_pirq_msi when Xen is enabled: the function should never identify an MSI as Xen pirq when not running on Xen. Signed-off-by: Stefano Stabellini CC: m...@redhat.com CC: berra...@redhat.com CC: xen-devel@lists.xen.org --- hw/pci/msix.c |2 +- xen-hvm.c |3 ++

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Corneliu ZUZU
On 2/15/2016 1:41 PM, Jan Beulich wrote: On 15.02.16 at 07:37, wrote: default: -return -EOPNOTSUPP; +/* + * Should not be reached unless arch_monitor_get_capabilities() is not + * properly implemented. In that case, since reaching this point does +

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Corneliu ZUZU
On 2/15/2016 1:41 PM, Jan Beulich wrote: +++ b/xen/include/xen/monitor.h @@ -0,0 +1,30 @@ +/* + * include/xen/monitor.h + * + * Common monitor_op domctl handler. + * + * Copyright (c) 2015 Tamas K Lengyel (ta...@tklengyel.com) + * Copyright (c) 2016, Bitdefender S.R.L. + * + * This program is fre

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Stefano Stabellini
On Mon, 15 Feb 2016, Jan Beulich wrote: > >>> On 15.02.16 at 07:37, wrote: > > default: > > -return -EOPNOTSUPP; > > +/* > > + * Should not be reached unless arch_monitor_get_capabilities() is > > not > > + * properly implemented. In that case, since reaching

Re: [Xen-devel] [PATCH v3 02/23] libxc: Implementation of XEN_XSPLICE_op in libxc (v5).

2016-02-15 Thread Wei Liu
On Fri, Feb 12, 2016 at 01:05:40PM -0500, Konrad Rzeszutek Wilk wrote: > The underlaying toolstack code to do the basic > operations when using the XEN_XSPLICE_op syscalls: > - upload the payload, > - get status of an payload, > - list all the payloads, > - apply, check, replace, and revert the

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Corneliu ZUZU
On 2/15/2016 2:25 PM, Stefano Stabellini wrote: On Mon, 15 Feb 2016, Jan Beulich wrote: On 15.02.16 at 07:37, wrote: default: -return -EOPNOTSUPP; +/* + * Should not be reached unless arch_monitor_get_capabilities() is not + * properly implemented. In that

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 13:14, wrote: > On 2/15/2016 1:41 PM, Jan Beulich wrote: > On 15.02.16 at 07:37, wrote: >>> default: >>> -return -EOPNOTSUPP; >>> +/* >>> + * Should not be reached unless arch_monitor_get_capabilities() is >>> not >>> + * properly impl

Re: [Xen-devel] [PATCH v3 14/23] libxl: info: Display build_id of the hypervisor.

2016-02-15 Thread Wei Liu
On Fri, Feb 12, 2016 at 01:05:52PM -0500, Konrad Rzeszutek Wilk wrote: > If the hypervisor is built with we will display it. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > v2: Include HAVE_*, use libxl_zalloc, s/rc/ret/ > v3: Retry with different size if 1020 is not enough. > --- > tools/libxl

Re: [Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Andrew Cooper
On 15/02/16 11:57, Jan Beulich wrote: > ... and hence the respective {read,write}_msr() hook parameter doesn't > need to be "unsigned long". > > Signed-off-by: Jan Beulich I would suggest uint32_t instead (being more architecturally self-documenting), but either way, Reviewed-by: Andrew Cooper

Re: [Xen-devel] [PATCH v3 03/23] xen-xsplice: Tool to manipulate xsplice payloads (v4)

2016-02-15 Thread Wei Liu
On Fri, Feb 12, 2016 at 01:05:41PM -0500, Konrad Rzeszutek Wilk wrote: [...] > diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c > new file mode 100644 > index 000..13f762f > --- /dev/null > +++ b/tools/misc/xen-xsplice.c One gripe I have with this program is that many of its fu

Re: [Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 13:51, wrote: > On 15/02/16 11:57, Jan Beulich wrote: >> ... and hence the respective {read,write}_msr() hook parameter doesn't >> need to be "unsigned long". >> >> Signed-off-by: Jan Beulich > > I would suggest uint32_t instead (being more architecturally > self-documenting),

Re: [Xen-devel] [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-02-15 Thread Wei Liu
On Mon, Feb 15, 2016 at 09:07:13AM +, Paul Durrant wrote: > > [...] > > # Option 2: Invent a xen-9p device > > > > Another way of doing it is to expose a dummy xen-9p device, so that we > > can use -fsdev XXX -device xen-9p,YYY. This simple device should be > > used to capture the parameters

Re: [Xen-devel] [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 15 February 2016 13:16 > To: Paul Durrant > Cc: Wei Liu; qemu-de...@nongnu.org; Xen-devel; Anthony Perard; > gk...@linux.vnet.ibm.com; aneesh.ku...@linux.vnet.ibm.com; Stefano > Stabellini > Subject: Re: [Qemu-devel]

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Corneliu ZUZU
On 2/15/2016 2:44 PM, Jan Beulich wrote: switch ( mop->op ) { case XEN_DOMCTL_MONITOR_OP_ENABLE: case XEN_DOMCTL_MONITOR_OP_DISABLE: /* Check if event type is available. */ if ( unlikely(!(arch_monitor_get_capabilities(d) & (1 << mop->event))) )

Re: [Xen-devel] [PATCH] x86emul: fold almost identical code

2016-02-15 Thread Andrew Cooper
On 15/02/16 12:00, Jan Beulich wrote: > AAM/AAD as well as DAA/DAS emulation code is respectively almost > identical. Fold each pair, following what's already the case for > AAA/AAS. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-de

Re: [Xen-devel] [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-02-15 Thread Juergen Gross
On 15/02/16 14:16, Wei Liu wrote: > On Mon, Feb 15, 2016 at 09:07:13AM +, Paul Durrant wrote: >>> > [...] >>> # Option 2: Invent a xen-9p device >>> >>> Another way of doing it is to expose a dummy xen-9p device, so that we >>> can use -fsdev XXX -device xen-9p,YYY. This simple device should b

Re: [Xen-devel] [PATCH v2 11/30] xen/x86: Calculate maximum host and guest featuresets

2016-02-15 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -1,13 +1,165 @@ > #include > #include > +#include > +#include > +#include > + > +#define COMMON_1D INIT_COMMON_FEATURES > > const uint32_t known_features[] = INIT_KNOWN_FEATURES; > const uint

Re: [Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Andrew Cooper
On 15/02/16 12:06, Jan Beulich wrote: > Let's give the compiler as much liberty in picking instruction operands > as possible. Also drop unnecessary size modifiers when the correct size > can already be derived from the asm() operands. Finally also drop an > "unsigned" from idiv_dbl()'s second para

Re: [Xen-devel] [Qemu-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-02-15 Thread Wei Liu
On Mon, Feb 15, 2016 at 02:33:05PM +0100, Juergen Gross wrote: > On 15/02/16 14:16, Wei Liu wrote: > > On Mon, Feb 15, 2016 at 09:07:13AM +, Paul Durrant wrote: > >>> > > [...] > >>> # Option 2: Invent a xen-9p device > >>> > >>> Another way of doing it is to expose a dummy xen-9p device, so th

Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

2016-02-15 Thread Konrad Rzeszutek Wilk
On Sat, Feb 13, 2016 at 08:23:14PM -0500, Boris Ostrovsky wrote: > On 02/11/2016 04:10 PM, Konrad Rzeszutek Wilk wrote: > > > >This patch fixes the issue by: > > 1) Use kzalloc to initialize to a well known state. > > 2) Put 'struct pci_sysdata' at the start of 'pcifront_sd'. That > > way acc

Re: [Xen-devel] [PATCH v2 12/30] xen/x86: Generate deep dependencies of features

2016-02-15 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > @@ -20,12 +21,34 @@ uint32_t __read_mostly hvm_featureset[FSCAPINTS]; > > static void sanitise_featureset(uint32_t *fs) > { > +uint32_t disabled_features[FSCAPINTS]; > unsigned int i; > > for ( i = 0; i < FSCAPINTS; ++i ) > { > /

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 14:29, wrote: > On 2/15/2016 2:44 PM, Jan Beulich wrote: >> >>> switch ( mop->op ) >>> { >>> case XEN_DOMCTL_MONITOR_OP_ENABLE: >>> case XEN_DOMCTL_MONITOR_OP_DISABLE: >>> /* Check if event type is available. */ >>> if ( unlikely(!(arc

Re: [Xen-devel] [Qemu-devel] [PATCH] xen: xen_is_pirq_msi only when xen_enabled()

2016-02-15 Thread Markus Armbruster
Stefano Stabellini writes: > Only return true from xen_is_pirq_msi when Xen is enabled: the function > should never identify an MSI as Xen pirq when not running on Xen. Is this supposed to fix ivshmem-test with SPEED=slow? ___ Xen-devel mailing list X

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-15 Thread George Dunlap
On 12/02/16 00:22, Tamas K Lengyel wrote: > Currently the registers saved in the request depend on which type of event > is filling in the registers. In this patch we consolidate the two versions > of register filling function as to return a fix set of registers irrespective > of the underlying eve

Re: [Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 14:39, wrote: > On 15/02/16 12:06, Jan Beulich wrote: >> @@ -4542,9 +4542,10 @@ x86_emulate( >> >> case 0xbc: /* bsf or tzcnt */ { >> bool_t zf; >> -asm ( "bsf %2,%0; setz %b1" >> + >> +asm ( "bsf %2,%0; setz %1" >>: "=r" (dst.val)

Re: [Xen-devel] Two linkers - EFI one (mingw64) and normal GNU one [Fedora]

2016-02-15 Thread Konrad Rzeszutek Wilk
On Mon, Feb 15, 2016 at 02:32:45AM -0700, Jan Beulich wrote: > >>> On 12.02.16 at 18:19, wrote: > > Fedora for the longest time seems to have two linkers - one normal for GNU > > applications and then another - mingw64 - for building EFI applications. > > > > Which means that to compile ELF binar

Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

2016-02-15 Thread David Vrabel
On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: > --- a/drivers/pci/xen-pcifront.c > +++ b/drivers/pci/xen-pcifront.c > @@ -576,6 +578,7 @@ static void pcifront_free_roots(struct pcifront_device > *pdev) > free_root_bus_devs(bus_entry->bus); > > kfree(bus_entry->bus-

Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)

2016-02-15 Thread David Vrabel
On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: > Hey, > > These are patches that were developed for the Debian bug > 810379 which san Tommi had openned. > > The issue around from the two XSA fixes - which introduced > this regression. Applied to for-linus-4.6, thanks. I rewrote some of the com

[Xen-devel] Xen 4.6.1 released

2016-02-15 Thread Jan Beulich
All, I am pleased to announce the release of Xen 4.6.1. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.6 (tag RELEASE-4.6.1) or from the XenProject download page http://www.xenproject.org/downloads/xen-archives/xen-4

Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)

2016-02-15 Thread David Vrabel
On 15/02/16 14:35, David Vrabel wrote: > On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: >> Hey, >> >> These are patches that were developed for the Debian bug >> 810379 which san Tommi had openned. >> >> The issue around from the two XSA fixes - which introduced >> this regression. > > Applied to

[Xen-devel] [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1

2016-02-15 Thread Doug Goldstein
Switch from tracking a commit post 1.9.0 to the 1.9.1 release. Signed-off-by: Doug Goldstein --- Please make sure to sync git://xenbits.xen.org/seabios.git to upstream prior to pushing this to staging. --- Config.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Conf

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Andrew Cooper
On 15/02/16 09:20, Jan Beulich wrote: On 12.02.16 at 18:42, wrote: >> On 12/02/16 17:05, Jan Beulich wrote: >> On 05.02.16 at 14:42, wrote: +#define X86_FEATURE_VMXE ( 1*32+ 5) /*S Virtual Machine Extensions */ >>> Shouldn't this get a "nested-only" class? >> I am no

[Xen-devel] [linux-4.1 test] 82560: regressions - FAIL

2016-02-15 Thread osstest service owner
flight 82560 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/82560/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 66399 build-i386-rumpuserxen

Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.

2016-02-15 Thread Boris Ostrovsky
On 02/15/2016 09:05 AM, Konrad Rzeszutek Wilk wrote: On Sat, Feb 13, 2016 at 08:23:14PM -0500, Boris Ostrovsky wrote: On 02/11/2016 04:10 PM, Konrad Rzeszutek Wilk wrote: This patch fixes the issue by: 1) Use kzalloc to initialize to a well known state. 2) Put 'struct pci_sysdata' at the st

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 15:38, wrote: > On 15/02/16 09:20, Jan Beulich wrote: > On 12.02.16 at 18:42, wrote: >>> On 12/02/16 17:05, Jan Beulich wrote: >>> On 05.02.16 at 14:42, wrote: > #define X86_FEATURE_MWAITX( 3*32+29) /* MWAIT extension >>> (MONITORX/MWAITX) */ Why n

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Andrew Cooper
On 15/02/16 14:50, Jan Beulich wrote: On 15.02.16 at 15:38, wrote: >> On 15/02/16 09:20, Jan Beulich wrote: >> On 12.02.16 at 18:42, wrote: On 12/02/16 17:05, Jan Beulich wrote: On 05.02.16 at 14:42, wrote: >> #define X86_FEATURE_MWAITX( 3*32+29) /* MWAIT ex

Re: [Xen-devel] [PATCH v2 13/30] xen/x86: Clear dependent features when clearing a cpu cap

2016-02-15 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -53,8 +53,24 @@ static unsigned int cleared_caps[NCAPINTS]; > > void __init setup_clear_cpu_cap(unsigned int cap) > { > + const uint32_t *dfs; > + unsigned int i; > + > + if (

Re: [Xen-devel] [PATCH v2 13/30] xen/x86: Clear dependent features when clearing a cpu cap

2016-02-15 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -53,8 +53,24 @@ static unsigned int cleared_caps[NCAPINTS]; > > void __init setup_clear_cpu_cap(unsigned int cap) > { > + const uint32_t *dfs; > + unsigned int i; > + > + if (

Re: [Xen-devel] [PATCH v2 11/30] xen/x86: Calculate maximum host and guest featuresets

2016-02-15 Thread Andrew Cooper
On 15/02/16 13:37, Jan Beulich wrote: On 05.02.16 at 14:42, wrote: >> --- a/xen/arch/x86/cpuid.c >> +++ b/xen/arch/x86/cpuid.c >> @@ -1,13 +1,165 @@ >> #include >> #include >> +#include >> +#include >> +#include >> + >> +#define COMMON_1D INIT_COMMON_FEATURES >> >> const uint32_t kn

Re: [Xen-devel] Two linkers - EFI one (mingw64) and normal GNU one [Fedora]

2016-02-15 Thread Doug Goldstein
On 2/15/16 8:26 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 15, 2016 at 02:32:45AM -0700, Jan Beulich wrote: > On 12.02.16 at 18:19, wrote: >>> Fedora for the longest time seems to have two linkers - one normal for GNU >>> applications and then another - mingw64 - for building EFI applicati

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 15:53, wrote: > On 15/02/16 14:50, Jan Beulich wrote: > On 15.02.16 at 15:38, wrote: >>> On 15/02/16 09:20, Jan Beulich wrote: >>> On 12.02.16 at 18:42, wrote: > On 12/02/16 17:05, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> #define X86_FEAT

Re: [Xen-devel] [PATCH v2 11/30] xen/x86: Calculate maximum host and guest featuresets

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 15:57, wrote: > On 15/02/16 13:37, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> --- a/xen/arch/x86/cpuid.c >>> +++ b/xen/arch/x86/cpuid.c >>> @@ -1,13 +1,165 @@ >>> #include >>> #include >>> +#include >>> +#include >>> +#include >>> + >>> +#define COMMON_1D

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-15 Thread George Dunlap
On 12/02/16 14:59, Andrew Cooper wrote: > Coverity correctly identifies that the changes in mtrr_attrib_to_str() > introduce dead code. strings[] is a 2d array, rather than an array of > strings, which means that strings[x] will never be a NULL pointer. > > Adjust the check to compenstate, by loo

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-15 Thread Wei Liu
On Fri, Feb 12, 2016 at 07:24:59PM +0100, Olaf Hering wrote: [...] > > > > +if (libxl__xs_directory(gc, XBT_NULL, be_path, &be_dirs)) { > > > +rc = libxl__device_vscsi_reconfigure_add(egc, aodev, > > > &vscsi_saved, &d_config, be_path); > > > +if (rc) > > > +goto o

Re: [Xen-devel] [PATCH] tools/libxc: Fix use of zlib-options when building the domain builder

2016-02-15 Thread Roger Pau Monné
El 12/2/16 a les 20:21, Andrew Cooper ha escrit: > c/s de0f8c7c changed the use of zlib-options, and moved it from being locally > generated to coming from ./configure. > > However, it neglected to modify the users of zlib-options. The curious use of > $(call ...) was to select either the -D or -

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-15 Thread Olaf Hering
On Mon, Feb 15, Wei Liu wrote: > > I think yes, DEFINE_DEVICES_ADD has to be used somewhere. > I'm confused. You're joking, right? "Has to be used somewhere" is not > a justification for having it in this particular place. What would be the appropriate place? I think its there since I started wor

Re: [Xen-devel] [PATCH v2 12/30] xen/x86: Generate deep dependencies of features

2016-02-15 Thread Andrew Cooper
On 15/02/16 14:06, Jan Beulich wrote: On 05.02.16 at 14:42, wrote: >> @@ -20,12 +21,34 @@ uint32_t __read_mostly hvm_featureset[FSCAPINTS]; >> >> static void sanitise_featureset(uint32_t *fs) >> { >> +uint32_t disabled_features[FSCAPINTS]; >> unsigned int i; >> >> for ( i

Re: [Xen-devel] [PATCH v2 13/30] xen/x86: Clear dependent features when clearing a cpu cap

2016-02-15 Thread Andrew Cooper
On 15/02/16 14:53, Jan Beulich wrote: On 05.02.16 at 14:42, wrote: >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -53,8 +53,24 @@ static unsigned int cleared_caps[NCAPINTS]; >> >> void __init setup_clear_cpu_cap(unsigned int cap) >> { >> +const uint32_t *d

Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1)

2016-02-15 Thread Konrad Rzeszutek Wilk
On Mon, Feb 15, 2016 at 02:38:22PM +, David Vrabel wrote: > On 15/02/16 14:35, David Vrabel wrote: > > On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: > >> Hey, > >> > >> These are patches that were developed for the Debian bug > >> 810379 which san Tommi had openned. > >> > >> The issue around

Re: [Xen-devel] [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-15 Thread Andrew Cooper
On 15/02/16 15:02, Jan Beulich wrote: On 15.02.16 at 15:53, wrote: >> On 15/02/16 14:50, Jan Beulich wrote: >> On 15.02.16 at 15:38, wrote: On 15/02/16 09:20, Jan Beulich wrote: On 12.02.16 at 18:42, wrote: >> On 12/02/16 17:05, Jan Beulich wrote: >> On 05.02.1

Re: [Xen-devel] [PATCH v2 15/30] xen/x86: Improvements to in-hypervisor cpuid sanity checks

2016-02-15 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > @@ -4617,50 +4618,39 @@ void hvm_cpuid(unsigned int input, unsigned int *eax, > unsigned int *ebx, > /* Fix up VLAPIC details. */ > *ebx &= 0x00FFu; > *ebx |= (v->vcpu_id * 2) << 24; > + > +*ecx &= hvm_featureset[FEATURESET

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-15 Thread Wei Liu
On Mon, Feb 15, 2016 at 04:24:38PM +0100, Olaf Hering wrote: > On Mon, Feb 15, Wei Liu wrote: > > > > I think yes, DEFINE_DEVICES_ADD has to be used somewhere. > > I'm confused. You're joking, right? "Has to be used somewhere" is not > > a justification for having it in this particular place. > >

Re: [Xen-devel] [PATCH v2 11/30] xen/x86: Calculate maximum host and guest featuresets

2016-02-15 Thread Andrew Cooper
On 15/02/16 15:07, Jan Beulich wrote: > +uint32_t __read_mostly raw_featureset[FSCAPINTS]; +uint32_t __read_mostly host_featureset[FSCAPINTS]; +uint32_t __read_mostly pv_featureset[FSCAPINTS]; +uint32_t __read_mostly hvm_featureset[FSCAPINTS]; + +static void sanitise_f

Re: [Xen-devel] [PATCH v2 12/30] xen/x86: Generate deep dependencies of features

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 16:28, wrote: > On 15/02/16 14:06, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> @@ -20,12 +21,34 @@ uint32_t __read_mostly hvm_featureset[FSCAPINTS]; >>> >>> static void sanitise_featureset(uint32_t *fs) >>> { >>> +uint32_t disabled_features[FSCAPINTS]; >>>

[Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

2016-02-15 Thread Konrad Rzeszutek Wilk
Hey, I wanted to ask what folks would think of expanding the Wiki to include (making it a diff for simpler) this change. With my giant 30 set of patches that not only CC-ed xen-devel twice but had some patches CC some maintainers but not others - I figured it may be good to describe this in the

Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

2016-02-15 Thread Andrew Cooper
On 15/02/16 16:00, Konrad Rzeszutek Wilk wrote: > Hey, > > I wanted to ask what folks would think of expanding the Wiki to include > (making it a diff > for simpler) this change. With my giant 30 set of patches that not only CC-ed > xen-devel twice but had some patches CC some maintainers but not

[Xen-devel] [xen-unstable-smoke test] 82684: tolerable all pass - PUSHED

2016-02-15 Thread osstest service owner
flight 82684 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/82684/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v2 12/30] xen/x86: Generate deep dependencies of features

2016-02-15 Thread Andrew Cooper
On 15/02/16 15:52, Jan Beulich wrote: > --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -138,6 +138,61 @@ def crunch_numbers(state): state.hvm_shadow = featureset_to_uint32s(state.raw_hvm_shadow, >> nr_entries) state.hvm_hap = featureset_to_uint32s(s

Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

2016-02-15 Thread Roger Pau Monné
El 15/2/16 a les 17:00, Konrad Rzeszutek Wilk ha escrit: > Hey, > > I wanted to ask what folks would think of expanding the Wiki to include > (making it a diff > for simpler) this change. With my giant 30 set of patches that not only CC-ed > xen-devel twice but had some patches CC some maintainer

Re: [Xen-devel] [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1

2016-02-15 Thread Wei Liu
On Mon, Feb 15, 2016 at 08:38:02AM -0600, Doug Goldstein wrote: > Switch from tracking a commit post 1.9.0 to the 1.9.1 release. > Thanks for this patch. We can't apply this patch just yet. We need to wait a bit until the change to upstream trickles down to our own tree [0] -- OSSTest will work o

Re: [Xen-devel] [PATCH 01/14] xen: sched: __runq_tickle takes a useless cpu parameter

2016-02-15 Thread Konrad Rzeszutek Wilk
On Fri, Feb 05, 2016 at 07:33:34PM +0100, Dario Faggioli wrote: > as it is always acts on v->processor of the vcpu because > of which we are tickling. s/because of which// ? > > Getting rid of it makes the code easier to understand > and better looking. > > While there, remove a spurious blank

Re: [Xen-devel] [PATCH v3 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-15 Thread Tamas K Lengyel
On Mon, Feb 15, 2016 at 7:08 AM, Jan Beulich wrote: > >>> On 15.02.16 at 14:29, wrote: > > On 2/15/2016 2:44 PM, Jan Beulich wrote: > >> > >>> switch ( mop->op ) > >>> { > >>> case XEN_DOMCTL_MONITOR_OP_ENABLE: > >>> case XEN_DOMCTL_MONITOR_OP_DISABLE: > >>> /*

Re: [Xen-devel] [PATCH 02/14] xen: sched: move up the trace record for vcpu_wake and vcpu_sleep

2016-02-15 Thread Konrad Rzeszutek Wilk
On Fri, Feb 05, 2016 at 07:33:42PM +0100, Dario Faggioli wrote: > vcpu_wake() and vcpu_sleep() are called before the specific > schedulers wakeup and sleep routines (in fact, it is them > that calls those specific routine). Yeah!! > > Make the trace reflect that, by moving the records up. In > f

  1   2   >