>>> On 15.02.16 at 13:51, <andrew.coop...@citrix.com> wrote: > On 15/02/16 11:57, Jan Beulich wrote: >> ... and hence the respective {read,write}_msr() hook parameter doesn't >> need to be "unsigned long". >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > I would suggest uint32_t instead (being more architecturally > self-documenting), but either way, Reviewed-by: Andrew Cooper > <andrew.coop...@citrix.com>
While it might be "more architecturally self-documenting", it would also be less in line with types used elsewhere (at least for those pieces which I had looked at). This consistency consideration made me use unsigned int (which we imply to be at least 32 bits wide anyway). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel