Re: [Xen-devel] Error booting Xen

2016-02-03 Thread Shuai Ruan
On Tue, Feb 02, 2016 at 10:39:09AM +, Andrew Cooper wrote: > On 02/02/16 04:43, Shuai Ruan wrote: > > > >>> I tried booting staging branch but results were identical. Following > >>> line repeats endlessly. > >>> (XEN) traps.c:3290: GPF (): 82d0801c1cce -> 82d080252e5c > >>> > >>> $

Re: [Xen-devel] Error booting Xen

2016-02-03 Thread Dario Faggioli
Hey Harmandeep, On Fri, 2016-01-29 at 03:13 -0700, Jan Beulich wrote: > > > > On 28.01.16 at 20:17, wrote: > > Latest set looks good. No boot issues. No resets. > > Full log at http://paste2.org/NxHNW4vn  >  > > Sorry I don't know much about source of last few > > lines. I was just tracing in xen

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 12:48 AM, in message , George Dunlap wrote: > On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson > wrote: > > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > >> > Ought this function to really report success if these calls fail ? > >> > >> I think so. Till here

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-03 Thread Haozhong Zhang
On 02/02/16 14:15, Konrad Rzeszutek Wilk wrote: > > 3. Design of vNVDIMM in Xen > > Thank you for this design! > > > > > Similarly to that in KVM/QEMU, enabling vNVDIMM in Xen is composed of > > three parts: > > (1) Guest clwb/clflushopt/pcommit enabling, > > (2) Memory mapping, and > > (3)

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 08:10, wrote: > On 2/2/2016 11:21 PM, Jan Beulich wrote: > On 02.02.16 at 16:00, wrote: >>> The limit of 4G is to avoid the data missing from uint64 to uint32 >>> assignment. And I can accept the 8K limit for XenGT in practice. >>> After all, it is vGPU page tables we are t

[Xen-devel] [linux-4.1 test] 79950: regressions - FAIL

2016-02-03 Thread osstest service owner
flight 79950 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/79950/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 66399 build-i386-rumpuserxen

Re: [Xen-devel] [PATCH] x86/hvm: Provide list of emulated features in HVM CPUID leaf

2016-02-03 Thread Roger Pau Monné
El 3/2/16 a les 1:17, Andrew Cooper ha escrit: > On 02/02/2016 23:30, Boris Ostrovsky wrote: >> On 02/02/2016 06:22 PM, Andrew Cooper wrote: >>> On 02/02/2016 23:17, Boris Ostrovsky wrote: Hypervisor may choose which features to emulate for HVMlite guests. Guest will query the HVM CPUID l

Re: [Xen-devel] Xen 4.7 Development Update

2016-02-03 Thread Haozhong Zhang
On 02/01/16 10:45, Wei Liu wrote: [...] > = Projects = > > == Hypervisor == [...] > === x86 === [...] > * VMX TSC scaling support > - Haozhong Zhang v4 patch series was sent out. Patch 1 - 3 were merged. [...] > == Toolstack == > > * vNVDIMM support > - Haozhong Zhang v1 patch ser

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 08:00, wrote: > On 02/02/16 17:11, Stefano Stabellini wrote: >> Once upon a time somebody made the decision that ACPI tables >> on Xen should be static and included in hvmloader. That might have been >> a bad decision but at least it was coherent. Loading only *some* tables >> f

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 09:28, wrote: > On 02/02/16 14:15, Konrad Rzeszutek Wilk wrote: >> > 3.1 Guest clwb/clflushopt/pcommit Enabling >> > >> > The instruction enabling is simple and we do the same work as in KVM/QEMU. >> > - All three instructions are exposed to guest via guest cpuid. >> > - L1

Re: [Xen-devel] Nested virtualization off VMware vSphere 6.0 with EL6 guests crashes on Xen 4.6

2016-02-03 Thread Jan Beulich
>>> On 02.02.16 at 23:05, wrote: > This is getting more and more bizzare. > > I realized that this machine has VMCS shadowing so Xen does not trap on > any vmwrite or vmread. Unless I update the VMCS shadowing bitmap - which > I did for vmwrite and vmread to get a better view of this. It never >

Re: [Xen-devel] Xen 4.7 Development Update

2016-02-03 Thread Han, Huaitong
On Mon, 2016-02-01 at 10:45 +, Wei Liu wrote: > This email only tracks big items for xen.git tree. Please reply for > items you > woulk like to see in 4.7 so that people have an idea what is going on > and > prioritise accordingly. > > You're welcome to provide description and use cases of the

Re: [Xen-devel] [PATCH V8 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables

2016-02-03 Thread Jan Beulich
>>> On 02.02.16 at 08:35, wrote: > Protection keys define a new 4-bit protection key field(PKEY) in bits 62:59 > of > leaf entries of the page tables. > > PKRU register defines 32 bits, there are 16 domains and 2 attribute bits per > domain in pkru, for each i (0 ≤ i ≤ 15), PKRU[2i] is the acces

[Xen-devel] [PATCH 1/3] Move collectversions from ts-xen-build into Osstest::BuildSupport

2016-02-03 Thread Ian Campbell
I'm going to have a need for it elsewhere. Signed-off-by: Ian Campbell --- Osstest/BuildSupport.pm | 12 ts-xen-build| 13 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/Osstest/BuildSupport.pm b/Osstest/BuildSupport.pm index 933f6e1..a183

[Xen-devel] [PATCH 3/3] make-coverity-flight: set coverity_upload=true

2016-02-03 Thread Ian Campbell
Signed-off-by: Ian Campbell --- Apply once the previous patch + manual upload lead to us being happy. --- make-coverity-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make-coverity-flight b/make-coverity-flight index dafb61c..d086762 100755 --- a/make-coverity-flight +

[Xen-devel] [PATCH 2/3] Add a weekly coverity flight

2016-02-03 Thread Ian Campbell
This primarily consists of ts-coverity-scan and make-coverity-flight which constructs the sole job. The most recently scanned revision is pushed to a new coverity-scanned branch in the usual xen.git, tests are run on the master branch. For the cr-* integration we treat branch=coverity as a specia

Re: [Xen-devel] [PATCH v7 9/9] vring: Use the DMA API on Xen

2016-02-03 Thread David Vrabel
On 03/02/16 05:46, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski You forgot the previous Reviewed-by tags. David ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH OSSTEST 5/5 v2] mg-show-flight-runvars: recurse on buildjobs upon request

2016-02-03 Thread Ian Campbell
By looping over @rows looking for buildjobs runvars and adding those jobs to the output until nothing changes. The output is resorted by runvar name which is the desired default behaviour. As usual can be piped to sort(1) to sort by flight+job. Signed-off-by: Ian Campbell --- v2: - Use $jobcond

Re: [Xen-devel] [PATCH V8 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

2016-02-03 Thread Jan Beulich
>>> On 02.02.16 at 08:35, wrote: > This patch adds pkeys support for cpuid handing. > > Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is > CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of CR4.PKE. > > X86_FEATURE_OSXSAVE depends on guest X86_FEATURE_XSAVE, but cpu

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Ian Campbell
On Tue, 2016-02-02 at 15:06 -0700, Jim Fehlig wrote: > > > And extending > > the structure seems to be the right thing to do. > > So what do you think of the approach in the RFC patch? It adds discrete knobs > in > the disk config and extends the disk structure similarly. Before I can make > pro

Re: [Xen-devel] [PATCH 1/3] Move collectversions from ts-xen-build into Osstest::BuildSupport

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 09:46 +, Ian Campbell wrote: These 3 should all have been tagged "OSSTEST v2", sorry for the omission. > I'm going to have a need for it elsewhere. > > Signed-off-by: Ian Campbell > --- >  Osstest/BuildSupport.pm | 12 >  ts-xen-build| 13 +

Re: [Xen-devel] [PATCH V8 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

2016-02-03 Thread Han, Huaitong
On Wed, 2016-02-03 at 02:50 -0700, Jan Beulich wrote: > > > > On 02.02.16 at 08:35, wrote: > > This patch adds pkeys support for cpuid handing. > > > > Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is > > CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of > > CR4.PKE

Re: [Xen-devel] [PATCH V8 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables

2016-02-03 Thread Han, Huaitong
On Wed, 2016-02-03 at 02:43 -0700, Jan Beulich wrote: > > > > On 02.02.16 at 08:35, wrote: > > Protection keys define a new 4-bit protection key field(PKEY) in > > bits 62:59 > > of > > leaf entries of the page tables. > > > > PKRU register defines 32 bits, there are 16 domains and 2 attribute >

[Xen-devel] [PATCH] tools: libxencall/foreignmemory: initialise handle->fd

2016-02-03 Thread Ian Campbell
Otherwise the osdep close on the error path touches an uninitialised varialble. CID: 1351231 (foreignmemory) and 1351230 (call) Signed-off-by: Ian Campbell --- tools/libs/call/core.c | 2 ++ tools/libs/foreignmemory/core.c | 1 + 2 files changed, 3 insertions(+) diff --git a/tools/lib

[Xen-devel] [PATCH] libxenforeignmemory: handle partial failure correctly

2016-02-03 Thread Ian Campbell
Coverity rightly points out that checking for ret == NULL and then calling osdep unmap(ret) is wrong. The intention on this code path is to turn partial failure into total failure when the err argument is NULL, so we want to take this patch whenever ret is _non_ NULL (and err_to_free is set, indic

Re: [Xen-devel] [PATCH] libxl: Add CPU hotplug support for HVM domains without device model

2016-02-03 Thread Wei Liu
On Tue, Feb 02, 2016 at 04:02:12PM -0500, Boris Ostrovsky wrote: > HVMlite domains add/remove VCPUs by toggling "availability" property in > xenstore. > > Signed-off-by: Boris Ostrovsky If this is how it is supposed to work: Acked-by: Wei Liu However, I would like to ask for a follow-up patch

Re: [Xen-devel] [PATCH] tools: libxencall/foreignmemory: initialise handle->fd

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 10:09:42AM +, Ian Campbell wrote: > Otherwise the osdep close on the error path touches an uninitialised > varialble. > > CID: 1351231 (foreignmemory) and 1351230 (call) > > Signed-off-by: Ian Campbell Acked-by: Wei Liu > --- > tools/libs/call/core.c | 2

Re: [Xen-devel] [PATCH] libxenforeignmemory: handle partial failure correctly

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 10:10:01AM +, Ian Campbell wrote: > Coverity rightly points out that checking for ret == NULL and then > calling osdep unmap(ret) is wrong. > > The intention on this code path is to turn partial failure into total > failure when the err argument is NULL, so we want to t

Re: [Xen-devel] [PATCH 2/3] Add a weekly coverity flight

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 09:46 +, Ian Campbell wrote: > [...] > +sub build () { > +my $make = "make $makeflags"; > + > +# Pre build things we don't want coverity to scan, but which are > +# normally built by some other command. > +target_cmd_build($ho, 1000, $builddir, < +cd $build

[Xen-devel] [distros-debian-squeeze test] 38724: all pass

2016-02-03 Thread Platform Team regression test user
flight 38724 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38724/ Perfect :-) All tests in this flight passed baseline version: flight 38707 jobs: build-amd64 pass build-armhf

[Xen-devel] [libvirt bisection] complete build-i386-libvirt

2016-02-03 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen

Re: [Xen-devel] [PATCH] libxc: fix uninitialised usage of rc in meminit_hvm

2016-02-03 Thread Ian Campbell
On Tue, 2016-02-02 at 12:37 +, Wei Liu wrote: > On Tue, Feb 02, 2016 at 12:33:20PM +0100, Roger Pau Monne wrote: > > From: Roger Pau Monne > > > > Due to the HVMlite changes there's a chance that the value in rc is > > checked > > without being initialised. Fix this by initialising it to 0. >

Re: [Xen-devel] vm_event regression in 4.7

2016-02-03 Thread Andrew Cooper
On 03/02/16 01:32, Tamas K Lengyel wrote: > > > On Tue, Feb 2, 2016 at 6:00 PM, Andrew Cooper > mailto:andrew.coop...@citrix.com>> wrote: > > On 03/02/2016 00:51, Tamas K Lengyel wrote: >> Hello all, >> with the latest master branch of Xen there is a regression >> enabling vm_event

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Wei Liu
On Tue, Feb 02, 2016 at 03:06:01PM -0700, Jim Fehlig wrote: > Wei Liu wrote: > > On Mon, Jan 25, 2016 at 05:25:02PM -0700, Jim Fehlig wrote: > >> I would like to hear the community's opinion on supporting more qdisk > >> types in > >> xl/libxl, e.g. nbd, rbd, iSCSI, etc. I prefer supporting additi

[Xen-devel] Leaks in xc_tbuf_get_size() (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
George, Looks like xentrace is the only maintained component which uses this. so tag ;-) On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > * CID 1351228:    (RESOURCE_LEAK) > /tools/libxc/xc_tbuf.c: 73 in xc_tbuf_get_size() > /tools/libxc/xc_tbuf.c: 77 in xc_tbuf_get_size() Cov

[Xen-devel] Leak in xc_dom_load_hvm_kernel() (Was; Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
Roger, On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > ** CID 1351227:    (RESOURCE_LEAK) > /tools/libxc/xc_dom_hvmloader.c: 260 in xc_dom_load_hvm_kernel() > /tools/libxc/xc_dom_hvmloader.c: 270 in xc_dom_load_hvm_kernel() > /tools/libxc/xc_dom_hvmloader.c: 277 in xc_dom_load_

Re: [Xen-devel] Leaks in xc_tbuf_get_size() (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Andrew Cooper
On 03/02/16 10:37, Ian Campbell wrote: > George, > > Looks like xentrace is the only maintained component which uses this. so > tag ;-) > > On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: >> * CID 1351228:(RESOURCE_LEAK) >> /tools/libxc/xc_tbuf.c: 73 in xc_tbuf_get_size() >> /

Re: [Xen-devel] [PATCH] libxc: fix uninitialised usage of rc in meminit_hvm

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 10:30:54AM +, Ian Campbell wrote: > On Tue, 2016-02-02 at 12:37 +, Wei Liu wrote: > > On Tue, Feb 02, 2016 at 12:33:20PM +0100, Roger Pau Monne wrote: > > > From: Roger Pau Monne > > > > > > Due to the HVMlite changes there's a chance that the value in rc is > > >

[Xen-devel] [PATCH] tools: xenconsole: cleanup when clock_gettime fails.

2016-02-03 Thread Ian Campbell
All other error paths in the infinite loop in handle_io use break, so as to free resources. CID: 1351226 Signed-off-by: Ian Campbell --- tools/console/daemon/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c index e2e7

Re: [Xen-devel] [PATCH] libxc: fix uninitialised usage of rc in meminit_hvm

2016-02-03 Thread Roger Pau Monné
El 3/2/16 a les 11:30, Ian Campbell ha escrit: > On Tue, 2016-02-02 at 12:37 +, Wei Liu wrote: >> On Tue, Feb 02, 2016 at 12:33:20PM +0100, Roger Pau Monne wrote: >>> From: Roger Pau Monne >>> >>> Due to the HVMlite changes there's a chance that the value in rc is >>> checked >>> without being

[Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > * CID 1351223:  Concurrent data access violations  (MISSING_LOCK) > /xen/include/xen/spinlock.h: 362 in _percpu_write_unlock() Coverity seems to think this is new in 41b0aa569adb..9937763265d, presumably due to  commit f9dd43dddc

Re: [Xen-devel] [PATCH 2/3] Add a weekly coverity flight

2016-02-03 Thread Andrew Cooper
On 03/02/16 10:19, Ian Campbell wrote: > On Wed, 2016-02-03 at 09:46 +, Ian Campbell wrote: >> [...] >> +sub build () { >> +my $make = "make $makeflags"; >> + >> +# Pre build things we don't want coverity to scan, but which are >> +# normally built by some other command. >> +ta

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:45 +, Ian Campbell wrote: > On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > > * CID 1351223:  Concurrent data access violations  (MISSING_LOCK) > > /xen/include/xen/spinlock.h: 362 in _percpu_write_unlock() > > Coverity seems to think this is new in

Re: [Xen-devel] [PATCH] tools: xenconsole: cleanup when clock_gettime fails.

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 10:43:47AM +, Ian Campbell wrote: > All other error paths in the infinite loop in handle_io use break, so > as to free resources. > > CID: 1351226 > > Signed-off-by: Ian Campbell Acked-by: Wei Liu > --- > tools/console/daemon/io.c | 2 +- > 1 file changed, 1 inser

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Andrew Cooper
On 03/02/16 10:45, Ian Campbell wrote: > On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: >> * CID 1351223: Concurrent data access violations (MISSING_LOCK) >> /xen/include/xen/spinlock.h: 362 in _percpu_write_unlock() > Coverity seems to think this is new in 41b0aa569adb..993776

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:35 +, Wei Liu wrote: > > Ok. So in your opinion, even if any new disk config is encoded in 'target=', > > libxlu should split that up into (new) members of libxl_device_disk, not > > just > > plop it into libxl_device_disk.pdev_path? > > > > No, not necessarily. I di

Re: [Xen-devel] [PATCH] libxc: fix uninitialised usage of rc in meminit_hvm

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 11:44 +0100, Roger Pau Monné wrote: > El 3/2/16 a les 11:30, Ian Campbell ha escrit: > > On Tue, 2016-02-02 at 12:37 +, Wei Liu wrote: > > > On Tue, Feb 02, 2016 at 12:33:20PM +0100, Roger Pau Monne wrote: > > > > From: Roger Pau Monne > > > > > > > > Due to the HVMlite

Re: [Xen-devel] Leaks in xc_tbuf_get_size() (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:42 +, Andrew Cooper wrote: > On 03/02/16 10:37, Ian Campbell wrote: > > George, > > > > Looks like xentrace is the only maintained component which uses this. > > so > > tag ;-) > > > > On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > > > * CID 13512

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 10:51:27AM +, Ian Campbell wrote: > On Wed, 2016-02-03 at 10:35 +, Wei Liu wrote: > > > Ok. So in your opinion, even if any new disk config is encoded in > > > 'target=', > > > libxlu should split that up into (new) members of libxl_device_disk, not > > > just > >

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:50 +, Andrew Cooper wrote: > On 03/02/16 10:45, Ian Campbell wrote: > > On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > > > * CID 1351223:  Concurrent data access violations  (MISSING_LOCK) > > > /xen/include/xen/spinlock.h: 362 in _percpu_write_unlo

[Xen-devel] [PATCH] libxc: fix leak in xc_dom_load_hvm_kernel error path

2016-02-03 Thread Roger Pau Monne
Error path in xc_dom_load_hvm_kernel needs to use the 'error' label instead of directly returning. This is needed so the entries local variable is freed. Coverity-ID: 1351227 Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Ian Campbell Cc: Wei Liu --- tools/libxc/xc_dom_hvmloader.c | 6

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:55 +, Wei Liu wrote: > On Wed, Feb 03, 2016 at 10:51:27AM +, Ian Campbell wrote: > > On Wed, 2016-02-03 at 10:35 +, Wei Liu wrote: > > > > Ok. So in your opinion, even if any new disk config is encoded in > > > > 'target=', > > > > libxlu should split that up in

Re: [Xen-devel] [PATCH V8 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 11:04, wrote: > On Wed, 2016-02-03 at 02:50 -0700, Jan Beulich wrote: >> > > > On 02.02.16 at 08:35, wrote: >> > This patch adds pkeys support for cpuid handing. >> > >> > Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is >> > CPUID.7.0.ECX[4]:OSPKE and it re

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Wei Liu
On Wed, Feb 03, 2016 at 11:05:04AM +, Ian Campbell wrote: > On Wed, 2016-02-03 at 10:55 +, Wei Liu wrote: > > On Wed, Feb 03, 2016 at 10:51:27AM +, Ian Campbell wrote: > > > On Wed, 2016-02-03 at 10:35 +, Wei Liu wrote: > > > > > Ok. So in your opinion, even if any new disk config i

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-03 Thread Roger Pau Monné
El 3/2/16 a les 12:05, Ian Campbell ha escrit: > On Wed, 2016-02-03 at 10:55 +, Wei Liu wrote: >> On Wed, Feb 03, 2016 at 10:51:27AM +, Ian Campbell wrote: >>> On Wed, 2016-02-03 at 10:35 +, Wei Liu wrote: > Ok. So in your opinion, even if any new disk config is encoded in > 'ta

Re: [Xen-devel] Status of multiboot2 support on EFI?

2016-02-03 Thread Wei Liu
On Tue, Feb 02, 2016 at 01:02:56PM -0800, PGNet Dev wrote: > Here http://wiki.xenproject.org/wiki/Xen_EFI#Xen_as_gz_binary refers to > original discussion in 2013 (work has been deferred to Xen 4.6. ) > > and says "work has been deferred to Xen 4.6." > > >I think that this should be Xen 4.8 targe

Re: [Xen-devel] [PATCHv3 1/2] spinlock: move rwlock API and per-cpu rwlocks into their own files

2016-02-03 Thread Jan Beulich
>>> On 01.02.16 at 12:31, wrote: > From: Jennifer Herbert > > In preparation for a replacement read-write lock implementation, move > the API and the per-cpu read-write locks into their own files. > > Signed-off-by: Jennifer Herbert > Signed-off-by: David Vrabel I suppose this was meant to a

Re: [Xen-devel] [PATCHv3 2/2] spinlock: fair read-write locks

2016-02-03 Thread Jan Beulich
>>> On 01.02.16 at 12:31, wrote: > +void queue_write_lock_slowpath(rwlock_t *lock) > +{ > +u32 cnts; > + > +/* Put the writer into the wait queue. */ > +spin_lock(&lock->lock); > + > +/* Try to acquire the lock directly if no reader is present. */ > +if ( !atomic_read(&lock->cn

Re: [Xen-devel] Error booting Xen

2016-02-03 Thread Harmandeep Kaur
On Wed, Feb 3, 2016 at 1:53 PM, Dario Faggioli wrote: > Hey Harmandeep, > > On Fri, 2016-01-29 at 03:13 -0700, Jan Beulich wrote: >> > > > On 28.01.16 at 20:17, wrote: >> > Latest set looks good. No boot issues. No resets. >> > Full log at http://paste2.org/NxHNW4vn >> >> > Sorry I don't know muc

[Xen-devel] [qemu-mainline baseline-only test] 38723: tolerable FAIL

2016-02-03 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38723 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38723/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl 19 guest-start/debian.repe

[Xen-devel] [PATCH v2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Corneliu ZUZU
When __p2m_get_mem_access gets called, the p2m lock is already taken by either get_page_from_gva or p2m_get_mem_access. Possible code paths: 1) -> get_page_from_gva -> p2m_mem_access_check_and_get_page -> __p2m_get_mem_access 2) -> p2m_get_mem_acces

Re: [Xen-devel] [PATCH 2/2] x86/xsave: use alternative asm on xsave side.

2016-02-03 Thread Jan Beulich
>>> On 02.02.16 at 08:11, wrote: > --- a/xen/arch/x86/xstate.c > +++ b/xen/arch/x86/xstate.c > @@ -248,24 +248,26 @@ void xsave(struct vcpu *v, uint64_t mask) > uint32_t hmask = mask >> 32; > uint32_t lmask = mask; > int word_size = mask & XSTATE_FP ? (cpu_has_fpu_sel ? 8 : 0) : -1;

Re: [Xen-devel] [PATCH 1/4] libxl: Use libxl_strdup instead of strdup on libxl_version_info

2016-02-03 Thread Ian Campbell
On Mon, 2016-02-01 at 12:13 +, Wei Liu wrote: > On Tue, Jan 26, 2016 at 04:30:57PM -0500, Konrad Rzeszutek Wilk wrote: > > The change is simple replace of raw strdup with a libxl variant. > > The benefit of that is the libxl variant has the extra > > behaviour of abort-on-alloc-fail - and will

Re: [Xen-devel] xen/arm: drop hip04 support

2016-02-03 Thread Ian Campbell
On Tue, 2016-02-02 at 13:13 +, Zoltan Kiss wrote: > This platform is no longer actively used, but it makes GICv2 development > harder. > > Signed-off-by: Zoltan Kiss Thanks, I appreciate the proactive removal of no-longer supported platforms. I was going to ask you to confirm that you were

Re: [Xen-devel] [PATCH 2/4] libxc/xc_domain_resume: Update comment.

2016-02-03 Thread Ian Campbell
On Mon, 2016-02-01 at 12:14 +, Wei Liu wrote: > On Tue, Jan 26, 2016 at 04:30:58PM -0500, Konrad Rzeszutek Wilk wrote: > > To hopefully clarify what it meant. Also point out that mechanism > > by which the return 1 value is done is via an intimate knowledge of the > > hypercall ABI (i.e. which

Re: [Xen-devel] [PATCH 4/4] tools/libxl: run_helper - add #define for arguments.

2016-02-03 Thread Ian Campbell
On Tue, 2016-01-26 at 16:31 -0500, Konrad Rzeszutek Wilk wrote: > Describe what the four (or more in the future) arguments > are for. > > Acked-by: Ian Jackson > Signed-off-by: Konrad Rzeszutek Wilk applied. > --- >  tools/libxl/libxl_save_callout.c | 11 ++- >  1 file changed, 10 inse

Re: [Xen-devel] [PATCH] tools/libxc: Provide evtchn_port_or_error_t for compat xenctrl interface

2016-02-03 Thread Ian Campbell
On Mon, 2016-02-01 at 11:19 +, Ian Campbell wrote: > On Mon, 2016-02-01 at 11:08 +, Andrew Cooper wrote: > > c/s 2d2f789 "tools: rename libxc's evtchn_port_or_error_t with an xc_ > > prefix" doesn't cater for older applications which have requested > > XC_WANT_COMPAT_EVTCHN_API > > I think

Re: [Xen-devel] [PATCH] xl: don't free additional memory on soft reset

2016-02-03 Thread Ian Campbell
On Mon, 2016-02-01 at 10:39 +, Wei Liu wrote: > On Thu, Jan 28, 2016 at 11:58:25AM +0100, Vitaly Kuznetsov wrote: > > We don't need to free anything extra from Dom0 in order to perform soft > > reset. It can also fail soft reset if it happens that we don't have > > this > > memory (which we don

Re: [Xen-devel] [PATCH V2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Ian Campbell
On Wed, 2016-01-27 at 14:24 +0200, Corneliu ZUZU wrote: > When __p2m_get_mem_access gets called, the p2m lock is already taken > by either get_page_from_gva or p2m_get_mem_access. > > Possible code paths: > 1)-> get_page_from_gva > -> p2m_mem_access_check_and_get_page >

Re: [Xen-devel] [PATCH 3/3] tools/libxl: run_helper - add #define for arguments.

2016-02-03 Thread Ian Campbell
On Tue, 2016-01-26 at 16:25 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 3/3] tools/libxl: run_helper - add > #define for arguments."): > > On Mon, 2016-01-25 at 16:06 -0500, Konrad Rzeszutek Wilk wrote: > > > Describe what the four (or more in the future) arguments > > > are for. >

Re: [Xen-devel] [PATCH] libxl: Add CPU hotplug support for HVM domains without device model

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:10 +, Wei Liu wrote: > On Tue, Feb 02, 2016 at 04:02:12PM -0500, Boris Ostrovsky wrote: > > HVMlite domains add/remove VCPUs by toggling "availability" property in > > xenstore. > > > > Signed-off-by: Boris Ostrovsky > > If this is how it is supposed to work: > > Ac

Re: [Xen-devel] [PATCH] libxc: fix leak in xc_dom_load_hvm_kernel error path

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 11:59 +0100, Roger Pau Monne wrote: > Error path in xc_dom_load_hvm_kernel needs to use the 'error' label > instead > of directly returning. This is needed so the entries local variable is > freed. > > Coverity-ID: 1351227 > Signed-off-by: Roger Pau Monné Acked + applied, t

Re: [Xen-devel] [PATCH] libxenforeignmemory: handle partial failure correctly

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:17 +, Wei Liu wrote: > On Wed, Feb 03, 2016 at 10:10:01AM +, Ian Campbell wrote: > > Coverity rightly points out that checking for ret == NULL and then > > calling osdep unmap(ret) is wrong. > > > > The intention on this code path is to turn partial failure into to

Re: [Xen-devel] [PATCH] tools: xenconsole: cleanup when clock_gettime fails.

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:49 +, Wei Liu wrote: > On Wed, Feb 03, 2016 at 10:43:47AM +, Ian Campbell wrote: > > All other error paths in the infinite loop in handle_io use break, so > > as to free resources. > > > > CID: 1351226 > > > > Signed-off-by: Ian Campbell > > Acked-by: Wei Liu

Re: [Xen-devel] [PATCH] tools: libxencall/foreignmemory: initialise handle->fd

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 10:15 +, Wei Liu wrote: > On Wed, Feb 03, 2016 at 10:09:42AM +, Ian Campbell wrote: > > Otherwise the osdep close on the error path touches an uninitialised > > varialble. > > > > CID: 1351231 (foreignmemory) and 1351230 (call) > > > > Signed-off-by: Ian Campbell >

Re: [Xen-devel] [PATCH] xenstore: add stddef.h to xenstore_lib.h

2016-02-03 Thread Ian Campbell
On Thu, 2016-01-28 at 10:37 +, Wei Liu wrote: > On Wed, Jan 27, 2016 at 05:06:09PM +, Ian Campbell wrote: > > xs_perm_to_string takes a size_t which isn't defined by anything > > pulled in directly by this header. > > > > Given the other headers xenstore_lib.h pulls in this looks to be an

Re: [Xen-devel] [PATCH] tools/libxl: improve logging on domain create failure.

2016-02-03 Thread Ian Campbell
On Thu, 2016-01-28 at 10:52 +, Wei Liu wrote: > On Tue, Jan 26, 2016 at 02:38:46PM +, Ian Campbell wrote: > > A user reported[0] that xl create failed with just: > > libxl: error: libxl_create.c:892:initiate_domain_create: Unable to > > set domain build info defaults > > and some result

Re: [Xen-devel] [PATCH v2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 13:37 +0200, Corneliu ZUZU wrote: I just now applied a previous v2 which was already in my queue. Was this just an accidental resend of v2 or is there some important change and this is really a v3? > When __p2m_get_mem_access gets called, the p2m lock is already taken > by e

Re: [Xen-devel] [PATCHv3 2/2] spinlock: fair read-write locks

2016-02-03 Thread David Vrabel
On 03/02/16 11:28, Jan Beulich wrote: On 01.02.16 at 12:31, wrote: >> +void queue_write_lock_slowpath(rwlock_t *lock) >> +{ >> +u32 cnts; >> + >> +/* Put the writer into the wait queue. */ >> +spin_lock(&lock->lock); >> + >> +/* Try to acquire the lock directly if no reader is

Re: [Xen-devel] [PATCH OSSTEST 5/5 v2] mg-show-flight-runvars: recurse on buildjobs upon request

2016-02-03 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 5/5 v2] mg-show-flight-runvars: recurse on buildjobs upon request"): > By looping over @rows looking for buildjobs runvars and adding those > jobs to the output until nothing changes. > > The output is resorted by runvar name which is the desired default > beh

Re: [Xen-devel] [PATCH 1/3] Move collectversions from ts-xen-build into Osstest::BuildSupport

2016-02-03 Thread Ian Jackson
Ian Campbell writes ("[PATCH 1/3] Move collectversions from ts-xen-build into Osstest::BuildSupport"): > I'm going to have a need for it elsewhere. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-03 Thread Stefano Stabellini
On Wed, 3 Feb 2016, Haozhong Zhang wrote: > On 02/02/16 17:11, Stefano Stabellini wrote: > > Haozhong, thanks for your work! > > > > On Mon, 1 Feb 2016, Haozhong Zhang wrote: > > > 3.2 Address Mapping > > > > > > 3.2.1 My Design > > > > > > The overview of this design is shown in the following

Re: [Xen-devel] [PATCH 2/2] x86/xsave: use alternative asm on xsave side.

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 12:40, wrote: On 02.02.16 at 08:11, wrote: >> --- a/xen/arch/x86/xstate.c >> +++ b/xen/arch/x86/xstate.c >> @@ -248,24 +248,26 @@ void xsave(struct vcpu *v, uint64_t mask) >> uint32_t hmask = mask >> 32; >> uint32_t lmask = mask; >> int word_size = mask & XS

Re: [Xen-devel] [PATCH 2/3] Add a weekly coverity flight

2016-02-03 Thread Ian Jackson
Ian Campbell writes ("[PATCH 2/3] Add a weekly coverity flight"): > In my experiments the curl command took ~35 minutes to complete (rate > in the 100-200k range). Not sure if this is a problem. Note that curl > is run on the controller (via system_checked) and consequently has no > timeout etc. C

Re: [Xen-devel] [PATCH 3/3] make-coverity-flight: set coverity_upload=true

2016-02-03 Thread Ian Jackson
Ian Campbell writes ("[PATCH 3/3] make-coverity-flight: set coverity_upload=true"): > Signed-off-by: Ian Campbell > --- > Apply once the previous patch + manual upload lead to us being happy. I'll ack this at that time. Obviously there's nothing to review :-). Ian. ___

Re: [Xen-devel] [PATCH 2/3] Add a weekly coverity flight

2016-02-03 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 2/3] Add a weekly coverity flight"): > On 03/02/16 10:19, Ian Campbell wrote: > > Andy, I presume you deliberately started excluding stubdoms at some point? > > I think this is probably the right thing to do, at least for now, since > > stubdoms run with guest priv

Re: [Xen-devel] [PATCHv3 2/2] spinlock: fair read-write locks

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 12:57, wrote: > On 03/02/16 11:28, Jan Beulich wrote: > On 01.02.16 at 12:31, wrote: >>> +void queue_write_lock_slowpath(rwlock_t *lock) >>> +{ >>> +u32 cnts; >>> + >>> +/* Put the writer into the wait queue. */ >>> +spin_lock(&lock->lock); >>> + >>> +/* Try

Re: [Xen-devel] [PATCH V2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Corneliu ZUZU
On 2/3/2016 1:48 PM, Ian Campbell wrote: On Wed, 2016-01-27 at 14:24 +0200, Corneliu ZUZU wrote: When __p2m_get_mem_access gets called, the p2m lock is already taken by either get_page_from_gva or p2m_get_mem_access. Possible code paths: 1) -> get_page_from_gva -> p2m_mem_a

Re: [Xen-devel] [PATCH v6 6/8] arm/gic-v3: Refactor gicv3_init into generic and dt specific parts

2016-02-03 Thread Ian Campbell
On Sat, 2016-01-30 at 17:03 +0800, Shannon Zhao wrote: > > On 2016/1/28 18:27, Stefano Stabellini wrote: > > On Thu, 28 Jan 2016, Shannon Zhao wrote: > > > > From: Shannon Zhao > > > > > > > > Refactor gic-v3 related functions into dt and generic parts. This > > > > will be > > > > helpful when

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Andrew Cooper
On 03/02/16 11:00, Ian Campbell wrote: > On Wed, 2016-02-03 at 10:50 +, Andrew Cooper wrote: >> On 03/02/16 10:45, Ian Campbell wrote: >>> On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: * CID 1351223: Concurrent data access violations (MISSING_LOCK) /xen/include/x

Re: [Xen-devel] [PATCH v2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Corneliu ZUZU
On 2/3/2016 1:52 PM, Ian Campbell wrote: On Wed, 2016-02-03 at 13:37 +0200, Corneliu ZUZU wrote: I just now applied a previous v2 which was already in my queue. Was this just an accidental resend of v2 or is there some important change and this is really a v3? When __p2m_get_mem_access gets ca

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-02-03 Thread Haozhong Zhang
On 02/03/16 02:18, Jan Beulich wrote: > >>> On 03.02.16 at 09:28, wrote: > > On 02/02/16 14:15, Konrad Rzeszutek Wilk wrote: > >> > 3.1 Guest clwb/clflushopt/pcommit Enabling > >> > > >> > The instruction enabling is simple and we do the same work as in > >> > KVM/QEMU. > >> > - All three inst

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-03 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 03 February 2016 08:33 > To: Zhang Yu > Cc: Andrew Cooper; Ian Campbell; Paul Durrant; Wei Liu; Ian Jackson; Stefano > Stabellini; Kevin Tian; zhiyuan...@intel.com; xen-devel@lists.xen.org; Keir > (Xen.org) > Subjec

Re: [Xen-devel] Xen 4.7 Development Update

2016-02-03 Thread Olaf Hering
On Mon, Feb 01, Wei Liu wrote: > == Toolstack == > * Libxl PVSCSI support > - Olaf Hering I will send a new variant later this week. Getting pvscsi into 4.7 will most likely require much of your time for review, I hope you guys find the time and energy to do that. Olaf __

Re: [Xen-devel] [PATCH V2] arm: p2m.c bug-fix: hypervisor hang on __p2m_get_mem_access

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 13:54 +0200, Corneliu ZUZU wrote: > On 2/3/2016 1:48 PM, Ian Campbell wrote: > > On Wed, 2016-01-27 at 14:24 +0200, Corneliu ZUZU wrote: > > > When __p2m_get_mem_access gets called, the p2m lock is already taken > > > by either get_page_from_gva or p2m_get_mem_access. > > > >

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Andrew Cooper
On 03/02/16 12:21, Andrew Cooper wrote: > On 03/02/16 11:00, Ian Campbell wrote: >> On Wed, 2016-02-03 at 10:50 +, Andrew Cooper wrote: >>> On 03/02/16 10:45, Ian Campbell wrote: On Tue, 2016-02-02 at 20:23 -0800, scan-ad...@coverity.com wrote: > * CID 1351223: Concurrent data access

Re: [Xen-devel] [PATCH v4] xen: sched: convert RTDS from time to event driven model

2016-02-03 Thread Dario Faggioli
On Tue, 2016-02-02 at 22:33 -0500, Meng Xu wrote: > On Tue, Feb 2, 2016 at 10:08 AM, Dario Faggioli > wrote: > >  > > Is it ok to kill the replenishment in this case? > > > > This is a genuine question. What does the dynamic DS algorithm that > > you're trying to implement here says about this? M

[Xen-devel] [PATCH v2 0/2] x86: also use alternative asm on xsave side

2016-02-03 Thread Jan Beulich
1: support 2- and 3-way alternatives 2: xstate: also use alternative asm on xsave side Signed-off-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] missing lock in percpu_rwlock? (Was: Re: New Defects reported by Coverity Scan for XenProject)

2016-02-03 Thread Ian Campbell
On Wed, 2016-02-03 at 12:24 +, Andrew Cooper wrote: > On 03/02/16 12:21, Andrew Cooper wrote: > > On 03/02/16 11:00, Ian Campbell wrote: > > > On Wed, 2016-02-03 at 10:50 +, Andrew Cooper wrote: > > > > On 03/02/16 10:45, Ian Campbell wrote: > > > > > On Tue, 2016-02-02 at 20:23 -0800, scan

Re: [Xen-devel] [PATCH v3 3/3] tools: introduce parameter max_wp_ram_ranges.

2016-02-03 Thread Jan Beulich
>>> On 03.02.16 at 13:20, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 03 February 2016 08:33 >> To: Zhang Yu >> Cc: Andrew Cooper; Ian Campbell; Paul Durrant; Wei Liu; Ian Jackson; Stefano >> Stabellini; Kevin Tian; zhiyuan...@intel.com; xen-devel

  1   2   3   >