>>> On 2/3/2016 at 12:48 AM, in message
<CAFLBxZY38HfouhD4eS63+HieQ8dfsza=ry7r_cnghknmvlo...@mail.gmail.com>, George
Dunlap <george.dun...@eu.citrix.com> wrote:
> On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson <ian.jack...@eu.citrix.com>
> wrote:
> > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"):
> >> > Ought this function to really report success if these calls fail ?
> >>
> >> I think so. Till here, the USB device has already been unbound from
> >> usbback and removed from xenstore. usb-list cannot list it any more.
>
> Also, I think we probably should return some sort of error, so that
> scripts &c can at least know something out of the ordinary has
> happened, even if it doesn't go back to the state we started in when
> the function was called.
That makes sense. But do we need to differentiate failure at removing
xenstore information step and error in bind/unbind step? Or, treat
them as same? That affects doing it within other process (like
usbctrl-detach). For the former, xl usb-list can list usb device and
one can do usbdev-detach again; and if in a usbctrl-detach process,
will stop the process. For the later, one cannot do usbdev-detach,
and if in usbctrl-detach process, in current codes, will ignore that.
Chunyan
>
> -George
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
