Re: [Xen-devel] [PATCH v2 1/2] xen: move wallclock functions from x86 to common

2015-11-10 Thread Shannon Zhao
Hi Stefano, When I apply this patch, there are some warnings. Applying: xen: move wallclock functions from x86 to common /home/open-source/xen/.git/rebase-apply/patch:268: trailing whitespace. return wc_sec + (wc_nsec + NOW()) / 10ULL /home/open-source/xen/.git/rebase-apply/patch:299:

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Shannon Zhao
Hi Stefano, When I apply this patch, there are some warnings too. Applying: arm: export platform_op XENPF_settime64 /home/open-source/xen/.git/rebase-apply/patch:67: trailing whitespace. * /home/open-source/xen/.git/rebase-apply/patch:69: trailing whitespace. * /home/open-source/xen/.git/rebase

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/10/2015 at 02:11 AM, in message <22080.57829.461049.37...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V8 3/7] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach us

Re: [Xen-devel] [PATCH v1 01/11] xsplice: Design document (v2).

2015-11-10 Thread Ross Lagerwall
On 11/03/2015 06:15 PM, Ross Lagerwall wrote: From: Konrad Rzeszutek Wilk snip +## Patching code + +The first mechanism to patch that comes in mind is in-place replacement. +That is replace the affected code with new code. Unfortunately the x86 +ISA is variable size which places limits on how

[Xen-devel] [ovmf test] 63933: all pass - PUSHED

2015-11-10 Thread osstest service owner
flight 63933 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/63933/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf 3ab1434a6ede4e006ef0b001108c354f4fa6d91e baseline version: ovmf 3ec97ca490009ed5604ccd7f2653e5a9ecb

Re: [Xen-devel] [PATCH v2 1/2] xen: move wallclock functions from x86 to common

2015-11-10 Thread Jan Beulich
>>> On 09.11.15 at 18:32, wrote: > From: Stefano Stabellini > > Remove dummy arm implementation of wallclock_time. > Use shared_info() in common code rather than x86-ism to access it, when > possible. > > Define the static variable wc_sec, and the local variale sec in > update_domain_wallclock_

Re: [Xen-devel] [PATCH v9 00/17] Add VT-d Posted-Interrupts support

2015-11-10 Thread Jan Beulich
>>> On 10.11.15 at 08:33, wrote: > Thanks for your effort on this series and kindly ping.. Don't worry, it hasn't been forgotten. But getting to it will take time. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM

2015-11-10 Thread Jan Beulich
>>> On 10.11.15 at 08:55, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -636,8 +636,8 @@ static void __init efi_console_set_mode(void) > static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void) > { > EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info; > -EFI_

[Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Andrew Cooper
ml_interface_{read,write}() would miscalculate the quantity of data/space in the ring if it crossed the ring boundary, and incorrectly return a short read/write. This causes a protocol stall, as either side of the ring ends up waiting for what they believe to be the other side needing to take the

[Xen-devel] Using IRQ_GUEST|IRQ_PER_CPU to signal "delivery to current vcpu"?

2015-11-10 Thread Ian Campbell
Hi arch maintainers, The ARM hardware has a concept called a "Peripheral Private Interrupt" (PPI), an IRQ which is per-core as opposed to a "Shared Peripheral Interrupt" (SPI) which is per-SOC (routable to all cores). (For completeness the other classes of IRQ are "Software Generated Interrupt" (

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Wei Liu
On Tue, Nov 10, 2015 at 10:46:44AM +, Andrew Cooper wrote: > ml_interface_{read,write}() would miscalculate the quantity of > data/space in the ring if it crossed the ring boundary, and incorrectly > return a short read/write. > > This causes a protocol stall, as either side of the ring ends u

Re: [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM

2015-11-10 Thread Daniel Kiper
On Tue, Nov 10, 2015 at 03:55:50PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Commit 9fd08b4 (efi: split out efi_get_gop()) splits out the > codes getting the pointer to GOP as efi_get_gop(), but it doesn't > initialize the variable handles and gop to NULL like what the original As I can

Re: [Xen-devel] [qubes-devel] Re: Critique of the Xen Security Process

2015-11-10 Thread Lars Kurth
Hi everyone, firstly I wanted to thank everyone for raising this issue. I wanted to point out that we are not talking about a security process here, but the development process. Or more accurately the cost of writing more secure code and the relative importance of security compared to features

[Xen-devel] [distros-debian-snapshot test] 38263: regressions - trouble: broken/fail/pass

2015-11-10 Thread Platform Team regression test user
flight 38263 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38263/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-amd64-weekly-netinst-pygrub 3 host-install(3) broken REGR. vs. 3824

Re: [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM

2015-11-10 Thread Shannon Zhao
On 2015/11/10 18:45, Jan Beulich wrote: On 10.11.15 at 08:55, wrote: >> --- a/xen/common/efi/boot.c >> +++ b/xen/common/efi/boot.c >> @@ -636,8 +636,8 @@ static void __init efi_console_set_mode(void) >> static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void) >> { >> EFI_GRAPHIC

Re: [Xen-devel] [PATCH v2 1/2] xen: move wallclock functions from x86 to common

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Jan Beulich wrote: > >>> On 09.11.15 at 18:32, wrote: > > From: Stefano Stabellini > > > > Remove dummy arm implementation of wallclock_time. > > Use shared_info() in common code rather than x86-ism to access it, when > > possible. > > > > Define the static variable wc_sec,

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Shannon Zhao wrote: > Hi Stefano, > > When I apply this patch, there are some warnings too. > > Applying: arm: export platform_op XENPF_settime64 > /home/open-source/xen/.git/rebase-apply/patch:67: trailing whitespace. > * > /home/open-source/xen/.git/rebase-apply/patch:69:

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Peter Zijlstra wrote: > On Thu, Nov 05, 2015 at 05:30:01PM +, Stefano Stabellini wrote: > > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > > How can this be missing? Things compile fine now, right? > > > > Fair enough. > > > > > > > So please better explain why we do this cha

Re: [Xen-devel] Using IRQ_GUEST|IRQ_PER_CPU to signal "delivery to current vcpu"?

2015-11-10 Thread Jan Beulich
>>> On 10.11.15 at 11:48, wrote: > So, I was considering using a new bit in the common desc->status bit. Upon > checking xen/irq.h I found there was already IRQ_PER_CPU which appears to > be completely unused in the current code base (it looks to have been used > by IA64 and PPC, but never by x86

[Xen-devel] [PATCH v8.1 09/21] xen/x86: set the vPMU interface based on the presence of a lapic

2015-11-10 Thread Roger Pau Monne
Instead of choosing the interface to expose to guests based on the guest type, do it based on whether the guest has an emulated local apic or not. Signed-off-by: Roger Pau Monné Signed-off-by: Boris Ostrovsky Acked-by: Jan Beulich Cc: Jan Beulich Cc: Andrew Cooper --- Changes since v8: - Don

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Samuel Thibault
Andrew Cooper, on Tue 10 Nov 2015 10:46:44 +, wrote: > ml_interface_{read,write}() would miscalculate the quantity of > data/space in the ring if it crossed the ring boundary, and incorrectly > return a short read/write. > > This causes a protocol stall, as either side of the ring ends up wait

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread David Scott
> On 10 Nov 2015, at 11:41, Samuel Thibault > wrote: > > Andrew Cooper, on Tue 10 Nov 2015 10:46:44 +, wrote: >> ml_interface_{read,write}() would miscalculate the quantity of >> data/space in the ring if it crossed the ring boundary, and incorrectly >> return a short read/write. >> >> Thi

[Xen-devel] [PATCH v2 0/7] Xen wallclock on arm and arm64

2015-11-10 Thread Stefano Stabellini
Hi all, this series introduces PV wallclock time support on arm and arm64. Changes in v2: - introduce __current_kernel_time64 - rename dom0_op to platform_op - introduce XENPF_settime64 - extend pvclock_wall_clock with sec_hi - properly convert arch_timer ticker to nsec - use timespec64 interfac

[Xen-devel] [PATCH v2 3/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64

2015-11-10 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v2: - rename dom0_op to platform_op --- arch/arm/include/asm/xen/hypercall.h |2 ++ arch/arm/xen/enlighten.c |1 + arch/arm/xen/hypercall.S |1 + arch/arm64/xen/hypercall.S |1 + 4 files changed,

[Xen-devel] [PATCH v2 5/7] arm: extend pvclock_wall_clock with sec_hi

2015-11-10 Thread Stefano Stabellini
The hypervisor actually exposes an additional field to struct pvclock_wall_clock, with the high 32 bit seconds. Signed-off-by: Stefano Stabellini --- arch/arm/include/asm/xen/interface.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/xen/interface.h b/arch/arm/inclu

[Xen-devel] [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall

2015-11-10 Thread Stefano Stabellini
If Linux is running as dom0, call XENPF_settime64 to update the system time in Xen on pvclock_gtod notifications. Signed-off-by: Stefano Stabellini --- Changes in v2: - properly convert arch_timer ticker to nsec - rename dom0_op to platform_op - use timespec64 interfaces - use XENPF_settime64 -

[Xen-devel] [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock

2015-11-10 Thread Stefano Stabellini
Read the wallclock from the shared info page at boot time. Signed-off-by: Stefano Stabellini --- Changes in v2: - properly convert arch_timer ticker to nsec - use timespec64 interfaces - use sec_hi to get a 64-bit seconds value --- arch/arm/Kconfig |1 + arch/arm/xen/enlighten.c |

[Xen-devel] [PATCH v2 4/7] xen: introduce XENPF_settime64

2015-11-10 Thread Stefano Stabellini
Rename the current XENPF_settime hypercall and related struct to XENPF_settime32. Signed-off-by: Stefano Stabellini CC: konrad.w...@oracle.com CC: david.vra...@citrix.com CC: boris.ostrov...@oracle.com --- arch/x86/xen/time.c |8 include/xen/interface/platform.h | 18

[Xen-devel] [PATCH v2 2/7] xen: rename dom0_op to platform_op

2015-11-10 Thread Stefano Stabellini
The dom0_op hypercall has been renamed to platform_op since Xen 3.2, which is ancient, and modern upstream Linux kernels cannot run as dom0 and it anymore anyway. Signed-off-by: Stefano Stabellini CC: konrad.w...@oracle.com CC: david.vra...@citrix.com CC: boris.ostrov...@oracle.com --- arch/x86/

[Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Stefano Stabellini
__current_kernel_time64 returns a struct timespec64, without taking the xtime lock. Mirrors __current_kernel_time/current_kernel_time. Signed-off-by: Stefano Stabellini CC: a...@arndb.de CC: john.stu...@linaro.org CC: t...@linutronix.de CC: mi...@kernel.org CC: pet...@infradead.org --- include/l

[Xen-devel] [ovmf baseline-only test] 38264: all pass

2015-11-10 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38264 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38264/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf 3ab1434a6ede4e006ef0b001108c354f4fa6d91e baseline version: ovm

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-10 Thread Peter Zijlstra
On Tue, Nov 10, 2015 at 11:27:33AM +, Stefano Stabellini wrote: > On Mon, 9 Nov 2015, Peter Zijlstra wrote: > > On Thu, Nov 05, 2015 at 05:30:01PM +, Stefano Stabellini wrote: > > > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > > > How can this be missing? Things compile fine now, right? >

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Peter Zijlstra
On Tue, Nov 10, 2015 at 11:57:49AM +, Stefano Stabellini wrote: > __current_kernel_time64 returns a struct timespec64, without taking the > xtime lock. Mirrors __current_kernel_time/current_kernel_time. It always helps if you include a reason why you want a patch.

Re: [Xen-devel] [PATCHv1 1/3] x86/ept: remove unnecessary sync after resolving misconfigured entries

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 18:37, wrote: > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -644,7 +644,6 @@ bool_t ept_handle_misconfig(uint64_t gpa) > spurious = curr->arch.hvm_vmx.ept_spurious_misconfig; > rc = resolve_misconfig(p2m, PFN_DOWN(gpa)); > curr->arch.hvm

Re: [Xen-devel] Runtime services support for Xen on ARM

2015-11-10 Thread Stefano Stabellini
CC'ing xen-devel and Jan On Tue, 10 Nov 2015, Shannon Zhao wrote: > Hi Stefano, > > I'm working on adding Runtime services support at Xen side. Most of work > is adding the ARM part in xen/common/efi/runtime.c. > > There is one problem which block me. That is how to implement > efi_rs_enter() an

[Xen-devel] [linux-mingo-tip-master test] 63927: regressions - trouble: broken/fail/pass

2015-11-10 Thread osstest service owner
flight 63927 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/63927/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-pvgrub 3 host-install(3) broken REGR. vs. 60684 test-amd64

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: > __current_kernel_time64 returns a struct timespec64, without taking the > xtime lock. Mirrors __current_kernel_time/current_kernel_time. > Actually it doesn't mirror __current_kernel_time/current_kernel_time > diff --git a/include/

Re: [Xen-devel] [PATCH v2 1/3] xsm/xen_version: Add XSM for the xen_version hypercall.

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 20:36, wrote: > All of XENVER_* have now an XSM check. > > The subops for XENVER_[compile_info|changeset|commandline| > extraversion] are now priviliged operations. To not break > guests we still return an string - but it is just ''. And I continue to question at least the ext

Re: [Xen-devel] [PATCH v2 4/7] xen: introduce XENPF_settime64

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote: > Rename the current XENPF_settime hypercall and related struct to > XENPF_settime32. > > Signed-off-by: Stefano Stabellini > CC: konrad.w...@oracle.com > CC: david.vra...@citrix.com > CC: boris.ostrov...@oracle.com Looks good. > --

Re: [Xen-devel] [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 11:57:54 Stefano Stabellini wrote: > +static void xen_read_wallclock(struct timespec64 *ts) > +{ > + u32 version; > + u64 delta; > + struct timespec64 now; > + struct shared_info *s = HYPERVISOR_shared_info; > + struct pvclock_wall_clock *wa

Re: [Xen-devel] Runtime services support for Xen on ARM

2015-11-10 Thread Ian Campbell
On Tue, 2015-11-10 at 12:26 +, Stefano Stabellini wrote: > CC'ing xen-devel and Jan > > On Tue, 10 Nov 2015, Shannon Zhao wrote: > > Hi Stefano, > > > > I'm working on adding Runtime services support at Xen side. Most of > > work > > is adding the ARM part in xen/common/efi/runtime.c. > > >

Re: [Xen-devel] Using IRQ_GUEST|IRQ_PER_CPU to signal "delivery to current vcpu"?

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Ian Campbell wrote: > Hi arch maintainers, > > The ARM hardware has a concept called a "Peripheral Private Interrupt" > (PPI), an IRQ which is per-core as opposed to a "Shared Peripheral > Interrupt" (SPI) which is per-SOC (routable to all cores). > > (For completeness the ot

Re: [Xen-devel] [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 11:57:55 Stefano Stabellini wrote: > + op.u.settime64.nsecs = now.tv_nsec; > + op.u.settime64.system_time = arch_timer_read_counter() * > (u64)NSEC_PER_SEC; > + do_div(op.u.settime64.system_time, arch_timer_get_rate()); NSEC_PER_SEC is a large number,

Re: [Xen-devel] [PATCH QEMU-XEN v5 9/9] xen: make it possible to build without the Xen PV domain builder

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Ian Campbell wrote: > Until the previous patch this relied on xc_fd(), which was only > implemented for Xen 4.0 and earlier. > > Given this wasn't working since Xen 4.0 I have marked this as disabled > by default. > > Removing this support drops the use of a bunch of symbols f

Re: [Xen-devel] [qubes-devel] Re: Critique of the Xen Security Process

2015-11-10 Thread Lars Kurth
> On 9 Nov 2015, at 18:15, Wojtek Porczyk wrote: > > On Mon, Nov 09, 2015 at 04:31:58PM +, Franz wrote: >> Perhaps a way out of this impasse is to put bounties on Xen security tasks >> identified by Joanna and properly advertise these bounties to Xen users. >> [snip] > > This is fundamental

Re: [Xen-devel] Runtime services support for Xen on ARM

2015-11-10 Thread Jan Beulich
>>> On 10.11.15 at 13:26, wrote: > CC'ing xen-devel and Jan > > On Tue, 10 Nov 2015, Shannon Zhao wrote: >> Hi Stefano, >> >> I'm working on adding Runtime services support at Xen side. Most of work >> is adding the ARM part in xen/common/efi/runtime.c. >> >> There is one problem which block me

Re: [Xen-devel] [PATCHv1 3/3] x86/ept: defer the invalidation until the p2m lock is released

2015-11-10 Thread Tim Deegan
At 17:37 + on 06 Nov (1446831437), David Vrabel wrote: > Holding the p2m lock while calling ept_sync_domain() is very expensive > since it does a on_selected_cpus() call. IPIs on many socket machines > can be very slows and on_selected_cpus() is serialized. > > Defer the invalidate until the

Re: [Xen-devel] [PATCH QEMU-XEN v5 7/9] xen: Use stable library interfaces when they are available.

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > Specifically libxenevtchn, libxengnttab and libxenforeignmemory. > > Previous patches have already

Re: [Xen-devel] [PATCH QEMU-XEN v5 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxengnttab which provides access to grant > tables. > > In preparation

[Xen-devel] [xen-unstable-smoke test] 64060: tolerable all pass - PUSHED

2015-11-10 Thread osstest service owner
flight 64060 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/64060/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13

Re: [Xen-devel] [PATCH v11 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2015-11-10 Thread Stefano Stabellini
On Thu, 5 Nov 2015, Stefano Stabellini wrote: > Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM64. > Necessary duplication of paravirt.h and paravirt.c with ARM. > > The only paravirt interface supported is pv_time_ops.steal_clock, so no > runtime pvops patching needed. > > This all

Re: [Xen-devel] [PATCH v11 3/5] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2015-11-10 Thread Stefano Stabellini
On Thu, 5 Nov 2015, Stefano Stabellini wrote: > Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM. > > The only paravirt interface supported is pv_time_ops.steal_clock, so no > runtime pvops patching needed. > > This allows us to make use of steal_account_process_tick for stolen > tic

Re: [Xen-devel] [PATCH 2/2] arm: export platform_op XENPF_settime

2015-11-10 Thread Julien Grall
Hi Stefano, On 09/11/15 17:09, Stefano Stabellini wrote: > On Thu, 5 Nov 2015, Julien Grall wrote: >> For instance we may want to call update_domain_wallclock_time in >> construct_dom0 before clearing the pause flags. This is because the >> wallclock may be out of sync as construction DOM0 takes s

Re: [Xen-devel] [qubes-devel] Re: Critique of the Xen Security Process

2015-11-10 Thread Franz
On Tue, Nov 10, 2015 at 1:09 PM, Lars Kurth wrote: > > > On 9 Nov 2015, at 18:15, Wojtek Porczyk > wrote: > > > > On Mon, Nov 09, 2015 at 04:31:58PM +, Franz wrote: > >> Perhaps a way out of this impasse is to put bounties on Xen security > tasks > >> identified by Joanna and properly advert

Re: [Xen-devel] [PATCH v8.1 09/21] xen/x86: set the vPMU interface based on the presence of a lapic

2015-11-10 Thread Boris Ostrovsky
On 11/10/2015 06:30 AM, Roger Pau Monne wrote: Instead of choosing the interface to expose to guests based on the guest type, do it based on whether the guest has an emulated local apic or not. Signed-off-by: Roger Pau Monné Signed-off-by: Boris Ostrovsky Acked-by: Jan Beulich Cc: Jan Beulich

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Julien Grall
Hi Stefano, I've made some comment on the v1 after you resend this version. I think there are still valid with the new version. Can you give a look there? Regards, On 09/11/15 17:32, sstabell...@kernel.org wrote: > From: Stefano Stabellini > > Call update_domain_wallclock_time at domain initi

Re: [Xen-devel] Runtime services support for Xen on ARM

2015-11-10 Thread Shannon Zhao
On 2015/11/10 20:36, Ian Campbell wrote: On Tue, 2015-11-10 at 12:26 +, Stefano Stabellini wrote: CC'ing xen-devel and Jan On Tue, 10 Nov 2015, Shannon Zhao wrote: Hi Stefano, I'm working on adding Runtime services support at Xen side. Most of work is adding the ARM part in xen/common/e

Re: [Xen-devel] [PATCH 2/2] arm: export platform_op XENPF_settime

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Julien Grall wrote: > Hi Stefano, > > On 09/11/15 17:09, Stefano Stabellini wrote: > > On Thu, 5 Nov 2015, Julien Grall wrote: > >> For instance we may want to call update_domain_wallclock_time in > >> construct_dom0 before clearing the pause flags. This is because the > >> wa

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Stefano Stabellini
Actually I addressed all the ones I thought needed to be addressed and replied to the others. Is there anything that I missed? On Tue, 10 Nov 2015, Julien Grall wrote: > Hi Stefano, > > I've made some comment on the v1 after you resend this version. I think > there are still valid with the new ve

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Julien Grall
On 10/11/15 14:28, Stefano Stabellini wrote: > Actually I addressed all the ones I thought needed to be addressed and > replied to the others. Is there anything that I missed? I was speaking about: <5641fb01.4050...@citrix.com> Regards, -- Julien Grall _

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Peter Zijlstra wrote: > On Tue, Nov 10, 2015 at 11:57:49AM +, Stefano Stabellini wrote: > > __current_kernel_time64 returns a struct timespec64, without taking the > > xtime lock. Mirrors __current_kernel_time/current_kernel_time. > > It always helps if you include a reaso

Re: [Xen-devel] [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator

2015-11-10 Thread Daniel Kiper
On Mon, Nov 09, 2015 at 09:05:15PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 20.07.2015 16:35, Daniel Kiper wrote: > > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms > > when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. > > Relocator

Re: [Xen-devel] [PATCH v2 4/7] xen: introduce XENPF_settime64

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Arnd Bergmann wrote: > On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote: > > Rename the current XENPF_settime hypercall and related struct to > > XENPF_settime32. > > > > Signed-off-by: Stefano Stabellini > > CC: konrad.w...@oracle.com > > CC: david.vra...@citrix

Re: [Xen-devel] [PATCH 2/2] arm: export platform_op XENPF_settime

2015-11-10 Thread Julien Grall
On 10/11/15 14:27, Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Julien Grall wrote: >> Hi Stefano, >> >> On 09/11/15 17:09, Stefano Stabellini wrote: >>> On Thu, 5 Nov 2015, Julien Grall wrote: For instance we may want to call update_domain_wallclock_time in construct_dom0 before clea

Re: [Xen-devel] [PATCH v2 4/7] xen: introduce XENPF_settime64

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 14:43:26 Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Arnd Bergmann wrote: > > On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote: > > > Rename the current XENPF_settime hypercall and related struct to > > > XENPF_settime32. > > > > > > Signed-off-by: Ste

Re: [Xen-devel] [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-10 Thread Daniel Kiper
On Mon, Nov 09, 2015 at 09:08:35PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 20.07.2015 16:35, Daniel Kiper wrote: > > Signed-off-by: Daniel Kiper > What is handling the actual relocation? In Xen we get image offset from GRUB2 and using this value we calculate relative addresses.

Re: [Xen-devel] [PATCH v9 01/17] VT-d Posted-intterrupt (PI) design

2015-11-10 Thread Dario Faggioli
On Tue, 2015-11-03 at 16:43 +0800, Feng Wu wrote: > diff --git a/docs/misc/vtd-pi.txt b/docs/misc/vtd-pi.txt > new file mode 100644 > index 000..f9b4637 > --- /dev/null > +++ b/docs/misc/vtd-pi.txt > +With VT-d Posted-interrupt we can get the following advantages: > +- Direct delivery of exte

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Wei Liu
On Tue, Nov 10, 2015 at 10:46:44AM +, Andrew Cooper wrote: > ml_interface_{read,write}() would miscalculate the quantity of > data/space in the ring if it crossed the ring boundary, and incorrectly > return a short read/write. > > This causes a protocol stall, as either side of the ring ends u

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Samuel Thibault
Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > I think I will port this patch to cxenstored at some point. As far as I > can tell cxenstored's data / space calculation is bogus in the same way. The low-level function return short reads and writes, yes, but that is handled at a higher level:

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Wei Liu
On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > > I think I will port this patch to cxenstored at some point. As far as I > > can tell cxenstored's data / space calculation is bogus in the same way. > > The low-level function

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Samuel Thibault
Wei Liu, on Tue 10 Nov 2015 15:09:33 +, wrote: > On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > > Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > > > I think I will port this patch to cxenstored at some point. As far as I > > > can tell cxenstored's data / space calcula

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Arnd Bergmann wrote: > On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: > > __current_kernel_time64 returns a struct timespec64, without taking the > > xtime lock. Mirrors __current_kernel_time/current_kernel_time. > > > > Actually it doesn't mirror __current_ke

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread John Stultz
On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Arnd Bergmann wrote: >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: >> > __current_kernel_time64 returns a struct timespec64, without taking the >> > xtime lock. Mirrors __current_kernel_time/curre

[Xen-devel] [linux-next test] 63942: tolerable FAIL

2015-11-10 Thread osstest service owner
flight 63942 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/63942/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-libvirt-xsm 6 xen-boot fail blocked in 63747 test-amd64-i386-xl-qemuu-win7-a

[Xen-devel] [PATCH v2 3/8] libxl: implement virDomainInterfaceStats

2015-11-10 Thread Joao Martins
Introduce support for domainInterfaceStats API call for querying network interface statistics. Consequently it also enables the use of `virsh domifstat ` command. After succesful guest creation we fill the network interfaces names based on domain, device id and append suffix if it's emulated in t

[Xen-devel] [PATCH v2 2/8] libxl: implement virDomainMemorystats

2015-11-10 Thread Joao Martins
Introduce support for domainMemoryStats API call, which consequently enables the use of `virsh dommemstat` command to query for memory statistics of a domain. We support the following statistics: balloon info, available and currently in use. swap-in, swap-out, major-faults, minor-faults require coo

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Thomas Gleixner
On Tue, 10 Nov 2015, John Stultz wrote: > On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini > wrote: > > On Tue, 10 Nov 2015, Arnd Bergmann wrote: > >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: > >> > __current_kernel_time64 returns a struct timespec64, without taking the >

[Xen-devel] [PATCH v2] libxl: add p2p migration

2015-11-10 Thread Joao Martins
Introduce support for VIR_MIGRATE_PEER2PEER in libxl driver for supporting migration in Openstack. Most of the changes occur at the source and no modifications at the receiver. In P2P mode there is only the Perform phase so we must handle the connection with the destination and actually perform th

[Xen-devel] [PATCH v2 8/8] libxl: implement virDomainGetJobStats

2015-11-10 Thread Joao Martins
Introduces support for domainGetJobStats which has the same info as domainGetJobInfo but in a slightly different format. Another difference is that virDomainGetJobStats can also retrieve info on the most recently completed job. Though so far this is only used in the source node to know if the migra

[Xen-devel] [PATCH v2 1/8] libxl: implement virDomainGetCPUStats

2015-11-10 Thread Joao Martins
Introduce support for domainGetCPUStats API call and consequently allow us to use `virsh cpu-stats`. The latter returns a more brief output than the one provided by`virsh vcpuinfo`. Signed-off-by: Joao Martins --- Changes since v1: - Remove libxl_vcpuinfo_dispose() in favor or using libxl_vcpui

[Xen-devel] [PATCH v2 7/8] libxl: implement virDomainGetJobInfo

2015-11-10 Thread Joao Martins
Introduce support for domainGetJobInfo to get info about the ongoing job. If the job is active it will update the timeElapsed which is computed with the "started" field added to struct libxlDomainJobObj. For now we support just the very basic info and all jobs have VIR_DOMAIN_JOB_UNBOUNDED (i.e. n

[Xen-devel] [PATCH v2 5/8] libxl: implement virDomainBlockStats

2015-11-10 Thread Joao Martins
Introduce initial support for domainBlockStats API call that allow us to query block device statistics. openstack nova uses this API call to query block statistics, alongside virDomainMemoryStats and virDomainInterfaceStats. Note that this patch only introduces it for VBD for starters. QDisk will

[Xen-devel] [PATCH v2 6/8] libxl: implement virConnectGetAllDomainStats

2015-11-10 Thread Joao Martins
Introduce support for connectGetAllDomainStats call that allow us to _all_ domain(s) statistics including network, block, cpus and memory. Changes are rather mechanical and mostly take care of the format to export the data. Signed-off-by: Joao Martins --- Changes since v1: - Rework flags checkin

[Xen-devel] [PATCH v2 0/8] libxl: domain statistics support

2015-11-10 Thread Joao Martins
Hey, This series bring support for various statistics about domains regarding CPU, Memory, Network Interfaces, Block and Jobs. Not all of the statistics are implemented: qdisk support is missing in this series and some of the memory statistics aren't available. With this series we further impleme

[Xen-devel] [PATCH v2 4/8] util: add virDiskNameParse to handle disk and partition idx

2015-11-10 Thread Joao Martins
Introduce a new helper function "virDiskNameParse" which extends virDiskNameToIndex but handling both disk index and partition index. Also rework virDiskNameToIndex to be based on virDiskNameParse. A test is also added for this function testing both valid and invalid disk names. Signed-off-by: Joa

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread John Stultz
On Tue, Nov 10, 2015 at 7:31 AM, Thomas Gleixner wrote: > On Tue, 10 Nov 2015, John Stultz wrote: >> On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini >> wrote: >> > On Tue, 10 Nov 2015, Arnd Bergmann wrote: >> >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: >> >> > __current_

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Thomas Gleixner
On Tue, 10 Nov 2015, John Stultz wrote: > I'm sort of objecting to a different issue, where the > __current_kernel_time() implementation probably shouldn't be grabbing > the tk_core.timekeeper directly, and instead should take a passed > pointer to a timekeeper. The vdso/pv_clock usage should have

Re: [Xen-devel] [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Arnd Bergmann wrote: > On Tuesday 10 November 2015 11:57:55 Stefano Stabellini wrote: > > + op.u.settime64.nsecs = now.tv_nsec; > > + op.u.settime64.system_time = arch_timer_read_counter() * > > (u64)NSEC_PER_SEC; > > + do_div(op.u.settime64.system_time, arch

[Xen-devel] [PATCH v2 2/8] xen: arm: fix typo in the description of struct pending_irq->desc

2015-11-10 Thread Ian Campbell
s/it/if/ makes more sense. Signed-off-by: Ian Campbell --- xen/include/asm-arm/vgic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h index cb51a9e..7d580cc 100644 --- a/xen/include/asm-arm/vgic.h +++ b/xen/include/asm-a

[Xen-devel] [PATCH v2 7/8] xen: arm: context switch vtimer PPI state.

2015-11-10 Thread Ian Campbell
... instead of artificially masking the timer interrupt in the timer state and relying on the guest to unmask (which it isn't required to do per the h/w spec, although Linux does). By using the newly added hwppi save/restore functionality we make use of the GICD I[SC]ACTIVER registers to save and

[Xen-devel] [PATCH v2] xen: arm: context switch vtimer PPI state.

2015-11-10 Thread Ian Campbell
... instead of artificially masking the timer interrupt in the timer state and relying on the guest to unmask which it isn't required to do per the h/w spec, although Linux does, other OSes (FreeRTOS?) needed changes. Making the vtimer follow the h/w spec is the main driving force here although it

[Xen-devel] [PATCH v2 6/8] xen: arm: supporting routing a PPI to the current vcpu.

2015-11-10 Thread Ian Campbell
That is whichever vcpu is resident when the interrupt fires. An interrupt is in this state when both IRQ_GUEST and IRQ_PER_CPU are set in the descriptor status. Only PPIs can be in this mode. This requires some peripheral specific code to make use of the previously introduced functionality to save

[Xen-devel] [PATCH v2 3/8] xen: arm: Refactor route_irq_to_guest

2015-11-10 Thread Ian Campbell
Split out the bit which allocates the struct irqaction and calls __setup_irq into a new function (setup_guest_irq). I'm going to want to call this a second time in a subsequent patch. Note that the action is now allocated and initialised with the desc lock held (since it is taken by the caller). I

[Xen-devel] [PATCH v2 5/8] xen: arm: add interfaces to save/restore the state of a PPI.

2015-11-10 Thread Ian Campbell
Make use of the GICD I[SC]ACTIVER registers to save and restore the active state of the interrupt. For edge triggered interrupts we also need to context switch the pending bit via I[SC]PENDR. Note that for level triggered interrupts SPENDR sets a latch which is only cleared by ICPENDR (and not by

[Xen-devel] [PATCH v2 8/8] HACK: Force virt timer to PPI0 (IRQ16)

2015-11-10 Thread Ian Campbell
Just for testing so the guest vtimer ppi it isn't the same as the physical virt timer PPI on my platform, and therefore allows to exercise the non-1:1 bits of the code. --- xen/include/public/arch-arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/arch-arm

[Xen-devel] [PATCH v2 1/8] xen: arm: fix indendation of struct vtimer

2015-11-10 Thread Ian Campbell
Signed-off-by: Ian Campbell --- xen/include/asm-arm/domain.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index e7e40da..c56f06e 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain

[Xen-devel] [PATCH v2 4/8] xen: arm: remove vgic_vcpu_inject_spi()

2015-11-10 Thread Ian Campbell
Currently this has only a single caller, which I intend to teach about injecting PPIs shortly. This helper doesn't add much so remove it. Drop a stray tab from the comment immediately preceding this change. Signed-off-by: Ian Campbell --- xen/arch/arm/irq.c | 7 +-- xen/arch/arm/vg

Re: [Xen-devel] [RFC PATCH v2 01/16] hvmloader: Fix scratch_alloc to avoid overlaps

2015-11-10 Thread Jan Beulich
>>> On 26.10.15 at 17:03, wrote: > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -479,7 +479,7 @@ void *scratch_alloc(uint32_t size, uint32_t align) > align = 16; > > s = (scratch_start + align - 1) & ~(align - 1); > -e = s + size - 1; > +

Re: [Xen-devel] [PATCH v8 13/21] xen/x86: make sure the HVM callback vector is correctly set

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 17:05, wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -330,6 +330,10 @@ void hvm_set_callback_via(struct domain *d, uint64_t via) > (via_type > HVMIRQ_callback_vector) ) > via_type = HVMIRQ_callback_none; > > +if ( via_type !=

Re: [Xen-devel] [PATCH v2 2/3] XENVER_build_id: Provide ld-embedded build-ids

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 20:36, wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -109,15 +109,19 @@ $(TARGET)-syms: prelink.o xen.lds > $(BASEDIR)/common/symbols-dummy.o > $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ > | $(BASEDIR)/tools/symbols --sysv --sort >$(@

  1   2   >