>>> On 06.11.15 at 17:05, <roger....@citrix.com> wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -330,6 +330,10 @@ void hvm_set_callback_via(struct domain *d, uint64_t via) > (via_type > HVMIRQ_callback_vector) ) > via_type = HVMIRQ_callback_none; > > + if ( via_type != HVMIRQ_callback_vector && > + (!has_vlapic(d) || !has_vioapic(d)) ) > + return;
What about PIC? With vpic_irq_positive_edge() now asserting has_vpic(), and hvm_set_callback_irq_level() calling the former, I don't think the above is sufficient. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
