>>> On 26.10.15 at 17:03, <anthony.per...@citrix.com> wrote: > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -479,7 +479,7 @@ void *scratch_alloc(uint32_t size, uint32_t align) > align = 16; > > s = (scratch_start + align - 1) & ~(align - 1); > - e = s + size - 1; > + e = s + size;
This further increases the delta to the actually quite similar mem_alloc(). I'd prefer the two to remain in sync as much as possible, and hence either the other one to also be adjusted or this one to be fixed the other way around (dropping the first "- 1" in the assignment to s, but requiring changes elsewhere too). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
