[Xen-devel] [PATCH v2] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Jan Beulich
The number of slots per page being 511 (i.e. not a power of two) means that the (32-bit) read and write indexes going beyond 2^32 will likely disturb operation. The hypervisor side gets I/O req server creation extended so we can indicate that we're using suitable atomic accesses where needed, allow

[Xen-devel] [PATCH v2 qemu-trad] HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Jan Beulich
The number of slots per page being 511 (i.e. not a power of two) means that the (32-bit) read and write indexes going beyond 2^32 will likely disturb operation. The hypervisor side gets I/O req server creation extended so we can indicate that we're using suitable atomic accesses where needed, allow

Re: [Xen-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Jan Beulich
>>> On 22.07.15 at 19:24, wrote: > I'll queue this change up for the next QEMU release cycle. Thanks - v2 (with the adjusted description) just sent. It would however be nice for our variant in 4.6 to also gain this, perhaps independent of upstream's schedule. Jan _

Re: [Xen-devel] [PATCH v3 2/3] x86/ldt: Make modify_ldt optional

2015-07-23 Thread Jan Beulich
>>> On 22.07.15 at 21:23, wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1015,6 +1015,7 @@ config VM86 > config X86_16BIT > bool "Enable support for 16-bit segments" if EXPERT > default y > + depends on MODIFY_LDT_SYSCALL > ---help--- > This option is

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-23 Thread Jan Beulich
>>> On 22.07.15 at 20:10, wrote: > I don't think this is currently doable with what we have for CPUID > support in xl syntax. I am pretty sure we need to at least be able to > specify all leaf 4's indexes. And we can't. > > BTW, irrespective of this particular problem, adding support for indexe

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 06:43, wrote: > Hmm, I didn't think of user processes. Are you aware of cases where they > are to be considered? Why wouldn't a sophisticated user mode program attempt to adjust certain memory objects' sizes based on cache size? Jan __

Re: [Xen-devel] [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 08:52:24AM +0800, Chen, Tiejun wrote: > Ian, > > Thanks for your effort. > > A tiny change may be needed but I don't block this. > > >+libxl__xc_device_get_rdm(libxl__gc *gc, > >+ uint32_t flag, > > Since now we are sitting on xc_reserved_device_m

Re: [Xen-devel] [PATCH v13 00/16] Fix RMRR (avoid RDM)

2015-07-23 Thread Wei Liu
Forgot to do this yesterday. With my RM hat on: Release-acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-23 Thread Chen, Tiejun
These cosmetic changes can be fixed by a follow-up patch. If Jackson would like not to fix this directly in his tree, I can post this a small patch but we'd better squash this into the predecessor just as one commit. Thanks Tiejun ___ Xen-devel m

[Xen-devel] [PATCH for-4.6 04/13] xl: free pid string in do_daemonize

2015-07-23 Thread Wei Liu
Pid is a null terminated string allocated by asprintf. It should be freed after use. Also fixed a coding style problem while I was there. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/l

[Xen-devel] [PATCH for-4.6 00/13] tools: fixes inspired by Coverity scan

2015-07-23 Thread Wei Liu
Wei Liu (13): libxl: use thread-safe localtime_t and handle NULL libxl: properly clean up array in libxl_list_cpupool failure path libxl: remove a bunch of pointless assignments xl: free pid string in do_daemonize xl: check json string is not null before printing in create_domain xl: ca

[Xen-devel] [PATCH for-4.6 06/13] xl: call libxl_dominfo_{init, dispose} in psr_cmt_show

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index fc61650..2d95e35 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -8217,11 +8217,14 @@ static int psr_cmt_sho

[Xen-devel] [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments

2015-07-23 Thread Wei Liu
Those values are overwritten before they can be of any use. Signed-off-by: Wei Liu --- tools/libxl/libxl_dom.c | 2 +- tools/libxl/libxl_remus_disk_drbd.c | 2 +- tools/libxl/xl_cmdimpl.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH for-4.6 02/13] libxl: properly clean up array in libxl_list_cpupool failure path

2015-07-23 Thread Wei Liu
Document how cpupool_info works. Distinguish success (ERROR_FAIL + ENOENT) vs failure in libxl_list_cpupool and properly clean up the array in failure path. Also switch to libxl__realloc and call libxl_cpupool_{init,dispose} where appropriate. There is change of behaviour. Previously if memory a

[Xen-devel] [PATCH for-4.6 09/13] xl: call libxl_bitmap_{init, dispose} in main_cpupoolcreate

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 79cef7a..7e279cd 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -7244,6 +7244,9 @@ int main_cpupoolcreate

[Xen-devel] [PATCH for-4.6 08/13] xl: call libxl_dominfo_init in main_list

2015-07-23 Thread Wei Liu
Also change the path that disposes of the buffer to use info_buf to avoid confusing coverity. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index a4e56ef..79cef7a 1006

[Xen-devel] [PATCH for-4.6 01/13] libxl: use thread-safe localtime_t and handle NULL

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_x86.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index 8cd15ca..bac0b8f 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -306,10 +306,16 @@ int

[Xen-devel] [PATCH for-4.6 07/13] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 2d95e35..a4e56ef 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -7660,6 +7660,8 @@ int main_cpupoolnumaspli

[Xen-devel] [PATCH for-4.6 05/13] xl: check json string is not null before printing in create_domain

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index bfd8e59..fc61650 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -2763,6 +2763,11 @@ static uint32_t creat

Re: [Xen-devel] [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 08:38 -0600, Jan Beulich wrote: > This being an in-guest component, it shouldn't get to see (and even > less so use) tools-only public interfaces. > > Signed-off-by: Jan Beulich FWIW: Acked-by: Ian Campbell > > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmwa

[Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: dave.sc...@eu.citrix.com Please check if the use of caml_failwith is correct. --- tools/ocaml/libs/xl/xenlight_stubs.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 7b8d6db

[Xen-devel] [PATCH for-4.6 10/13] xl: valid fd can be 0 in main_loadpolicy

2015-07-23 Thread Wei Liu
Also fixed some style problems while I was there. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 7e279cd..3717568 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/t

[Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: David Scott As far as I can tell, all Val_$foo function does deep-copy, so we can safely call dispose in said function. --- tools/ocaml/libs/xl/xenlight_stubs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/xl/xenligh

[Xen-devel] [PATCH for-4.6 11/13] xl: free event struct after use in main_shutdown_or_reboot

2015-07-23 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 3717568..9edc0db 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -4766,8 +4766,10 @@ static

Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Andrew Cooper
On 23/07/2015 08:59, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Cc: David Scott > > As far as I can tell, all Val_$foo function does deep-copy, so we can > safely call dispose in said function. Sadly this is insufficient. failwith_xl() longjump()s back into the ocaml runtime, which ends up

Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 09:32:44AM +0100, Andrew Cooper wrote: > On 23/07/2015 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu > > --- > > Cc: David Scott > > > > As far as I can tell, all Val_$foo function does deep-copy, so we can > > safely call dispose in said function. > > Sadly this is in

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Andrew Cooper
On 23/07/2015 08:59, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > Cc: dave.sc...@eu.citrix.com > > Please check if the use of caml_failwith is correct. This issue I have a different patch for, which could be 4.6 material, if it weren't for the same issue as identified in patch 12. In this cas

Re: [Xen-devel] [PATCH] oxenstored: link in the systemd system library

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 17:02 -0500, Jonathan Creekmore wrote: > If systemd is configured for use AND you are building oxenstored, the > C > systemd library must be linked in to the oxenstored binary instead of > just into the static ocaml stub. I can't see where it is linked into the static ocaml

Re: [Xen-devel] [PATCH] xenconsole: Allow non-interactive use

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 19:08 +0200, Martin Lucina wrote: > If xenconsole is run with stdin closed or redirected to /dev/null, > console_loop() will return immediately due to failure to read from > STDIN_FILENO. This patch tests if stdin and stdout are both connected > to > a TTY and, if not, xencon

Re: [Xen-devel] [PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-23 Thread Roger Pau Monné
El 22/07/15 a les 8.40, Bob Liu ha escrit: > There is a bug when migrate from !feature-persistent host to > feature-persistent > host, because domU still thinks new host/backend doesn't support persistent. > Dmesg like: > backed has not unmapped grant: 839 > backed has not unmapped grant: 773 > ba

Re: [Xen-devel] [PATCH] oxenstored: link in the systemd system library

2015-07-23 Thread Dave Scott
> On 22 Jul 2015, at 23:02, Jonathan Creekmore > wrote: > > If systemd is configured for use AND you are building oxenstored, the C > systemd library must be linked in to the oxenstored binary instead of > just into the static ocaml stub. This sounds sensible to me, Acked-by: David Scott >

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Dave Scott
> On 23 Jul 2015, at 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu > --- > Cc: dave.sc...@eu.citrix.com > > Please check if the use of caml_failwith is correct. This looks fine to me. Acked-by: David Scott > --- > tools/ocaml/libs/xl/xenlight_stubs.c | 4 > 1 file changed, 4 inserti

Re: [Xen-devel] [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent

2015-07-23 Thread Roger Pau Monné
El 22/07/15 a les 8.40, Bob Liu ha escrit: > We should consider info->feature_persistent when adding indriect page to list ^ indirect > info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered. > > Signed-off-by: Bob Liu

Re: [Xen-devel] [PATCH v2] xen-blkback: replace work_pending with work_busy in purge_persistent_gnt()

2015-07-23 Thread Roger Pau Monné
El 22/07/15 a les 8.40, Bob Liu ha escrit: > The BUG_ON() in purge_persistent_gnt() will be triggered when previous purge > work haven't finished. > There is a work_pending() before this BUG_ON, but it doesn't account if the > work > is still currently running. > > Signed-off-by: Bob Liu Acked-

Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Andrew Cooper
On 23/07/15 09:38, Wei Liu wrote: > On Thu, Jul 23, 2015 at 09:32:44AM +0100, Andrew Cooper wrote: >> On 23/07/2015 08:59, Wei Liu wrote: >>> Signed-off-by: Wei Liu >>> --- >>> Cc: David Scott >>> >>> As far as I can tell, all Val_$foo function does deep-copy, so we can >>> safely call dispose in

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 18:07 +0100, Ian Campbell wrote: > This was the rescheduled 8 July call, on the topic of PVH and related > work CCing people who were on the call this time. Perhaps a summary of what we discussed/agreed (AIUI) would be easier to (dis)agree with than the raw minutes:

Re: [Xen-devel] [PATCH for-4.6 01/13] libxl: use thread-safe localtime_t and handle NULL

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

2015-07-23 Thread Dave Scott
> On 23 Jul 2015, at 09:38, Andrew Cooper wrote: > > On 23/07/2015 08:59, Wei Liu wrote: >> Signed-off-by: Wei Liu >> --- >> Cc: dave.sc...@eu.citrix.com >> >> Please check if the use of caml_failwith is correct. > > This issue I have a different patch for, which could be 4.6 material, if > i

Re: [Xen-devel] [PATCH for-4.6 02/13] libxl: properly clean up array in libxl_list_cpupool failure path

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Document how cpupool_info works. Distinguish success (ERROR_FAIL + > ENOENT) vs failure in libxl_list_cpupool and properly clean up the > array > in failure path. > > Also switch to libxl__realloc and call libxl_cpupool_{init,dispose} > where a

Re: [Xen-devel] [PATCH v7 05/15] x86/altp2m: basic data structures and support routines.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 01:01, wrote: > @@ -6569,6 +6571,25 @@ void hvm_toggle_singlestep(struct vcpu *v) > v->arch.hvm_vcpu.single_step = !v->arch.hvm_vcpu.single_step; > } > > +void altp2m_vcpu_update_p2m(struct vcpu *v) > +{ > +if ( hvm_funcs.altp2m_vcpu_update_p2m ) > +hvm_funcs

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Roger Pau Monné
El 23/07/15 a les 11.08, Ian Campbell ha escrit: > On Wed, 2015-07-22 at 18:07 +0100, Ian Campbell wrote: >> This was the rescheduled 8 July call, on the topic of PVH and related >> work > > CCing people who were on the call this time. > > Perhaps a summary of what we discussed/agreed (AIUI) wou

Re: [Xen-devel] [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Those values are overwritten before they can be of any use. I commented on a similar patch recently (having acked it): The flip side is that if the code uses the "init everything and goto out on error" idiom then the init might need to b

Re: [Xen-devel] [PATCH for-4.6 04/13] xl: free pid string in do_daemonize

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Pid is a null terminated string allocated by asprintf. It should be > freed after use. > > Also fixed a coding style problem while I was there. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell __

Re: [Xen-devel] [PATCH for-4.6 01/13] libxl: use thread-safe localtime_t and handle NULL

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 10:14:43AM +0100, Ian Campbell wrote: > On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > > Signed-off-by: Wei Liu > > Acked-by: Ian Campbell I notice that I fat-fingered localtime_r as localtime_t in subject line. Ironically I pointed out the same error your reply to

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Andrew Cooper
On 23/07/15 10:08, Ian Campbell wrote: > On Wed, 2015-07-22 at 18:07 +0100, Ian Campbell wrote: >> This was the rescheduled 8 July call, on the topic of PVH and related >> work > CCing people who were on the call this time. > > Perhaps a summary of what we discussed/agreed (AIUI) would be easier t

Re: [Xen-devel] [PATCH for-4.6 06/13] xl: call libxl_dominfo_{init, dispose} in psr_cmt_show

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.6 05/13] xl: check json string is not null before printing in create_domain

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-23 Thread David Vrabel
On 23/07/15 07:46, Juergen Gross wrote: > On 07/23/2015 06:36 AM, Greg KH wrote: >> On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote: >>> On 07/23/2015 01:46 AM, Greg KH wrote: On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote: > Add the definition of pvUSB protoco

Re: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol description

2015-07-23 Thread David Vrabel
On 23/06/15 07:53, Juergen Gross wrote: > Add the definition of pvUSB protocol used between the pvUSB frontend in > a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0). > > This header was originally provided by Fujitsu for Xen based on Linux > 2.6.18. > > Changes are: > - adap

Re: [Xen-devel] [PATCH for-4.6 07/13] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu info here seems to be used in a loop, without any init or free. I think the init should be moved there, and the looping case needs a dispose, with only the final one being left until the end. (that loop looks a bit odd to

Re: [Xen-devel] [PATCH v7 06/15] VMX/altp2m: add code to support EPTP switching and #VE.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 01:01, wrote: > @@ -1770,6 +1771,105 @@ static bool_t vmx_is_singlestep_supported(void) > return cpu_has_monitor_trap_flag; > } > > +static void vmx_vcpu_update_eptp(struct vcpu *v) > +{ > +struct domain *d = v->domain; > +struct p2m_domain *p2m = NULL; > +st

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-23 Thread Andrew Cooper
On 23/07/15 05:43, Juergen Gross wrote: > On 07/22/2015 04:44 PM, Boris Ostrovsky wrote: >> On 07/22/2015 10:09 AM, Juergen Gross wrote: >>> On 07/22/2015 03:58 PM, Boris Ostrovsky wrote: On 07/22/2015 09:50 AM, Juergen Gross wrote: > On 07/22/2015 03:36 PM, Dario Faggioli wrote: >> On

Re: [Xen-devel] [PATCH for-4.6 08/13] xl: call libxl_dominfo_init in main_list

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Also change the path that disposes of the buffer to use info_buf to > avoid confusing coverity. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell But would it be less confusing to both human and machine readers if info_buf was always init'd a

Re: [Xen-devel] [PATCH for-4.6 09/13] xl: call libxl_bitmap_{init, dispose} in main_cpupoolcreate

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [Patch V4 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)

2015-07-23 Thread David Vrabel
On 23/06/15 07:53, Juergen Gross wrote: > Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen > domU to communicate with a USB device assigned to that domU. The > communication is all done via the pvUSB backend in a driver domain > (usually Dom0) which is owner of the physical de

Re: [Xen-devel] [PATCH for-4.6 10/13] xl: valid fd can be 0 in main_loadpolicy

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Also fixed some style problems while I was there. polFd is initialised to 0, I think it should be initialised to -1 as well as your change here, otherwise you can unexpectedly close stdin on some error paths. (also: studly caps, yuk, not your fa

Re: [Xen-devel] [PATCH for-4.6 11/13] xl: free event struct after use in main_shutdown_or_reboot

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu It appears there is no libxl_evgen_domain_death_dispose to call on the individual members of the array. Ah, because it is opaque. Acked-by: Ian Campbell Although since it is init'd to NULL you could also call free uncon

Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 09:32 +0100, Andrew Cooper wrote: > On 23/07/2015 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu > > --- > > Cc: David Scott > > > > As far as I can tell, all Val_$foo function does deep-copy, so we > > can > > safely call dispose in said function. > > Sadly this is ins

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 01:01, wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > > Reviewed-by: Andrew Cooper > --- > Changes since v6: > rename altp2m lazy copier, make bool_t, use __put_gfn throughout, >

Re: [Xen-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Jan Beulich wrote: > >>> On 22.07.15 at 19:24, wrote: > > I'll queue this change up for the next QEMU release cycle. > > Thanks - v2 (with the adjusted description) just sent. > > It would however be nice for our variant in 4.6 to also gain this, > perhaps independent of ups

Re: [Xen-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Stefano Stabellini wrote: > On Thu, 23 Jul 2015, Jan Beulich wrote: > > >>> On 22.07.15 at 19:24, wrote: > > > I'll queue this change up for the next QEMU release cycle. > > > > Thanks - v2 (with the adjusted description) just sent. > > > > It would however be nice for our v

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-23 Thread Roger Pau Monné
El 06/07/15 a les 14.58, Andrew Cooper ha escrit: > On 03/07/15 12:34, Roger Pau Monne wrote: >> Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are >> always started in 32bit protected mode with paging disabled. >> >> Signed-off-by: Roger Pau Monné >> Cc: Jan Beulich >> C

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 10:35 +0100, Andrew Cooper wrote: > On 23/07/15 10:08, Ian Campbell wrote: > > On Wed, 2015-07-22 at 18:07 +0100, Ian Campbell wrote: > > > This was the rescheduled 8 July call, on the topic of PVH and > > > related > > > work > > CCing people who were on the call this time.

Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

2015-07-23 Thread Andrew Cooper
On 23/07/15 10:55, Ian Campbell wrote: > On Thu, 2015-07-23 at 09:32 +0100, Andrew Cooper wrote: >> On 23/07/2015 08:59, Wei Liu wrote: >>> Signed-off-by: Wei Liu >>> --- >>> Cc: David Scott >>> >>> As far as I can tell, all Val_$foo function does deep-copy, so we >>> can >>> safely call dispose

Re: [Xen-devel] [PATCH v2 1/3] arm64: Add Xen boot support file

2015-07-23 Thread Fu Wei
Hi Vladimir, I have submitted a new patchset (v3) for xen boot. this patchset follows all your comment here. please help me again on this, Great thanks for your help. On 16 July 2015 at 00:18, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.07.2015 10:53, fu@linaro.org wrote: >> From:

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-23 Thread Roger Pau Monné
El 10/07/15 a les 20.47, Konrad Rzeszutek Wilk ha escrit: > On Fri, Jul 03, 2015 at 01:34:45PM +0200, Roger Pau Monne wrote: >> Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are >> always started in 32bit protected mode with paging disabled. > > This is kind of odd in the

Re: [Xen-devel] [PATCH v2] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Fabio Fantoni
Il 23/07/2015 08:59, Jan Beulich ha scritto: The number of slots per page being 511 (i.e. not a power of two) means that the (32-bit) read and write indexes going beyond 2^32 will likely disturb operation. The hypervisor side gets I/O req server creation extended so we can indicate that we're usi

Re: [Xen-devel] [PATCH v2] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. The hypervisor side gets I/O req server creation > extended so we can indicate that we're us

Re: [Xen-devel] [PATCH v7 11/15] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 01:01, wrote: > Signed-off-by: Ed White > > Acked-by: Jan Beulich And I have to withdraw this ack pending clarification of (and perhaps adjustment to) the #VE info address interface. > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -6138,6 +6138,140 @@ sta

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-23 Thread Roger Pau Monné
El 13/07/15 a les 16.01, Jan Beulich ha escrit: On 03.07.15 at 13:34, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -795,6 +795,15 @@ int arch_set_info_guest( >>c.nat->fs_base || c.nat->gs_base_user)) ) >> return -EINVAL; >> } >>

Re: [Xen-devel] [PATCH v3 2/3] x86/ldt: Make modify_ldt optional

2015-07-23 Thread Willy Tarreau
Hi Andy, On Wed, Jul 22, 2015 at 12:23:47PM -0700, Andy Lutomirski wrote: > The modify_ldt syscall exposes a large attack surface and is > unnecessary for modern userspace. Make it optional. Wouldn't you prefer something like this which makes it possible to re-enable it at runtime so that we can

Re: [Xen-devel] [PATCH v3 11/32] xen/x86: add bitmap of enabled emulated devices

2015-07-23 Thread Roger Pau Monné
El 06/07/15 a les 16.10, Andrew Cooper ha escrit: > On 03/07/15 12:34, Roger Pau Monne wrote: >> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c >> index a112953..d684f49 100644 >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -528,6 +528,7 @@ int arch_domain_create(st

Re: [Xen-devel] [PATCH v3 26/32] xenconsole: try to attach to PV console if HVM fails

2015-07-23 Thread Roger Pau Monné
El 14/07/15 a les 15.46, Stefano Stabellini ha escrit: > On Fri, 3 Jul 2015, Roger Pau Monne wrote: >> HVM guests have always used the emulated serial console by default, but if >> the emulated serial pty cannot be fetched from xenstore try to use the PV >> console instead. >> >> Signed-off-by: Rog

Re: [Xen-devel] [PATCH for-4.6 07/13] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 10:41:40AM +0100, Ian Campbell wrote: > On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote: > > Signed-off-by: Wei Liu > > info here seems to be used in a loop, without any init or free. I think > the init should be moved there, and the looping case needs a dispose, > with o

Re: [Xen-devel] [PATCH v3 10/32] libxc: remove dead HVM building code

2015-07-23 Thread Roger Pau Monné
El 06/07/15 a les 15.46, Andrew Cooper ha escrit: > On 03/07/15 12:34, Roger Pau Monne wrote: >> Remove xc_hvm_build_x86.c and xc_hvm_build_arm.c since xc_hvm_build is not >> longer used in order to create HVM guests. >> >> Signed-off-by: Roger Pau Monné >> Cc: Ian Jackson >> Cc: Stefano Stabelli

[Xen-devel] [xen-4.5-testing test] 59813: tolerable FAIL - PUSHED

2015-07-23 Thread osstest service owner
flight 59813 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59813/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 6 xen-boot fail in 59792 pass in 59813 test-amd64-i386-xl-qemuu-ovmf-a

Re: [Xen-devel] [PATCH v3 27/32] libxc: change the position of the special pages

2015-07-23 Thread Roger Pau Monné
El 10/07/15 a les 21.06, Konrad Rzeszutek Wilk ha escrit: > On Fri, Jul 03, 2015 at 05:36:15PM +0200, Roger Pau Monné wrote: >> El 03/07/15 a les 13.35, Roger Pau Monne ha escrit: >>> Change the physical memory address of the special pages when there are no >>> emulated devices. On HVM guests the s

[Xen-devel] [xen-unstable test] 59817: tolerable FAIL - PUSHED

2015-07-23 Thread osstest service owner
flight 59817 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59817/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-rumpuserxen-amd64 15 rumpuserxen-demo-xenstorels/xenstorels.repeat fail REGR. vs. 59795 te

Re: [Xen-devel] [PATCH v3 29/32] libxc/xen: introduce HVM_PARAM_FIRST_FREE_PFN

2015-07-23 Thread Roger Pau Monné
El 10/07/15 a les 21.05, Konrad Rzeszutek Wilk ha escrit: > On Fri, Jul 03, 2015 at 01:35:07PM +0200, Roger Pau Monne wrote: >> This HVM parameter returns the first free pfn after all the special pages. > > Could you describe how the layout of PFNs is now for the HVM guests? > > Is there some doc

Re: [Xen-devel] [PATCH v3 31/32] libxc: switch xc_dom_elfloader to be used with HVMlite domains

2015-07-23 Thread Roger Pau Monné
El 10/07/15 a les 21.07, Konrad Rzeszutek Wilk ha escrit: > On Fri, Jul 03, 2015 at 01:35:09PM +0200, Roger Pau Monne wrote: >> Allow xc_dom_elfloader to report a guest type as hvm-3.0-x86_32 if it's >> running inside of a HVM container and has the PHYS32_ENTRY elfnote set. >> >> Signed-off-by: Rog

Re: [Xen-devel] [PATCH] xenconsole: Allow non-interactive use

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 09:48:50AM +0100, Ian Campbell wrote: > On Wed, 2015-07-22 at 19:08 +0200, Martin Lucina wrote: > > If xenconsole is run with stdin closed or redirected to /dev/null, > > console_loop() will return immediately due to failure to read from > > STDIN_FILENO. This patch tests if

[Xen-devel] [PATCH] x86/msi: Don't dereference pdev before its NULL check

2015-07-23 Thread Andrew Cooper
Signed-off-by: Andrew Cooper CC: Jan Beulich --- xen/arch/x86/msi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index fa95048..160167c 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -1345,7 +1345,7 @@ int pci_res

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Konrad Rzeszutek Wilk
On July 23, 2015 5:08:46 AM EDT, Ian Campbell wrote: >On Wed, 2015-07-22 at 18:07 +0100, Ian Campbell wrote: >> This was the rescheduled 8 July call, on the topic of PVH and related > >> work > >CCing people who were on the call this time. > >Perhaps a summary of what we discussed/agreed (AIUI) wo

Re: [Xen-devel] [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Ian, you forgot your S-o-B. So I did, thanks. > Acked-by: Wei Liu Thanks. Also, I should mention that have retained the ack from Kevin Tian (CC'd), since my changes were almost entirely mechanical. Ian.

Re: [Xen-devel] [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-23 Thread Ian Jackson
Chen, Tiejun writes ("Re: [PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Thanks for your effort. > > A tiny change may be needed but I don't block this. Thanks. I have applied this change to my tree. There is no functional change and I don't feel the need to collect a new

Re: [Xen-devel] [PATCH v13 00/16] Fix RMRR (avoid RDM)

2015-07-23 Thread Ian Jackson
Chen, Tiejun writes ("Re: [PATCH v13 00/16] Fix RMRR (avoid RDM)"): > This was supposed to be my responsibility to resend this series so > appreciate for your extra effort. Thanks. > Yes. I can compile and boot successfully with/without rdm setting. Great. I will double check with Jan but I in

[Xen-devel] [PATCH] tools/libxl: Fixes to stream v2 task joining logic

2015-07-23 Thread Andrew Cooper
During review of the libxl migration v2 series, I changes the task joining logic, but clearly didn't think the result through properly. This patch fixes several errors. 1) Do not call check_all_finished() in the success cases of libxl__xc_domain_{save,restore}_done(). It serves no specific purpos

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Roger Pau Monné
El 23/07/15 a les 12.59, Konrad Rzeszutek Wilk ha escrit: [...] > We forgot to speak about dom0. This work outlined will lay out how to do it - > but the pieces for dom0 are not implemented and would need work (which > actually may be following most of the is_pvh in the hypervisor). Let's do tha

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Andrew Cooper
On 23/07/15 12:17, Roger Pau Monné wrote: > El 23/07/15 a les 12.59, Konrad Rzeszutek Wilk ha escrit: > [...] >> We forgot to speak about dom0. This work outlined will lay out how to do it >> - but the pieces for dom0 are not implemented and would need work (which >> actually may be following mos

Re: [Xen-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 12:04, wrote: > On Thu, 23 Jul 2015, Jan Beulich wrote: >> >>> On 22.07.15 at 19:24, wrote: >> > I'll queue this change up for the next QEMU release cycle. >> >> Thanks - v2 (with the adjusted description) just sent. >> >> It would however be nice for our variant in 4.6 to al

Re: [Xen-devel] [MINUTES] Monthly Xen.org Technical Call (2015-07-22)

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 13:17 +0200, Roger Pau Monné wrote: > El 23/07/15 a les 12.59, Konrad Rzeszutek Wilk ha escrit: > [...] > > We forgot to speak about dom0. This work outlined will lay out how > > to do it - but the pieces for dom0 are not implemented and would > > need work (which actually m

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 12:25, wrote: > El 13/07/15 a les 16.01, Jan Beulich ha escrit: > On 03.07.15 at 13:34, wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -795,6 +795,15 @@ int arch_set_info_guest( >>>c.nat->fs_base || c.nat->gs_base_user)) ) >>>

Re: [Xen-devel] [PATCH] tools/libxl: Fixes to stream v2 task joining logic

2015-07-23 Thread Wei Liu
On Thu, Jul 23, 2015 at 12:09:38PM +0100, Andrew Cooper wrote: > During review of the libxl migration v2 series, I changes the task > joining logic, but clearly didn't think the result through > properly. This patch fixes several errors. > > 1) Do not call check_all_finished() in the success cases

Re: [Xen-devel] [PATCH] tools/libxl: Fixes to stream v2 task joining logic

2015-07-23 Thread Andrew Cooper
On 23/07/15 12:38, Wei Liu wrote: > On Thu, Jul 23, 2015 at 12:09:38PM +0100, Andrew Cooper wrote: >> During review of the libxl migration v2 series, I changes the task >> joining logic, but clearly didn't think the result through >> properly. This patch fixes several errors. >> >> 1) Do not call c

Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

2015-07-23 Thread Ian Campbell
On Thu, 2015-07-23 at 05:29 -0600, Jan Beulich wrote: > > > > > > On 23.07.15 at 12:25, wrote: > > El 13/07/15 a les 16.01, Jan Beulich ha escrit: > > > > > > On 03.07.15 at 13:34, wrote: > > > > --- a/xen/arch/x86/domain.c > > > > +++ b/xen/arch/x86/domain.c > > > > @@ -795,6 +795,15 @@ int arc

[Xen-devel] [PATCH] x86/MSI: drop bogus NULL check from pci_restore_msi_state()

2015-07-23 Thread Jan Beulich
Commit 372900faf8 ("x86/MSI-X: reduce fiddling with control register during restore") introduced de-references of pdev before it gets checked against NULL. Instead of deferring the de-references, drop the pointless check - both call sites do that check already. Reported-by: Andrew Cooper Signed-o

Re: [Xen-devel] [PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-23 Thread Ian Jackson
Ian Jackson writes ("[PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy"): > From: Tiejun Chen > > This patch extends the existing hypercall to support rdm reservation policy. > We return error or just throw out a warning message depending on whether > the policy i

Re: [Xen-devel] [PATCH] x86/msi: Don't dereference pdev before its NULL check

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 12:54, wrote: > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -1345,7 +1345,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) > struct msi_desc *entry, *tmp; > struct irq_desc *desc; > struct msi_msg msg; > -u8 slot = PCI_SLOT(pdev->devfn), func

Re: [Xen-devel] [PATCH] x86/MSI: drop bogus NULL check from pci_restore_msi_state()

2015-07-23 Thread Andrew Cooper
On 23/07/15 12:44, Jan Beulich wrote: > Commit 372900faf8 ("x86/MSI-X: reduce fiddling with control register > during restore") introduced de-references of pdev before it gets > checked against NULL. Instead of deferring the de-references, drop > the pointless check - both call sites do that check

[Xen-devel] [v4 00/17] Add VT-d Posted-Interrupts support

2015-07-23 Thread Feng Wu
VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt. With VT-d Posted-Interrupts enabled, external interrupts from direct-assigned devices can be delivered to guests without VMM intervention when guest is running in non-root mode. You can find the VT-d Posted-Interrtups Spec. in

  1   2   3   >