On Thu, 2015-07-23 at 09:32 +0100, Andrew Cooper wrote: > On 23/07/2015 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > --- > > Cc: David Scott <dave.sc...@eu.citrix.com> > > > > As far as I can tell, all Val_$foo function does deep-copy, so we > > can > > safely call dispose in said function. > > Sadly this is insufficient. failwith_xl() longjump()s back into the > ocaml runtime, which ends up leaking any allocations made for > dominfo. > > This is a systemic problem with the Ocaml bindings and I have a > proposed > solution but it involves rewriting quite a lot of this code and is > definitely not 4.6 material.
Is it not sufficient to treat failwith_xl as a longjump statement (or any sort of "return-y" thing), which would simply necessitate doing the cleanup before calling it? Perhaps Coverity could model it as such and would therefore warn about the dead code being added here? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
