On Thu, Jul 23, 2015 at 09:32:44AM +0100, Andrew Cooper wrote: > On 23/07/2015 08:59, Wei Liu wrote: > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > --- > > Cc: David Scott <dave.sc...@eu.citrix.com> > > > > As far as I can tell, all Val_$foo function does deep-copy, so we can > > safely call dispose in said function. > > Sadly this is insufficient. failwith_xl() longjump()s back into the > ocaml runtime, which ends up leaking any allocations made for dominfo. > > This is a systemic problem with the Ocaml bindings and I have a proposed > solution but it involves rewriting quite a lot of this code and is > definitely not 4.6 material. >
Fine then. Systematic problem requires systematic fix. Let's ignore the last two patches in this series. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
