On Tue, 2015-04-07 at 16:21 -0700, Michael Chan wrote:
> On Tue, 2015-04-07 at 19:13 +0100, Ian Jackson wrote:
> > root@bedbug:~# ethtool -S xenbr0 | grep -v ': 0$'
> > no stats available
> > root@bedbug:~#
>
> Please provide ethtool -S on the tg3 device.
Ian, in your previous mail you indicated
On Tue, Apr 07, Konrad Rzeszutek Wilk wrote:
> You might also want to use 'sync_console'.
This does not give any extra info in the case of the reported hang.
Olaf
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
> From: Li, Liang Z
> Sent: Tuesday, April 07, 2015 9:27 PM
>
> This bug will be trigged when NMI happen in the L2 guest. The current
> code handles the NMI incorrectly. According to Intel SDM 31.7.1.2
> (Resuming Guest Software after Handling an Exception), If bit 31 of the
> IDT-vectoring inform
On Wed, Apr 08, Wen Congyang wrote:
> commit b9245b75 introduces a building error:
> make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader'
> gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statem
On 04/08/2015 03:21 PM, Olaf Hering wrote:
> On Wed, Apr 08, Wen Congyang wrote:
>
>> commit b9245b75 introduces a building error:
>> make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader'
>> gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing
>> -std=gnu99 -
On Wed, Apr 08, Wen Congyang wrote:
> On 04/08/2015 03:21 PM, Olaf Hering wrote:
> > On Wed, Apr 08, Wen Congyang wrote:
> >
> >> commit b9245b75 introduces a building error:
> >> make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader'
> >> gcc -O1 -fno-omit-frame-pointer -m32 -ma
On 04/08/2015 03:28 PM, Olaf Hering wrote:
> On Wed, Apr 08, Wen Congyang wrote:
>
>> On 04/08/2015 03:21 PM, Olaf Hering wrote:
>>> On Wed, Apr 08, Wen Congyang wrote:
>>>
commit b9245b75 introduces a building error:
make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader'
On Wed, 2015-04-08 at 13:59 +0800, Chao Peng wrote:
> > Mostly, I was curious to learn why that is not reflected in the current
> > implementation, i.e., whether there are any reasons why we should not
> > take advantage of per-socketness of RMIDs, as reported by SDM, as that
> > can greatly help
Hi Pranav,
On Mon, Apr 06, 2015 at 02:24:01PM +0530, Pranavkumar Sawargaonkar wrote:
> In old X-Gene Storm firmware and DT, secure mode addresses have been
> mentioned in GICv2 node. In this case maintenance interrupt is used
> instead of EOI HW method.
>
> This patch checks the GIC Distributor B
Hi Ian,
I am currently looking into the asynchronous task cancellation in libxl and
have a few very specific queries, if you could answer.
1.In libxl_domain_resume(),why is libxl_ao_complete called before
AO_INPROGRESS?
2.In libxl_ao_cancel() - the function goes through the ctx->aos_i
On 08/04/15 08:33, Wen Congyang wrote:
> On 04/08/2015 03:28 PM, Olaf Hering wrote:
>> On Wed, Apr 08, Wen Congyang wrote:
>>
>>> On 04/08/2015 03:21 PM, Olaf Hering wrote:
On Wed, Apr 08, Wen Congyang wrote:
> commit b9245b75 introduces a building error:
> make[1]: Entering direc
> From: Wu, Feng
> Sent: Thursday, April 02, 2015 4:40 PM
>
> > -Original Message-
> > From: Tian, Kevin
> > Sent: Thursday, April 02, 2015 2:25 PM
> > To: Wu, Feng; xen-devel@lists.xen.org
> > Cc: jbeul...@suse.com; k...@xen.org; Zhang, Yang Z
> > Subject: RE: [RFC v1 13/15] Update Posted
On 08/04/15 09:23, Dario Faggioli wrote:
> On Wed, 2015-04-08 at 13:59 +0800, Chao Peng wrote:
>
>>> Mostly, I was curious to learn why that is not reflected in the current
>>> implementation, i.e., whether there are any reasons why we should not
>>> take advantage of per-socketness of RMIDs, as re
On Wed, Apr 08, 2015 at 08:23:11AM +, Dario Faggioli wrote:
> On Wed, 2015-04-08 at 13:59 +0800, Chao Peng wrote:
>
> > > Mostly, I was curious to learn why that is not reflected in the current
> > > implementation, i.e., whether there are any reasons why we should not
> > > take advantage of
> From: Wu, Feng
> Sent: Thursday, April 02, 2015 3:18 PM
>
> > -Original Message-
> > From: Tian, Kevin
> > Sent: Thursday, April 02, 2015 2:01 PM
> > To: Wu, Feng; xen-devel@lists.xen.org
> > Cc: jbeul...@suse.com; k...@xen.org; Zhang, Yang Z
> > Subject: RE: [RFC v1 11/15] vmx: Add a gl
On 04/07/2015 09:25 PM, Meng Xu wrote:
> Hi George, Dario and Konrad,
>
> I finished a prototype of the RTDS scheduler with the dedicated CPU
> feature and did some quick evaluation on this feature. Right now, I
> need to refactor the code (because it is kind of messy when I was
> exploring differ
On Tue, Apr 7, 2015 at 5:11 PM, Andrew Cooper wrote:
> On 07/04/15 14:27, Liang Li wrote:
>> This bug will be trigged when NMI happen in the L2 guest. The current
>> code handles the NMI incorrectly. According to Intel SDM 31.7.1.2
>> (Resuming Guest Software after Handling an Exception), If bit 3
On Wed, 8 Apr 2015, Manish Jaggi wrote:
> On Wednesday 08 April 2015 11:05 AM, Manish Jaggi wrote:
> >
> > On Tuesday 07 April 2015 10:13 PM, Stefano Stabellini wrote:
> > > On Tue, 7 Apr 2015, Jaggi, Manish wrote:
> > > > Hi Julien,
> > > >
> > > >
> > > > Following patch generated compiler err
From: Iurii Konovalenko
Changes in v2:
- Commit message edited
- Signed-off is set
Iurii Konovalenko (1):
arm: irq: increase size of irq from uint8_t to uint32_t
tools/libxc/include/xenctrl.h | 10 +-
tools/libxc/xc_domain.c | 10 +-
xen/include/public/domctl.h
From: Iurii Konovalenko
Changes are dedicated to XEN_DOMCTL_irq_permission and
IRQ pssthrough API functions.
Signed-off-by: Iurii Konovalenko
---
tools/libxc/include/xenctrl.h | 10 +-
tools/libxc/xc_domain.c | 10 +-
xen/include/public/domctl.h | 2 +-
3 files changed
On Wednesday 08 April 2015 02:53 PM, Stefano Stabellini wrote:
On Wed, 8 Apr 2015, Manish Jaggi wrote:
On Wednesday 08 April 2015 11:05 AM, Manish Jaggi wrote:
On Tuesday 07 April 2015 10:13 PM, Stefano Stabellini wrote:
On Tue, 7 Apr 2015, Jaggi, Manish wrote:
Hi Julien,
Following patch g
On 08/04/2015 10:31, Manish Jaggi wrote:
There are lot of issues with pci_to_dev approach
a) iommu_ops callbacks have a pci_dev parameter in x86 but have a device
parameter in arm (smmu.c)
b) hack is done to make device as pci_dev and that is not a good way
of doing.
I prefer having minimal/so
On 04/08/2015 04:46 PM, Andrew Cooper wrote:
> On 08/04/15 08:33, Wen Congyang wrote:
>> On 04/08/2015 03:28 PM, Olaf Hering wrote:
>>> On Wed, Apr 08, Wen Congyang wrote:
>>>
On 04/08/2015 03:21 PM, Olaf Hering wrote:
> On Wed, Apr 08, Wen Congyang wrote:
>
>> commit b9245b75 intr
On Tue, 2015-04-07 at 18:26 +0100, Andrew Cooper wrote:
> Previously, all pcpu stacks tended to be allocated on node 0.
>
> Signed-off-by: Andrew Cooper
> CC: Keir Fraser
> CC: Jan Beulich
>
Again, FWIW:
Reviewed-by: Dario Faggioli
Out of curiosity...
> xen/arch/x86/smpboot.c |2 +-
>
CC Anthony who once told me a trick to do that.
On Tue, Apr 07, 2015 at 10:44:18PM -0400, mailing lists wrote:
> Following the guide for nested virtualization here:
>
> http://wiki.xenproject.org/wiki/Nested_Virtualization_in_Xen
>
> It states that one option for display issues is to force "full
On Tue, 2015-04-07 at 18:26 +0100, Andrew Cooper wrote:
> Hoist MEMF_node(cpu_to_node(cpu)) to the start of the function, and avoid
> passing (potentially bogus) memflags if node information is not available.
>
> Signed-off-by: Andrew Cooper
> CC: Keir Fraser
> CC: Jan Beulich
>
FWIW,
Reviewed
On Tue, 2015-04-07 at 18:26 +0100, Andrew Cooper wrote:
> This was missed by c/s 54ce2db "x86/numa: adjust datatypes for node and pxm"
> which changed the array definition in numa.c
>
> Signed-off-by: Andrew Cooper
> CC: Keir Fraser
> CC: Jan Beulich
> CC: Boris Ostrovsky
>
Reviewed-by: Dario
On 03/04/15 07:45, Bob Liu wrote:
> Remove the 'DEPRECATED' and next patch will follow the protocol defined here
> to
> support multi-page ring.
Why are you un-deprecating this instead of using max-ring-page-order?
Are you allowing for non power of two counts? If so, the documentation
needs to be
Wen Congyang writes ("[Xen-devel] [PATCH] hvmloader: fix building error"):
> commit b9245b75 introduces a building error:
...
> smbios.c:384:46: error: invalid digit "8" in octal constant
> smbios.c:792:46: error: invalid digit "8" in octal constant
> make[1]: *** [smbios.o] Error 1
Thanks for thi
On 08/04/15 11:46, Ian Jackson wrote:
> Wen Congyang writes ("[Xen-devel] [PATCH] hvmloader: fix building error"):
>> commit b9245b75 introduces a building error:
> ...
>> smbios.c:384:46: error: invalid digit "8" in octal constant
>> smbios.c:792:46: error: invalid digit "8" in octal constant
>> m
> -Original Message-
> From: Tian, Kevin
> Sent: Wednesday, April 08, 2015 4:54 PM
> To: Wu, Feng; xen-devel@lists.xen.org
> Cc: jbeul...@suse.com; k...@xen.org; Zhang, Yang Z
> Subject: RE: [RFC v1 13/15] Update Posted-Interrupts Descriptor during vCPU
> scheduling
>
> > From: Wu, Feng
On Tue, Apr 07, 2015 at 02:05:28PM +0100, Ian Jackson wrote:
> Some operating systems (including Linux and FreeBSD[1]) signal not
> (only) POLLIN when a reading pipe reaches EOF, but POLLHUP (with or
> without POLLIN). This is permitted[2]. The implications are that in
> the general case it is no
> -Original Message-
> From: Tian, Kevin
> Sent: Wednesday, April 08, 2015 5:02 PM
> To: Wu, Feng; xen-devel@lists.xen.org
> Cc: jbeul...@suse.com; k...@xen.org; Zhang, Yang Z
> Subject: RE: [RFC v1 11/15] vmx: Add a global wake-up vector for VT-d
> Posted-Interrupts
>
> > From: Wu, Feng
On 04/07/2015 11:27 AM, Andrew Cooper wrote:
> On 04/04/2015 03:14, Dario Faggioli wrote:
>> Hi Everyone,
>>
>> This RFC series is the outcome of an investigation I've been doing about
>> whether we can take better advantage of features like Intel CMT (and of PSR
>> features in general). By "take b
On 04/04/2015 03:14 AM, Dario Faggioli wrote:
> ### Per-vCPU cache monitoring
>
> This means being able to tell how much of the L3 is being used by each vCPU.
> Monitoring the cache occupancy of a specific domain, would still be possible,
> just by summing up the contributions from all the domain'
Hi Iurii,
On 08/04/15 10:29, Iurii Konovalenko wrote:
> From: Iurii Konovalenko
>
> Changes are dedicated to XEN_DOMCTL_irq_permission and
> IRQ pssthrough API functions.
s/pssthrough/passthrough
It's worth noticing that PHYSDEV_* operations already using 32 bits type
but signed one. Many plac
Hi Chen,
On 07/04/15 12:24, Chen Baozi wrote:
> We have already had the boot pagetable when reaching the point
s/had/added/ ?
> of early_printk fixmap setup. Thus there is no longer necessary
s/there is/it is/ ?
> to calculate physical address of xen_fixmap.
>
> Signed-off-by: Chen Baozi
Ot
Koushik Chakravarty writes ("tools/libxl - Async Task Cancellation Query"):
> I am currently looking into the asynchronous task cancellation in libxl and
> have a few very specific queries, if you could answer.
Sure. Thanks for what has evidently been a careful review of the
code.
> 1.In li
This doc comment about ao lifecycle failed to mention the option of
completing the ao during the initiator function. (Indeed, the most
obvious reading would forbid it.)
Restructure the comment, describe this situation, and generally
improve the wording.
Also, fix a grammar problem (missing word
[ In v4 of the series I will combine this fixup with the named patch
using git-rebase -i --autosquash -iwj. ]
v4: Actually record aos on aos_inprogress.
(Report from Koushik Chakravarty at Citrix.)
Signed-off-by: Ian Jackson
---
tools/libxl/libxl_event.c |5 -
1 file changed, 4 in
On Wed, Apr 08, 2015 at 11:10:00AM +0100, Wei Liu wrote:
> CC Anthony who once told me a trick to do that.
>
> On Tue, Apr 07, 2015 at 10:44:18PM -0400, mailing lists wrote:
> > Following the guide for nested virtualization here:
> >
> > http://wiki.xenproject.org/wiki/Nested_Virtualization_in_Xe
On 07/04/15 03:55, Waiman Long wrote:
> This patch adds the necessary Xen specific code to allow Xen to
> support the CPU halting and kicking operations needed by the queue
> spinlock PV code.
This basically looks the same as the version I wrote, except I think you
broke it.
> +static void xen_ql
Thanks Ian for the answers. I have a follow - up on the below:
"Can I suggest adding a unique private 'id' field to the libxl_asyncop_how
structure, that will be populated by AO_CREATE? This will help finding the
matching corresponding libxl_ao from the ctx->aos_inprogress in
libxl_ao_cancel()
Hi Chen,
Subject: I think you can drop the "_" in spin_table.
On 07/04/15 08:33, Chen Baozi wrote:
> From: Chen Baozi
>
> On arm64, either firmware or xen's smp_up_cpu gate uses WFE on secondary
> cpus to stand-by when booting. Thus, using SEV is enough for the boot
> cpu to kick other secondar
Hi, Julien!
Do you mean I need to add your comment to commit message?
Best regards.
Iurii Konovalenko | Senior Software Engineer
GlobalLogic
On Wed, Apr 8, 2015 at 2:26 PM, Julien Grall wrote:
>
> Hi Iurii,
>
> On 08/04/15 10:29, Iurii Konovalenko wrote:
> > From: Iurii Konovalenko
> >
> > Ch
On 08/04/15 13:29, Iurii Konovalenko wrote:
> Do you mean I need to add your comment to commit message?
Yes please. It will keep track of why you only changes xc_domctl_*irq*
Cheers,
--
Julien Grall
___
Xen-devel mailing list
Xen-devel@lists.xen.org
From: Iurii Konovalenko
The following patch series adds ability to relocate Xen in over 4GB space
for 32-bit arm cores with LPAE.
Iurii Konovalenko (2):
arm: Add ability to relocate Xen in over 4GB space
arm: skip verifying memory continuity
xen/Rules.mk | 1 +
xen/arch
From: Iurii Konovalenko
Odd check.
Signed-off-by: Iurii Konovalenko
Signed-off-by: Andrii Anisov
---
xen/arch/arm/setup.c | 4
1 file changed, 4 deletions(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 66e2834..a7fcbb6 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/
From: Iurii Konovalenko
Primary CPU relocate Xen in over 4GB space and wake up seondary CPUs.
Secondary CPUs run on unrelocated copy of Xen until turning on MMU.
After turning on MMU secondary CPUs run on relocated copy of Xen.
To add ability to relocate Xen in over 4GB space add following to
co
flight 50363 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/50363/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i3866 capture-logs !broken [st=!broken!]
build-i386-xsm
Since a PVH hardware domain has access to the physical hardware create a
custom more permissive IO bitmap. The permissions set on the bitmap are
populated based on the contents of the ioports rangeset.
Also add the IO ports of the serial console used by Xen to the list of not
accessible IO ports.
On Wed, 2015-04-08 at 12:30 +0100, George Dunlap wrote:
> On 04/04/2015 03:14 AM, Dario Faggioli wrote:
> > ### Per-vCPU cache monitoring
> >
> > This means being able to tell how much of the L3 is being used by each vCPU.
> > Monitoring the cache occupancy of a specific domain, would still be
>
Hi Tamas,
On 26/03/15 22:05, Tamas K Lengyel wrote:
> From: Julien Grall
>
> The function domain_get_maximum_gpfn is returning the maximum gpfn ever
> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose.
>
> We use this in xenaccess as to avoid the user attempting to set
On 03/04/15 07:44, Bob Liu wrote:
> From: Wei Liu
>
> Originally Xen PV drivers only use single-page ring to pass along
> information. This might limit the throughput between frontend and
> backend.
>
> The patch extends Xenbus driver to support multi-page ring, which in
> general should improve
On 04/04/2015 03:14 AM, Dario Faggioli wrote:
> This allows for a new item to be passed as part of the psr=
> boot option: "percpu_cmt". If that is specified, Xen tries,
> at boot time, to associate an RMID to each core.
>
> XXX This all looks rather straightforward, if it weren't
> for the fa
On Wed, 2015-04-08 at 12:27 +0100, George Dunlap wrote:
> On 04/07/2015 11:27 AM, Andrew Cooper wrote:
> > There seem to be several areas of confusion indicated in your document.
> > I am unsure whether this is a side effect of the way you have written
> > it, but here are (hopefully) some words
The patch that will use xc_domain_maximum_gpfn is not included right now in
this series as my other series significantly cleans up the existing
xen-access test code. Before that's merged, there is no point in carrying
that patch here as it will be in conflict anyway. I'm intending to send
that once
If the device being added to Xen is not contained in the ACPI table,
walk the PCI device tree to find a parent that is contained in the ACPI
table before finding the PXM information from this device.
Signed-off-by: Ross Lagerwall
---
drivers/xen/pci.c | 15 +--
1 file changed, 13 ins
On 08/04/15 14:38, Tamas K Lengyel wrote:
> The patch that will use xc_domain_maximum_gpfn is not included right now
> in this series as my other series significantly cleans up the existing
> xen-access test code. Before that's merged, there is no point in
> carrying that patch here as it will be i
On Wed, Apr 8, 2015 at 3:42 PM, Julien Grall
wrote:
> On 08/04/15 14:38, Tamas K Lengyel wrote:
> > The patch that will use xc_domain_maximum_gpfn is not included right now
> > in this series as my other series significantly cleans up the existing
> > xen-access test code. Before that's merged, t
On 08/04/15 14:47, Tamas K Lengyel wrote:
> I think updating libxc to not truncate the value would be the preferred
> way to go forward (changing return type to uint64_t). I already added
> those changes to this patch and it's only a handful of instances.
It won't work if the toolstack is running
Thanks to Konrad, Michael and Prashant for your attention.
Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen"):
> Ian, in your previous mail you indicated there are no drops or errors
> reported on eth0 (assuming this is the tg3 port), which is added to the
> bridge xenbr0 i
On Wed, 2015-04-08 at 14:28 +0100, George Dunlap wrote:
> On 04/04/2015 03:14 AM, Dario Faggioli wrote:
> > This allows for a new item to be passed as part of the psr=
> > boot option: "percpu_cmt". If that is specified, Xen tries,
> > at boot time, to associate an RMID to each core.
> >
> > XXX T
On 04/08/2015 09:39 AM, Ross Lagerwall wrote:
If the device being added to Xen is not contained in the ACPI table,
walk the PCI device tree to find a parent that is contained in the ACPI
table before finding the PXM information from this device.
Signed-off-by: Ross Lagerwall
---
drivers/xen/p
On Wed, Apr 08, 2015 at 09:09:23AM +0200, Olaf Hering wrote:
> On Tue, Apr 07, Konrad Rzeszutek Wilk wrote:
>
> > You might also want to use 'sync_console'.
>
> This does not give any extra info in the case of the reported hang.
No, but are you able to at least dump the status of the registers?
From: Iurii Konovalenko
Changes are dedicated to XEN_DOMCTL_irq_permission and
IRQ pssthrough API functions.
PHYSDEV_* operations already using 32 bits type but signed one.
Although, PHYSDEV_* operations are not yet used on ARM and LPIs support
(which are using very high number) are not support
From: Iurii Konovalenko
Changes in v3:
- Julien Grall's comment added to commit message
Changes in v2:
- Commit message edited
- Signed-off is set
Iurii Konovalenko (1):
arm: irq: increase size of irq from uint8_t to uint32_t
tools/libxc/include/xenctrl.h | 10 +-
tools/
On Wed, Apr 08, 2015 at 11:46:44AM +0100, David Vrabel wrote:
> On 03/04/15 07:45, Bob Liu wrote:
> > Remove the 'DEPRECATED' and next patch will follow the protocol defined
> > here to
> > support multi-page ring.
>
> Why are you un-deprecating this instead of using max-ring-page-order?
> Are yo
On 08/04/15 15:21, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 08, 2015 at 11:46:44AM +0100, David Vrabel wrote:
>> On 03/04/15 07:45, Bob Liu wrote:
>>> Remove the 'DEPRECATED' and next patch will follow the protocol defined
>>> here to
>>> support multi-page ring.
>>
>> Why are you un-deprecating
Hi Tamas,
One minor question.
On 26/03/15 22:05, Tamas K Lengyel wrote:
> +/*
> + * We had a mem_access permission limiting the access, but the page type
> + * could also be limiting, so we need to check that as well.
> + */
> +maddr = p2m_lookup(current->domain, ipa, &t);
> +
On Fri, Apr 03, 2015 at 04:49:01PM -0600, Jim Fehlig wrote:
> V3 of a small series to fix issues wrt domain destroy
>
> V1:
> https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
>
> V2:
> https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html
>
> In this version, p
Hey Jim, Andrew, and Ian,
This is libvirt v1.2.14 + three patches:
c82a59b libxl: drop virDomainObj lock when destroying a domain
a1c9d30 libxl: acquire a job when destroying a domain
5bd5406 libxl: Move job acquisition in libxlDomainStart to callers
For fun I've set up an guest with PCI passthro
It is unhealthy. If the device is not doing any DMA operations
it would work - but if you are saving and there are DMA operations
happening the chance of corruption (outstanding DMAs) increase.
As such re-use the check migration used.
Signed-off-by: Konrad Rzeszutek Wilk
---
src/libxl/libxl_dom
That function can fail.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
Cc: Dario Faggioli
---
tools/libxl/libxl_dom.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index a88db69..bc2e596 100644
--- a/tool
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
Cc: Charles Arnold
---
tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c
b/tools/xenstat/libxenstat/src/xenstat_qmp.c
index 2cb99e9..f3aeec4 100644
The second argument of poll(2) is the number of file descriptors. POLLIN
is defined as 1 so it happens to work.
Also do two cleanups while I was there:
1. There is only one fd, so a one-element array is enough.
2. Initialise pfd to make code linter happy.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Passing NULL to strcmp can cause segmentation fault. Continue in that
case.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
Cc: Charles Arnold
---
tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstat/libxenstat/sr
Originally qmp_stats is only freed in failure path and leaked in success
path.
Instead of wiring up the success path, rearrange the code a bit to
always free qmp_stats before checking if info is NULL.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
Cc: Charles Arnold
---
tools/xensta
Wei Liu (4):
libxenstat: check xc_interface_open return value
libxenstat: YAJL_GET_STRING may return NULL
libxenstat: always free qmp_stats
libxenstat: qmp_read fix and cleanup
tools/xenstat/libxenstat/src/xenstat_qmp.c | 18 --
1 file changed, 12 insertions(+), 6 deletion
On Wed, Apr 08, 2015 at 12:37:58PM +0100, Ian Jackson wrote:
> This doc comment about ao lifecycle failed to mention the option of
> completing the ao during the initiator function. (Indeed, the most
> obvious reading would forbid it.)
>
> Restructure the comment, describe this situation, and gen
On 08/04/15 16:01, Wei Liu wrote:
> Passing NULL to strcmp can cause segmentation fault. Continue in that
> case.
>
> Signed-off-by: Wei Liu
> Cc: Ian Campbell
> Cc: Ian Jackson
> Cc: Charles Arnold
Reviewed-by: Andrew Cooper
> ---
> tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
> 1 fi
On 08/04/15 16:01, Wei Liu wrote:
> Signed-off-by: Wei Liu
> Cc: Ian Campbell
> Cc: Ian Jackson
> Cc: Charles Arnold
The xenstat handle passed around already has an open xc_handle. That
should be reused rather than opening a new one every time we want to get
a list of domain ids.
~Andrew
>
> On Tue, Apr 7, 2015 at 2:42 AM, mailing lists wrote:
> > Hi --
> >
> > I've been trying to get nested virtualization working with Xen so that
> > I could boot Windows and use Hyper-V related features, however I have
> > not had much success. Using Windows 8.1 or Windows 2012r2, I'm able
> > to
On 08/04/15 16:01, Wei Liu wrote:
> The second argument of poll(2) is the number of file descriptors. POLLIN
> is defined as 1 so it happens to work.
>
> Also do two cleanups while I was there:
> 1. There is only one fd, so a one-element array is enough.
> 2. Initialise pfd to make code linter happ
Hi Tamas,
The code looks good. See few typoes and coding style issue below.
On 26/03/15 22:05, Tamas K Lengyel wrote:
> +static int p2m_mem_access_radix_set(struct p2m_domain *p2m, unsigned long
> pfn,
> +p2m_access_t a)
> +{
> +int rc;
> +
> +if ( !p2
On 08/04/15 15:47, Konrad Rzeszutek Wilk wrote:
> Hey Jim, Andrew, and Ian,
>
> This is libvirt v1.2.14 + three patches:
> c82a59b libxl: drop virDomainObj lock when destroying a domain
> a1c9d30 libxl: acquire a job when destroying a domain
> 5bd5406 libxl: Move job acquisition in libxlDomainStart
El 02/04/15 a les 20.32, Andrew Cooper ha escrit:
> Presented here is v8 of the Migration v2 series (libxc subset), which is able
> to function when transparently inserted under an unmodified xl/libxl.
>
> There are numerous tweaks in v8 (fix build with MiniOS, tweak some code to
> appease Coverit
On Wed, Apr 8, 2015 at 5:26 PM, Julien Grall
wrote:
> Hi Tamas,
>
> The code looks good. See few typoes and coding style issue below.
>
> On 26/03/15 22:05, Tamas K Lengyel wrote:
> > +static int p2m_mem_access_radix_set(struct p2m_domain *p2m, unsigned
> long pfn,
> > +
On Wed, Apr 08, 2015 at 04:25:06PM +0100, Andrew Cooper wrote:
> On 08/04/15 16:01, Wei Liu wrote:
> > The second argument of poll(2) is the number of file descriptors. POLLIN
> > is defined as 1 so it happens to work.
> >
> > Also do two cleanups while I was there:
> > 1. There is only one fd, so
On Wed, Apr 08, 2015 at 04:21:56PM +0100, Andrew Cooper wrote:
> On 08/04/15 16:01, Wei Liu wrote:
> > Signed-off-by: Wei Liu
> > Cc: Ian Campbell
> > Cc: Ian Jackson
> > Cc: Charles Arnold
>
> The xenstat handle passed around already has an open xc_handle. That
> should be reused rather than
Wei Liu writes ("[PATCH 3/4] libxenstat: always free qmp_stats"):
> Originally qmp_stats is only freed in failure path and leaked in success
> path.
>
> Instead of wiring up the success path, rearrange the code a bit to
> always free qmp_stats before checking if info is NULL.
Acked-by: Ian Jackso
Andrew Cooper writes ("Re: [PATCH 4/4] libxenstat: qmp_read fix and cleanup"):
> On 08/04/15 16:01, Wei Liu wrote:
> > The second argument of poll(2) is the number of file descriptors. POLLIN
> > is defined as 1 so it happens to work.
...
> > @@ -311,6 +312,9 @@ static int qmp_read(int qfd, unsigne
A year or so ago I had done a near identical guide in spanish, to make
installing Xen more accessible to hispanic people. However, I figured out that
pretty much everyone which was interesed in it, didn't had the proper Hardware
to try Passthrough, and anyone who does, should have no issues unde
Wei Liu writes ("[PATCH 2/4] libxenstat: YAJL_GET_STRING may return NULL"):
> Passing NULL to strcmp can cause segmentation fault. Continue in that
> case.
>
> Signed-off-by: Wei Liu
> Cc: Ian Campbell
> Cc: Ian Jackson
> Cc: Charles Arnold
Acked-by: Ian Jackson
Wei Liu writes ("[PATCH] libxl: check return value of libxl_vcpu_setaffinity"):
> That function can fail.
...
> }
>
> -libxl_for_each_set_bit(j, v->vcpus)
> -libxl_set_vcpuaffinity(CTX, domid, j, NULL, &cpumap);
> +libxl_for_each_set_bit(j, v->vcpus) {
> +
On Wed, Apr 08, 2015 at 04:49:58PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH 3/4] libxenstat: always free qmp_stats"):
> > Originally qmp_stats is only freed in failure path and leaked in success
> > path.
> >
> > Instead of wiring up the success path, rearrange the code a bit to
> > alw
On Wed, Apr 8, 2015 at 4:33 PM, Julien Grall
wrote:
> Hi Tamas,
>
> One minor question.
>
> On 26/03/15 22:05, Tamas K Lengyel wrote:
> > +/*
> > + * We had a mem_access permission limiting the access, but the page
> type
> > + * could also be limiting, so we need to check that as wel
On Wed, Apr 08, 2015 at 04:55:26PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] libxl: check return value of
> libxl_vcpu_setaffinity"):
> > That function can fail.
> ...
> > }
> >
> > -libxl_for_each_set_bit(j, v->vcpus)
> > -libxl_set_vcpuaffinity(CTX, domi
Hi Iurii,
OOI, can you give more context why you need to relocate Xen over 4GB?
On 08/04/15 13:36, Iurii Konovalenko wrote:
> From: Iurii Konovalenko
>
> Primary CPU relocate Xen in over 4GB space and wake up seondary CPUs.
Typoes:
s/relocate/relocates
s/seondary/secondary
> Secondary CPUs r
That function can fail.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
Cc: Dario Faggioli
---
v2: add missing `}'.
---
tools/libxl/libxl_dom.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index a88db69.
1 - 100 of 151 matches
Mail list logo
