Re: [Xen-devel] [PATCH 9/9] qspinlock, x86, kvm: Implement KVM support for paravirt qspinlock

2015-03-20 Thread Raghavendra K T
On 03/20/2015 02:38 AM, Waiman Long wrote: On 03/19/2015 06:01 AM, Peter Zijlstra wrote: [...] You are probably right. The initial apply_paravirt() was done before the SMP boot. Subsequent ones were at kernel module load time. I put a counter in the __native_queue_spin_unlock() and it registere

[Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
Some change commited to staging earlier this week breaks ocaml bindings, as shown below. I think it was introduced between a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: NotImplementedError: Cannot handle KeyedUnion fields which are not Structs But now that I

[Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Wen Congyang
After commit 6d896e13, we should pass -errno on read failure. Signed-off-by: Wen Congyang --- tools/libxl/libxl_aoutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aoutils.c index 0d4c8af..b93f0e4 100644 --- a/tools/libxl/

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ross Lagerwall
On 03/20/2015 08:17 AM, Wen Congyang wrote: After commit 6d896e13, we should pass -errno on read failure. Signed-off-by: Wen Congyang --- tools/libxl/libxl_aoutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aoutils.c

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Wen Congyang
On 03/20/2015 04:25 PM, Ross Lagerwall wrote: > On 03/20/2015 08:17 AM, Wen Congyang wrote: >> After commit 6d896e13, we should pass -errno on read failure. >> >> Signed-off-by: Wen Congyang >> --- >> tools/libxl/libxl_aoutils.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> dif

Re: [Xen-devel] [PATCH RFC V2 4/5] xl: add pvusb commands

2015-03-20 Thread Chun Yan Liu
>>> On 3/7/2015 at 01:25 AM, in message , George Dunlap wrote: > On Mon, Jan 19, 2015 at 8:28 AM, Chunyan Liu wrote: > > Add pvusb commands. > > > > To attach a usb device to guest through pvusb, one could follow > > following example: > > > > #xl usb-ctrl-attach test_vm version=1 num_p

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:10 +0100, Olaf Hering wrote: > Some change commited to staging earlier this week breaks ocaml bindings, > as shown below. I think it was introduced between > a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: > > NotImplementedError: Cannot

Re: [Xen-devel] [xen-4.3-testing test] 36526: regressions - FAIL

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 23:31 +, xen.org wrote: > flight 36526 xen-4.3-testing real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/36526/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-i3865

[Xen-devel] [xen-4.3-testing test] 36551: regressions - trouble: blocked/fail/pass/preparing/queued/running

2015-03-20 Thread xen . org
flight 36551 xen-4.3-testing running [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36551/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 queued test-amd64-i386-xl-qemuu-ovmf-amd64

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-03-20 Thread Chun Yan Liu
>>> On 3/7/2015 at 12:50 AM, in message , George Dunlap wrote: > On Mon, Jan 19, 2015 at 8:28 AM, Chunyan Liu wrote: > > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h > > index 0a123f1..2e89244 100644 > > --- a/tools/libxl/libxl.h > > +++ b/tools/libxl/libxl.h > > > +int libxl_

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:04 +0800, Chen, Tiejun wrote: > Refactor again, > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 8599a6a..05c8916 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -409,6 +409,23 @@ static char *dm_spice_options(libxl__gc *gc

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 14:54 -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 19, 2015 at 04:47:58PM +, Ian Campbell wrote: > > On Wed, 2015-03-18 at 20:24 -0400, Konrad Rzeszutek Wilk wrote: > > > Instead of assuming everything is always OK. We stash > > > the gpfns value as an parameter. > >

Re: [Xen-devel] xe timer

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 00:41 +0100, HANNAS YAYA Issa wrote: > when I compile xen the timer run only once. I believe Xen timers are one-shot only. If you want a periodic timer then you will need to rearm it at the end of your handler. Check the plt_overflow_timer for an example of this sort of thin

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 11:50 -0600, Charles Arnold wrote: > > Whether the interface exists (even in buggy form) or not in older > > versions is important because if it doesn't exist then that would be a > > build failure, which we would want to avoid. > > Right. The tree feature was added in versio

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 13:20 -0600, Charles Arnold wrote: > >>> On 3/19/2015 at 12:09 PM, Anthony PERARD > >>> wrote: > > On Wed, Mar 18, 2015 at 04:12:26PM +, Ian Campbell wrote: > >> My second concern here is with the use of /var/run/xen/qmp-libxl-%i from > >> outside of libxl. I can't reme

Re: [Xen-devel] [xen-4.3-testing test] 36551: regressions - trouble: blocked/fail/pass/preparing/queued/running

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:37 +, xen.org wrote: > flight 36551 xen-4.3-testing running [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/36551/ > > Regressions :-( I killed this per <1426844180.21742.98.ca...@citrix.com>. ___ Xen-devel mail

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread Vitaly Chernooky
On Fri, Mar 20, 2015 at 6:04 AM, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > On Thu, Mar 19, 2015 at 03:10:49PM +0200, Vitaly Chernooky wrote: > > David, > > > > On Thu, Mar 19, 2015 at 3:00 PM, David Vrabel > > wrote: > > > > > On 19/03/15 12:10, Iurii Konovalenko wrot

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Chen, Tiejun
+case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: +LOG(ERROR, "unable to detect required gfx_passthru_kind"); In this case you will now have logged twice. I'd suggest logging only here and not in the helper. +default: And this case is subtly different to LIBXL_GF

Re: [Xen-devel] [PATCH v2] tools/libxl: close the logfile_w and null file descriptors in libxl__spawn_qdisk_backend() error path

2015-03-20 Thread Wei Liu
On Thu, Mar 19, 2015 at 05:51:15AM +, Koushik Chakravarty wrote: > Signed-off-by: Koushik Chakravarty > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu Acked-by: Wei Liu > --- > tools/libxl/libxl_dm.c |8 +++- > 1 file changed, 7 insertions(+), 1 delet

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread Vitaly Chernooky
On Fri, Mar 20, 2015 at 6:04 AM, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > On Thu, Mar 19, 2015 at 03:10:49PM +0200, Vitaly Chernooky wrote: > > David, > > > > On Thu, Mar 19, 2015 at 3:00 PM, David Vrabel > > wrote: > > > > > On 19/03/15 12:10, Iurii Konovalenko wrot

Re: [Xen-devel] [PATCH v3] libxl/libxl_qmp.c: fix error handling in qmp_open

2015-03-20 Thread Wei Liu
On Thu, Mar 19, 2015 at 12:55:12PM +, PRAMOD DEVENDRA wrote: > From: Pramod Devendra > > 1. Make sure sun_path does not overflow > 2. Close qmp_fd on error > 3. Use goto out for error handling > > Signed-off-by: Pramod Devendra > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell

Re: [Xen-devel] [PATCH] tools/libxl: close the logfile_w and null file descriptors in libxl__spawn_qdisk_backend() error path

2015-03-20 Thread Wei Liu
I think this patch is identical to the one I just acked. FWIW in the future there is no need to submit the same patch multiple times. We will ask you to resend if it is necessary. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote: > +if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) { > +if (libxl_gfx_passthru_kind_from_string(buf, > + > &b_info->u.hvm.gfx_passthru_kind)) { > +fprintf(stderr, > +"E

Re: [Xen-devel] [PATCH v2] xen-netback: making the bandwidth limiter runtime settable

2015-03-20 Thread Wei Liu
On Thu, Mar 19, 2015 at 11:05:42AM +0100, Imre Palik wrote: > From: "Palik, Imre" > > With the current netback, the bandwidth limiter's parameters are only > settable during vif setup time. This patch register a watch on them, and > thus makes them runtime changeable. > > When the watch fires,

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Chen, Tiejun
On 2015/3/20 18:11, Ian Campbell wrote: On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote: +if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) { +if (libxl_gfx_passthru_kind_from_string(buf, + &b_info->u.hvm.gfx_passthru_kind)) { +fprintf(stder

Re: [Xen-devel] [PATCH V4] Add flag to start info regarding virtual mapped p2m list

2015-03-20 Thread Ian Campbell
On Wed, 2015-03-18 at 16:28 +0100, Juergen Gross wrote: > Xen pv domains are using a domain private p2m list to convert guest pfns > to mfns. This p2m list has to be updated by the Xen tools during domain > restore and migration, as the mfns will most likely change. In order to > locate the p2m lis

Re: [Xen-devel] [PATCH v2 3/7] x86: detect and initialize Intel CAT feature

2015-03-20 Thread Dario Faggioli
On Thu, 2015-03-19 at 13:35 +, Jan Beulich wrote: > >>> On 19.03.15 at 13:44, wrote: > > On Thu, 2015-03-19 at 18:41 +0800, Chao Peng wrote: > > > >> diff --git a/docs/misc/xen-command-line.markdown > > b/docs/misc/xen-command-line.markdown > >> index 63871cb..768c55f 100644 > >> --- a/docs/

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread Vitaly Chernooky
So I have finished my investigation and suggest to discuss the simple attaches patch. With best regards, On Fri, Mar 20, 2015 at 12:08 PM, Vitaly Chernooky < vitalii.chernoo...@globallogic.com> wrote: > > > On Fri, Mar 20, 2015 at 6:04 AM, Marek Marczykowski-Górecki < > marma...@invisiblethingsl

Re: [Xen-devel] [RFC PATCH v2 00/29] libxl: Cancelling asynchronous operations

2015-03-20 Thread Euan Harris
On Tue, Mar 03, 2015 at 12:08:04PM +, Ian Campbell wrote: > > I wouldn't recommend testing it yet until I've at least smoke tested > > it to see that things still work if you don't cancel them. > > Would review of the series be useful and/or appreciated at this stage? > > Perhaps the first ha

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread Marek Marczykowski-Górecki
On Fri, Mar 20, 2015 at 12:08:48PM +0200, Vitaly Chernooky wrote: > On Fri, Mar 20, 2015 at 6:04 AM, Marek Marczykowski-Górecki < > marma...@invisiblethingslab.com> wrote: > > > On Thu, Mar 19, 2015 at 03:10:49PM +0200, Vitaly Chernooky wrote: > > > David, > > > > > > On Thu, Mar 19, 2015 at 3:00

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread David Vrabel
On 20/03/15 10:38, Vitaly Chernooky wrote: > So I have finished my investigation and suggest to discuss the simple > attaches patch. Looks ok to me. But this needs to go via the filesystem maintainers, Cc'ing Linus on it. You should explain the deadlock in more detail in the commit message and m

Re: [Xen-devel] [PATCH v4 21/33] xen/passthrough: Introduce iommu_construct

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 20:29, wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -187,6 +187,32 @@ void iommu_teardown(struct domain *d) > tasklet_schedule(&iommu_pt_cleanup_tasklet); > } > > +int iommu_construct(struct domain *d) > +{ > +int rc = 0

Re: [Xen-devel] [PATCH v4 26/33] xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 20:29, wrote: > @@ -344,6 +344,13 @@ int iommu_do_domctl( > ret = iommu_do_pci_domctl(domctl, d, u_domctl); > #endif > > +#ifdef HAS_DEVICE_TREE > +if ( ret != -ENODEV) > +return ret; > + > +ret = iommu_do_dt_domctl(domctl, d, u_domctl); > +#endif > + >

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 16:17 +0800, Wen Congyang wrote: > After commit 6d896e13, we should pass -errno on read failure. Hrm, this means that 6d896e13 was a more subtle interface change than I was expecting (I'd forgotten that errno wasn't negative in userspace). This means that someone needs to au

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: > Do the new callers actually need the number of bytes read/written or was > this just something which seemed like a good idea since it was in hand? > > If it isn't needed In fact, irrespective of the needs of the future callers lets go back

Re: [Xen-devel] [Qemu-devel] [PATCH v4 5/5] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

2015-03-20 Thread Stefan Berger
On 03/10/2015 08:14 AM, Quan Xu wrote: make sure QEMU machine class is initialized and QEMU has registered Xen stubdom vTPM driver when call tpm_init() Signed-off-by: Quan Xu --- vl.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index f6b

Re: [Xen-devel] [PATCH v4 11/33] xen/arm: route_irq_to_guest: Check validity of the IRQ

2015-03-20 Thread Stefano Stabellini
On Thu, 19 Mar 2015, Julien Grall wrote: > Currently Xen only supports SPIs routing for guest, add a function > is_assignable_irq to check if we can assign a given IRQ to the guest. > > Secondly, make sure the vIRQ is not the greater that the number of IRQs > configured in the vGIC and it's an SPI

Re: [Xen-devel] Deadlock in /proc/xen/xenbus watch+read on 3.17+ (maybe earlier)

2015-03-20 Thread Vitaly Chernooky
David, On Fri, Mar 20, 2015 at 12:46 PM, David Vrabel wrote: > On 20/03/15 10:38, Vitaly Chernooky wrote: >> So I have finished my investigation and suggest to discuss the simple >> attaches patch. > > Looks ok to me. But this needs to go via the filesystem maintainers, > Cc'ing Linus on it. Ju

[Xen-devel] [qemu-mainline test] 36522: regressions - FAIL

2015-03-20 Thread xen . org
flight 36522 qemu-mainline real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36522/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-win7-amd64 13 guest-localmigrate/x10 fail REGR. vs. 35893 test-amd64-amd64-xl

Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-20 Thread Stefan Berger
On 03/19/2015 08:56 AM, Ian Campbell wrote: On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: @@ -151,6 +152,8 @@ device_hardware_setup(void) esp_scsi_setup(); megasas_setup(); pvscsi_setup(); +if (runningOnXen()) +vtpm4hvm_setup(); Is there anything which is actua

Re: [Xen-devel] [PATCH v4 13/33] xen/arm: gic_route_irq_to_guest: Honor the priority given in parameter

2015-03-20 Thread Stefano Stabellini
On Thu, 19 Mar 2015, Julien Grall wrote: > The priority is already hardcoded in route_irq_to_guest and therefore > can't be controlled by the guest. > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > Changes in v4: > - Patch added > --- > xen/arch/arm/gic.c | 2

Re: [Xen-devel] [OSSTEST Nested PATCH 0/6] Introduction of netsted HVM test job

2015-03-20 Thread Pang, LongtaoX
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Friday, March 20, 2015 12:32 AM > To: Pang, LongtaoX > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; wei.l...@citrix.com; > Hu, Robert > Subject: Re: [OSSTEST Nested PATCH 0/6] Introduction of net

Re: [Xen-devel] [OSSTEST Nested PATCH 1/6] parsing grub which has 'submenu' primitive

2015-03-20 Thread Pang, LongtaoX
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Friday, March 20, 2015 12:17 AM > To: Pang, LongtaoX > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; wei.l...@citrix.com; > Hu, Robert > Subject: Re: [OSSTEST Nested PATCH 1/6] parsing grub which

Re: [Xen-devel] [PATCH v3] libxl/libxl_qmp.c: fix error handling in qmp_open

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:08 +, Wei Liu wrote: > On Thu, Mar 19, 2015 at 12:55:12PM +, PRAMOD DEVENDRA wrote: > > From: Pramod Devendra > > > > 1. Make sure sun_path does not overflow > > 2. Close qmp_fd on error > > 3. Use goto out for error handling > > > > Signed-off-by: Pramod Devendr

Re: [Xen-devel] [PATCH v2] tools/libxl: close the logfile_w and null file descriptors in libxl__spawn_qdisk_backend() error path

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:08 +, Wei Liu wrote: > On Thu, Mar 19, 2015 at 05:51:15AM +, Koushik Chakravarty wrote: > > Signed-off-by: Koushik Chakravarty > > CC: Ian Jackson > > CC: Stefano Stabellini > > CC: Ian Campbell > > CC: Wei Liu > > Acked-by: Wei Liu Applied. _

Re: [Xen-devel] [PATCH] docs: Mention a common pitfall in ballooning

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 17:09 +, George Dunlap wrote: > Several users have reported that their available free memory in the > guest when they used maxmem >> memory was much smaller than when > maxmem == memory. This is the unavoidable consequence of how > ballooning works, but it's not something

Re: [Xen-devel] [PATCH] tools/libxl: close the logfile_w and null file descriptors in libxl__spawn_qdisk_backend() error path

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:10 +, Wei Liu wrote: > I think this patch is identical to the one I just acked. Houshik, Having just applied this patch I now have no further patches from you in my queue, if there were others then please resend. Ian. ___

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-20 Thread Ian Campbell
On Wed, 2015-03-18 at 11:52 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: > > > >> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: > >> > >>> From: Ian Jackson > >>> > >>> Unlock the userdata before we actually call xc_doma

Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-20 Thread Stefan Berger
On 03/19/2015 09:35 PM, Xu, Quan wrote: -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Thursday, March 19, 2015 8:57 PM To: Xu, Quan Cc: ke...@koconnor.net; stef...@linux.vnet.ibm.com; xen-devel@lists.xen.org; qemu-de...@nongnu.org; stefano.stabell...@eu.ci

[Xen-devel] swap out guest physical page

2015-03-20 Thread HANNAS YAYA Issa
Hi Is it possible to swap out guest physical page from hypervisor in xen ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-20 Thread Pang, LongtaoX
Add xen-devel in mail loop. > -Original Message- > From: Pang, LongtaoX > Sent: Friday, March 20, 2015 7:59 PM > To: 'Ian Campbell' > Cc: ian.jack...@eu.citrix.com; wei.l...@citrix.com; Hu, Robert > Subject: RE: [OSSTEST Nested PATCH 2/6] Add and expose some testsupport > APIs > > > > >

Re: [Xen-devel] VM Migration on ARM

2015-03-20 Thread Vijay Kilari
Hi Andrew, On Wed, Mar 11, 2015 at 4:21 PM, Andrew Cooper wrote: > On 11/03/15 05:32, Vijay Kilari wrote: >> Hi Andrew, >> >> From Ian & Stefano, I came to know that you have introduced >> Migration framework v2 >> under below patch series >> >> http://marc.info/?l=xen-devel&m=141036915311145

Re: [Xen-devel] swap out guest physical page

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 13:09 +0100, HANNAS YAYA Issa wrote: > Hi > Is it possible to swap out guest physical page from hypervisor in xen The keyword you need in the context of Xen is "paging" not "swap", with that you should be able to find docs in the source tree and the wiki etc. Paging happens

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 12:09 +, Pang, LongtaoX wrote: > Add xen-devel in mail loop. Here is what I wrong in reply to the private version without noticing that it was private. On Fri, 2015-03-20 at 11:59 +, Pang, LongtaoX wrote: > > > > -Original Message- > > From: Ian Campbell [m

Re: [Xen-devel] xen/x86: unable to build with gcc5

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-13 at 12:58 +, Jan Beulich wrote: > >>> On 13.03.15 at 13:25, wrote: > > From: Ian Campbell > > Date: Fri, 13 Mar 2015 12:22:25 + > > Subject: [PATCH] xen: common: Use unbounded array for symbols_offset. > > > > Using a singleton array causes gcc5 to report: > > symbols.c

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-20 Thread Ian Campbell
On Wed, 2015-03-11 at 14:47 +, Julien Grall wrote: > Hi Ian, > > On 11/03/2015 14:11, Ian Campbell wrote: > > This allows for early-printk to be specified (for existing UARTS at > > least) without the need to edit Rules.mk. > > > > The existing shortcuts are retained, but in a much more compac

Re: [Xen-devel] [PATCH] xen/passthrough: Support a single iommu_domain(context bank) per xen domain per SMMU

2015-03-20 Thread Julien Grall
Hello Robert, Thank you for the patch. The commit title is too long (over 80 characters). On 19/03/2015 18:25, Robbie VanVossen wrote: If multiple devices are being passed through to the same domain and they share a single SMMU, then they only require a single iommu_domain. In arm_smmu_assign

[Xen-devel] [Patch V2 0/2] xen: fix regressions regarding memory hotplug in pv domains

2015-03-20 Thread Juergen Gross
Fix some regressions introduced in 3.16 and 3.19. Changes in V2: - use "range" in Kconfig instead of BUILD_BUG_ON_MSG() as suggested by Boris Ostrovsky and Paul Bolle - simplify ifdeffery regarding P2M_LIMIT in patch 1 as requested by David Vrabel - changed test for failure of set_phys_to_machin

[Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-20 Thread Juergen Gross
Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear virtual mapped sparse p2m list") introduced a regression regarding to memory hotplug for a pv-domain: as the virtual space for the p2m list is allocated for the to be expected memory size of the domain only, hotplugged memory a

[Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-20 Thread Juergen Gross
Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set regions above the end of RAM as 1:1") introduced a regression. To be able to add memory pages which were added via memory hotplug to a pv domain, the pages must be "invalid" instead of "identity" in the p2m list before they can be adde

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-20 Thread Pang, LongtaoX
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Friday, March 20, 2015 8:20 PM > To: Pang, LongtaoX > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; wei.l...@citrix.com; > Hu, Robert > Subject: Re: [OSSTEST Nested PATCH 2/6] Add and expose some

Re: [Xen-devel] [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote: [...] > * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid > type > (core, socket, node). But not for distance: > @@ -1375,7 +1360,7 @@ static PyObject *pyxc_numainfo(XcObject *self) > for ( j = 0; j <=

Re: [Xen-devel] [PATCH v5 4/8] sysctl: Make XEN_SYSCTL_numainfo a little more efficient

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: > A number of changes to XEN_SYSCTL_numainfo interface: > > * Make sysctl NUMA topology query use fewer copies by combining some > fields into a single structure and copying distances for each node > in a single copy. > * NULL meminfo a

Re: [Xen-devel] [RFC PATCH v2 03/22] xen/arm: Add bitmap_find_next_zero_area helper function

2015-03-20 Thread Julien Grall
Hi Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K bitmap_find_next_zero_area helper function will be used by physical ITS driver imported from linux Signed-off-by: Vijaya Kumar K --- xen/arch/arm/arm64/lib/find_next_bit.c | 39 +

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 12:59 +, Pang, LongtaoX wrote: > > > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: Friday, March 20, 2015 8:20 PM > > To: Pang, LongtaoX > > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; wei.l...@citrix.com; > >

Re: [Xen-devel] [RFC PATCH v2 00/22] xen/arm: Add ITS support

2015-03-20 Thread Julien Grall
Hi Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add ITS support for arm. Following major features are supported - GICv3 ITS support for arm64 platform - Supports multi ITS node - LPI descriptors are allocated on-demand - Only ITS Dom0 is supported Tes

Re: [Xen-devel] [Patch V2 1/2] xen: prepare p2m list for memory hotplug

2015-03-20 Thread Daniel Kiper
On Fri, Mar 20, 2015 at 01:55:38PM +0100, Juergen Gross wrote: > Commit 054954eb051f35e74b75a566a96fe756015352c8 ("xen: switch to linear > virtual mapped sparse p2m list") introduced a regression regarding to > memory hotplug for a pv-domain: as the virtual space for the p2m list > is allocated for

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 08:55 AM, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set regions above the end of RAM as 1:1") introduced a regression. To be able to add memory pages which were added via memory hotplug to a pv domain, the pages must be "invalid" instead of "id

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-20 Thread Daniel Kiper
On Fri, Mar 20, 2015 at 01:55:39PM +0100, Juergen Gross wrote: > Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set > regions above the end of RAM as 1:1") introduced a regression. > > To be able to add memory pages which were added via memory hotplug to > a pv domain, the pages must be

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Konrad Rzeszutek Wilk
On Thu, Mar 19, 2015 at 05:54:03PM -0400, Boris Ostrovsky wrote: > xc_numainfo() is not expected to be used on a hot path and therefore > hypercall buffer management can be pushed into libxc. This will simplify > life for callers. > > Also update error logging macros. > > Signed-off-by: Boris Ost

Re: [Xen-devel] [PATCH v5 6/8] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: > +if (cputopo) { > +if ((ret = xc_hypercall_bounce_pre(xch, cputopo))) I think this guy will tolerate a NULL here (and on post), so I think/hope you can get away without this conditional stuff. Can you give it a go please. The

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Ian Campbell
On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: > diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c > index 411128e..607ae61 100644 > --- a/tools/libxc/xc_misc.c > +++ b/tools/libxc/xc_misc.c > @@ -209,22 +209,49 @@ out: > return ret; > } > > -int xc_numainfo(xc_interface

Re: [Xen-devel] [PATCH] xen/passthrough: Support a single iommu_domain(context bank) per xen domain per SMMU

2015-03-20 Thread Robert VanVossen
On 3/20/2015 8:39 AM, Julien Grall wrote: > Hello Robert, > > Thank you for the patch. > No problem. :) >> xen/drivers/passthrough/arm/smmu.c | 113 >> >> 1 file changed, 88 insertions(+), 25 deletions(-) >> >> diff --git a/xen/drivers/passthrough/arm

Re: [Xen-devel] [PATCH v5 2/8] pci: Stash device's PXM information in struct pci_dev

2015-03-20 Thread Konrad Rzeszutek Wilk
On Thu, Mar 19, 2015 at 05:53:58PM -0400, Boris Ostrovsky wrote: > If ACPI provides PXM data for IO devices then dom0 will pass it to > hypervisor during PHYSDEVOP_pci_device_add call. This information, > however, is currently ignored. > > We will store this information (in the form of nodeID) in

Re: [Xen-devel] [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 09:25 AM, Ian Campbell wrote: On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote: [...] * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid type (core, socket, node). But not for distance: @@ -1375,7 +1360,7 @@ static PyObject *pyxc_numainfo(XcObj

Re: [Xen-devel] [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:00 -0400, Boris Ostrovsky wrote: > On 03/20/2015 09:25 AM, Ian Campbell wrote: > > On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote: > > [...] > >> * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid > >> type > >>(core, socket, node). >

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 09:49 AM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 19, 2015 at 05:54:03PM -0400, Boris Ostrovsky wrote: xc_numainfo() is not expected to be used on a hot path and therefore hypercall buffer management can be pushed into libxc. This will simplify life for callers. Also update error

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:10 -0400, Boris Ostrovsky wrote: > I actually think it's the other way around: when I made the first change > in 4/8 I added spaces, which this file's style generally doesn't use. > > Which, conveniently, is different from the style used by xc_misc.c Right, libxc uses th

Re: [Xen-devel] [PATCH v5 5/8] sysctl: Add sysctl interface for querying PCI topology

2015-03-20 Thread Konrad Rzeszutek Wilk
On Thu, Mar 19, 2015 at 05:54:01PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > > Changes in v5: > * Increment ti->first_dev in the loop > * Make node in xen_sysctl_pcitopoinfo a uint32 > * Move sysctl to follow hearder file's order >

Re: [Xen-devel] [PATCH v5 6/8] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 09:54 AM, Ian Campbell wrote: On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: +if (cputopo) { +if ((ret = xc_hypercall_bounce_pre(xch, cputopo))) I think this guy will tolerate a NULL here (and on post), so I think/hope you can get away without this condition

Re: [Xen-devel] [PATCH v5 1/8] numa: __node_distance() should return u8

2015-03-20 Thread Konrad Rzeszutek Wilk
On Thu, Mar 19, 2015 at 05:53:57PM -0400, Boris Ostrovsky wrote: > SLIT values are byte-sized and some of them (0-9 and 255) have > special meaning. Adjust __node_distance() to reflect this and > modify scrub_heap_pages() and do_sysctl() to deal with > __node_distance() returning an invalid SLIT en

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-20 Thread Juergen Gross
On 03/20/2015 02:46 PM, Daniel Kiper wrote: On Fri, Mar 20, 2015 at 01:55:39PM +0100, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set regions above the end of RAM as 1:1") introduced a regression. To be able to add memory pages which were added via memory hot

Re: [Xen-devel] [PATCH v5 6/8] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:24 -0400, Boris Ostrovsky wrote: > On 03/20/2015 09:54 AM, Ian Campbell wrote: > > On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: > >> +if (cputopo) { > >> +if ((ret = xc_hypercall_bounce_pre(xch, cputopo))) > > I think this guy will tolerate a NULL h

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 09:56 AM, Ian Campbell wrote: On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c index 411128e..607ae61 100644 --- a/tools/libxc/xc_misc.c +++ b/tools/libxc/xc_misc.c @@ -209,22 +209,49 @@ out: return ret; }

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Konrad Rzeszutek Wilk
On Fri, Mar 20, 2015 at 09:48:08AM +, Ian Campbell wrote: > On Thu, 2015-03-19 at 14:54 -0400, Konrad Rzeszutek Wilk wrote: > > On Thu, Mar 19, 2015 at 04:47:58PM +, Ian Campbell wrote: > > > On Wed, 2015-03-18 at 20:24 -0400, Konrad Rzeszutek Wilk wrote: > > > > Instead of assuming everyth

Re: [Xen-devel] [Patch V2 2/2] xen: before ballooning hotplugged memory, set frames to invalid

2015-03-20 Thread Juergen Gross
On 03/20/2015 02:44 PM, Boris Ostrovsky wrote: On 03/20/2015 08:55 AM, Juergen Gross wrote: Commit 25b884a83d487fd62c3de7ac1ab5549979188482 ("x86/xen: set regions above the end of RAM as 1:1") introduced a regression. To be able to add memory pages which were added via memory hotplug to a pv do

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:31 -0400, Boris Ostrovsky wrote: > On 03/20/2015 09:56 AM, Ian Campbell wrote: > > On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: > >> diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c > >> index 411128e..607ae61 100644 > >> --- a/tools/libxc/xc_misc.c >

[Xen-devel] [PATCH v3 0/2] x86: bitops adjustments

2015-03-20 Thread Jan Beulich
1: simplify non-atomic bitops 2: make atomic bitops consistent with non-atomic ones Signed-off-by: Jan Beulich --- v3: Replace ADDR uses by *(int *)addr to not re-gain the volatile qualifier. New patch 2. ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Konrad Rzeszutek Wilk
On Fri, Mar 20, 2015 at 10:34:34AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 20, 2015 at 09:48:08AM +, Ian Campbell wrote: > > On Thu, 2015-03-19 at 14:54 -0400, Konrad Rzeszutek Wilk wrote: > > > On Thu, Mar 19, 2015 at 04:47:58PM +, Ian Campbell wrote: > > > > On Wed, 2015-03-18 a

[Xen-devel] [PATCH v3 2/2] x86: make atomic bitops consistent with non‑atomic ones

2015-03-20 Thread Jan Beulich
- use int instead of long pointers (matching the 'l' suffix on insns) - use "+m" instead or a pair of "=m" and "m" in asm() constraints Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/bitops.h +++ b/xen/include/asm-x86/bitops.h @@ -17,8 +17,8 @@ * modified. */ -#define ADDR (*(volati

[Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-20 Thread Jan Beulich
- being non-atomic, their pointer arguments shouldn't be volatile- qualified - their (half fake) memory operands can be a single "+m" instead of being both an output and an input Signed-off-by: Jan Beulich --- v3: Replace ADDR uses by *(int *)addr to not re-gain the volatile qualifier. v2

[Xen-devel] [PATCH] x86: properly parenthesize {read, write}_atomic()

2015-03-20 Thread Jan Beulich
... at once eliminating some redundancy from the read variant (the cast to the destination type can be done once outside the switch). Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/atomic.h +++ b/xen/include/asm-x86/atomic.h @@ -31,24 +31,25 @@ build_write_atomic(write_u64_atomic, "q" voi

[Xen-devel] [ovmf test] 36525: tolerable FAIL - PUSHED

2015-03-20 Thread xen . org
flight 36525 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36525/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-pair17 guest-migrate/src_host/dst_host fail like 36087 Tests which did not succeed, but are

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:49 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 20, 2015 at 10:34:34AM -0400, Konrad Rzeszutek Wilk wrote: > > On Fri, Mar 20, 2015 at 09:48:08AM +, Ian Campbell wrote: > > > On Thu, 2015-03-19 at 14:54 -0400, Konrad Rzeszutek Wilk wrote: > > > > On Thu, Mar 19, 20

Re: [Xen-devel] [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 10:46 AM, Ian Campbell wrote: On Fri, 2015-03-20 at 10:31 -0400, Boris Ostrovsky wrote: On 03/20/2015 09:56 AM, Ian Campbell wrote: On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote: diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c index 411128e..607ae61 100644 -

[Xen-devel] [PATCH 0/2] printk adjustments

2015-03-20 Thread Jan Beulich
1: introduce gprintk() 2: make {,g}dprintk() a no-op in non-debug builds Signed-off-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC PATCH v2 06/22] xen/arm: its: Port ITS driver to xen

2015-03-20 Thread Julien Grall
Hello Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: static LIST_HEAD(its_nodes); static DEFINE_SPINLOCK(its_lock); -static struct device_node *gic_root_node; -static struct rdists *gic_rdists; +static struct dt_device_node *gic_root_node; +static struct rdist_prop *gic_rdists;

[Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-20 Thread Jan Beulich
... and convert several gdprintk()-s to it, as the next patch will make them no-ops in non-debug builds. Note that as a non-debug facility this does not print file name and line number of the origin, to people are expected to use meaningful and easily distinguishable messages (i.e. just like with

[Xen-devel] [PATCH 2/2] make {,g}dprintk() a no‑op in non‑debug builds

2015-03-20 Thread Jan Beulich
As discussed before, code absolutely wanting to get something into the log should use {,g}printk() instead. Signed-off-by: Jan Beulich --- a/xen/include/xen/config.h +++ b/xen/include/xen/config.h @@ -72,16 +72,6 @@ #define MB(_mb) (_AC(_mb, UL) << 20) #define GB(_gb) (_AC(_gb, UL) <<

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-20 Thread Jim Fehlig
Ian Campbell wrote: > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c >> index b6541d4..b43db1a 100644 >> --- a/tools/libxl/libxl.c >> +++ b/tools/libxl/libxl.c >> @@ -1481,6 +1481,10 @@ static void domain_destroy_callback(libxl__e

  1   2   3   >