Re: [Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-28 Thread Wei Liu
On Tue, Jun 27, 2017 at 12:31:20PM -0600, Jan Beulich wrote: > >>> Wei Liu 06/26/17 6:29 PM >>> > >Since ARM doesn't need do_nmi_op, move the hypercall handler from > >common/kernel.c to pv/callback.c. > > There are two handlers you actually move, and while their neither large nor > likely to cha

Re: [Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-27 Thread Stefano Stabellini
On Mon, 26 Jun 2017, Wei Liu wrote: > Since ARM doesn't need do_nmi_op, move the hypercall handler from > common/kernel.c to pv/callback.c. Drop the stubs in ARM. Delete the > common and ARM nmi.h and adjust header inclusions in various files. > > Signed-off-by: Wei Liu Acked-by: Stefano Stabell

Re: [Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-27 Thread Andrew Cooper
On 27/06/17 19:31, Jan Beulich wrote: Wei Liu 06/26/17 6:29 PM >>> >> Since ARM doesn't need do_nmi_op, move the hypercall handler from >> common/kernel.c to pv/callback.c. > There are two handlers you actually move, and while their neither large nor > likely to change, I still somewhat disli

Re: [Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-27 Thread Jan Beulich
>>> Wei Liu 06/26/17 6:29 PM >>> >Since ARM doesn't need do_nmi_op, move the hypercall handler from >common/kernel.c to pv/callback.c. There are two handlers you actually move, and while their neither large nor likely to change, I still somewhat dislike the code duplication you introduce. But I g

Re: [Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-27 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Since ARM doesn't need do_nmi_op, move the hypercall handler from > common/kernel.c to pv/callback.c. Drop the stubs in ARM. Delete the > common and ARM nmi.h and adjust header inclusions in various files. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper

[Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-26 Thread Wei Liu
Since ARM doesn't need do_nmi_op, move the hypercall handler from common/kernel.c to pv/callback.c. Drop the stubs in ARM. Delete the common and ARM nmi.h and adjust header inclusions in various files. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Juli