On 27/06/17 19:31, Jan Beulich wrote: >>>> Wei Liu <wei.l...@citrix.com> 06/26/17 6:29 PM >>> >> Since ARM doesn't need do_nmi_op, move the hypercall handler from >> common/kernel.c to pv/callback.c. > There are two handlers you actually move, and while their neither large nor > likely to change, I still somewhat dislike the code duplication you introduce. > But I guess not enough to put under question the R-b you've already got > from Andrew.
If its not obvious already, I am taking a strong stance against any code obfuscation, because obfuscation the source code is entirely detrimental to the project. Macros such as DO() fall into the obfuscation category, so I will support all changes which reduce/remove its usage. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
