On Tue, Jun 27, 2017 at 12:31:20PM -0600, Jan Beulich wrote: > >>> Wei Liu <wei.l...@citrix.com> 06/26/17 6:29 PM >>> > >Since ARM doesn't need do_nmi_op, move the hypercall handler from > >common/kernel.c to pv/callback.c. > > There are two handlers you actually move, and while their neither large nor > likely to change, I still somewhat dislike the code duplication you introduce. > But I guess not enough to put under question the R-b you've already got > from Andrew. >
I'm with Andrew here. I deliberately unrolled all macros because the resulting code is cleaner. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
