On 19/11/15 06:24, Chun Yan Liu wrote:
>
>
On 11/19/2015 at 09:33 AM, in message
> <564d9761026600085...@relay2.provo.novell.com>, "Chun Yan Liu"
> wrote:
>
>>
> On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>,
> Olaf
>> Hering wrote:
>>> On Tue
>>> On 11/19/2015 at 09:33 AM, in message
<564d9761026600085...@relay2.provo.novell.com>, "Chun Yan Liu"
wrote:
>
On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>,
Olaf
> Hering wrote:
> > On Tue, Nov 17, Chun Yan Liu wrote:
> >
> > > I think l
>>> On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>,
>>> Olaf
Hering wrote:
> On Tue, Nov 17, Chun Yan Liu wrote:
>
> > I think libxl_device_usb doesn't need to be changed into
> libxl_device_usbdev?
>
> In case of vscsi the struct and functions names are odd.
On Wed, Nov 18, Ian Campbell wrote:
> I'd been hoping that someone involved ion this would generate a patch
> adding a template for this controller+devices model to libxl.h, I've not
> seen anything since George's original RFC[0] "libxl: Introduce a template
> for devices with a controller".
Its
On Wed, 2015-11-18 at 10:44 +0100, Olaf Hering wrote:
> On Tue, Nov 17, Chun Yan Liu wrote:
>
> > I think libxl_device_usb doesn't need to be changed into
> > libxl_device_usbdev?
>
> In case of vscsi the struct and functions names are odd. It was not
> obvious which one belongs to a ctrl and wh
On Tue, Nov 17, Chun Yan Liu wrote:
> I think libxl_device_usb doesn't need to be changed into libxl_device_usbdev?
In case of vscsi the struct and functions names are odd. It was not
obvious which one belongs to a ctrl and which one belongs to a device.
In the meantime I have changed everything
>>> On 11/16/2015 at 06:01 PM, in message <5649a988.7010...@citrix.com>, George
Dunlap wrote:
> On 13/11/15 11:19, Olaf Hering wrote:
> > On Wed, Oct 21, Chunyan Liu wrote:
> >
> >> Add pvusb APIs, including:
> >
> >> @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [
>
>>> On 11/17/2015 at 02:06 AM, in message
<22090.6954.35639.703...@mariner.uk.xensource.com>, Ian Jackson
wrote:
> Thanks for your attention to my earlier mail. I'll delete all the
> comments where we agree :-).
>
> > > > > > +/* bind/unbind usb device interface */
> > > > > > +static i
Thanks for your attention to my earlier mail. I'll delete all the
comments where we agree :-).
> > > > > +/* bind/unbind usb device interface */
> > > > > +static int unbind_usb_intf(libxl__gc *gc, char *intf, char
> > > > > **drvpath)
> > > > > +{
> > ...
> > > > > +dp = libxl__z
On 13/11/15 11:19, Olaf Hering wrote:
> On Wed, Oct 21, Chunyan Liu wrote:
>
>> Add pvusb APIs, including:
>
>> @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [
>> ("pcidevs", Array(libxl_device_pci, "num_pcidevs")),
>> ("rdms", Array(libxl_device_rdm, "num_rdms")),
>
On Wed, Oct 21, Chunyan Liu wrote:
> Add pvusb APIs, including:
> @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [
> ("pcidevs", Array(libxl_device_pci, "num_pcidevs")),
> ("rdms", Array(libxl_device_rdm, "num_rdms")),
> ("dtdevs", Array(libxl_device_dtdev, "num_
>>> On 11/13/2015 at 01:27 AM, in message
, George
Dunlap wrote:
> On Wed, Oct 21, 2015 at 10:08 AM, Chunyan Liu wrote:
> > +static int
> > +get_assigned_devices(libxl__gc *gc,
> > + libxl_device_usb **list, int *num)
> > +{
> > +char **domlist;
> > +unsigned
>>> On 11/12/2015 at 07:32 PM, in message <20151112113200.ga...@aepfle.de>, Olaf
Hering wrote:
> On Wed, Oct 21, Chunyan Liu wrote:
>
> > Add pvusb APIs, including:
>
> Some comments below.
>
> After a quick look I miss the proposed ctrl/device separation for pvscsi
> (what handles "s
>>> On 11/13/2015 at 01:00 AM, in message
<22084.50631.506663.212...@mariner.uk.xensource.com>, Ian Jackson
wrote:
> Chun Yan Liu writes ("Re: [PATCH V8 3/7] libxl: add pvusb API"):
> > On 11/10/2015 at 02:11 AM, in message
> > <22080.57829.461049.37...@mariner.uk.xensource.com>, Ian Jackson
On Wed, Oct 21, 2015 at 10:08 AM, Chunyan Liu wrote:
> +static int
> +get_assigned_devices(libxl__gc *gc,
> + libxl_device_usb **list, int *num)
> +{
> +char **domlist;
> +unsigned int nd = 0, i, j, k;
> +int rc;
> +
> +*list = NULL;
> +*num = 0;
> +
> +
Chun Yan Liu writes ("Re: [PATCH V8 3/7] libxl: add pvusb API"):
> On 11/10/2015 at 02:11 AM, in message
> <22080.57829.461049.37...@mariner.uk.xensource.com>, Ian Jackson
> wrote:
> > Chunyan Liu writes ("[PATCH V8 3/7] libxl: add pvusb API"):
> > > +void libxl__device_usbctrl_add(libxl__egc *e
On Wed, Oct 21, Chunyan Liu wrote:
> Add pvusb APIs, including:
Some comments below.
After a quick look I miss the proposed ctrl/device separation for pvscsi
(what handles "state" changes?). But, I have to read all the other
dozen+ threads about that topic first.
> +flexarray_append_pair(b
>>> On 11/11/2015 at 02:11 AM, in message
<22082.13115.276320.572...@mariner.uk.xensource.com>, Ian Jackson
wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API"):
> > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote:
>
>>> On 11/11/2015 at 01:57 AM, in message
, George
Dunlap wrote:
> On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote:
> >> > +void libxl__device_usbctrl_add(libxl__egc *egc, uint32_t domid,
> >> > + libxl_device_usbctrl *usbctrl,
> >> > +
George Dunlap writes ("Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API"):
> On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote:
> > Which cast? Here, we want to get a uint_8 value, but buf is a string,
> > we need to do atoi.
>
> atoi() isn't a cast, it
On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote:
>> > +void libxl__device_usbctrl_add(libxl__egc *egc, uint32_t domid,
>> > + libxl_device_usbctrl *usbctrl,
>> > + libxl__ao_device *aodev)
>> > +{
>>
>> Thanks for adjusting the error-
>>> On 11/10/2015 at 02:11 AM, in message
<22080.57829.461049.37...@mariner.uk.xensource.com>, Ian Jackson
wrote:
> Chunyan Liu writes ("[PATCH V8 3/7] libxl: add pvusb API"):
> > Add pvusb APIs, including:
> > - attach/detach (create/destroy) virtual usb controller.
> > - attach/detach us
Chunyan Liu writes ("[PATCH V8 3/7] libxl: add pvusb API"):
> Add pvusb APIs, including:
> - attach/detach (create/destroy) virtual usb controller.
> - attach/detach usb device
> - list usb controller and usb devices
> - some other helper functions
Thanks for this.
I have reviewed it in deta
On Wed, Nov 4, 2015 at 6:31 AM, Chun Yan Liu wrote:
> Ian & George, any comments?
Hey Chunyan,
I did actually spend a chunk of time looking at this last week.
Looking at the diff-of-diffs, it looks like you've addressed
everything I asked you to address. I still want to take a longer look
at it
Ian & George, any comments?
>>> On 10/21/2015 at 05:08 PM, in message
<1445418510-19614-4-git-send-email-cy...@suse.com>, Chunyan Liu
wrote:
> Add pvusb APIs, including:
> - attach/detach (create/destroy) virtual usb controller.
> - attach/detach usb device
> - list usb controller and usb
On 10/21/2015 11:08 AM, Chunyan Liu wrote:
Add pvusb APIs, including:
- attach/detach (create/destroy) virtual usb controller.
- attach/detach usb device
- list usb controller and usb devices
- some other helper functions
Signed-off-by: Chunyan Liu
Signed-off-by: Simon Cao
---
changes
Add pvusb APIs, including:
- attach/detach (create/destroy) virtual usb controller.
- attach/detach usb device
- list usb controller and usb devices
- some other helper functions
Signed-off-by: Chunyan Liu
Signed-off-by: Simon Cao
---
changes:
- update COMPARE_USB to compare ctrl and port
27 matches
Mail list logo
