>>> On 11/19/2015 at 09:33 AM, in message <564d97610200006600085...@relay2.provo.novell.com>, "Chun Yan Liu" <cy...@suse.com> wrote:
> >>>> On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>, >>>> Olaf > Hering <o...@aepfle.de> wrote: > > On Tue, Nov 17, Chun Yan Liu wrote: > > > > > I think libxl_device_usb doesn't need to be changed into > > libxl_device_usbdev? George & Olaf, About the naming, can we get to a decision? e.g. * usb controller and everything related, using "usbctrl" * usb device and everything related, using "usbdev" (?) Currently in pvusb, almost everywhere referring to a usb device, we use "usb". Like: libxl_device_usb, libxl_device_usb_add/remove, etc. If we decide, I can update all together. - Chunyan > > > > In case of vscsi the struct and functions names are odd. It was not > > obvious which one belongs to a ctrl and which one belongs to a device. > > In the meantime I have changed everything related to a scsi host, it > > contains now 'vscsictrl'. The names related to devices will follow. > > > > I suggest to do apply the same also to usb and make it clear what > > belongs to a ctrl and what to a device. Havent checked your patch what > > places that actually would be. > > Currently in pvusb patches, all places using 'usbctrl' means usb controller, > 'usb' means usb device. > > - Chunyan > > > > > Olaf > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
