On Wed, Oct 21, Chunyan Liu wrote:
> Add pvusb APIs, including:
Some comments below.
After a quick look I miss the proposed ctrl/device separation for pvscsi
(what handles "state" changes?). But, I have to read all the other
dozen+ threads about that topic first.
> + flexarray_append_pair(back, "state", "1");
4.6+ has macros for "state" values, like
flexarray_append_pair(back, "state", GCSPRINTF("%d", XenbusStateInitialising));
> + flexarray_append_pair(front, "state", "1");
4.6+ has macros for "state" values.
> + LOG(DEBUG, "Adding new usb device to xenstore");
Which one? Perhaps print also details.
> + LOG(DEBUG, "Removing USB device from xenstore");
Which one? Perhaps print also details.
> + /* check if the USB interface is already bound to "usbbcak" */
Typo.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
