Re: [Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-03 Thread Jan Beulich
>>> On 02.05.17 at 19:04, wrote: > On 02/05/17 16:15, Jan Beulich wrote: >> get_page() logs a message when it fails (dom_cow is never dying or >> paging_mode_external()), so better avoid the call when it's pointless >> to do anyway. >> >> Signed-off-by: Jan Beulich > > The other option would be

Re: [Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-03 Thread Jan Beulich
>>> On 02.05.17 at 18:54, wrote: > On 02/05/17 16:31, Jan Beulich wrote: > On 02.05.17 at 17:15, wrote: >>> get_page() logs a message when it fails (dom_cow is never dying or >>> paging_mode_external()), so better avoid the call when it's pointless >>> to do anyway. >>> >>> Signed-off-by: Jan

Re: [Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-02 Thread George Dunlap
On 02/05/17 16:15, Jan Beulich wrote: > get_page() logs a message when it fails (dom_cow is never dying or > paging_mode_external()), so better avoid the call when it's pointless > to do anyway. > > Signed-off-by: Jan Beulich The other option would be to add "domain == dom_cow" as a condition fo

Re: [Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-02 Thread George Dunlap
On 02/05/17 16:31, Jan Beulich wrote: On 02.05.17 at 17:15, wrote: >> get_page() logs a message when it fails (dom_cow is never dying or >> paging_mode_external()), so better avoid the call when it's pointless >> to do anyway. >> >> Signed-off-by: Jan Beulich >> --- >> Possibly we could be e

Re: [Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-02 Thread Jan Beulich
>>> On 02.05.17 at 17:15, wrote: > get_page() logs a message when it fails (dom_cow is never dying or > paging_mode_external()), so better avoid the call when it's pointless > to do anyway. > > Signed-off-by: Jan Beulich > --- > Possibly we could be even more rigid and bail right away if ->is_dy

[Xen-devel] [PATCH] x86/mm: silence a pointless warning

2017-05-02 Thread Jan Beulich
get_page() logs a message when it fails (dom_cow is never dying or paging_mode_external()), so better avoid the call when it's pointless to do anyway. Signed-off-by: Jan Beulich --- Possibly we could be even more rigid and bail right away if ->is_dying is set. --- a/xen/arch/x86/mm/p2m.c +++ b/x