get_page() logs a message when it fails (dom_cow is never dying or
paging_mode_external()), so better avoid the call when it's pointless
to do anyway.
Signed-off-by: Jan Beulich <jbeul...@suse.com>
---
Possibly we could be even more rigid and bail right away if ->is_dying
is set.
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -501,9 +501,9 @@ struct page_info *get_page_from_gfn_p2m(
if ( fdom == NULL )
page = NULL;
}
- else if ( !get_page(page, d)
+ else if ( !get_page(page, d) &&
/* Page could be shared */
- && !get_page(page, dom_cow) )
+ (!p2m_is_shared(*t) || !get_page(page, dom_cow)) )
page = NULL;
}
p2m_read_unlock(p2m);
x86/mm: silence a pointless warning
get_page() logs a message when it fails (dom_cow is never dying or
paging_mode_external()), so better avoid the call when it's pointless
to do anyway.
Signed-off-by: Jan Beulich <jbeul...@suse.com>
---
Possibly we could be even more rigid and bail right away if ->is_dying
is set.
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -501,9 +501,9 @@ struct page_info *get_page_from_gfn_p2m(
if ( fdom == NULL )
page = NULL;
}
- else if ( !get_page(page, d)
+ else if ( !get_page(page, d) &&
/* Page could be shared */
- && !get_page(page, dom_cow) )
+ (!p2m_is_shared(*t) || !get_page(page, dom_cow)) )
page = NULL;
}
p2m_read_unlock(p2m);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
