>>> On 02.05.17 at 19:04, <george.dun...@citrix.com> wrote: > On 02/05/17 16:15, Jan Beulich wrote: >> get_page() logs a message when it fails (dom_cow is never dying or >> paging_mode_external()), so better avoid the call when it's pointless >> to do anyway. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > The other option would be to add "domain == dom_cow" as a condition for > which get_page() doesn't report an error.
That would imo be undesirable namely for the currently one case where get_page(..., dom_cow) is being used from mem_sharing.c. > But on the whole I think this is probably the better option: > > Acked-by: George Dunlap <george.dun...@citrix.com> Thanks. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
