Re: [Xen-devel] [PATCH] pygrub: remove isconfig option

2016-03-22 Thread Boris Ostrovsky
On 03/22/2016 04:46 PM, Firas Azar wrote: Andrew: Currently if we use pygrub --isconfig , there is a good chance that this command could fail with an "out of memory" error. This can happen especially if the image file in question is at least a few gigabytes in size and the dom0_mem setting is

Re: [Xen-devel] [PATCH] pygrub: remove isconfig option

2016-03-22 Thread Firas Azar
Andrew: Currently if we use pygrub --isconfig , there is a good chance that this command could fail with an "out of memory" error. This can happen especially if the image file in question is at least a few gigabytes in size and the dom0_mem setting is relatively small. So even if any software

Re: [Xen-devel] [PATCH] pygrub: remove isconfig option

2016-03-22 Thread Andrew Cooper
On 22/03/16 20:06, Firas Azar wrote: > The pygrub command option "isconfig" is broken and obsolete. This patch > removes it since the alternate options "-l -n" provide the same functionality. Broken how? Are you sure that no existing software is using that option? ~Andrew _

[Xen-devel] [PATCH] pygrub: remove isconfig option

2016-03-22 Thread Firas Azar
The pygrub command option "isconfig" is broken and obsolete. This patch removes it since the alternate options "-l -n" provide the same functionality. Signed-off-by: Firas Azar --- tools/pygrub/src/pygrub | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a