On 03/22/2016 04:46 PM, Firas Azar wrote:
Andrew:
Currently if we use pygrub --isconfig <image>, there is a good chance
that this command could fail with an "out of memory" error. This can
happen especially if the image file in question is at least a few
gigabytes in size and the dom0_mem setting is relatively small. So
even if any software used this option it is likely it would fail. This
problem is due to the parser using "readlines" function in
GrubConf.py, which attempts to load the entire file into memory.
FWIW, the same problem is observed on unstable. Running this option
results in very high disk IO rate and eventually OOM killer wakes up and
whacks pygrub.
So chances are this has been broken for a while since I believe Firas is
working with 4.4. I haven't tried anything other than unstable though.
-boris
The advantage of "-l -n" option is that it exercises the "real" code
path, which boots the PV guests.
Regards
--Firas
On 03/22/2016 04:22 PM, Andrew Cooper wrote:
On 22/03/16 20:06, Firas Azar wrote:
The pygrub command option "isconfig" is broken and obsolete. This
patch removes it since the alternate options "-l -n" provide the
same functionality.
Broken how?
Are you sure that no existing software is using that option?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
