Re: [Xen-devel] Xen 4.7 Test Day Instructions for RC2+ : Call to action for people who added new features / functionality to Xen 4.7

2016-05-09 Thread Chun Yan Liu
>>> On 5/9/2016 at 11:28 PM, in message <6db04875-03d4-4542-b06c-2b0412d08...@gmail.com>, Lars Kurth wrote: > Hi all, > > I added the following sections based on git logs to man pages. Authors are > on the CC list and should review and modify (or suggest edits by replying to > this threa

Re: [Xen-devel] [PATCH] bind_usbintf: do not reuse 'path'

2016-04-07 Thread Chun Yan Liu
>>> On 4/8/2016 at 12:52 AM, in message <22278.36941.470901.631...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH] bind_usbintf: do not reuse 'path'"): > > To avoid confusion, add a new variable "intf_path" to indicate > > driver/interface path, let "path" indicat

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

2016-04-07 Thread Chun Yan Liu
>>> On 4/8/2016 at 01:04 AM, in message <22278.37677.975595.101...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of > usbdev_busaddr_to_busid"): > > Thanks, Ian! > > Should I ta

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-07 Thread Chun Yan Liu
>>> On 4/8/2016 at 12:45 AM, in message <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > > In testing with libvirt pvusb functionality, found a rc check > > error in libxl_device_usbdev_list. Cor

Re: [Xen-devel] Redundant lstats in libxl_pvusb.c

2016-04-07 Thread Chun Yan Liu
>>> On 4/7/2016 at 06:43 PM, in message <22278.14817.248393.423...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: Redundant lstats in libxl_pvusb.c"): > > <22274.33583.712655.413...@mariner.uk.xensource.com>, Ian Jac

Re: [Xen-devel] Redundant lstats in libxl_pvusb.c

2016-04-07 Thread Chun Yan Liu
>>> On 4/4/2016 at 11:07 PM, in message <22274.33583.712655.413...@mariner.uk.xensource.com>, Ian Jackson wrote: > In libxl_usb.c, usbintf_get_drvpath calls stat(2) on the driver sysfs > path, and then realpath on the same path. It's true. This could be done by calling realpath only. Will co

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

2016-04-07 Thread Chun Yan Liu
Thanks, Ian! >>> On 4/4/2016 at 11:09 PM, in message <1459782600-16073-1-git-send-email-ian.jack...@eu.citrix.com>, Ian Jackson wrote: > We must set rc before using `goto out'. > > Bug introduced in bf7628f0 "libxl: add pvusb API". > > CID: 1358113 > Signed-off-by: Ian Jackson > CC: cov

Re: [Xen-devel] [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents

2016-04-07 Thread Chun Yan Liu
>>> On 4/4/2016 at 11:10 PM, in message <1459782600-16073-2-git-send-email-ian.jack...@eu.citrix.com>, Ian Jackson wrote: > Bug introduced in bc023ecd > "libxl_utils: add internal function to read sysfs file contents" > > CID: 1358108 > Signed-off-by: Ian Jackson > CC: cover...@xenprojec

Re: [Xen-devel] [PATCH v3 2/5] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-24 Thread Chun Yan Liu
>>> On 3/25/2016 at 02:29 PM, in message <56f4dade.4040...@suse.com>, Juergen >>> Gross wrote: > On 25/03/16 03:23, Chun Yan Liu wrote: > > > > > >>>> On 3/23/2016 at 08:24 PM, in message > > <1458735847-9448-3-git-send-emai

Re: [Xen-devel] [PATCH v3 4/5] libxl: check for dynamic device model start required

2016-03-24 Thread Chun Yan Liu
>>> On 3/25/2016 at 02:25 PM, in message <56f4d9d6.8030...@suse.com>, Juergen >>> Gross wrote: > On 25/03/16 03:06, Chun Yan Liu wrote: > > > > > >>>> On 3/23/2016 at 08:24 PM, in message > > <1458735847-9448-5-git-send-

Re: [Xen-devel] [PATCH v3 2/5] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-24 Thread Chun Yan Liu
>>> On 3/23/2016 at 08:24 PM, in message <1458735847-9448-3-git-send-email-jgr...@suse.com>, Juergen Gross wrote: > Add a new pvusb backend type "qusb" which is provided by qemu. It can > be selected either by specifying the type directly in the configuration > or it is selected automatically

Re: [Xen-devel] [PATCH v3 4/5] libxl: check for dynamic device model start required

2016-03-24 Thread Chun Yan Liu
>>> On 3/23/2016 at 08:24 PM, in message <1458735847-9448-5-git-send-email-jgr...@suse.com>, Juergen Gross wrote: > Add a service routine checking whether a device model must be started > after adding a device to a domain. > > Signed-off-by: Juergen Gross > --- > tools/libxl/libxl.c

[Xen-devel] issue: xen pv guest text mode key press by TigerVNC

2016-03-11 Thread Chun Yan Liu
Hi, List, Currently after switch from TightVNC to TigerVNC, found a key-press issue in XEN pv guest, after investigation by myself, didn't find root cause yet, could anyone help to have a look or have some idea? Following is a description of the issue and some investigation result: In Xen pv gue

Re: [Xen-devel] [RESEND][PATCH V16 0/6] xen pvusb toolstack work

2016-03-08 Thread Chun Yan Liu
>>> On 3/8/2016 at 07:33 PM, in message <56deb899.7080...@citrix.com>, George Dunlap wrote: > On 08/03/16 01:37, Chunyan Liu wrote: > > This patch series is to add pvusb toolstack work, supporting hot add|remove > > USB device to|from guest and specify USB device in domain configuration > f

Re: [Xen-devel] [PATCH V16 4/6] libxl: add pvusb API

2016-03-07 Thread Chun Yan Liu
Sorry, corrected a wrong rc. Resent it, please refer to: http://lists.xen.org/archives/html/xen-devel/2016-03/msg00908.html >>> On 3/4/2016 at 12:55 PM, in message <1457067356-3306-5-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add pvusb APIs, including: > - attach/detach (create/destr

Re: [Xen-devel] [PATCH V16 0/6] xen pvusb toolstack work

2016-03-07 Thread Chun Yan Liu
Sorry, just corrected a rc in 4/6, and resent patch series, please refer to: http://lists.xen.org/archives/html/xen-devel/2016-03/msg00904.html >>> On 3/4/2016 at 12:55 PM, in message <1457067356-3306-1-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > This patch series is to add pvusb toolst

Re: [Xen-devel] [PATCH V15 4/6] libxl: add pvusb API

2016-03-03 Thread Chun Yan Liu
>>> On 3/3/2016 at 05:27 PM, in message , George Dunlap wrote: > On Thu, Mar 3, 2016 at 2:59 AM, Chun Yan Liu wrote: >>>>> On 3/3/2016 at 02:46 AM, in message <56d7350f.7010...@citrix.com>, George > > Dunlap wrote: > >> Sorry, just looked

Re: [Xen-devel] [PATCH V15 4/6] libxl: add pvusb API

2016-03-03 Thread Chun Yan Liu
>>> On 3/3/2016 at 05:20 PM, in message , George Dunlap wrote: > On Thu, Mar 3, 2016 at 3:11 AM, Chun Yan Liu wrote: >>>>> On 3/3/2016 at 02:32 AM, in message <56d731b1.60...@citrix.com>, George >>>>> Dunlap > > wrote: > >

Re: [Xen-devel] [PATCH V15 4/6] libxl: add pvusb API

2016-03-02 Thread Chun Yan Liu
>>> On 3/3/2016 at 02:32 AM, in message <56d731b1.60...@citrix.com>, George >>> Dunlap wrote: > On 01/03/16 08:09, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb controller and

Re: [Xen-devel] [PATCH V15 4/6] libxl: add pvusb API

2016-03-02 Thread Chun Yan Liu
>>> On 3/3/2016 at 02:46 AM, in message <56d7350f.7010...@citrix.com>, George Dunlap wrote: > On 02/03/16 18:32, George Dunlap wrote: > > On 01/03/16 08:09, Chunyan Liu wrote: > >> Add pvusb APIs, including: > >> - attach/detach (create/destroy) virtual usb controller. > >> - attach/detac

Re: [Xen-devel] [PATCH V14 4/6] libxl: add pvusb API

2016-02-29 Thread Chun Yan Liu
>>> On 2/29/2016 at 06:14 PM, in message <56d419f6.8030...@citrix.com>, George Dunlap wrote: > On 26/02/16 12:09, Ian Jackson wrote: > > George Dunlap writes ("Re: [Xen-devel] [PATCH V14 4/6] libxl: add pvusb > API"): > >> On Fri, Feb 19, 2016 at 10:39 AM, Chunyan Liu wrote: > >>> + [...

Re: [Xen-devel] [PATCH V14 4/6] libxl: add pvusb API

2016-02-25 Thread Chun Yan Liu
>>> On 2/24/2016 at 01:10 AM, in message , George Dunlap wrote: > On Fri, Feb 19, 2016 at 10:39 AM, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb controller and usb devices > > -

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Chun Yan Liu
>>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, >>> Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > #xl usbctrl-attach test_vm version=1 ports=8 > > > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 > > I think this does not handle the -N kn

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Chun Yan Liu
n >>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, >>> Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > #xl usbctrl-attach test_vm version=1 ports=8 > > > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 > > I think this does not handle the -N k

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 10:33 PM, in message <56b20fcc.3010...@citrix.com>, George Dunlap wrote: > On 02/02/16 18:11, Ian Jackson wrote: > > George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb > API"): > >> There are effectively four states a device can be in, from the > >>

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 10:38 PM, in message <56b210fa.7040...@citrix.com>, George Dunlap wrote: > On 03/02/16 07:34, Chun Yan Liu wrote: > > > > > >>>> On 2/3/2016 at 02:11 AM, in message > > <22192.61775.427189.268...@mariner.uk.xensour

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 12:48 AM, in message , George Dunlap wrote: > On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson > wrote: > > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > >> > Ought this function to really report success if these calls fail ? > >> > >> I think so. Till here

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-02 Thread Chun Yan Liu
>>> On 2/3/2016 at 02:11 AM, in message <22192.61775.427189.268...@mariner.uk.xensource.com>, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb > API"): > > There are effectively four states a device can be in, from the > > 'assignment' point of vie

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-01 Thread Chun Yan Liu
>>> On 1/27/2016 at 12:21 AM, in message , George Dunlap wrote: > On Tue, Jan 26, 2016 at 7:43 AM, Chun Yan Liu wrote: > > > > > >>>> On 1/20/2016 at 12:56 PM, in message > > <569f83f5020000660009e...@relay2.provo.novell.com>, "Chu

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread Chun Yan Liu
>>> On 1/27/2016 at 12:12 AM, in message <20160126161253.ga9...@gmail.com>, Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > +++ b/tools/libxl/libxl.c > > @@ -3204,7 +3204,7 @@ void > libxl__device_disk_local_initiate_detach(libxl__egc *egc, > > aodev->dev = device;

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-25 Thread Chun Yan Liu
>>> On 1/20/2016 at 12:56 PM, in message <569f83f502660009e...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > >>>> On 1/19/2016 at 11:48 PM, in message > <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson > wro

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-19 Thread Chun Yan Liu
>>> On 1/19/2016 at 11:48 PM, in message <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach u

Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

2016-01-13 Thread Chun Yan Liu
>>> On 1/13/2016 at 02:31 AM, in message <22165.18064.452737.543...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V12 3/5] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach u

Re: [Xen-devel] Xen 4.7 Development Update

2016-01-04 Thread Chun Yan Liu
>>> On 1/4/2016 at 06:15 PM, in message , Wei Liu wrote: > This email only tracks big items for xen.git tree. Please reply for items you > woulk like to see in 4.7 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use c

Re: [Xen-devel] [PATCH v10 3/5] libxl: add pvusb API

2015-12-14 Thread Chun Yan Liu
>>> On 12/14/2015 at 07:37 PM, in message , George Dunlap wrote: > On Mon, Dec 14, 2015 at 7:25 AM, Chun Yan Liu wrote: > > > > > >>>> On 12/10/2015 at 08:08 PM, in message <56696b4b.7060...@citrix.com>, > >>>> George >

Re: [Xen-devel] [PATCH v10 3/5] libxl: add pvusb API

2015-12-13 Thread Chun Yan Liu
>>> On 12/10/2015 at 08:08 PM, in message <56696b4b.7060...@citrix.com>, George Dunlap wrote: > On 10/12/15 12:05, George Dunlap wrote: > > From: Chunyan Liu > > > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device

Re: [Xen-devel] [PATCH v10 0/5] xen pvusb toolstack work

2015-12-10 Thread Chun Yan Liu
>>> On 12/10/2015 at 08:05 PM, in message <1449749113-1243-1-git-send-email-george.dun...@eu.citrix.com>, George Dunlap wrote: > Chunyan, > > I did a thorough review of v3, and almost all the comments I had fell > into two categories: > > 1. Trivial things that could be easily fixed >

Re: [Xen-devel] [RESEND][PATCH V9 3/7] libxl: add pvusb API

2015-12-07 Thread Chun Yan Liu
Any comments? >>> On 11/25/2015 at 05:46 PM, in message <1448444775-6974-4-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb devices > - s

Re: [Xen-devel] [PATCH v2] libxl: Introduce a template for devices with a controller

2015-12-01 Thread Chun Yan Liu
ontroller. > > In the interest of consistency, this patch introduces a section that > sketches out a template for interfaces for such devices. Acked. > > Signed-off-by: George Dunlap > Acked-by: Juergen Gross > --- > CC: Ian Campbell > CC: Ian Jackson &

Re: [Xen-devel] [PATCH V9 0/7] xen pvusb toolstack work

2015-11-25 Thread Chun Yan Liu
According to current active discussion: libxl: Introduce a template for devices with a controller https://www.mail-archive.com/xen-devel@lists.xen.org/msg46720.html Will update naming and RESEND. - Chunyan >>> On 11/24/2015 at 04:35 PM, in message <1448354134-21644-1-git-send-email-cy...@suse.co

Re: [Xen-devel] [PATCH] libxl: Introduce a template for devices with a controller

2015-11-24 Thread Chun Yan Liu
son > CC: Wei Liu > CC: Juergen Gross > CC: Chun Yan Liu > CC: Olaf Hering > > Changes in v1 (since the RFC): > > - Use rather than , and rather than specifying > controller and device. The idea being to allow SCSI to use > terminology more natu

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-18 Thread Chun Yan Liu
>>> On 11/19/2015 at 09:33 AM, in message <564d9761026600085...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > >>>> On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>, >>>> Olaf > Hering wrote: &

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-18 Thread Chun Yan Liu
>>> On 11/18/2015 at 05:44 PM, in message <20151118094410.gb21...@aepfle.de>, >>> Olaf Hering wrote: > On Tue, Nov 17, Chun Yan Liu wrote: > > > I think libxl_device_usb doesn't need to be changed into > libxl_device_usbdev? > > In ca

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-17 Thread Chun Yan Liu
>>> On 11/16/2015 at 06:01 PM, in message <5649a988.7010...@citrix.com>, George Dunlap wrote: > On 13/11/15 11:19, Olaf Hering wrote: > > On Wed, Oct 21, Chunyan Liu wrote: > > > >> Add pvusb APIs, including: > > > >> @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [ >

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-16 Thread Chun Yan Liu
>>> On 11/17/2015 at 02:06 AM, in message <22090.6954.35639.703...@mariner.uk.xensource.com>, Ian Jackson wrote: > Thanks for your attention to my earlier mail. I'll delete all the > comments where we agree :-). > > > > > > > +/* bind/unbind usb device interface */ > > > > > > +static i

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-12 Thread Chun Yan Liu
>>> On 11/13/2015 at 01:27 AM, in message , George Dunlap wrote: > On Wed, Oct 21, 2015 at 10:08 AM, Chunyan Liu wrote: > > +static int > > +get_assigned_devices(libxl__gc *gc, > > + libxl_device_usb **list, int *num) > > +{ > > +char **domlist; > > +unsigned

Re: [Xen-devel] [PATCH V8 7/7] domcreate: support pvusb in configuration file

2015-11-12 Thread Chun Yan Liu
>>> On 11/13/2015 at 12:10 AM, in message , George Dunlap wrote: > On Wed, Oct 21, 2015 at 10:08 AM, Chunyan Liu wrote: > > Add code to support pvusb in domain config file. One could specify > > usbctrl and usb in domain's configuration file and create domain, > > then usb controllers will

Re: [Xen-devel] [PATCH V8 5/7] xl: add pvusb commands

2015-11-12 Thread Chun Yan Liu
>>> On 11/12/2015 at 10:42 PM, in message <20151112144211.ga5...@aepfle.de>, >>> Olaf Hering wrote: > On Wed, Oct 21, Chunyan Liu wrote: > > > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > > usb-attach and usb-detach. > > How is this supposed to be handled in libvirt?

Re: [Xen-devel] [PATCH V8 5/7] xl: add pvusb commands

2015-11-12 Thread Chun Yan Liu
>>> On 11/12/2015 at 07:38 PM, in message , George Dunlap wrote: > On Wed, Oct 21, 2015 at 10:08 AM, Chunyan Liu wrote: > > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > > usb-attach and usb-detach. > > > > To attach a usb device to guest through pvusb, one could follow

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-12 Thread Chun Yan Liu
>>> On 11/12/2015 at 07:32 PM, in message <20151112113200.ga...@aepfle.de>, Olaf Hering wrote: > On Wed, Oct 21, Chunyan Liu wrote: > > > Add pvusb APIs, including: > > Some comments below. > > After a quick look I miss the proposed ctrl/device separation for pvscsi > (what handles "s

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-12 Thread Chun Yan Liu
>>> On 11/13/2015 at 01:00 AM, in message <22084.50631.506663.212...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH V8 3/7] libxl: add pvusb API"): > > On 11/10/2015 at 02:11 AM, in message > > <22080.57829.461049.3

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/11/2015 at 02:11 AM, in message <22082.13115.276320.572...@mariner.uk.xensource.com>, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API"): > > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: >

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/11/2015 at 01:57 AM, in message , George Dunlap wrote: > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: > >> > +void libxl__device_usbctrl_add(libxl__egc *egc, uint32_t domid, > >> > +

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/10/2015 at 02:11 AM, in message <22080.57829.461049.37...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V8 3/7] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach us

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-03 Thread Chun Yan Liu
Ian & George, any comments? >>> On 10/21/2015 at 05:08 PM, in message <1445418510-19614-4-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb

Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

2015-10-13 Thread Chun Yan Liu
On 10/13/2015 09:15 PM, George Dunlap wrote: On 13/10/15 02:46, Chun Yan Liu wrote: On 10/12/2015 09:46 PM, George Dunlap wrote: On 12/10/15 08:19, Chun Yan Liu wrote: + +usbinfo->devnum = usb->u.hostdev.hostaddr; +usbinfo->busnum = usb->u.hostdev.hostbus;

Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

2015-10-12 Thread Chun Yan Liu
On 10/12/2015 09:46 PM, George Dunlap wrote: On 12/10/15 08:19, Chun Yan Liu wrote: + +usbinfo->devnum = usb->u.hostdev.hostaddr; +usbinfo->busnum = usb->u.hostdev.hostbus; + +busid = usb_busaddr_to_busid(gc, usb->u.hostdev.hostbus, +

Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

2015-10-12 Thread Chun Yan Liu
>>> On 10/1/2015 at 01:55 AM, in message <560c2204.9030...@citrix.com>, George Dunlap wrote: > On 25/09/15 03:11, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb controllers and u

Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

2015-10-12 Thread Chun Yan Liu
>>> On 10/8/2015 at 10:41 PM, in message <22038.32910.375958.407...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V7 3/7] libxl: add pvusb API"): > > Add pvusb APIs, including: > ... > > > +/* Utility to read backend xenstore keys */ > > +#define READ_BACKEND

Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

2015-10-09 Thread Chun Yan Liu
>>> On 10/1/2015 at 01:55 AM, in message <560c2204.9030...@citrix.com>, George Dunlap wrote: > On 25/09/15 03:11, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb controllers and u

Re: [Xen-devel] [PATCH V7 5/7] xl: add pvusb commands

2015-10-09 Thread Chun Yan Liu
>>> On 10/2/2015 at 01:02 AM, in message <560d6733.4030...@citrix.com>, George Dunlap wrote: > On 25/09/15 03:11, Chunyan Liu wrote: > > Add pvusb commands: usb-ctrl-attach, usb-ctrl-detach, usb-list, > > usb-attach and usb-detach. > > > > To attach a usb device to guest through pvusb, one

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-17 Thread Chun Yan Liu
>>> On 9/14/2015 at 10:03 PM, in message , George Dunlap wrote: > On Mon, Sep 14, 2015 at 12:12 PM, Ian Jackson > wrote: > > Juergen Gross writes ("Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb > API"): > >> On 09/14/2015 12:36 PM, George Dunlap wrote: > >> > Anyone want to look into

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-17 Thread Chun Yan Liu
>>> On 9/9/2015 at 12:52 AM, in message <55ef1244@citrix.com>, George Dunlap wrote: > On 09/08/2015 03:17 PM, Ian Campbell wrote: > > On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote: > > > > Sorry for the delay, between 4.6 freeze crunch, conference and vacation > > I've been a bi

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-17 Thread Chun Yan Liu
>>> On 9/9/2015 at 12:52 AM, in message <55ef1244@citrix.com>, George Dunlap wrote: > On 09/08/2015 03:17 PM, Ian Campbell wrote: > > On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote: > > > > Sorry for the delay, between 4.6 freeze crunch, conference and vacation > > I've been a bi

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-15 Thread Chun Yan Liu
>>> On 9/11/2015 at 09:26 PM, in message <1441978018.3549.33.ca...@citrix.com>, >>> Ian Campbell wrote: > On Thu, 2015-09-10 at 23:42 -0600, Chun Yan Liu wrote: > > > > > Do these fields have any particular size requirements arising from e.g. &g

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-10 Thread Chun Yan Liu
>>> On 9/8/2015 at 10:17 PM, in message <1441721852.24450.120.ca...@citrix.com>, Ian Campbell wrote: > On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote: > > Sorry for the delay, between 4.6 freeze crunch, conference and vacation > I've been a bit swamped. > > I'm just going to commen

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-09-09 Thread Chun Yan Liu
>>> On 9/9/2015 at 12:52 AM, in message <55ef1244@citrix.com>, George Dunlap wrote: > On 09/08/2015 03:17 PM, Ian Campbell wrote: > > On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote: > > > > Sorry for the delay, between 4.6 freeze crunch, conference and vacation > > I've been a bi

Re: [Xen-devel] [RFC PATCH 0/7] domain snapshot implementation

2015-08-30 Thread Chun Yan Liu
ping? >>> On 8/11/2015 at 06:44 PM, in message <1439289896-27849-1-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add vm snapshot implementation. Support snapshot-create and > snapshot-revert. > > Current Limitations: > > About disk snapshot create, there are many cases: > - qdisk

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-30 Thread Chun Yan Liu
Ian and George, could I have your comments? Thanks, Chunyan >>> On 8/11/2015 at 07:27 PM, in message <2015082702.gf7...@zion.uk.xensource.com>, Wei Liu wrote: > On Mon, Aug 10, 2015 at 06:35:24PM +0800, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-17 Thread Chun Yan Liu
>>> On 8/13/2015 at 05:09 PM, in message <20150813090938.gi7...@zion.uk.xensource.com>, Wei Liu wrote: > On Tue, Aug 11, 2015 at 08:24:01PM -0600, Chun Yan Liu wrote: > > > > > > >>> On 8/11/2015 at 07:27 PM, in message > > <

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-13 Thread Chun Yan Liu
>>> On 8/13/2015 at 05:09 PM, in message <20150813090938.gi7...@zion.uk.xensource.com>, Wei Liu wrote: > On Tue, Aug 11, 2015 at 08:24:01PM -0600, Chun Yan Liu wrote: > > > > > > >>> On 8/11/2015 at 07:27 PM, in message > > <

Re: [Xen-devel] [PATCH V6 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-08-11 Thread Chun Yan Liu
>>> On 8/11/2015 at 07:26 PM, in message <2015082655.ge7...@zion.uk.xensource.com>, Wei Liu wrote: > On Mon, Aug 10, 2015 at 06:35:23PM +0800, Chunyan Liu wrote: > > Sysfs file has size=4096 but actual file content is less than that. > > Current libxl_read_file_contents will treat it as e

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-11 Thread Chun Yan Liu
>>> On 8/11/2015 at 07:27 PM, in message <2015082702.gf7...@zion.uk.xensource.com>, Wei Liu wrote: > On Mon, Aug 10, 2015 at 06:35:24PM +0800, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device

Re: [Xen-devel] [PATCH V5 3/7] libxl: add pvusb API

2015-08-07 Thread Chun Yan Liu
>>> On 8/7/2015 at 01:21 AM, in message <55c39796.8000...@citrix.com>, George Dunlap wrote: > On 08/06/2015 04:11 AM, Chun Yan Liu wrote: > > As 4.6 goes to bug fixing stage, maybe we can pick up this thread? :-) > > > > Beside to call for your preciou

Re: [Xen-devel] [PATCH V5 3/7] libxl: add pvusb API

2015-08-06 Thread Chun Yan Liu
>>> On 8/7/2015 at 01:21 AM, in message <55c39796.8000...@citrix.com>, George Dunlap wrote: > On 08/06/2015 04:11 AM, Chun Yan Liu wrote: > > As 4.6 goes to bug fixing stage, maybe we can pick up this thread? :-) > > > > Beside to call for your preciou

Re: [Xen-devel] [PATCH V5 3/7] libxl: add pvusb API

2015-08-05 Thread Chun Yan Liu
still need reading sysfs things. Could we get to a final decision? If these are settled down, I can update related code. Thanks, Chunyan >>> On 7/7/2015 at 05:57 PM, in message <559ba270.4000...@eu.citrix.com>, George Dunlap wrote: > On 07/07/2015 02:25 AM, Chun Yan L

Re: [Xen-devel] [PATCH V5 7/7] domcreate: support pvusb in configuration file

2015-08-05 Thread Chun Yan Liu
>>> On 7/13/2015 at 06:08 PM, in message <55a38e2e.60...@suse.com>, Juergen >>> Gross wrote: > On 06/25/2015 12:07 PM, Chunyan Liu wrote: > > Add code to support pvusb in domain config file. One could specify > > usbctrl and usb in domain's configuration file and create domain, > > then usb

Re: [Xen-devel] [PATCH V5 3/7] libxl: add pvusb API

2015-07-06 Thread Chun Yan Liu
Any comments on the implementation? If there is anything improper, I can update. Thanks, Chunyan >>> On 6/25/2015 at 06:07 PM, in message <1435226838-3067-4-git-send-email-cy...@suse.com>, Chunyan Liu wrote: > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controlle

Re: [Xen-devel] [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-30 Thread Chun Yan Liu
>>> On 6/30/2015 at 05:08 PM, in message <21906.23698.778991.627...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH V5 2/7] libxl_read_file_contents: add new > entry to read sysfs file"): > > >

Re: [Xen-devel] [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-29 Thread Chun Yan Liu
>>> On 6/29/2015 at 06:52 PM, in message <21905.9050.452111.208...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH V5 2/7] libxl_read_file_contents: add new > entry to read sysfs file"): > > On 6/26/2015 at 09:05 PM, i

Re: [Xen-devel] [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-29 Thread Chun Yan Liu
>>> On 6/26/2015 at 09:05 PM, in message <21901.20009.85407.581...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH V5 2/7] libxl_read_file_contents: add new > entry to read sysfs file"): > > >

Re: [Xen-devel] [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-25 Thread Chun Yan Liu
>>> On 6/25/2015 at 07:09 PM, in message <21899.57676.368102.982...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V5 2/7] libxl_read_file_contents: add new entry > to read sysfs file"): > > Sysfs file has size=4096 but actual file content is less than that. > >

Re: [Xen-devel] [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-25 Thread Chun Yan Liu
>>> On 6/25/2015 at 07:09 PM, in message <21899.57676.368102.982...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V5 2/7] libxl_read_file_contents: add new entry > to read sysfs file"): > > Sysfs file has size=4096 but actual file content is less than that. > >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-23 Thread Chun Yan Liu
>>> On 6/23/2015 at 07:29 PM, in message <558942ff.5060...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/23/2015 11:18 AM, Chun Yan Liu wrote: >>>>> On 6/16/2015 at 01:47 AM, in message <557f0fa7.2060...@eu.citrix.com>, >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-23 Thread Chun Yan Liu
>>> On 6/16/2015 at 01:47 AM, in message <557f0fa7.2060...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/10/2015 04:20 AM, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb cont

[Xen-devel] Proposed plan for libxl USB interface (was Re: [PATCH V4 3/7] libxl: add pvusb API)

2015-06-22 Thread Chun Yan Liu
>>> On 6/22/2015 at 09:29 PM, in message <55880dcc.6070...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/18/2015 01:08 PM, George Dunlap wrote: > > This usb interface stuff is really becoming a morass. The core > > functionality is fairly independent of the interface. I'm inclined to >

[Xen-devel] Proposed plan for libxl USB interface (was Re: [PATCH V4 3/7] libxl: add pvusb API)

2015-06-22 Thread Chun Yan Liu
>>> On 6/22/2015 at 09:29 PM, in message <55880dcc.6070...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/18/2015 01:08 PM, George Dunlap wrote: > > This usb interface stuff is really becoming a morass. The core > > functionality is fairly independent of the interface. I'm inclined to >

[Xen-devel] Proposed plan for libxl USB interface (was Re: [PATCH V4 3/7] libxl: add pvusb API)

2015-06-22 Thread Chun Yan Liu
>>> On 6/22/2015 at 09:29 PM, in message <55880dcc.6070...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/18/2015 01:08 PM, George Dunlap wrote: > > This usb interface stuff is really becoming a morass. The core > > functionality is fairly independent of the interface. I'm inclined to >

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API [and 1 more messages]

2015-06-17 Thread Chun Yan Liu
>>> On 6/17/2015 at 06:27 PM, in message <55814b9f.6070...@eu.citrix.com>, >>> George Dunlap wrote: > On 06/17/2015 04:59 AM, Juergen Gross wrote: > > On 06/16/2015 06:34 PM, George Dunlap wrote: > >> On Tue, Jun 16, 2015 at 4:59 PM, Ian Jackson > >> wrote: > >>> George Dunlap writes ("Re

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-17 Thread Chun Yan Liu
>>> On 6/17/2015 at 07:34 PM, in message >>> <1434540857.13744.334.ca...@citrix.com>, Ian Campbell wrote: > On Tue, 2015-06-16 at 16:20 +0200, Juergen Gross wrote: > > My point was to avoid the sysfs accesses in libxl in order to support > > BSD as well and to reduce the complexity. > > A

Re: [Xen-devel] [PATCH RFC v1] libxl: Introduce a template for devices with a controller

2015-06-17 Thread Chun Yan Liu
we could come to some sort of agreement on this such that > it can be used as the basis for both the pvusb and pvscsi interfaces. As > such your feedback here is important... > > > > > Signed-off-by: George Dunlap > > --- > > CC: Ian Campbell > > CC:

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 03:39 PM, in message <557afd2f0266000d4...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > >>>> On 6/12/2015 at 12:42 AM, in message > <21881.47707.526863.158...@mariner.uk.xensource.com>, Ian Jackson > wrote:

Re: [Xen-devel] [PATCH V4 5/7] xl: add pvusb commands

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 03:37 PM, in message <557a8c57.1040...@suse.com>, Juergen >>> Gross wrote: > On 06/10/2015 05:20 AM, Chunyan Liu wrote: > > Add pvusb commands: usb-ctrl-attach, usb-ctrl-detach, usb-list, > > usb-attach and usb-detach. > > > > To attach a usb device to guest through pvu

Re: [Xen-devel] [PATCH V4 3/7] libxl: add pvusb API

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 12:42 AM, in message <21881.47707.526863.158...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[Xen-devel] [PATCH V4 3/7] libxl: add pvusb API"): > > Add pvusb APIs, including: > ... > > Thanks for your contribution. I'm afraid I haven't had time

Re: [Xen-devel] [PATCH V4 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-06-12 Thread Chun Yan Liu
>>> On 6/12/2015 at 12:16 AM, in message <21881.46148.466883.923...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[Xen-devel] [PATCH V4 2/7] libxl_read_file_contents: add > > new entry to read sysfs file"): > > Sysfs file has size=4096 but actual file content is less

[Xen-devel] 答复: Re: [PATCH V3 3/6] libxl: add pvusb API

2015-06-08 Thread Chun Yan Liu
>>> 在 2:16 的 2015/5/20 上,在讯息 中,George Dunlap 写入: > On Sun, Apr 19, 2015 at 4:50 AM, Chunyan Liu wrote: > > +int libxl_device_usb_getinfo(libxl_ctx *ctx, char *busid, libxl_usbinfo > *usbinfo) > > +{ > > Sorry, missed something. This function is wrong. It gives you > information about a *ho

[Xen-devel] 答复: Re: [PATCH V3 3/6] libxl: add pvusb API

2015-06-08 Thread Chun Yan Liu
>>> 在 2:06 的 2015/5/20 上,在讯息 中,George Dunlap 写入: > On Sun, Apr 19, 2015 at 4:50 AM, Chunyan Liu wrote: > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach usb device > > - list usb controller and usb devices > > - some other helpe

Re: [Xen-devel] [PATCH V3 3/6] libxl: add pvusb API

2015-05-20 Thread Chun Yan Liu
>>> On 5/20/2015 at 05:04 PM, in message <20150520090407.gw26...@zion.uk.xensource.com>, Wei Liu wrote: > On Mon, May 18, 2015 at 09:20:43PM -0600, Chun Yan Liu wrote: > [...] > > > > > > > +for (;;) { > > > > +rc = libx

Re: [Xen-devel] [PATCH V3 2/6] libxl_read_file_contents: fix reading sysfs file

2015-05-18 Thread Chun Yan Liu
>>> On 5/18/2015 at 10:30 PM, in message <20150518143008.ge9...@zion.uk.xensource.com>, Wei Liu wrote: > On Mon, May 18, 2015 at 03:23:38PM +0100, Ian Jackson wrote: > > Chunyan Liu writes ("[PATCH V3 2/6] libxl_read_file_contents: fix reading > sysfs file"): > > > Sysfs file has size=4096

Re: [Xen-devel] [PATCH V3 3/6] libxl: add pvusb API

2015-05-18 Thread Chun Yan Liu
>>> On 5/19/2015 at 02:07 AM, in message <20150518180724.gh9...@zion.uk.xensource.com>, Wei Liu wrote: > (I look at overall code structure this pass. I haven't done a line by > line review.) > > On Sun, Apr 19, 2015 at 11:50:49AM +0800, Chunyan Liu wrote: > > Add pvusb APIs, including: >

  1   2   >