Re: [Xen-devel] [PATCH] x86/mm: Split read_cr3() into read_cr3_pa() and __read_cr3()

2017-06-12 Thread Ingo Molnar
* Andy Lutomirski wrote: > The kernel has several code paths that read CR3. Most of them assume that > CR3 contains the PGD's physical address, whereas some of them awkwardly > use PHYSICAL_PAGE_MASK to mask off low bits. > > Add explicit mask macros for CR3 and convert all of the CR3 readers.

[Xen-devel] [linux-linus test] 110380: tolerable FAIL - PUSHED

2017-06-12 Thread osstest service owner
flight 110380 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/110380/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-xsm 5 xen-install fail in 110346 pass in 110380 test-amd64-i386-xl-qemuu-win7-amd

Re: [Xen-devel] [PATCH v3 08/18] xen/pvcalls: implement connect command

2017-06-12 Thread Juergen Gross
On 02/06/17 21:31, Stefano Stabellini wrote: > Allocate a socket. Keep track of socket <-> ring mappings with a new data > structure, called sock_mapping. Implement the connect command by calling > inet_stream_connect, and mapping the new indexes page and data ring. > Allocate a workqueue and a wor

Re: [Xen-devel] [PATCH v3 07/18] xen/pvcalls: implement socket command

2017-06-12 Thread Juergen Gross
On 02/06/17 21:31, Stefano Stabellini wrote: > Just reply with success to the other end for now. Delay the allocation > of the actual socket to bind and/or connect. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/pvcalls-back.c | 2

Re: [Xen-devel] [PATCH v3 18/18] xen: introduce a Kconfig option to enable the pvcalls backend

2017-06-12 Thread Juergen Gross
On 02/06/17 21:31, Stefano Stabellini wrote: > Also add pvcalls-back to the Makefile. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/Kconfig | 12 > drivers/xen/Makefile | 1 + > 2 files changed, 13 insertions(+) >

[Xen-devel] [seabios test] 110383: tolerable FAIL - PUSHED

2017-06-12 Thread osstest service owner
flight 110383 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/110383/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 15 guest-localmigrate/x10 fail like 108165 test-amd64-i386-xl-qemuu-win7-amd64 16 g

Re: [Xen-devel] ARM: SMMUv3 support

2017-06-12 Thread Manish Jaggi
On 3/29/2017 5:30 AM, Goel, Sameer wrote: Sure, I will try to post something soon. Hi Sameer, Are you still working on SMMU v3, can you please post patches. Thanks Manish Thanks, Sameer On 3/27/2017 11:03 PM, Vijay Kilari wrote: On Mon, Mar 27, 2017 at 10:00 PM, Goel, Sameer wrote: Hi,

[Xen-devel] [qemu-mainline bisection] complete test-armhf-armhf-xl-vhd

2017-06-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-armhf-armhf-xl-vhd testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemuu git://git.qemu.org/qemu.git Tree: xen git://xenbits.xen.org/xen.git *** Foun

[Xen-devel] [linux-4.9 test] 110371: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110371 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/110371/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 6 xen-boot fail REGR. vs. 107358 Tests which are faili

[Xen-devel] [xen-4.9-testing test] 110374: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110374 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110374/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 15 guest-localmigrate/x10 fail REGR. vs. 110219 Tests whi

[Xen-devel] [PATCH 2/2] tools/xenstat: fix missing linkage of libxenstat against libyajl

2017-06-12 Thread Peter Große
This fixes the python bindings, since symbols were missing in libxenstat. xentop doesn't use any yajl functions, so drop linking libyajl. Signed-off-by: Peter Große --- tools/xenstat/libxenstat/Makefile | 2 +- tools/xenstat/xentop/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletio

[Xen-devel] [PATCH 1/2] libxenstat: use python detected by configure for python bindings

2017-06-12 Thread Peter Große
Signed-off-by: Peter Große --- tools/xenstat/libxenstat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile index 85cec63ebf..08b0f35172 100644 --- a/tools/xenstat/libxenstat/Makefile +++ b/tools/xenst

[Xen-devel] [PATCH 0/2] Fix python bindings for libxenstat

2017-06-12 Thread Peter Große
Hello. I tried to build and use the python bindings for libxenstat. Building worked, after I changed the hardcoded PYTHON_VERSION variable in the tools/xenstat/libxenstat/Makefile. Maybe the version detected by configure can be used here. The 1st patch tries to address this. Then, when I tried t

Re: [Xen-devel] [PATCH v11 08/34] ARM: GIC: Add checks for NULL pointer pending_irq's

2017-06-12 Thread Stefano Stabellini
On Fri, 9 Jun 2017, Andre Przywara wrote: > For LPIs the struct pending_irq's are dynamically allocated and the > pointers will be stored in a radix tree. Since an LPI can be "unmapped" > at any time, teach the VGIC how to deal with irq_to_pending() returning > a NULL pointer. > We just do nothing

Re: [Xen-devel] [PATCH v11 06/34] ARM: vGIC: move irq_to_pending() calls under the VGIC VCPU lock

2017-06-12 Thread Stefano Stabellini
On Mon, 12 Jun 2017, Julien Grall wrote: > Hi Andre, > > On 09/06/17 18:41, Andre Przywara wrote: > > @@ -285,6 +291,17 @@ void arch_move_irqs(struct vcpu *v) > > struct vcpu *v_target; > > int i; > > > > +/* > > + * We don't migrate LPIs at the moment. > > + * If we ever do

Re: [Xen-devel] [PATCH v11 01/34] ARM: vGIC: avoid rank lock when reading priority

2017-06-12 Thread Stefano Stabellini
On Mon, 12 Jun 2017, Julien Grall wrote: > Hi Andre, > > On 09/06/17 18:41, Andre Przywara wrote: > > When reading the priority value of a virtual interrupt, we were taking > > the respective rank lock so far. > > However for forwarded interrupts (Dom0 only so far) this may lead to a > > deadlock

[Xen-devel] tags in backport commits

2017-06-12 Thread Stefano Stabellini
Hi all, I think we should discuss and agree on a set of tags to use in our backports to stable trees. Specifically, I would like to see a tag that specifies the id of the original commit, like "master commit" that Jan is using today. I would prefer if the tag didn't have any spaces, thus, I sugge

Re: [Xen-devel] [PATCH v3 06/18] xen/pvcalls: handle commands from the frontend

2017-06-12 Thread Boris Ostrovsky
> + > static void pvcalls_back_work(struct work_struct *work) > { > + struct pvcalls_fedata *priv = container_of(work, > + struct pvcalls_fedata, register_work); > + int notify, notify_all = 0, more = 1; > + struct xen_pvcalls_request req; > + struct xenbus_device *de

Re: [Xen-devel] [PATCH v4 4/8] mm: Scrub memory from idle loop

2017-06-12 Thread Dario Faggioli
On Mon, 2017-06-12 at 13:01 -0400, Boris Ostrovsky wrote: > On 06/12/2017 04:08 AM, Jan Beulich wrote: > > > > > On 19.05.17 at 17:50, wrote: > > > > > > Instead of scrubbing pages during guest destruction (from > > > free_heap_pages()) do this opportunistically, from the idle loop. > > > > This

Re: [Xen-devel] [PATCH v3 05/18] xen/pvcalls: connect to a frontend

2017-06-12 Thread Boris Ostrovsky
On 06/02/2017 03:31 PM, Stefano Stabellini wrote: > Introduce a per-frontend data structure named pvcalls_fedata. It > contains pointers to the command ring, its event channel, a list of > active sockets and a tree of passive sockets (passing sockets need to be > looked up from the id on listen, ac

Re: [Xen-devel] [PATCH v3 04/18] xen/pvcalls: xenbus state handling

2017-06-12 Thread Boris Ostrovsky
On 06/02/2017 03:31 PM, Stefano Stabellini wrote: > Introduce the code to handle xenbus state changes. > > Implement the probe function for the pvcalls backend. Write the > supported versions, max-page-order and function-calls nodes to xenstore, > as required by the protocol. > > Introduce stub fun

Re: [Xen-devel] [PATCH v3 01/18] xen: introduce the pvcalls interface header

2017-06-12 Thread Boris Ostrovsky
On 06/02/2017 03:31 PM, Stefano Stabellini wrote: > Introduce the C header file which defines the PV Calls interface. It is > imported from xen/include/public/io/pvcalls.h. > > Signed-off-by: Stefano Stabellini > CC: konrad.w...@oracle.com > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com Re

[Xen-devel] [xen-unstable test] 110362: tolerable FAIL

2017-06-12 Thread osstest service owner
flight 110362 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/110362/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-rumprun-i386 16 rumprun-demo-xenstorels/xenstorels.repeat fail in 110311 pass in 110362 test-a

[Xen-devel] [linux-next test] 110369: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110369 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/110369/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 5 kernel-build fail REGR. vs. 110131 test-amd64-i386-xl-q

[Xen-devel] [xen-4.7-testing test] 110353: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110353 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110353/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3865 xen-buildfail REGR. vs. 109620 build-i386-xsm

Re: [Xen-devel] [PATCH] tools: fix several "format-truncation" errors with GCC 7

2017-06-12 Thread Zhongze Liu
Hi Ian, Thanks for pointing out the problems. I've consulted several maintainers about this and have drafted a new patch for it (in a new [patch v2] thread). Please have a look at it. Thanks. Cheers, Zhongze Liu. 2017-06-12 20:31 GMT+08:00 Ian Jackson : > Zhongze Liu writes ("[PATCH] tools: fix

[Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

2017-06-12 Thread Zhongze Liu
GCC 7.1.1 complains that several buffers passed to snprintf() in xenpmd and tools/ocmal/xc are too small to hold the largest possible resulting string. enlarge the size of these buffers to fix the warnings. Signed-off-by: Zhongze Liu --- CC: David Scott CC: Ian Jackson CC: Wei Liu Changed si

Re: [Xen-devel] [PATCH 2/2] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2017-06-12 Thread Adrian Pop
On Mon, Jun 12, 2017 at 04:51:48PM +0100, Wei Liu wrote: > On Fri, Jun 09, 2017 at 07:51:54PM +0300, Adrian Pop wrote: > > Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a > > privileged domain to change the value of the #VE suppress bit for a > > page. > > > > Add a libxc wrapp

[Xen-devel] [PATCH] x86/mm: Split read_cr3() into read_cr3_pa() and __read_cr3()

2017-06-12 Thread Andy Lutomirski
The kernel has several code paths that read CR3. Most of them assume that CR3 contains the PGD's physical address, whereas some of them awkwardly use PHYSICAL_PAGE_MASK to mask off low bits. Add explicit mask macros for CR3 and convert all of the CR3 readers. This will keep them from breaking whe

[Xen-devel] [linux-linus test] 110346: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110346 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/110346/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-xsm 5 xen-install fail REGR. vs. 110093 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH v4 6/8] mm: Keep heap accessible to others while scrubbing

2017-06-12 Thread Boris Ostrovsky
>> @@ -1175,6 +1258,8 @@ static void free_heap_pages( >> if ( page_state_is(&pg[i], offlined) ) >> tainted = 1; >> >> +pg[i].u.free.scrub_state = 0; > Is this really needed for every page in the buddy? > The concern here is that is we break the buddy (in alloc_heap

Re: [Xen-devel] [PATCH v4 4/8] mm: Scrub memory from idle loop

2017-06-12 Thread Boris Ostrovsky
On 06/12/2017 04:08 AM, Jan Beulich wrote: On 19.05.17 at 17:50, wrote: >> Instead of scrubbing pages during guest destruction (from >> free_heap_pages()) do this opportunistically, from the idle loop. > This is too brief for my taste. In particular the re-ordering ... > >> --- a/xen/arch/x86

Re: [Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-12 Thread Julien Grall
Hi Jan, On 12/06/17 16:27, Jan Beulich wrote: On 12.06.17 at 17:11, wrote: We place the trampoline no lower than at 256k, so we have ample space to read the MBRs of BIOS disks into an aligned buffer right below the trampoline (not doing so has been found to be a problem on a buggy BIOS coming

Re: [Xen-devel] [Xen-devel[PATCH Resend v2] xen: common: rbtree: ported updates from linux tree

2017-06-12 Thread Dario Faggioli
On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > I have not imported augmented and rcu rbtree functionality to the xen > tree, > as there was no specific requirement for current planned > implementation. > > Please share your inputs. Thanks in advance. > So, I'm having another look at th

Re: [Xen-devel] [Resend][PATCH 04/17] rbtree: empty nodes have no color

2017-06-12 Thread Dario Faggioli
On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > Empty nodes have no color.  We can make use of this property to > simplify the > code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. > Mmm... you have significantly cut the changelog. I appreciate that some of the removed text speak

Re: [Xen-devel] [Resend][PATCH 06/17] rbtree: break out of rb_insert_color loop after tree rotation

2017-06-12 Thread Dario Faggioli
On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > --- a/xen/common/rbtree.c > +++ b/xen/common/rbtree.c > @@ -110,11 +110,8 @@ void rb_insert_color(struct rb_node *node, > struct rb_root *root) >   >  if (parent->rb_right == node) >  { > -register str

Re: [Xen-devel] [PATCH v11 31/34] ARM: vITS: handle INVALL command

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The INVALL command instructs an ITS to invalidate the configuration data for all LPIs associated with a given redistributor (read: VCPU). This is nasty to emulate exactly with our architecture, so we just iterate over all mapped LPIs and filter

Re: [Xen-devel] [PATCH v11 28/34] ARM: vITS: handle MOVI command

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The MOVI command moves the interrupt affinity from one redistributor (read: VCPU) to another. For now migration of "live" LPIs is not yet implemented, but we store the changed affinity in our virtual ITTE and the pending_irq. Signed-off-by: And

Re: [Xen-devel] [PATCH v11 27/34] ARM: vITS: handle MAPTI/MAPI command

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The MAPTI commands associates a DeviceID/EventID pair with a LPI/CPU pair and actually instantiates LPI interrupts. MAPI is just a variant of this comment, where the LPI ID is the same as the event ID. We connect the already allocated host LPI t

Re: [Xen-devel] [PATCH v10 25/32] ARM: vITS: handle MAPTI/MAPI command

2017-06-12 Thread Julien Grall
Hi Andre, On 07/06/17 18:49, Andre Przywara wrote: On 02/06/17 18:12, Julien Grall wrote: On 05/26/2017 06:35 PM, Andre Przywara wrote: +/* + * radix_tree_insert() returns an error either due to an internal + * condition (like memory allocation failure) or because the LPI already +

Re: [Xen-devel] [PATCH v11 26/34] ARM: GICv3: handle unmapped LPIs

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: @@ -478,8 +515,14 @@ static void gic_update_one_lr(struct vcpu *v, int i) gic_hw_ops->read_lr(i, &lr_val); irq = lr_val.virq; p = irq_to_pending(v, irq); -/* An LPI might have been unmapped, in which case we just clean up here

Re: [Xen-devel] [PATCH v2] xen: avoid deadlock in xenbus driver

2017-06-12 Thread Andre Przywara
Hi, On 08/06/17 15:03, Juergen Gross wrote: > There has been a report about a deadlock in the xenbus driver: > > [ 247.979498] == > [ 247.985688] WARNING: possible circular locking dependency detected > [ 247.991882] 4.12.0-rc4-00022-gc4b25c0

Re: [Xen-devel] [Resend][PATCH 14/17] rbtree: place easiest case first in rb_erase()

2017-06-12 Thread Dario Faggioli
On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > --- a/xen/common/rbtree.c > +++ b/xen/common/rbtree.c > @@ -376,18 +376,29 @@ static void __rb_erase_color(struct rb_node > *node, struct rb_node *parent, >   >  void rb_erase(struct rb_node *node, struct rb_root *root) >  { > -struct rb

Re: [Xen-devel] [PATCH v11 24/34] ARM: vITS: handle CLEAR command

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: This introduces the ITS command handler for the CLEAR command, which clears the pending state of an LPI. This removes a not-yet injected, but already queued IRQ from a VCPU. As read_itte() is now eventually used, we add the static keyword. Hmm

Re: [Xen-devel] [Resend][PATCH 13/17] rbtree: add __rb_change_child() helper function

2017-06-12 Thread Dario Faggioli
On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > @@ -65,6 +65,22 @@ static inline struct rb_node *rb_red_parent(struct > rb_node *red) >  return (struct rb_node *)red->__rb_parent_color; >  } >   > +static inline void > +__rb_change_child(struct rb_node *old, struct rb_node *new, > +  

Re: [Xen-devel] [PATCH v10 25/32] ARM: vITS: handle MAPTI/MAPI command

2017-06-12 Thread Andre Przywara
Hi, On 09/06/17 20:14, Stefano Stabellini wrote: > On Fri, 9 Jun 2017, Andre Przywara wrote: >> On 02/06/17 18:12, Julien Grall wrote: >>> Hi Andre, >>> >>> On 05/26/2017 06:35 PM, Andre Przywara wrote: The MAPTI commands associates a DeviceID/EventID pair with a LPI/CPU pair and actuall

Re: [Xen-devel] [PATCH v11 20/34] ARM: vITS: introduce translation table walks

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The ITS stores the target (v)CPU and the (virtual) LPI number in tables. Introduce functions to walk those tables and translate an device ID - event ID pair into a pair of virtual LPI and vCPU. We map those tables on demand - which is cheap on a

Re: [Xen-devel] [PATCH v11 19/34] ARM: vITS: add command handling stub and MMIO emulation

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: Emulate the memory mapped ITS registers and provide a stub to introduce the ITS command handling framework (but without actually emulating any commands at this time). This fixes a misnomer in our virtual ITS structure, where the spec is confusin

Re: [Xen-devel] [PATCH v11 18/34] ARM: vGIC: advertise LPI support

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: To let a guest know about the availability of virtual LPIs, set the respective bits in the virtual GIC registers and let a guest control the LPI enable bit. Only report the LPI capability if there is at least one ITS emulated for that guest (whi

Re: [Xen-devel] [PATCH v11 14/34] ARM: GICv3: forward pending LPIs to guests

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c index dbaf45a..03d23b6 100644 --- a/xen/arch/arm/gic-v3-lpi.c +++ b/xen/arch/arm/gic-v3-lpi.c @@ -136,6 +136,85 @@ uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_p

Re: [Xen-devel] [PATCH] domctl: improve device assignment structure layout and use

2017-06-12 Thread Wei Liu
On Fri, Jun 09, 2017 at 07:47:12AM -0600, Jan Beulich wrote: > Avoid needless gaps. Make flags field mandatory for all three > operations (and rename it to fit the intended future purpose of > possibly holding more than just one flag). > > Also correct a typo in a related domctl.h comment. > > Si

Re: [Xen-devel] [PATCH 2/2] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2017-06-12 Thread Wei Liu
On Fri, Jun 09, 2017 at 07:51:54PM +0300, Adrian Pop wrote: > Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a > privileged domain to change the value of the #VE suppress bit for a > page. > > Add a libxc wrapper for invoking this hvmop. > > Signed-off-by: Adrian Pop > --- >

[Xen-devel] [xen-unstable-smoke test] 110375: tolerable trouble: broken/pass - PUSHED

2017-06-12 Thread osstest service owner
flight 110375 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/110375/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] [PATCH v11 13/34] ARM: GIC: ITS: remove no longer needed VCPU ID in host LPI entry

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: To get easy access to the VCPU a forwareded LPI interrupt should be NIT: s/forwareded/forwarded/ injected to, so far we stored the VCPU ID in the host LPI entry. However this creates a redundancy, since we keep the target VCPU in the struct

Re: [Xen-devel] [PATCH v2 0/2] x86: Add a hvmop for setting the #VE suppress bit

2017-06-12 Thread Adrian Pop
I've just noticed I had forgotten to update the version of the patch in the email subject. Sorry! ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v11 12/34] ARM: vGIC: add LPI VCPU ID to struct pending_irq

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The target CPU for an LPI is encoded in the interrupt translation table entry, so can't be easily derived from just an LPI number (short of walking *all* tables and find the matching LPI). To avoid this in case we need to know the VCPU (for the

Re: [Xen-devel] [PATCH v11 11/34] ARM: vGIC: cache virtual LPI priority in struct pending_irq

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: We enhance struct pending_irq to cache the priority information for LPIs. Reading the information from there is faster than accessing the property table from guest memory. Also it use some padding area in the struct, so does not require more mem

Re: [Xen-devel] read_atomic, write_atomic, add_sized

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 17:19, wrote: > On 12/06/17 11:55, Jan Beulich wrote: > On 12.06.17 at 12:24, wrote: >>> I am trying to understand why we decided to implement the helpers >>> read_atomic, write_atomic, add_sized in assembly rather than directly in C. >>> >>> AFAICT implementation in C sim

Re: [Xen-devel] [PATCH v11 10/34] ARM: GIC: export and extend vgic_init_pending_irq()

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: For LPIs we later want to dynamically allocate struct pending_irqs. So beside needing to initialize the struct from there we also need to clean it up and re-initialize it later on. Export vgic_init_pending_irq() and extend it to be reusable. Si

Re: [Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-12 Thread Andrew Cooper
On 12/06/17 16:11, Jan Beulich wrote: > We place the trampoline no lower than at 256k, so we have ample space > to read the MBRs of BIOS disks into an aligned buffer right below the > trampoline (not doing so has been found to be a problem on a buggy BIOS > coming with a Skull Canyon NUC). To facil

Re: [Xen-devel] [PATCH v11 08/34] ARM: GIC: Add checks for NULL pointer pending_irq's

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: For LPIs the struct pending_irq's are dynamically allocated and the pointers will be stored in a radix tree. Since an LPI can be "unmapped" at any time, teach the VGIC how to deal with irq_to_pending() returning a NULL pointer. We just do nothin

Re: [Xen-devel] [PATCH v11 07/34] ARM: vGIC: introduce gic_remove_irq()

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: To avoid code duplication in a later patch, introduce a generic function to remove a virtual IRQ from the VGIC. Call that function instead of the open-coded version in vgic_migrate_irq(). Signed-off-by: Andre Przywara --- xen/arch/arm/gic.c

Re: [Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 17:11, wrote: > We place the trampoline no lower than at 256k, so we have ample space > to read the MBRs of BIOS disks into an aligned buffer right below the > trampoline (not doing so has been found to be a problem on a buggy BIOS > coming with a Skull Canyon NUC). To facilitat

[Xen-devel] FTR: osstest load spikes, countermeasures

2017-06-12 Thread Ian Jackson
I wrote on IRC: 11:07 andyhhp: Looking at your xtf failure in 110095. 11:08 Diziet: yes - it is odd 11:08 the test itself didn't fail 11:10 andyhhp: Jun 8 07:26:08 osstest uptime: 07:26:08 up 168 days, 19:53, 9 users, load average: 19.87, 10.37, 9.17 11:10 So your failure coi

Re: [Xen-devel] [PATCH v11 06/34] ARM: vGIC: move irq_to_pending() calls under the VGIC VCPU lock

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: @@ -285,6 +291,17 @@ void arch_move_irqs(struct vcpu *v) struct vcpu *v_target; int i; +/* + * We don't migrate LPIs at the moment. + * If we ever do, we must make sure that the struct pending_irq does + * not go away,

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 June 2017 16:08 > To: Paul Durrant > Cc: Julien Grall (julien.gr...@arm.com) ; Andrew > Cooper ; xen-devel(xen- > de...@lists.xenproject.org) ; 'Boris > Ostrovsky' ; Juergen Gross > > Subject: RE: [Xen-devel] d

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 17:03, wrote: > On 12/06/17 15:06, Jan Beulich wrote: > On 12.06.17 at 14:41, wrote: >>> On 12/06/17 07:23, Jan Beulich wrote: As a side note, I'm removing these here since the further SIMD emulation patches I have ready, but would prefer to post only once 4.

Re: [Xen-devel] read_atomic, write_atomic, add_sized

2017-06-12 Thread Andre Przywara
Hi, On 12/06/17 11:55, Jan Beulich wrote: On 12.06.17 at 12:24, wrote: >> I am trying to understand why we decided to implement the helpers >> read_atomic, write_atomic, add_sized in assembly rather than directly in C. >> >> AFAICT implementation in C similar to Linux helpers WRITE_ONCE/REA

Re: [Xen-devel] [PATCH v11 05/34] ARM: vGIC: rework gic_remove_from_queues()

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The function name gic_remove_from_queues() was a bit of a misnomer, since it just removes an IRQ from the pending queue, not both queues. Rename the function to make this more clear, also give it a pointer to a struct pending_irq directly and re

[Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-12 Thread Jan Beulich
We place the trampoline no lower than at 256k, so we have ample space to read the MBRs of BIOS disks into an aligned buffer right below the trampoline (not doing so has been found to be a problem on a buggy BIOS coming with a Skull Canyon NUC). To facilitate that move MBR reading past EDD info retr

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 16:43, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of >> Paul Durrant >> Sent: 12 June 2017 15:29 >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 12 June 2017 14:55 >> > >> > That worked fine: >> > >> > >> > >> > (XEN) MBR[80] @ 85e0

[Xen-devel] [PATCH] ipxe: update to newer commit

2017-06-12 Thread Wei Liu
To get 5f85cbb9ee1c00cec81a848a9e871ad5d1e7f53f to placate gcc 7. The only patch we have applies cleanly. Reported-by: Zhongze Liu Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Zhongze Liu --- tools/firmware/etherboot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Andrew Cooper
On 12/06/17 15:06, Jan Beulich wrote: On 12.06.17 at 14:41, wrote: >> On 12/06/17 07:23, Jan Beulich wrote: >> On 09.06.17 at 19:50, wrote: On 08/06/17 16:49, Jan Beulich wrote: > Drop a redundant input constraint, correct a comment, and (re)move > fix.insn_bytes adjustments

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 12 June 2017 15:43 > To: Paul Durrant ; 'Jan Beulich' > > Cc: Juergen Gross ; Andrew Cooper > ; Julien Grall (julien.gr...@arm.com) > ; 'Boris Ostrovsky' ; > xen-devel(xen-de...@lists.xenproject.org) de...@lists.xenproject.org> > Subject:

Re: [Xen-devel] [PATCH v11 04/34] ARM: GICv3: setup number of LPI bits for a GICv3 guest

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: The host supports a certain number of LPI identifiers, as stored in the GICD_TYPER register. Store this number from the hardware register in vgic_v3_hw to allow injecting the very same number into a guest (Dom0). DomUs get the legacy number of 1

Re: [Xen-devel] [xen-unstable test] 110009: regressions - FAIL

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 16:30, wrote: > On 09/06/17 09:19, Jan Beulich wrote: > On 07.06.17 at 10:12, wrote: >> On 06.06.17 at 21:19, wrote: On Tue, 6 Jun 2017, Jan Beulich wrote: On 06.06.17 at 16:00, wrote: >> Looking at the serial logs for that and comparing them with 10

Re: [Xen-devel] [PATCH v11 02/34] ARM: GICv3: enable ITS on the host

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: Even though the ITS emulation is not yet in place, the host ITS already gets initialized and Xen tries to map the host collections. However for commands to be processed we need to *enable* the ITS, which will be done in a later patch not yet mer

Re: [Xen-devel] [PATCH v11 01/34] ARM: vGIC: avoid rank lock when reading priority

2017-06-12 Thread Julien Grall
Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: When reading the priority value of a virtual interrupt, we were taking the respective rank lock so far. However for forwarded interrupts (Dom0 only so far) this may lead to a deadlock with the following call chain: - MMIO access to change the IR

[Xen-devel] [qemu-mainline test] 110340: regressions - FAIL

2017-06-12 Thread osstest service owner
flight 110340 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/110340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow210 guest-start fail REGR. vs. 109975 test-amd64-amd64-

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Paul Durrant > Sent: 12 June 2017 15:29 > To: 'Jan Beulich' > Cc: Juergen Gross ; Andrew Cooper > ; Julien Grall (julien.gr...@arm.com) > ; 'Boris Ostrovsky' ; > xen-devel(xen-de...@lists.xenproj

Re: [Xen-devel] [xen-unstable test] 110009: regressions - FAIL

2017-06-12 Thread Julien Grall
Hi Jan, On 09/06/17 09:19, Jan Beulich wrote: On 07.06.17 at 10:12, wrote: On 06.06.17 at 21:19, wrote: On Tue, 6 Jun 2017, Jan Beulich wrote: On 06.06.17 at 16:00, wrote: Looking at the serial logs for that and comparing them with 10009, it's not terribly easy to see what's going on beca

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 June 2017 14:55 > To: Paul Durrant > Cc: Julien Grall (julien.gr...@arm.com) ; Andrew > Cooper ; xen-devel(xen- > de...@lists.xenproject.org) ; 'Boris > Ostrovsky' ; Juergen Gross > > Subject: RE: [Xen-devel] d

Re: [Xen-devel] [PATCH] domctl: improve device assignment structure layout and use

2017-06-12 Thread Julien Grall
On 09/06/17 14:47, Jan Beulich wrote: Avoid needless gaps. Make flags field mandatory for all three operations (and rename it to fit the intended future purpose of possibly holding more than just one flag). Also correct a typo in a related domctl.h comment. Signed-off-by: Jan Beulich --- The

[Xen-devel] [PATCH v3 2/4] xen: add sysfs node for guest type

2017-06-12 Thread Juergen Gross
Currently there is no reliable user interface inside a Xen guest to determine its type (e.g. HVM, PV or PVH). Instead of letting user mode try to determine this by various rather hacky mechanisms (parsing of boot messages before they are gone, trying to make use of known subtle differences in behav

[Xen-devel] [PATCH v3 1/4] doc, xen: document hypervisor sysfs nodes for xen

2017-06-12 Thread Juergen Gross
Today only a few sysfs nodes under /sys/hypervisor/ are documented for Xen in Documentation/ABI/testing/sysfs-hypervisor-pmu. Add the remaining Xen sysfs nodes under /sys/hypervisor/ in a new file Documentation/ABI/stable/sysfs-hypervisor-xen and add the Xen specific sysfs docs to the MAINTAINERS

[Xen-devel] [PATCH v3 4/4] xen: add sysfs node for hypervisor build id

2017-06-12 Thread Juergen Gross
For support of Xen hypervisor live patching the hypervisor build id is needed. Add a node /sys/hypervisor/properties/buildid containing the information. Signed-off-by: Juergen Gross --- Documentation/ABI/testing/sysfs-hypervisor-xen | 11 +- drivers/xen/sys-hypervisor.c

[Xen-devel] [PATCH v3 3/4] xen: sync include/xen/interface/version.h

2017-06-12 Thread Juergen Gross
Sync include/xen/interface/version.h with the Xen source. Signed-off-by: Juergen Gross --- include/xen/interface/version.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/xen/interface/version.h b/include/xen/interface/version.h index 7ff6498679a3..145f12f9ecec 10064

[Xen-devel] [PATCH v3 0/4] xen: add xen sysfs nodes

2017-06-12 Thread Juergen Gross
In order to be able to determine the Xen guest type from within the guest as a user there is currently no stable interface available. Add a sysfs node for that purpose as the guest type information is available for the kernel. While doing this document all the other Xen related sysfs nodes. Add

Re: [Xen-devel] DESIGN: CPUID part 3

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 16:02, wrote: > My original statement was "if the guest uses LBR/LER, then migration > needs to be restricted to hardware with an identical LBR format". > > You countered that, saying we could emulate LBR/LER as an alternative. > The implication here is that we could alter the

Re: [Xen-devel] [PATCH] domctl: improve device assignment structure layout and use

2017-06-12 Thread Julien Grall
Hi Jan, On 09/06/17 14:47, Jan Beulich wrote: Avoid needless gaps. Make flags field mandatory for all three operations (and rename it to fit the intended future purpose of possibly holding more than just one flag). Also correct a typo in a related domctl.h comment. Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 14:41, wrote: > On 12/06/17 07:23, Jan Beulich wrote: > On 09.06.17 at 19:50, wrote: >>> On 08/06/17 16:49, Jan Beulich wrote: Drop a redundant input constraint, correct a comment, and (re)move fix.insn_bytes adjustments (these aren't needed for custom stub i

Re: [Xen-devel] DESIGN: CPUID part 3

2017-06-12 Thread Andrew Cooper
On 12/06/17 14:42, Jan Beulich wrote: On 12.06.17 at 15:36, wrote: >> On 12/06/17 14:29, Jan Beulich wrote: >> On 12.06.17 at 15:07, wrote: On 08/06/17 14:47, Jan Beulich wrote: On 08.06.17 at 15:12, wrote: >> The `disable_migrate` field shall be dropped. The concept

Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 14:05, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 June 2017 12:12 >> To: Paul Durrant >> Cc: Julien Grall (julien.gr...@arm.com) ; Andrew >> Cooper ; xen-devel(xen- >> de...@lists.xenproject.org) ; 'Boris >> Ostrovsky' ; Ju

[Xen-devel] [xen-4.8-testing baseline-only test] 71545: tolerable trouble: blocked/broken/fail/pass

2017-06-12 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 71545 xen-4.8-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71545/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-ins

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 15:36, wrote: > On 09/06/17 12:15, Robin Murphy wrote: >> On 08/06/17 20:30, Sameer Goel wrote: >> [...] >>> /** >>> - * iort_iommu_configure - Set-up IOMMU configuration for a device. >>> + * iort_iommu_configure - Set-up IOMMU configuration for a device. This >>> + * function

Re: [Xen-devel] DESIGN: CPUID part 3

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 15:36, wrote: > On 12/06/17 14:29, Jan Beulich wrote: > On 12.06.17 at 15:07, wrote: >>> On 08/06/17 14:47, Jan Beulich wrote: >>> On 08.06.17 at 15:12, wrote: > The `disable_migrate` field shall be dropped. The concept of > migrateability > is not boolea

[Xen-devel] [OSSTEST PATCH 2/2] fixup! ts-xen-build: Build livepatches test-cases

2017-06-12 Thread Ian Jackson
Use substep_eval, so we cope with xen.git revisions which do not support `make dist-tests'. Signed-off-by: Ian Jackson --- ts-xen-build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ts-xen-build b/ts-xen-build index eaf44b1..097ac0a 100755 --- a/ts-xen-build +++ b/ts-xen

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-12 Thread Julien Grall
(CC x86 folks) Hi, On 09/06/17 12:15, Robin Murphy wrote: On 08/06/17 20:30, Sameer Goel wrote: [...] /** - * iort_iommu_configure - Set-up IOMMU configuration for a device. + * iort_iommu_configure - Set-up IOMMU configuration for a device. This + * function sets up the fwspec as needed for

Re: [Xen-devel] DESIGN: CPUID part 3

2017-06-12 Thread Andrew Cooper
On 12/06/17 14:29, Jan Beulich wrote: On 12.06.17 at 15:07, wrote: >> On 08/06/17 14:47, Jan Beulich wrote: >> On 08.06.17 at 15:12, wrote: The `disable_migrate` field shall be dropped. The concept of migrateability is not boolean; it is a large spectrum, all of which ne

Re: [Xen-devel] [OSSTEST PATCH] Drop build-*-oldkern [and 1 more messages]

2017-06-12 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH] Drop build-*-oldkern"): > That is for testing the in-xen.git kernel build machinery which we > surely don't care about anymore. Thanks. I will push this in a moment. Acked-by: Ian Jackson Wei Liu writes ("Re: [OSSTEST PATCH] Drop build-*-oldkern"): > And the ru

  1   2   >